From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49967C19F32 for ; Fri, 7 Mar 2025 06:03:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A8AC280004; Fri, 7 Mar 2025 01:03:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 459BF280003; Fri, 7 Mar 2025 01:03:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3212F280004; Fri, 7 Mar 2025 01:03:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 13855280003 for ; Fri, 7 Mar 2025 01:03:12 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 362101A046E for ; Fri, 7 Mar 2025 06:03:13 +0000 (UTC) X-FDA: 83193712266.13.7B7C765 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id 8BC6616000E for ; Fri, 7 Mar 2025 06:03:11 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=VDocaQE+; spf=pass (imf08.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741327391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nlyqZZ6euZbQvqYvgIbcDiDKRjXCI71DWeOzknGJauc=; b=r7M7nR50X1V4XLU3p7vA+1+Ed1Km/WjFQCKQLyEfQeIwH+Y8UA3bAxENr7nUVA1L8QOVMu OrumIStKGxJhSfGXxHMeW4NA7lXtIiK/EvVBCOTI7TiTmcedXz7d9KoYCDFr1TyUQsPQJD tFf3d6rU2D6A1mtWjTy1TmISCpCRyDs= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=VDocaQE+; spf=pass (imf08.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741327391; a=rsa-sha256; cv=none; b=ESZwtbnuwRPwov0+qGP/9nByHjIKRaBhHIEKnOdDnCjOv1qvO+IdjeBzSMw1BZekxUTRdM MSTjfNp+jBNzvXCtGq9tK6KSFrtzdK4WLU5uu/14lGpDL79TwCkEBCALI4IWU+wvPtwVMf M5t1AshFDBn3rTC+bYCEccTMKChSr04= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 02C32A45511; Fri, 7 Mar 2025 05:57:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A418CC4CEE2; Fri, 7 Mar 2025 06:03:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741327390; bh=CRAihNkGRLaidsZuzsLC506Y8MOu0f2lmWlCIxy18H0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VDocaQE++DVK22rJjR70kxQTmMZHHuSCR7WjyiwjfJTHNTUq7Ul09dyUSB6USROlD PmFKhruwh42vcXvtqkr1t9+HYVC57Vfcc370h8VlDwUIoKmoqVTdPJpIBz4ssbdX1U 2s4q7IFjhxQudeGaTX2sDHFRIa1SeDM5gE0ebBEM= Date: Fri, 7 Mar 2025 07:03:06 +0100 From: Greg Kroah-Hartman To: Pratyush Yadav Cc: linux-kernel@vger.kernel.org, Jonathan Corbet , Eric Biederman , Arnd Bergmann , Alexander Viro , Christian Brauner , Jan Kara , Hugh Dickins , Alexander Graf , Benjamin Herrenschmidt , David Woodhouse , James Gowans , Mike Rapoport , Paolo Bonzini , Pasha Tatashin , Anthony Yznaga , Dave Hansen , David Hildenbrand , Jason Gunthorpe , Matthew Wilcox , Wei Yang , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, kexec@lists.infradead.org Subject: Re: [RFC PATCH 1/5] misc: introduce FDBox Message-ID: <2025030700-paramedic-untoasted-9cec@gregkh> References: <20250307005830.65293-1-ptyadav@amazon.de> <20250307005830.65293-2-ptyadav@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250307005830.65293-2-ptyadav@amazon.de> X-Stat-Signature: u81a33z8ja4hexdynkae1k7xgunjst7c X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8BC6616000E X-Rspam-User: X-HE-Tag: 1741327391-16919 X-HE-Meta: U2FsdGVkX1/sdlt6L5jM39Dq8XcTftzt1a+i0oOLg8/3ygftJTb9NeqCYhB8YaWrAfm1WoJIsGOfUd8isJ2954JTcJuDb3bYiVqtVTlriRTBztp+1ZoZbzOc300hbNq+xUYafGIANj3wt0LwsGGx4uHbL03a6xuKHVzt9KCnivZRVv4yBSNxefNQ8nY7tUXnoGMyy9tCunxmfbL1AwvmCK4vhxj1EHW20eYWuFEdZ00TXUwzjD2tB5rUoC8yWePUXh9vf+n3Qd0/YpW90//b60NUbNbB9KlgfILym7wgWFzBWA0pMqX3mi30Y7y82M25pvDl6OM6XDMlNSBV/ChlqPxCm+P/APFMMvFHo12BQBCjSDXdXPUSqWBcy5zE06gsvgXRyYg8ynShpZ6mgaDr/7riICLzjkx8lR6tzo3l56XucLTgFeawyy7JvxTZIORKsr2ldlrpX6v6aKZXfmXPVnIqo8xi4rE+GC1aHZLMHhW+bybIx5ahgtkSmtCQEQZVo6jOJGUB/k9lF0oJ86Q+8G0dObGHGWeaxMNed2bZwj/FkoK4MrN1y8XF/9j6VuwcMvZsqiORQXqYl8sJrf9fDind+jRWF2xIgNWCV9imvFzUlG52j78mll7VHrS51MGr5xnz99z2O+pyINiLXB9Hm25QPFj9WgC/ma2wrZ8vv3+fOZ9PE+Bj6BsEHDCbysKqKn2CHSIWoXDEVSh9B5rAV4lmqb0RqR1PmvVJ5w0eGVKebgYVrnVRT/mBdUCgFJQvNOOYFLZUzIZca5VZt7QAP2NTIrNiA5yuq7Ve+W5lZfayfT7dyIed7+x3TqFxRka6qTEFQ+TBERTgOeHwWZxkrD2qBthE/jwjAaj/txZIuqvMBIO+wJIeOOi/LSWmmfXFNhfmWtGfeaJMYzxPVKbTAZfYuOyDjDl6D7quzP5dQ+ZvEnC4UkrUNHKcXlO9sKUopbqb63qJsbU5ZwAY7xS 3KvdHUbL loH7wT4DYfnOaMYsv2ad0bB4fjUhDFFe7KwCKFqG8bh7C+hPkHK6u9516r2Ye8bPdvKOcR1s8WhcsgocSKk6c8bUFS1ctwreq6WH7fPyyhgtwMSOu3PqYkYNnfErznLVDFB2hODTlHZatZxROmKsetAN3hLZww0cHJ88DO/Gg0+a9KwwvNEy40ptaS0NYojIgiuXUs7gjet/5BBVqFgp9iOs04Jv9s0z2KkRAjUAvnwCNs41C2Zkdc7orEe/xB93IXFA/4tiF9Yc/+/UootM7cTRgVxBZT/zZNfQJf2bUmIXVShxLKL4OHRv4WNKU94d9SDGQlrYPjLyYkZ/oW1E+m0eBwpdAeb1570rweDcH67aJ4XmI0X5SwqU02ESMKrJmbWxA+j6l/dfRuSFGeOeePxKHGFmZn0+2x0da X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: One quick review note: On Fri, Mar 07, 2025 at 12:57:35AM +0000, Pratyush Yadav wrote: > +/** > + * struct fdbox - A box of FDs. > + * @name: Name of the box. Must be unique. > + * @rwsem: Used to ensure exclusive access to the box during SEAL/UNSEAL > + * operations. > + * @dev: Backing device for the character device. > + * @cdev: Character device which accepts ioctls from userspace. You now have a structure that contains 2 different reference counts, which is going to be impossible to handle properly. Which one defines the lifetime of the object? That's not going to work, please fix. thanks, greg k-h