From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BB8DC282D1 for ; Thu, 6 Mar 2025 19:09:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DD4828001A; Thu, 6 Mar 2025 14:09:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 659C0280019; Thu, 6 Mar 2025 14:09:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D4A528001A; Thu, 6 Mar 2025 14:09:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2B8F5280019 for ; Thu, 6 Mar 2025 14:09:12 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C232CC25F8 for ; Thu, 6 Mar 2025 19:09:11 +0000 (UTC) X-FDA: 83192064102.03.CD130D9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 1B47CC0003 for ; Thu, 6 Mar 2025 19:09:09 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tS5DCNrz; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741288150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bTp2gSjs3hsVsgEPL+HTOWBovvjxWVtP9N22n27wPwk=; b=X0UwDVWXZmdymkicpXO+OWdcd8NdM1d3XhLCuwqBED37pn930fVrNGgXWyg8gZycK+/6RL q8qtSZW2LyhDM+bsZJjUBCDT/Fj4HKCUG5yFe7O5NiCmOidGZB7l0Hem+hUto9GGD2uK0G LsYgKyQuD/3lHTiZPxLii6O3SjpA+Zs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tS5DCNrz; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741288150; a=rsa-sha256; cv=none; b=DfEhe/3nrMl4HCZiusIO9KFo6J2/tp2s0KVofAWofIp1immtprRF9/b8a9ww4ib2ml4rIT UfI17usLFKZZCCizuDdNhoYseoiOVJvU0ZXDeCJBf068/L9WQmXo8NX+VSZNNFkq5J/zXE 3DT88fLhgX0GV4y/R2KLIHcCe0RzHIM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6849D5C5813; Thu, 6 Mar 2025 19:06:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE94EC4CEE4; Thu, 6 Mar 2025 19:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741288148; bh=g8O+Y+hUe0dXdskx73ule0fZiAy+9KERaeSyIOO+cVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tS5DCNrz3UQrB6+6NwbFRXMQqxfZ1Hzy3qQNRblgCtzqc7k/fmtB0eFe+cWwX1kRg mMlMzoB5E7Dcp9VLrV/MFhzApUDboOq3HCDrNaZI6nbTyc6LsheE9eViYk4BqY2m96 PPrMdPf9LcXJNut36fnGgbbT3O0XucNN9L9LzMekvkJEOcZ7J6CeWq2Hh+gr4rYKbi Z2NW+EqrSftQpY/hGBtR0wW9LuNZoRijBEwz0MaXZcWp89/F1QnCz/6jTfSkrYGunF VONz3BPL24AWZuWAQV0mHkDT24HpN+VADfrUavgsmNF7cjkhkhU9JcyiOusnp816iR CmXGkEKZ6MU5A== From: SeongJae Park To: Shakeel Butt Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 09/16] mm/memory: split non-tlb flushing part from zap_page_range_single() Date: Thu, 6 Mar 2025 11:09:04 -0800 Message-ID: <20250306190905.842447-1-sj@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <7rnj5pt7uaftvvf6sqge4vowvcht7n4cqb4hxh3o6kzxtqumqi@p7ugsoqh6iiz> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: s6skn5gx687ddb8t4kca88roci33gupm X-Rspamd-Queue-Id: 1B47CC0003 X-Rspamd-Server: rspam07 X-HE-Tag: 1741288149-388609 X-HE-Meta: U2FsdGVkX18hHpHsteV6JJ3x3eCzx7iywnnxaZ4BMO/9XTJansEl3E3nIDd4tAQkdTTcQiVr/x85ComtTTfJV6pM6l3SFPQCat/cjAZk6fyWoJXur7bohLcmcNo51nI/rfssqMVtPbcTnvy9jmSLjpZG96lot+zjt6WELylZVk1jH9CAZZy2ripah1FjLmOZe4lUKcfl95yCO+j1Udp2TQq03zlDPnhwUsTsYyhT7KHSMs2BLqC/Ye5ZuNRFn0izVcjL5X/iSJUC+YjlDPg6yDFR6odVT+CIYCsPXx/gtbKz9m8ArEy0uLAYbJnPp0H6wyRMz/nGWE09/O+j7sWjwI/MBq2SWKN9Z/imDFFNaUab8OSaNRD/+ry6J8CamBQCUIOe83eiyydjaPksl1yPvRtMC7HRdNd+YwYsrdh2LDfbfiqAU/RyC48RK6a9CUuatqPxXtK/8YZpRDH/Cbm7wHxUqea/5Um3OO8bXlTJRMfK5vvTb2qL4l5U69YELRLDavY5CAmxF5s0HCW9NuhuXQSyDcuyGU0cqU5uYEFqA5e7Cky7alvQ/hyJRcCRbL04mOE7NW72mwXySSOKnVMhHuJEfs2kAJZUZY+DdJeU6SlTIoj3Vm8hV9LsOUZsAnb5MdQMpG29TZl49bDfVEVxvaByzpoaGX9+onBzgY/aXCzOBEEiYZpmfyEEjObfvGHr9WQz3VKhG17eF9jwxoRlhiSB8M6YHXkOuQZarEdsMaWyUKddPsMud5Q+8SWFmAFXwpmxx218AYKHrcq5adhrCZCtIwLrz/gd3uTpiex7gyGgwBdOOD8Wg4XQ/66UFYjp21QS7FemVilHLUUk559Co0hyz7hH0EuInMymAMwzZ4grBb0lvwX5pIBJHYSzWPW3DNUKVZcp6pOhJf0HD4nfpxT9lWwZgakHLc3GqK6GM+7bMGzBdhUqri1GxGTtaBXwEcSNkdddAlnOiZ1hYnN CXE4lfqU ZfNjkqW21PIwWg7fwh2eC+Ri+cl6qAUm8KrBT/ch4UPYSKX+WEzl3aC60KskBiVEfUsQJer/y+1UKSJVwOfQK6qI8qUW/YaRQiL+07Y5AdOG+KZs9alxJM96NeHqRpn1XkUdVu54Jbex7QfBvqtRgXRO3suiEeQSGx3OTCJ+xY3qzHOfvRnvpCDwOXyoO53SErR2aL7juWA10wH/32OGg0X3VWQb5xGTCoNcjmJjThZoxUroQOh9xCl5kB4wvCvQMk1kY0p4YfTO3PMnDwXUzpkRpTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 6 Mar 2025 10:45:01 -0800 Shakeel Butt wrote: > On Wed, Mar 05, 2025 at 10:16:04AM -0800, SeongJae Park wrote: > > Some of zap_page_range_single() callers such as [process_]madvise() with > > MADV_DONEED[_LOCKED] cannot batch tlb flushes because > > zap_page_range_single() does tlb flushing for each invocation. Split > > out core part of zap_page_range_single() except mmu_gather object > > initialization and gathered tlb entries flushing part for such batched > > tlb flushing usage. > > > > Signed-off-by: SeongJae Park > > --- > > mm/memory.c | 36 ++++++++++++++++++++++-------------- > > 1 file changed, 22 insertions(+), 14 deletions(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index a838c8c44bfd..aadb2844c701 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -2011,38 +2011,46 @@ void unmap_vmas(struct mmu_gather *tlb, struct ma_state *mas, > > mmu_notifier_invalidate_range_end(&range); > > } > > > > -/** > > - * zap_page_range_single - remove user pages in a given range > > - * @vma: vm_area_struct holding the applicable pages > > - * @address: starting address of pages to zap > > - * @size: number of bytes to zap > > - * @details: details of shared cache invalidation > > - * > > - * The range must fit into one VMA. > > - */ > > -void zap_page_range_single(struct vm_area_struct *vma, unsigned long address, > > +static void unmap_vma_single(struct mmu_gather *tlb, > > + struct vm_area_struct *vma, unsigned long address, > > unsigned long size, struct zap_details *details) > > { > > Please add kerneldoc for this function and explicitly specify that tlb > can not be NULL. Maybe do that in the patch where you make it > non-static. Thank you for this nice suggestion, I will do so in the next version. Thanks, SJ