From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B19C282D1 for ; Thu, 6 Mar 2025 12:33:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 825C2280002; Thu, 6 Mar 2025 07:33:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D54F280001; Thu, 6 Mar 2025 07:33:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69C7D280002; Thu, 6 Mar 2025 07:33:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4FB53280001 for ; Thu, 6 Mar 2025 07:33:35 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7B163B99F2 for ; Thu, 6 Mar 2025 12:33:37 +0000 (UTC) X-FDA: 83191067274.05.B8C9199 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 4E5E080015 for ; Thu, 6 Mar 2025 12:33:35 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GwUdjJpL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741264415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YSaun7lz0bYxj+TpuiSszwxCug8hPax6TNKoHPYNE3k=; b=OhNVmYdX+CaurIJq8Ph5MxZsFiH6XC1r6d34BjEP3V4/jXTDfHwuY+jo14vlTg2HIcHvXC oqw5dSXkNta4Xu5CfuFOvRq0Yao3/VHMYThWZ6dr+0Ta/0WfYXmWholiNVgK+IkSH9hEk1 aqY07Pkh0m/9xJYqhNBS2EzQQCydb90= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GwUdjJpL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741264415; a=rsa-sha256; cv=none; b=r24PezPr+w0tdVJSPZAYSlxDfe7BXI9ncuLC2VB26pJ9reyzTdTla4XbIpthFMqfxF35ZJ elLnKZ8bztbR2o3UD1sM4foC8v5359QFdd6ZCF0vZd+95T9hb61nFPvEXMeJy+imUorMsV CU9DD+BH+9tm1+U1ic6TBPeQ1mg5C68= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741264414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YSaun7lz0bYxj+TpuiSszwxCug8hPax6TNKoHPYNE3k=; b=GwUdjJpL430wMKRtz8jYrsZhrVZfW0zuuMukS9UKd5voyAx4JdP0lOYhd3aDZrXpRIzDE4 sV3mwqGTfYtbaa/72abioYUi2hvtzauAUEvl5mdJ3KJK9sx89XKIK4zsNMcB51ORVVqK0S UuvMD6OCpCfz6/Tv8usyjgGQ3t3jkik= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-7dVMJNGsO7ylcJzUCNfUbg-1; Thu, 06 Mar 2025 07:33:28 -0500 X-MC-Unique: 7dVMJNGsO7ylcJzUCNfUbg-1 X-Mimecast-MFC-AGG-ID: 7dVMJNGsO7ylcJzUCNfUbg_1741264406 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 27E1719560AB; Thu, 6 Mar 2025 12:33:25 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.240]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 110551955DDE; Thu, 6 Mar 2025 12:33:17 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 6 Mar 2025 13:32:54 +0100 (CET) Date: Thu, 6 Mar 2025 13:32:46 +0100 From: Oleg Nesterov To: K Prateek Nayak Cc: Linus Torvalds , Miklos Szeredi , Alexander Viro , Christian Brauner , Andrew Morton , Hugh Dickins , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jan Kara , "Matthew Wilcox (Oracle)" , Mateusz Guzik , "Gautham R. Shenoy" , Rasmus Villemoes , Neeraj.Upadhyay@amd.com, Ananth.narayan@amd.com, Swapnil Sapkal Subject: Re: [RFC PATCH 3/3] treewide: pipe: Convert all references to pipe->{head,tail,max_usage,ring_size} to unsigned short Message-ID: <20250306123245.GE19868@redhat.com> References: <20250306113924.20004-1-kprateek.nayak@amd.com> <20250306113924.20004-4-kprateek.nayak@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250306113924.20004-4-kprateek.nayak@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4E5E080015 X-Rspam-User: X-Stat-Signature: okqyjobi9qmtzf85w69qybd5w5wn64bj X-HE-Tag: 1741264415-621882 X-HE-Meta: U2FsdGVkX19AF96Tr5grnf+6uP+XM8rrSilxwVZxun2dW6RsbiNNmLZrKZUfGzzgzQoC/A67KpVXA75QaTCT+exff6TonpNgDxLsLyjZDSyzuw3UhS9TF9r4FnJq5ae//hXCLxnae+pnONuTnOtEy1HfZI+aAWpI8b18TKWp/pFms1l9jLQtF3BBleglfyFLMAlwdeIoZoCdGK0a+7aZSJk97mcJpGSFYS8qvdRASkI0iNt7lmwh6LU9JsF+djFuAvNdTpK8p+Qsf58dbPAUJXisFlQ3PsEZEnLj7pKdDHTu/lvlzkzKpQeo4uhdEU/0rFQ6F68mNmJram7ymq1M8TzYrsCfdynkooH6mBEy3Gn5HcXPRrguJplRrrWeTBIxrKtBQqULP4kif/fMGteQFAM7jjNZIXgxIxVsBaxzOMa21nj+99L+qKNnq3JY7Z394Yi9iuqzRIfSJOUj6TTuvjkOzvRUD/EoMUtpkjiV9Ct168QXEydMeSIOs7kiHt9goOJdMLuVRL+pJoxxgjoU/jDW5Zfxc23bj96ysK5rD/e3vatbo5xIeXS/MVO2QlRN7S0SC9lSRwlxPPn0OfcUmKuoQ2aLVDFw1W4vXgw6Q0DHlqZeGj0qzFby++f6tGrEnjbwd74ECDIfdcKvzJE75RIUJYrPgcxbKUKeDV5BkGQ3PfIpwAwew2z+SdY6Hyk3riOe2alkHyOPYHSmEQtGENWp2ErDB5pKB+t+XKtAmjrjPf4tIZyfIqFMmCMy8qEyaweu3o0OTggqN3j5dvmQwhfO5aqjhaI2OmvVz8lhHG4Cl3uooiEhiL1RJdH2f2ZtzOfZQ2BHW5WJZJNY8paapYY+C829yoVwcsEqUtikI3pGHC3FG1z3sHORHOSnMwtk8khe3Jcu1XwFeaVw+60oTzKbjghJG0+mDtNdVLEQlud9qIKEFpxu/ZvO+8vHiHr2hzERABU5mZn1RtdMq2W ULYsP3am GXY+OPIYdPQ2GXBv/kyJG4I3yXUUidB9awI97menFAedczQGVRZGXYd4Cl/o4zCPW2TqVjv9g3uJxicnxaatc6iz0nWUdW2dbPqeUf2uRrbb3XVJluYy1ud/XMP7aK95+CT6lycDkDoc79TGbV5t7dgqM5Ken7FNj7qs0oy3ZUz/UInNT52bDQs3sPY1mgugTqi7KVWiQQgSq0Yu5ZcP9XxLU/gG+YRvf2DXrv6i0PVNcP2P5Du17z8+tWb7qqcney6SiSY4O487fB6gxxVRFf/NnIv6BDvokNyAeaPjihg/8akBySMkQNv+Gdn38zGJ7HAKX43CPZeQJrIj4LjVUhEeWpbMLJulbLYgVeKA434e3/c0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/06, K Prateek Nayak wrote: > > @@ -272,9 +272,9 @@ pipe_read(struct kiocb *iocb, struct iov_iter *to) > */ > for (;;) { > /* Read ->head with a barrier vs post_one_notification() */ > - unsigned int head = smp_load_acquire(&pipe->head); > - unsigned int tail = pipe->tail; > - unsigned int mask = pipe->ring_size - 1; > + unsigned short head = smp_load_acquire(&pipe->head); > + unsigned short tail = pipe->tail; > + unsigned short mask = pipe->ring_size - 1; I dunno... but if we do this, perhaps we should s/unsigned int/pipe_index_t instead? At least this would be more grep friendly. Oleg.