From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A03C282D1 for ; Thu, 6 Mar 2025 12:29:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E98D280002; Thu, 6 Mar 2025 07:29:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09825280001; Thu, 6 Mar 2025 07:29:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA241280002; Thu, 6 Mar 2025 07:29:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CDABC280001 for ; Thu, 6 Mar 2025 07:29:02 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3FBDD141483 for ; Thu, 6 Mar 2025 12:29:04 +0000 (UTC) X-FDA: 83191055808.09.A1E7428 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 28118140013 for ; Thu, 6 Mar 2025 12:29:02 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="bL/+ogvi"; spf=pass (imf23.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741264142; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0V8bEBMj4qDTw4A6gJnd9yt6K6KK+9XkOtnCntFymag=; b=kstI4SuVN4Em9j0MtHxF4zCmpKtEstTVxN6aj8Gw+bMI+Za6/t+u5QY9842L+8WS7SJTXJ DSRjDptzD7iQaZZvvaSG6IobPJKomDSJ34xH8gTClFAezr2SUc8qvP87oa0VD7CE5YOCSs DYNa11kVW1FDgf7kMSVL9XFQT+R2dDU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="bL/+ogvi"; spf=pass (imf23.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741264142; a=rsa-sha256; cv=none; b=5yJVeNcFNgSRjhPCrTkp/xUt7YPheZTlgZe/sJM6bMMliXIV48EP1BG2QD8+Xq55kbEgSG 0T3Azr+wUGUGmbOFWBlVjIy5SkUe91WldgHwyc8lmBodTk8agcnBRznnF4jj75YYmvN1zi Yf3y8WWk+f/1e/TGTAeTdNK2qMAapdU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741264141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0V8bEBMj4qDTw4A6gJnd9yt6K6KK+9XkOtnCntFymag=; b=bL/+ogvi/HP0nOrZcT9zwZIRrA0E8oeiMpcILXlpUyczaMmCuwEaxDzYxlopipz1SF0ZLI DN5DJfEpQyZl6pCViPkYa219G3ypdXeFUGhkxvthcKY7I2BXhg16p4vts7PKYP9sKe6uV4 tLgUtcFu8XdL8gx09gJYrAp9k/PGPCk= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-I2e09rAfMYy5CSas15muGA-1; Thu, 06 Mar 2025 07:28:50 -0500 X-MC-Unique: I2e09rAfMYy5CSas15muGA-1 X-Mimecast-MFC-AGG-ID: I2e09rAfMYy5CSas15muGA_1741264128 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 417EF1956055; Thu, 6 Mar 2025 12:28:47 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.240]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 26037180AF7A; Thu, 6 Mar 2025 12:28:39 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 6 Mar 2025 13:28:16 +0100 (CET) Date: Thu, 6 Mar 2025 13:28:08 +0100 From: Oleg Nesterov To: K Prateek Nayak Cc: Linus Torvalds , Miklos Szeredi , Alexander Viro , Christian Brauner , Andrew Morton , Hugh Dickins , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jan Kara , "Matthew Wilcox (Oracle)" , Mateusz Guzik , "Gautham R. Shenoy" , Rasmus Villemoes , Neeraj.Upadhyay@amd.com, Ananth.narayan@amd.com, Swapnil Sapkal Subject: Re: [RFC PATCH 1/3] fs/pipe: Limit the slots in pipe_resize_ring() Message-ID: <20250306122807.GD19868@redhat.com> References: <20250306113924.20004-1-kprateek.nayak@amd.com> <20250306113924.20004-2-kprateek.nayak@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250306113924.20004-2-kprateek.nayak@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspam-User: X-Stat-Signature: a5mw5azoqzy1caruxrr1kf1cca97ntf7 X-Rspamd-Queue-Id: 28118140013 X-Rspamd-Server: rspam07 X-HE-Tag: 1741264141-899751 X-HE-Meta: U2FsdGVkX1/bkHxvb0VxVmz6t5V6N1caIHfxIPlI8rdhx6ET6/+UAXCvRTjVed/lTAn/mSmcDbHDmV0ovun1PhBlkIBk52UH8lTOjMYTwPz3Q/SG5MDqv+Pm0YR7RLxTVSgI5/BzYWx2MlSk96gZD8z0cktoc5ukWF61Bxy0MxcSbbQr72d8fJ4gtsTtvq7r0ULglxHnrinuJ70ngSI81L71UUJPA2gjft7NYEVaDSvMhLnELiDLfug2uOmBa5ekn4QYEtoCOwBWxqed+ORdFsMqQ57l3GZqTmCMzWbq84J4RBeg4f/bQtsvO93ZkUQ6HEapr1VKqd1OR5oPsScaK9fpcSOr0MSrsMzOSexTQHGnoC1vXrmDwrhZjwjgUROERJws1/65FJYDXdZyN2y7b8hJ6sofbuYSo2bfcEbEzRgM12KUChJif1KJAhrx7dsPkY5lz97q50cTUDEgYzxNy0ZYDpjDCnrndmZtu8jqR4s8Tr+ADmTdyd1y78I4LbMhaJBkV+FSSlWwKUkSFMN1Jo45UncnE6pogoSMcxy7JRLl4P7lNfVN8wfPhoxG9wU8XGFhniRa4+/Ejykqgo58mMnI+GRZLk0V+MqA3OGBAi5+3WaAwZaq5yTsAp0dFkft7kug4tpO2rUkC1YUxJi3dUhdDgFjWv+xJdssx1p61fQLqkCZZFbT1O1pRBxp3jO3XUSkGPkTqHX8a/NocThT7LQsugCFaS5FORwXRHpWBsq7675an1ntMjqDnVXF65NX+kmCgk7q85PxW6FHR6+4k/h2IFQjYff+71dp9jZ2/RXEgKcjO2MMICuLXyn0peF7YTXxzQXoNzsXeui6RJYxq2lIOIoKu/w9MFweMHnbRD9mrj3Su3vbCQ3ohJUtjM58CBx92YtT/q2+97oCFoPnrObWiQ7Uw2pRoPNbUOYovFfO+k6HSCoNBXmwA1FiHLLTkhdAbE72+MngL6mbgHP 8DIPCc1n gcManf8TMGgqvUUvGY0RnNb6QmfFK+6CIHGlifiwhUn7kQT+cwj++7xzgJai2a8NZL6VjuRfOYmNYktLYnlxSAjBoV/NX7RrIDtzdfC0lXDupyEmhvtQmFtghwfz+2c5XF9044pHFu/WX6FwTsWd5pxO3887S/07hYvtd8i2wi3ahdpJi6z1FyhwJdqI6fJ6ITif+ISGpfbjBW0ztFuNgt0buiT/bq0SzQ4khi6Caf+nsQOEUBvzEf6f1YhsMu8VJ2JUGehH46Er/S0e4HYfXaGp47QcGxKoajjOAjviIRvZAMLyNIey4RzCZ1bRBSeCIkvrXez43Td2llyQToTNZ+nqc4q+WV66J5rkbNCgnCmf6bgysMqeY+EDf48NixU2Ll5kF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/06, K Prateek Nayak wrote: > > @@ -1272,6 +1272,10 @@ int pipe_resize_ring(struct pipe_inode_info *pipe, unsigned int nr_slots) > struct pipe_buffer *bufs; > unsigned int head, tail, mask, n; > > + /* nr_slots larger than limits of pipe->{head,tail} */ > + if (unlikely(nr_slots > BIT(BITS_PER_TYPE(pipe_index_t) - 1))) Hmm, perhaps if (nr_slots > (pipe_index_t)-1u) is more clear? Oleg.