From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0A8AC19F32 for ; Wed, 5 Mar 2025 23:13:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6511C280003; Wed, 5 Mar 2025 18:13:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DA0B280002; Wed, 5 Mar 2025 18:13:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A29E280003; Wed, 5 Mar 2025 18:13:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 28164280002 for ; Wed, 5 Mar 2025 18:13:33 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A371755D5A for ; Wed, 5 Mar 2025 23:13:34 +0000 (UTC) X-FDA: 83189051148.09.E43514C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id 11AF3120009 for ; Wed, 5 Mar 2025 23:13:32 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Th+awcCS; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741216413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CFK0PmbhXsZRA3Z3WQZUDUMO1UckRaRXZsCDjXFOueo=; b=MyheLSCWVT0rJj9ZIphGK6Sm9unUYIRLp3Btb985qPVMvLaoTL1nbz0RBV3MSDApuD9RJF WvTgIn9uwSaCUJ4vjH5WAjQixBX6YSdSajndB8sXdbI7Rzunnv+o1qU8JUyAW/WgkpzwaS 24cpk1hBU0D+a4W8ImBa+pKV54uBHrE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741216413; a=rsa-sha256; cv=none; b=3Me6MXfs1xK7dwPkEGkxDMaj0twP2k+C5Gm1oUS2z+tECDXdMKD4Iuukec52WQbwu61ZZ9 3+ImyiUTTDwuwpyb7ZiiR2V4VxCnU0BF9/xKoqRiWItYZmy8Cfsg72qggiypQoI8SA2jUK 81sCGf88bru4t6VmQUdTBr09zkTsqI0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Th+awcCS; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 9FD24A45A6A; Wed, 5 Mar 2025 23:08:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7960C4CED1; Wed, 5 Mar 2025 23:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741216412; bh=nrs6zpmQViFjEJD8G+aklJVnKL0K+d4w0V904x6332Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Th+awcCSFo8y9tB/bPyc132kczNW/dq2JrKQQNV+PPnBmmxAT8cEmYJ3zD2m6FAWS U5+wcSxAZ8Ghd4YojxFBO8Y2NoFHE/xecOuQ4jquGpFSy+9AsEd/I1T4sZdk6aMTPW KI1NOj6Ol0T0AnkPaRII1L+Xd7dM79bL7QHW6bI5hU2vEd/RLl1P5+sQajIKnZ5t4n i300NdTzdNgbkcsiftwWHluxE+gqva6vBxhhFz0oy6jof0KGvtBOToRohyNKsq24Rv IsGOsLQ4aKrdMne2gKtKgF9KCuteLkiNzPl3vxS+VoiEWPG9xArpUg1uwtfBHHofry gt9LbXpuW+J5Q== From: SeongJae Park To: Shakeel Butt Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 01/16] mm/madvise: use is_memory_failure() from madvise_do_behavior() Date: Wed, 5 Mar 2025 15:13:29 -0800 Message-Id: <20250305231329.136686-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: w8a6yppjfbeqom5p7iwedbia571dry4t X-Rspamd-Queue-Id: 11AF3120009 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741216412-123498 X-HE-Meta: U2FsdGVkX198kMUso46SOoXW8doEJMusY8qX0cBd/7jh9CAaTyZbvadUdILqf47l3LQw4/qGRXkMpf0RDggdD2Dr8QNWkicSv05V7lJDOrWm+arNlgdDA6vkzuD0nTT55s+NR2fhTwb/RdeDYwbFjn4ZGf79OTJG1XlJK5Bng2Uvi9OIipk+oJwSzMgTt2I3GBCS9YBEBDrsUagADNCVX0fyUGdaIPHrneerTzCseZW6twGxB01IutkJkyGIY/j0mLMsxdkg2q9MuU7+1lqSCBYd/8jp5mzusjf/rFSKCMx4NQRU/h2TMc4Da1nU0LREzJo82k2ThbRDKb3oo/K6zBKAmkgjAQ467rZ8qiLdWRk5Fy/bdIqybBhxaFXcNIONykD3QBwEGTl2Un83ZBlFwYyzst0fn9uTXt+WgHSFhSSxYGypPGXnxftn2eQR0SBTRbrlhONiDl8NdXU8LAreyjdHtA9yjmPdHiW+ojMkD+nvBm/0oxB3IzTyjIn606+/3g5RJIkGvc+L7+l/AXPcX1O33hZgM1toeWbge9rXEKc58PpDN/93RazjqVOQ65aoYaR/MoLHPw/9aRAjlMzF62AanL9xY36RO7z95No++cbpB1dyAgZ67cN/I3MGCJMM7eDEUt+kiKyH9py1nVL7ri9z22dKbIn2t9BwEvUfgolpt/VIiy0aqHO3zFEPBO6sPmdD88cnUqxCsai5KS/GDezmQBTJtaoHtlK4CGbXXN616EyELkGP99ZsPWZSWF7u7MTk9Hjn3ndn1toGkzJEPWdrav4HYGz+WcloerYpU9ACMTD+RApwaS14JOJb/endyO0e7Nbf24IZI1YsFaiNMtmB48HUpjQzKacifahX86Iuguw+t86AEc99vZnGfuEgFE3bQCBr3Y+a5OCcW5GC3zFAc10ae1ULcyBzm7gQXj0mM1jUORCmm4vYFYdRXXA2vS1H6uauOm6BynwaPVJ 2aCsUdLT Sd3KhNqy6cqDIiu3JZHQ/vqMuHmLXyIN5UGRkwO8lJYSz4BlULeIaxSCoPHyGCHn9VYvJWeDF+VI0sF0671rSst5rYabR9PjpefP3Jsq8gtD9zCWKGwPvCNYLHiWU51BftCcNr/nooyTkkKySfDjpExZRRc95gsTxpHematnlEmgTRssG8lHmIYP0ui6GI9TPtJNTY2s9hrWX5a2MMhazNrecvPhq1VbYImraGFDoL5k9xMHxiJjxs8BdWKnwvYcckbuOGr4qxl4rk+TSKKQ4dcJAUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 5 Mar 2025 12:25:51 -0800 Shakeel Butt wrote: > On Wed, Mar 05, 2025 at 10:15:56AM -0800, SeongJae Park wrote: > > To reduce redundant open-coded checks of CONFIG_MEMORY_FAILURE and > > MADV_{HWPOISON,SOFT_OFFLINE} in madvise_[un]lock(), is_memory_failure() > > has introduced. madvise_do_behavior() is still doing the same > > open-coded check, though. Use is_memory_failure() instead. > > > > Signed-off-by: SeongJae Park > > --- > > mm/madvise.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/mm/madvise.c b/mm/madvise.c > > index 388dc289b5d1..dbc8fec05cc6 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -1640,10 +1640,8 @@ static int madvise_do_behavior(struct mm_struct *mm, > > unsigned long end; > > int error; > > > > -#ifdef CONFIG_MEMORY_FAILURE > > - if (behavior == MADV_HWPOISON || behavior == MADV_SOFT_OFFLINE) > > + if (is_memory_failure(behavior)) > > return madvise_inject_error(behavior, start, start + len_in); > > You might want to either define empty madvise_inject_error() for > !CONFIG_MEMORY_FAILURE or keep CONFIG_MEMORY_FAILURE here. Good catch. I confirmed build fails when !CONFIG_MEMORY_FAILURE. I will define empty madvise_inject_error(). > > > -#endif > > start = untagged_addr_remote(mm, start); > > end = start + len; > > > > -- > > 2.39.5