From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78234C282EC for ; Wed, 5 Mar 2025 23:02:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B13D4280005; Wed, 5 Mar 2025 18:02:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA638280003; Wed, 5 Mar 2025 18:02:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EF7C280005; Wed, 5 Mar 2025 18:02:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6E389280003 for ; Wed, 5 Mar 2025 18:02:26 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 64FAAB7663 for ; Wed, 5 Mar 2025 23:02:26 +0000 (UTC) X-FDA: 83189023092.25.79D48C8 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id 6A782120020 for ; Wed, 5 Mar 2025 23:02:24 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=M6HeptYf; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741215744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q6YWG0jAikSVdih9B4ZTcDcsqaiNC8RIrog6lCUFFOU=; b=qE3nrapPdTUwRdmFwQfKWpCGdXDVo7+D7v4W16pchNdtGsZ49DJ4ZmSTUGwAvsq0SCgjJF 9VfQXqpigicybUPKqhTwden0A+z3N/T3ebK6C+Sv+q/xH9NidW1fqHtWqtcFwgsJCm1ged o4dNlK+1TdYmgcwValfMirUEChlRIik= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741215744; a=rsa-sha256; cv=none; b=LIlCiH9Zjln8GZ3SPe/ZEQwTY98gjezsIYgYan4Kg8/PqbD+mmD8OxhmVVbYlKxY555mVQ OA5eFv3rj5Hng9QmCaNR29NULKigSdbuhk9DioxKkjHJ4HG70Ll7wV2vllxzivZZlLp0ok bDInpqNWi0hIXQ0xYcu4XhihBE4ARic= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=M6HeptYf; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 252BAA465AF; Wed, 5 Mar 2025 22:56:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 618B0C4CED1; Wed, 5 Mar 2025 23:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741215743; bh=RT34XeNjBWgzD0ZN8J6EvR3tl5kGle9qJ4bsjQ3pd50=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M6HeptYfM5LX312DQ+XiDr5qTJirK8w57ErL1+7DiDSwXjh3TAmLmjiCNdY4KFGqI zTsVfn+MC5I3CBVRT5ciopZFt6DFsw6fEpAiFkhQTpQNWtSqf14tMZgRBEHvzPs7qz S8Dpqlj+WU9n3jAQOpw5vBEsbKHo/z+Q2li/KKDG3VHWy67I8QiUVlIgM1+UvB92Xa fqNk7anhzsLVRatfX6X1ERumDS+/Ih8gG5zvIvCRf98oj1qRXEJIixz6ygKIdSqOYS Gi1nsbh3jHmkq4ftxg/wQ6h4WYjfk4X2HlfqIPi9xjqL7EvmASYwhjqw2JMeut0IHd m4V69v7GO8Z5Q== From: SeongJae Park To: Nadav Amit Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, Linux Kernel Mailing List , "open list:MEMORY MANAGEMENT" Subject: Re: [RFC PATCH 00/16] mm/madvise: batch tlb flushes for MADV_DONTNEED and MADV_FREE Date: Wed, 5 Mar 2025 15:02:21 -0800 Message-Id: <20250305230221.60260-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <7BC81F7C-191F-451D-8FE5-5BB268F6B0A1@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6A782120020 X-Stat-Signature: aamhbg9qqyj3rzo67j8sn9kjsbfnwufk X-HE-Tag: 1741215744-847070 X-HE-Meta: U2FsdGVkX1+iFnmCnEwGRUfvY4Ijum8UShJrwODIo7+PBCKu5ngbPkFRz/KBygiXy//oHw49+mMUNL1n8cZWdpGVmJeP1kGsB0D399eApICT6M3tbJr7wwO7punvhd2DZZ1iRFopmGg6Iag5zjmBLi0HeLQcwd4bNMo+GtmBeEIfrkuEqZe3iuviUwfFL+34Z5IGjj0v/EINheFAumWWVm6ExCWOilTeDaU8HdhLDJJWkk9lHHKkgf2tT53m5pdx3d4dzm+Q2YmRcSJ2NQXbI4yGZ9TYA4sTaPIv9zDHDRlNt4Q72TJyBgPkf4TXcw+Ik9AjrsmSvdyawnAcUpOnZ8kL5IZ9GQuyMf70tzJK91wd/eagVXGie6nfAEmKRbm66wE5tVoT6SdZTz9aoSPVFbfeopTB7SAs7fFvOB1MbYMFik0dIp0C677qMW9NbuweIzTJ1lUqcFp2X2OsWTkDsn18Tntxim4PGHjLCscS+Iv2zuD7TI99SrfCyJ/NUUE9PXOfx4ibFdWB8bHlW+3XKVciCFL975w/jSsZTrz5Ge9Jzf9KFEIhBBcVblattqdc7GKv0cvXdoCIeo84TrA9/eG2R35veZcydJK7h6EcVW4NaOUn9gPr6bnDYvEe/EyoOeYASLod2/0dHrOR0A5JIev17PICRVEv0NJ1GpcFdCS/Whax97gmkyfUg3GbdT561oUoDPIwWWalUlVCHF4u4MTap+qs8fT9oV85bs0ltd3dJDW+bBi3mdRNb1r4+PMtVc1k7abWs7Pm/mJ9u+a3XLx/fx0cagI/KXJJNeEVK+O3M/x01FHSZzY7/CYBMXq5Qghan9ap7EVUxnyODFiqIt+PmZexwT18RzHJOvkqjPGG9FemQd15Vw5MyHXv7fa+vPSDZAT61d54z0WpVzpIQbIyZsPnmI/AYzUzL6GWYQVSlsj26EY9wgav/ywYAJamA3RXhu1/HR6TT4khPmt nyPK9dmC 4maKGVCGnmS1Hc8kIvgeN64tpkgl4h9eZrwHssrGh09WiTT1Y4eKX3VpXKsk/GQ72cqusIZDmWQm1H8jDLMMnySHSzRIhAzu5FMkcEYYf4ukMURC95+AHOCmK5bzmxBhbRIoXY72fX1RGoRWrWOVvh/aa1EZuYKg2gCHSGDs4H0kSSPYkJOYnKwEWbB0cxd7IXT2UvY8H53JADKO8HzqnTPloDnXS79//njjSl821xtuv9ONFVIhZ3bZ7E/xv5xtTCxQOR7Ne8+ODBAxF50kLW3xlFTPdtZpSZMu6T4DBdRsZu1AOcxj/GmmV5DZHviXd2bXBXlRHM4+igctmWrNGp3u0+M/xrmwxqjKrT3Hpnjb9YYNPCv8zd96IdJs0pQGM0o1fyAsBRY5Z7EcE7OWA1y+T66zlOlAcXdgpRDPb8Q4DJjHQoggJd1d/aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 5 Mar 2025 22:36:45 +0200 Nadav Amit wrote: > > > On 5 Mar 2025, at 20:15, SeongJae Park wrote: > > > > For MADV_DONTNEED[_LOCKED] or MADV_FREE madvise requests, tlb flushes > > can happen for each vma of the given address ranges. Because such tlb > > flushes are for address ranges of same process, doing those in a batch > > is more efficient while still being safe. Modify madvise() and > > process_madvise() entry level code path to do such batched tlb flushes, > > while the internal unmap logics do only gathering of the tlb entries to > > flush. > > I made some related (similar?) patches in the past. You can see if you > find something useful in the discussion there. I think your version avoids > some of the “mistakes” I made. Thank you for sharing this! I sure I can learn and use many things from this work and previous discussions. > > [1] https://lore.kernel.org/all/20210926161259.238054-1-namit@vmware.com/T/#m23ccd29bad04a963c4d8c64ec3581f7c301c7806 Thanks, SJ