From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C20C282DE for ; Thu, 6 Mar 2025 06:39:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DE766B007B; Thu, 6 Mar 2025 01:39:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88D296B0082; Thu, 6 Mar 2025 01:39:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77D006B0083; Thu, 6 Mar 2025 01:39:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 596936B007B for ; Thu, 6 Mar 2025 01:39:00 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 98B76B8766 for ; Thu, 6 Mar 2025 06:39:00 +0000 (UTC) X-FDA: 83190173640.04.AC7D50B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id D762E140002 for ; Thu, 6 Mar 2025 06:38:58 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="nB/HooUz"; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741243139; a=rsa-sha256; cv=none; b=OLzh6iaOIEjmNSp9jTVRHbfe9UzVHB7sc6Oj6wfxfLu5kqvAH0w4wTS7wLUXzmhGbSfpUV uoqoc0VB22sQvIRMwOdzKTyLyuL3pWJjN/R2VxEYRaP2wQm4uKd1O7cbSYlSgNJ7csmieI 2Pl875vLfdzFa2NCQ6I1s283XZ7nFp0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="nB/HooUz"; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741243139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cQXKOcKDXauLiN3vpydLbpAwfyJsVi+QEn4uF/FRXGo=; b=ahrA4LPb4ffVZpLVGnvKXOxDZOtyrdm3HLRcNn88NdVrVB5jE3KnvbvOxjOW4sPsNo9XWl oTTbciVMXhN6gX7MU8jASm0ZbCN42OeZa4A0CAE6FdP/ZT4Y8uJYPpfGW7d05zebd2eN8A Gw/lOwYQ5lzO8HDXgSp1HoU16+9hL5I= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EAA945C3DD8; Thu, 6 Mar 2025 06:36:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE21FC4CEE4; Thu, 6 Mar 2025 06:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741243137; bh=PlpKZKn/KdWC3NfT/6WeCDc7fHykXga8zHfHhafMXrs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nB/HooUzZ+2R2690PKAiPLlhVvDVDT1BNHhhZNrzLsSUvcPyPg8XgfSrpuslliXZo PjzDHycXNWMdWJB9ysa3vvxpOt+y9/47iosuhsfPuIwYNIutrRvgk3MhEqPxSMtDjs wt3i5do6CPfak4onEGRuDB3zAiUzuxSTGAbysKtk= Date: Wed, 5 Mar 2025 22:38:56 -0800 From: Andrew Morton To: Dev Jain Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, anshuman.khandual@arm.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, david@redhat.com, willy@infradead.org, hughd@google.com, ziy@nvidia.com Subject: Re: [PATCH] mm/vma: Do not register private-anon mappings with khugepaged during mmap Message-Id: <20250305223856.bc1a0c90339cf0d353e8be34@linux-foundation.org> In-Reply-To: <20250306063037.16299-1-dev.jain@arm.com> References: <20250306063037.16299-1-dev.jain@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D762E140002 X-Stat-Signature: 3g3prbhrnhjgx51a7bnyd1ajtdrdam38 X-Rspam-User: X-HE-Tag: 1741243138-477541 X-HE-Meta: U2FsdGVkX18x1T3xfiPHAL5QGNtt9iqNUKBHBS7gjvP6qUd4vkgtb6L5XFcGk02UQXSio7FtZgDv8Sk2FgSQZ8qAxFAJB+PF2lY+g9GXZv6I4W2hUArHBF3Kth5LRQC6os+RJ5+j3cUWNMdXHRomfqwdwVuDt970/W0xRU5ctHFsODp/PL51nCM2XxC9rQFgAo/5YOmY9H2X8k0Vi5AW1OlYXX2t8TJYWcOdg8W7w6EbHMrvgOtw7/k80QEhfGjcZoUFI5JjYXKvQUn5HNIYQfqgAbbHbX9h0Ij1aRBKF6ufQEBKpfYY5nh+QK5OwWv6fYRjCtgQGb2IVr2xZt/HwZDm9564Sz+D4KXcGZw9CE2dObkxBoaQhsGbrhShaIl6l9CVEf9RYBa59iT9EytHYiaR6PWAk4YqDjkVzgc3ZcCgn3Wz7raKo527Wie47ob7QpWpGCcwWGoV3CG9ms/FKgMaZWJs6smZAhVMwxCKLtJFtZx4jssKgHry5BW1J+mk+BeIKDR1OLW/ARuDUbxIcmMMVElxH98pIc86T50tQkLuvwCaaFPSzYRfKn+CgPmmpn3P008/NllIMejDF1CCOR7XLjNRNEgbn6OHK6hOPQy1ohu6+L1GKbBe5OO0JFS9tbbJMi+Pvg7X0cDiEjPZLvA4ZpuH31Pl0p1w3v0jTAc7K75H4v7joWsKCE312jxDAjAPP+AXhuNaY4O5JOHhN8Y7s8PJDtdEsTzUE5TFZkDZ2DxZQzvZgJiOWMmE8KUhozVfU6VDfMFelpOHmuJj6tVMYeFlODQSRq2jKhtScpuOGDvy2D9ggGO9m6ij/TYW8o/N1ODbysdoWTzjz7zt654kwA/kdwsx+iip7ikqBNMiNUCd8lgfIbRIHKpIpHPcUIfLDA18rl5Suxy3iNBKtrIRI+huhg5EWZS695Efali1dSizcWmPI57d8K05/ZoY7eG5xYo8sX4mVS06hkQ dUQXJFqm nf5S3hjQY3zJXowyKZohcn0FLGHMr62EFXm/3KmGrFEkKasJTwrowW3Dfc6Uhhu9WoRiCQK1+NrPTc4k2VD3OwXFqtiBeull6Y8flzIBLoXAEkjc3Z29OZvZIaqODL/dAOiL0/iH586tZ3iG0Y0u3SRPFhL3fjMzw34FYd89y8ckW6wBhNjg5Njng4PQjrXrGyVsHeNxM+G8BJsLsbjZl8NZV/QZm5xr+z1j/trllBUf1U3gUlkGkHTvsaGA/qdUoNfC8GTT7Nu2R93JMW15ZZLV/gfr7Wo9nC9/qkCN4msnSa0z2WVxNgCeV/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 6 Mar 2025 12:00:37 +0530 Dev Jain wrote: > We already are registering private-anon VMAs with khugepaged during fault > time, in do_huge_pmd_anonymous_page(). Commit "register suitable readonly > file vmas for khugepaged" moved the khugepaged registration logic from > shmem_mmap to the generic mmap path. Make this logic specific for non-anon > mappings. Please fully describe the userspace-visible effects of this bug. > Fixes: 613bec092fe7 ("mm: mmap: register suitable readonly file vmas for khugepaged") > Signed-off-by: Dev Jain Thanks, I'll add cc:stable.