From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A517FC19F32 for ; Wed, 5 Mar 2025 22:27:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 254D2280007; Wed, 5 Mar 2025 17:27:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 207EA280001; Wed, 5 Mar 2025 17:27:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07FB0280007; Wed, 5 Mar 2025 17:27:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E147C280001 for ; Wed, 5 Mar 2025 17:27:42 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7A569C0B77 for ; Wed, 5 Mar 2025 22:27:43 +0000 (UTC) X-FDA: 83188935606.02.EA7EDE3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id D95012000C for ; Wed, 5 Mar 2025 22:27:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MBq58oec; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741213662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JAxCuMcvL29D1SOmmNGOr37K5swVLKKjmsz/IwJp9S4=; b=CjEWjy88JRH6cy3IY5995QWy/l9M5f5w0Zk0wbKALeIE+84fyCCXSDXJmHF2y7qnB6Z9fD v01xtlV1snYM+IEC6s9BkgiShcJm1CIdqX4qle44D9zsZCi323LM+Hf0LO8I4/FPCLyxVJ WE1eeHbMDpOFWOleAbQDWGEHL5HffU4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741213662; a=rsa-sha256; cv=none; b=WfMZyzy8XKdk7AgYwfQt28Ot4h9siVm8hvGQ8lbRzb4YuyOXmvNHqI206nlNvJbyTQiDpZ 0ehXZEsRnzU+5uAl+MILy0t1/tpmxNNxOV+L4o4AgbZATJDsivRTY8MP+vitgwdYVp1FLh ECyAlpW1hi9uGAVaWuJhDhLgmW5jx6I= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MBq58oec; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4CFBD5C677A; Wed, 5 Mar 2025 22:25:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C03DCC4CED1; Wed, 5 Mar 2025 22:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741213661; bh=AUd6l3/n6b21S89N2joBnG5ZkxmjuNuJETDzA5Bc2qA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MBq58oechD8L4MQkW3fn0Tpw6vXxl4DckF6IuMpfAZ7cRURq4LSqwmGfJ2Qyhyl+j xILQ+rvDl6RTD1+f8ioKV8c6jWQOoW+VKKSFQCCUDpTOy5zTntp8YOL2Ul2FM6Q/af CWalBjWTs6JYvgEetmJxcTcs5mr0fyzFJWMTu7dcVCAWoG42xsD6uS/M1F9I8MQFmn 8fM0m/anAg5J9hdnj1Eu9L6OCHJMfIkXtXUhKlzYl1Dp6wnS14ktdfMXU6P+JQ81v4 OT0jo8U6A22XAubNVLmW4qRSk5ihvC+FEdxwfMo+UTKw0czWbtMkZv0KBNEooRypkv +uwxQJp8YCNtg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/8] mm/damon/sysfs-schemes: implement core_filters and ops_filters directories Date: Wed, 5 Mar 2025 14:27:27 -0800 Message-Id: <20250305222733.59089-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250305222733.59089-1-sj@kernel.org> References: <20250305222733.59089-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D95012000C X-Stat-Signature: f3yiarz8sb6etbzntqiwn64z59dkyizm X-HE-Tag: 1741213661-98978 X-HE-Meta: U2FsdGVkX19KlOtMY9WRfK2bBpbrklF08GY2Q/EsYCpkf+EkpwrR90mjWWm8kVHgI90NhaP8x+R+2fyC/i6HwgCu/OsQvPsr+MT/Ey72ioX57/OVH4AAWGeW5qbynqxzXF5PTF2BOLK4scK77ARfYwsfmNhF9sXtJkDShRlMG5YbaNw7h47R3QVsxxbTjcDAPN0bMexasls0ZK3lbVMCIELo3ppzd3cUB46Klm2nuaLOOtCJEwcrCQaGCtf0grNXqq37mdhFo0m/1WfFO9Q85YHjkGqk5rkbG9KD7raFh/83FWntQey2OfYhYaaKYaSlWZZuSyAH9Zp4OslGDeRlFVc0VKiF836x1ZEtWHtPt3kUzvXtFLjJk+Q4VrZaQfnTH70+85GrX1DGoTDP/PnDksQugb5s+RKZHRQj9BKAKO5CfCuDRl0/Aw44PpMZHJdf2552kGc90DPiOOmutdqvA4tCHJUhfxgn8dj8jkXVtWVKDaN0yCc0061WhfIs3vFSBZurFdz+EXaH/YcH7ZYQmIvK8kUleeXGV1DP0JlFnwBkioxwFU8+Cvud3pN/XooPPooQJWPVp9i8LLuovtzvexslZyinBvdrF33WM6pTm6Vfay+Jwnx4KZ11QvVhHSlXmn4jjvQLJOU8kw9tJbwFLA6uMgRLr3l3d9KSL+KfRYZ9FZ+Rdl18Bq8imF1PxM/L00lsrtydsvx2u/ifyLEumgvpHsWvrT0orz4ZG1jOgk6KISfx5PwLibZMIBGfCb+pZomr9uPYebcaLOfZSvZMk02W02r2LEJ/SebxRM0HN6tsfSQ935+JFm9OnCgNZnOZWIkIZ445T5lpFUqBJNcdMFBW1WuLLt64FcDvoraTwCVN7MSrGGEQBbSpsSxlf16ZRupe2gbYzWMCQZ/TuuetP1agmupuUwrbW4Dh0UbgOB64DgZ3s9IxKKEispG2HwhyH3LI/Ad+nUSrk+EceiK CR20HbXa hXK3CQx5dkB+BU6cCK2JQ0n7TySWx6+H1V6cPqaicbe32ptJQyelp+uS8jCweXK5Adg/sQjpgRT3Yt/JOCXpa/gmuz4B6PPl8YPFsjmm+kL+H1p0atzu82zXv9Zmo2WHYCEh7HR2jeGJ4QLLHWH/SQ8A4XofFbWUw1PRM7LKxqRke/l1JBC9XSa4pIZUyMvcP+cUtHI6mwfrxXUSUAltW7cPZhRZRcdJg3NDrOhGoWKcumrzGEGuAj+aSM96YAx47wLbgJCeuu1o+ScOXyPc/0BnhCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Implement two DAMOS sysfs directories for managing core and operations layer handled filters separately. Those are named as 'core_filters' and 'ops_filters', and have files hierarchy same to 'filters'. This commit is only populating and cleaning up the directories, not really connecting the files with DAMON. Following changes will make the connections. Signed-off-by: SeongJae Park --- mm/damon/sysfs-schemes.c | 40 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 541ca5887b24..61ff800ce78d 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -1504,6 +1504,8 @@ struct damon_sysfs_scheme { unsigned long apply_interval_us; struct damon_sysfs_quotas *quotas; struct damon_sysfs_watermarks *watermarks; + struct damon_sysfs_scheme_filters *core_filters; + struct damon_sysfs_scheme_filters *ops_filters; struct damon_sysfs_scheme_filters *filters; struct damon_sysfs_stats *stats; struct damon_sysfs_scheme_regions *tried_regions; @@ -1624,6 +1626,33 @@ static int damon_sysfs_scheme_set_filters(struct damon_sysfs_scheme *scheme, return err; } +static int damos_sysfs_set_filter_dirs(struct damon_sysfs_scheme *scheme) +{ + int err; + + err = damon_sysfs_scheme_set_filters(scheme, "filters", + &scheme->filters); + if (err) + return err; + err = damon_sysfs_scheme_set_filters(scheme, "core_filters", + &scheme->core_filters); + if (err) + goto put_filters_out; + err = damon_sysfs_scheme_set_filters(scheme, "ops_filters", + &scheme->ops_filters); + if (err) + goto put_core_filters_out; + return 0; + +put_core_filters_out: + kobject_put(&scheme->core_filters->kobj); + scheme->core_filters = NULL; +put_filters_out: + kobject_put(&scheme->filters->kobj); + scheme->filters = NULL; + return err; +} + static int damon_sysfs_scheme_set_stats(struct damon_sysfs_scheme *scheme) { struct damon_sysfs_stats *stats = damon_sysfs_stats_alloc(); @@ -1672,8 +1701,7 @@ static int damon_sysfs_scheme_add_dirs(struct damon_sysfs_scheme *scheme) err = damon_sysfs_scheme_set_watermarks(scheme); if (err) goto put_quotas_access_pattern_out; - err = damon_sysfs_scheme_set_filters(scheme, "filters", - &scheme->filters); + err = damos_sysfs_set_filter_dirs(scheme); if (err) goto put_watermarks_quotas_access_pattern_out; err = damon_sysfs_scheme_set_stats(scheme); @@ -1688,6 +1716,10 @@ static int damon_sysfs_scheme_add_dirs(struct damon_sysfs_scheme *scheme) kobject_put(&scheme->tried_regions->kobj); scheme->tried_regions = NULL; put_filters_watermarks_quotas_access_pattern_out: + kobject_put(&scheme->ops_filters->kobj); + scheme->ops_filters = NULL; + kobject_put(&scheme->core_filters->kobj); + scheme->core_filters = NULL; kobject_put(&scheme->filters->kobj); scheme->filters = NULL; put_watermarks_quotas_access_pattern_out: @@ -1711,6 +1743,10 @@ static void damon_sysfs_scheme_rm_dirs(struct damon_sysfs_scheme *scheme) kobject_put(&scheme->watermarks->kobj); damon_sysfs_scheme_filters_rm_dirs(scheme->filters); kobject_put(&scheme->filters->kobj); + damon_sysfs_scheme_filters_rm_dirs(scheme->core_filters); + kobject_put(&scheme->core_filters->kobj); + damon_sysfs_scheme_filters_rm_dirs(scheme->ops_filters); + kobject_put(&scheme->ops_filters->kobj); kobject_put(&scheme->stats->kobj); damon_sysfs_scheme_regions_rm_dirs(scheme->tried_regions); kobject_put(&scheme->tried_regions->kobj); -- 2.39.5