From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ECB1C282DE for ; Wed, 5 Mar 2025 18:35:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED034280012; Wed, 5 Mar 2025 13:34:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8108280008; Wed, 5 Mar 2025 13:34:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAE03280012; Wed, 5 Mar 2025 13:34:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A7995280008 for ; Wed, 5 Mar 2025 13:34:39 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 730F71C898B for ; Wed, 5 Mar 2025 18:16:31 +0000 (UTC) X-FDA: 83188302582.07.2DBDBC8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id C02931C000B for ; Wed, 5 Mar 2025 18:16:29 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sN32lAfO; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741198589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3KfMVIKNn6da5EWExH1fQbkcjhelc3wqv/jnIkqx/T0=; b=A99IEOjkZ+L64+AKhzloLTZ9kIjmBRt0qIH1PvM4BRbsQt1iB2wfwCnlvfh37Ym+tE2bSH bwir0dBfPoEFIcKxH4OcuiBzgbhL4uBRGWgXnG6IMugDiJ0y7wzkMfGdJCfylrSw/XgFMG NmsRcH8mnYbA+AstMRoh2mkQj2iV7Ns= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sN32lAfO; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741198589; a=rsa-sha256; cv=none; b=v78xi/Vo22wqO4U+xQ8CUKMBUvkivNSj3MFgf09Bo65NVe1RwH2F88kX3IKZW9mc7NGp1E SRsGBdIRMXf9l4S8U2n2Fc9I7rdZmB9jyes7NXBCjJcDfXHjQKFSNjE1OPaVUUrZ8w473/ f2aj0SkWVJ9zVf67qTZuPqsKEg4BD4w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 96EA85C6B93; Wed, 5 Mar 2025 18:14:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16D77C4CEE2; Wed, 5 Mar 2025 18:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741198589; bh=5ks7fx/Q1sCl0dg2a2snRfWoft6X+IgkXl2rMy0gCGQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sN32lAfOUBUATYQrwl4BKcRsrxm4mSQ3kaYsz2Z0kSriFn1jgHlzV2U6C0xBm4hsD 7coxL6aUxhuXz8dmZDGAsaUAqHV7ZEehscytuEa1vzbq5q8IyAtkZv7VEsjmKuJud/ nTE3QtKiSWsnOMNuDEtJc+rEEuERdsBPbstKTMn31F18ss5rnYWoEV1kGzrwhf9So+ Oh78y+Kz0NuzwnB6DhGgCOqIyb7sWaPAX/f+xGUuDF9HqCWId0tYJK2QPmxz+eb4WU oQOBVsBu52cCCIl3YKWmT+1GhR+dupStWnrMDZwC2FnOPaLGckhmNZGnmQWJRAYYG1 kn3rTbJOOUrVA== From: SeongJae Park To: Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 08/16] mm/madvise: pass madvise_behavior struct to madvise_dontneed_free() Date: Wed, 5 Mar 2025 10:16:03 -0800 Message-Id: <20250305181611.54484-9-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250305181611.54484-1-sj@kernel.org> References: <20250305181611.54484-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C02931C000B X-Stat-Signature: cbmur3x6jsnpbae5rx5mr6y9er7mme1p X-HE-Tag: 1741198589-668249 X-HE-Meta: U2FsdGVkX19ouEvECO6UbiqcIOmaAJtOEbFzStYelGKs8AJKXFIv3PDNkuzpDVp6PRpnkwb0KvGgLi9o0uIcqqo7vx+BGqSOsPzlkQRUUKOFh0OXGKCOUVoVE/jIknZLeNYANH2cmG9xD+O6lvCVDQATZDAzS4LgnNloiIpbGdXV2LTBe/FinnITDat3Zfus6/XtQrHLd9qvyj4/i0YXWHCz4qbJikojotU5EQG7y91nbwIofMFh918eI2f9D61KJMp9AJztJaC/e8b8qz6Wkp7RG4nctokRVHwL4eq1VUW1EOYdL9BPUeox23pG7veQ3TbbhNVdtrUul3ZP2ByW/xqjzQ/k8QaMvDFCJoh3B9ly9jA6JmgwYpdXyBrnlNZ6sOg3oc75X/0BG1keGvYiNPM7KJSgkKtFcbWo2mx2QhCjcIQorGFz3bkYAXe9PrsKORK2jMXYyraRU74wPDf4FvgM8G8cYeRUZX5A1JlbJZKXHEVUq10Dc/u53VhgZS1vr1BwM7mWSBU20FxT4GJ28XT2+1hbpwFwbLRAXOJmdgEbXkKgn0wSh0XpVqRG9sJSpnkuEJRUSPTBOWYjgsSFyKareztWOFSuQdbCOAxQh5kVVPsvQONJJvSJDj+Jk/PUCOU3Q/a3IiUyES0dX/Pu+shDelXbd9YyLRyjTlhc9wEqr/5YzmRIhqlMtZG6PYsqA9l0kotygxM/nmi1jles6acHl5PdFIx2d/rO9ojM1S3NiIlDYb3L8VzMfWsk11SWdaE4C34NPX1iBmm1m0Bqv+tFUUbiEeIaon7XDOpwK2JKGioOEjwnF4eUcmRLi54GIMEm2VIysN4ZAIFbeVp2QP0fI+AAm/scHoA1j3IDGeGKvCDQouuWLwcg4cfupKmhwZb+f5pciMlvPGu0unDkKGWR1p3GX1x9jcjEMb4kEKGzrSoJ7S/g8WSfm7RTxDTa891fkxo+TGvXOPsZt82 +TYVr4qt ZfAP2QqyW9Pd5a3c89r8IoqqGzqz4oRTy1Zq/nY7kUuXiUfYjCxEtKdIAdSfA2R5X/ivAE47ihfDzVO5/kutzEX4USWcmrxaJm4FaY6rWe3pYA3Ze+IX8/9o69NbiKMI1drjTa5X1UrXlKJn/orL+xhgIRRsbUMqfkGZHVsOdbzm0M1IXR7YJWCuKeEeCzuyKILIonPgju2Yug5jOZzlKHlLx9W/Cu6uBmbqkK1qXvQcsEruTCFoQVanFsBAT9C/AzNjASX4Oj9V7q92peKoO3gAek7oAsDgmYcl/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: madvise_dontneed_free() can be optimized to batch tlb flushes by receiving mmu_gather object that initialized and finished outside, and doing only gathering of tlb entries that need to be flushed into the received mmu_gather object. But the function is receiving only one single behavior integer value. Update it to receive 'struct madvise_behavior' object so that upcoming tlb flushes batching optimization can pass the mmu_gather object. Signed-off-by: SeongJae Park --- mm/madvise.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 6fa7dabe5bad..73a4323197e2 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -890,11 +890,16 @@ static bool madvise_dontneed_free_valid_vma(struct vm_area_struct *vma, return true; } +struct madvise_behavior { + int behavior; +}; + static long madvise_dontneed_free(struct vm_area_struct *vma, struct vm_area_struct **prev, unsigned long start, unsigned long end, - int behavior) + struct madvise_behavior *madv_behavior) { + int behavior = madv_behavior->behavior; struct mm_struct *mm = vma->vm_mm; *prev = vma; @@ -1241,10 +1246,6 @@ static long madvise_guard_remove(struct vm_area_struct *vma, &guard_remove_walk_ops, NULL); } -struct madvise_behavior { - int behavior; -}; - /* * Apply an madvise behavior to a region of a vma. madvise_update_vma * will handle splitting a vm area into separate areas, each area with its own @@ -1276,7 +1277,7 @@ static int madvise_vma_behavior(struct vm_area_struct *vma, case MADV_FREE: case MADV_DONTNEED: case MADV_DONTNEED_LOCKED: - return madvise_dontneed_free(vma, prev, start, end, behavior); + return madvise_dontneed_free(vma, prev, start, end, arg); case MADV_NORMAL: new_flags = new_flags & ~VM_RAND_READ & ~VM_SEQ_READ; break; -- 2.39.5