From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB234C282DE for ; Wed, 5 Mar 2025 18:34:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59EA328000C; Wed, 5 Mar 2025 13:32:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 54CC2280008; Wed, 5 Mar 2025 13:32:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F2D228000C; Wed, 5 Mar 2025 13:32:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1CC50280008 for ; Wed, 5 Mar 2025 13:32:32 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B6B14C0947 for ; Wed, 5 Mar 2025 18:16:30 +0000 (UTC) X-FDA: 83188302540.23.B4AA7B9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id AF2DD18001F for ; Wed, 5 Mar 2025 18:16:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NJNXUPRx; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741198588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6qAvzzGXfRPnq5itzJ++hOWOD9mv0c1nzOsOjm8pozc=; b=s5rA6uM0iqjSCswlUOET0/hnRAKlYFFNUGNAT29lLJILjBBzBjXDAfw65Pmt8v8LLofmmw 5/QQUWYc05QXj977r//XMnlhudMrwsrEv+kx4ZrHe2Gb0+Dto4pDLXGxBy86viTP0kExLP b2gYvpCpEQLWhTArzPp/ecmelrGqpUM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NJNXUPRx; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741198588; a=rsa-sha256; cv=none; b=lljxJR4P4D7IBD/wB29FqZOVzvANcjnG7ea/GnH95E9irAKNxvtLnBNEDE54nQal41tVF3 O99VdqmPfL1cbfgDgnF95fkDtinVSWqD1UbglwD1WKxmJ8z8VjzzWkhDCHrhoJ2o48FEAy LRGSppUgoCsl3JMZxYbQeKk/afMbxqg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 726105C6BE9; Wed, 5 Mar 2025 18:14:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E25D9C4CED1; Wed, 5 Mar 2025 18:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741198588; bh=3LG3O8N+F8TPPzR8Mb+NGODzxzconMM3ZSxJjGwNDUk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NJNXUPRxqjS1gIwtMlxNbHOdcW9b79WtuUL9PyyAEjlIn+Vmdx0iNdtdhmifJPV/R GCVbmonJu8xRM/kk1GlHomD/e5U5XgM1Mb4hpN+hhnvzr0gKLqLDQ6Kgx4D530bHXB Gme7DF42kCSOhJa6YAaCSpl/2/uZLtNh3bZ4RcoB8CGYExP2VclEe8CSPjg7C7oPfq 0CWC2UoS3J+VTBFxclXBq8041eB+Tr3mNqQTsnpMPctCSCNU8Caa8ZF3vNxC4wlPuT Xf7drlusvq8z2sRG9d+2OvVKAG+6QfWdADuPevd6T8pyRWvg80ned9ISgfgActsxyB dJGUsCap7Ys/g== From: SeongJae Park To: Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 07/16] mm/madvise: make madvise_walk_vmas() visit function receives a void pointer Date: Wed, 5 Mar 2025 10:16:02 -0800 Message-Id: <20250305181611.54484-8-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250305181611.54484-1-sj@kernel.org> References: <20250305181611.54484-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: rp9e4f1d6fg7t9wpsefwngsowztt63h7 X-Rspamd-Queue-Id: AF2DD18001F X-Rspamd-Server: rspam07 X-HE-Tag: 1741198588-620816 X-HE-Meta: U2FsdGVkX19nOk+CX/Uy22UPvUtgf3zUXQzoZsu4gDDWrBz4vTneskVeV+tdHLd0FSYQ9l+zLGGtqjzdCssC5/fM4GmOkMcJbe5TapAQ/I28gDWajRAxhEq22OSBpakOUPZSyhXGOWlOH1oQUvKA7igzVtvU9hYRwTBt4TfEAPfxXocbL+Lsl0URhwGNVnxTjjvk+Nn6ZcG2uxawY/eJhYSbe0Edi3MLHpQ8NlO5/K2l1lrxsoNenq4AnwjUCgDbXCDS9acAPTf/BZbqVYUud9M8NIJxfAjrwk9u1JsoC5ba36ZN6sO+KrcE8pBn2TypTYviQ+weXZIE82I0i49wyEjuBkoEe6lD1AyaQlKQNUxOPk3tddl8T2AkmGD5lszpuqDSdIZGX9Y0P9XpzBPZIPQBw4/o8IGGW3w7TdxhfV3ZYk0bprVadfeAXFUGPqsMwG2hQYs93/uMqs1yG6XUreOkKzVme503CdGzIQq/I9u87FKHqgZ1XnKal1z/MR0PzEqrbC+j+0+2T0lIqtnYN56BJioMKxcq62Ec6IDJuywa34MpLxo079ATPG2RYTCAYrLdtcOSQU6oXb6xw/idAaoZDNDz51aTXpb3I8N5eYlWolULrBT7WbVcOXYPHPY1O/vND1F2NrIpY+KTz6jRg0As0P046ezhy6fyGoCO5a+TUr7J/mpbdsf0nnRQCNQvslCDrC8nEjT0IKBnEzYQiHqr2KFOQoE/kg9j4la0qamMpEXXrDgMLp9rRjink9UEp2DPPOgVHTmlohmvgeTQUau63WiAhAKTdtS6QpnuuBXiCIkh0NL/vp+bRZ52dF7sj8Z5b3cIl/yA3yi9Fyp7kC5UhaSVPusHsVex3eCA6pLRt5DIEMmLTLSA9RbVGu4plNYAtOZv3z02KKcvsbIOv5JbZnTMib7YYMhYD8ubWr8w4uBhaIsBCH1iZHnHZ6AgSgL6PCzwULLjP6SSZhe RQ4hK6L6 77hliSPWqPC9p7Q/dfTJCkHhkZiwMa4UgAaFDtGHJIOxyrnTADwNYdgy+FXFRW2iUR9xGn5khHoS4KW8dVwjApGhQNYYcGAoHTyatukUKkKHPzh7XbtELl4cMRMDN9TL6uYhdULNTc3+vnkdWGv2wBgna+tuPfmzSCMYcy7J72enY2NVeczWA7zFry404C4CpQ9H/iZFvovpi1VYNdgYKrxMp2a3/NS7VTfe1uh1H8Fhe0FYG6sWb4zpsK2+3PWSxGhQgtlFcbkiFgCFF2OpqIquC8g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: madvise_walk_vmas() is used for two visit functions, namely madvise_vma_anon_name() and madvise_walk_vmas(). The visit function type is defined to receive an 'unsigned long' type argument. But, both visit functions need a pointer argument, so casting the arguments between 'unsinged long' and the real pointer types. It is more idiomatic and clean to use a void pointer type for such cases. Update the visit function type to receive a void pointer as the argument and cleanup the type-casting code. Signed-off-by: SeongJae Park --- mm/madvise.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 8c4c128eaeb7..6fa7dabe5bad 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1253,9 +1253,9 @@ struct madvise_behavior { static int madvise_vma_behavior(struct vm_area_struct *vma, struct vm_area_struct **prev, unsigned long start, unsigned long end, - unsigned long behavior_arg) + void *behavior_arg) { - struct madvise_behavior *arg = (struct madvise_behavior *)behavior_arg; + struct madvise_behavior *arg = behavior_arg; int behavior = arg->behavior; int error; struct anon_vma_name *anon_name; @@ -1468,10 +1468,10 @@ static bool process_madvise_remote_valid(int behavior) */ static int madvise_walk_vmas(struct mm_struct *mm, unsigned long start, - unsigned long end, unsigned long arg, + unsigned long end, void *arg, int (*visit)(struct vm_area_struct *vma, struct vm_area_struct **prev, unsigned long start, - unsigned long end, unsigned long arg)) + unsigned long end, void *arg)) { struct vm_area_struct *vma; struct vm_area_struct *prev; @@ -1529,7 +1529,7 @@ int madvise_walk_vmas(struct mm_struct *mm, unsigned long start, static int madvise_vma_anon_name(struct vm_area_struct *vma, struct vm_area_struct **prev, unsigned long start, unsigned long end, - unsigned long anon_name) + void *anon_name) { int error; @@ -1538,7 +1538,7 @@ static int madvise_vma_anon_name(struct vm_area_struct *vma, return -EBADF; error = madvise_update_vma(vma, prev, start, end, vma->vm_flags, - (struct anon_vma_name *)anon_name); + anon_name); /* * madvise() returns EAGAIN if kernel resources, such as @@ -1570,7 +1570,7 @@ int madvise_set_anon_name(struct mm_struct *mm, unsigned long start, if (end == start) return 0; - return madvise_walk_vmas(mm, start, end, (unsigned long)anon_name, + return madvise_walk_vmas(mm, start, end, anon_name, madvise_vma_anon_name); } #endif /* CONFIG_ANON_VMA_NAME */ @@ -1689,8 +1689,7 @@ static int madvise_do_behavior(struct mm_struct *mm, if (is_memory_populate(behavior)) error = madvise_populate(mm, start, end, behavior); else - error = madvise_walk_vmas(mm, start, end, - (unsigned long)madv_behavior, + error = madvise_walk_vmas(mm, start, end, madv_behavior, madvise_vma_behavior); blk_finish_plug(&plug); return error; -- 2.39.5