From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C34C19F32 for ; Wed, 5 Mar 2025 18:36:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C19D280015; Wed, 5 Mar 2025 13:36:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26F97280008; Wed, 5 Mar 2025 13:36:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13CF0280015; Wed, 5 Mar 2025 13:36:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E52A0280008 for ; Wed, 5 Mar 2025 13:36:02 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DDB7455234 for ; Wed, 5 Mar 2025 18:16:28 +0000 (UTC) X-FDA: 83188302456.25.CB3DDE6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id CD5861C001F for ; Wed, 5 Mar 2025 18:16:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tuw7cR1M; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741198586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TycSZsNN/c6xEUKKvd5Xv/5XMrfk0SzU7ANigaWafqc=; b=SfiTDR1Ppu8WzChZvtTBSi+W66nUmXaAh08wToQajbOfP2qpGKuB1b31yVOIim7UZ2VaMX NGewlekpuuNAdnC1sPFNdOO0Wj3lFai+0vgtBo2ieUuXq/HLtCoVfiZtAD5mzVEpJQflg0 e4YNRiyM4UBxHLCYs142j9FndA0hteQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tuw7cR1M; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741198586; a=rsa-sha256; cv=none; b=SU9GeNO60StnfjsMnIBcgIN3yIiOTH7vhw3N6UBs5F/wg7G1puA89S/835Ies7oRz9c1Ll jGJEBad8g8ZSiHPmqffyxdJAYx5YqkWEEwytOvBucm3JHpR+s2EqzWNa0E1P38lgoBxDsl 4+SS0fF0uvxGqxKDs7TiHZ0oIHDdy+s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 41D265C6BDF; Wed, 5 Mar 2025 18:14:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9685C4CED1; Wed, 5 Mar 2025 18:16:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741198585; bh=zA6hArayCI2Rl1M1lVh5I5ZUimJAVrPkFcOBSQrdmgA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tuw7cR1MHr5aXndjIuHntuhVG2we1MfPpIbDEiWcfzdWAVCjwriV5BA9ak4kJ43J5 FqOuVr5sM11QSKbSAQgOlmUL/KObNY95VB9FOfZr/6/PE2woIGfHoPq/nHYSGSzkjv 14y/WzbzFk3iklvMwASgDW5TnelJWbMGFd2jponx0g3PkCxDEwXsXbr4Y0c+/OkowP b4J1RfkKX3qpb6iPvKLdJpQYNDNJ8xYZJzm/xv/l24+SW8A5s8VU3AkpxnrVVLoxca Ge4I3F8AKetaxegjk6tf6YcIx1EdcyWgY6x2uyisSlmZ5wpedBfyqHKuLaw8dd2jcL tQw7ln6j3BFgQ== From: SeongJae Park To: Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 05/16] mm/madvise: define and use madvise_behavior struct for madvise_do_behavior() Date: Wed, 5 Mar 2025 10:16:00 -0800 Message-Id: <20250305181611.54484-6-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250305181611.54484-1-sj@kernel.org> References: <20250305181611.54484-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CD5861C001F X-Stat-Signature: 6nmkp3mocbsy4bfz5g1uizu9f3hebspr X-HE-Tag: 1741198586-97328 X-HE-Meta: U2FsdGVkX1+RZf5O4liaNXDhextuGi6QYo+otQsBUc0iGOtr58sEJEWy7+ha66yV/yjAbGU60wVciDgWOx6XfpcU59T7TrG3be4jtt/SLcTkpDgeYegQXq9j0oWBXb44BDJPjqvpGCZzp0/dM+vp+y0VXhqsjFNMBUlqjgymoC1ts21t2cpmFw1zQTx/yeGgOWw47HkLuroWFDYnCZyY22MtrD0sbQ74C8VmmwffApmNUDvGB1oitGjZ5zmeSswMBN4AdT6DzOgwtamR86RJxwA+bPpeN8Zhn12tivBHpGrXMt5qemXL8CLPrR1Hi21gDx032XEE5ERbzhviYSWvxgve2z+Frs8CnFz1lg1cX4V1UXsNxHqC46Gl913V2AfrA6sIHGWVNEoka+zTJ78cQKozF15WxYqQ6jrJIjWsw7hl8V33HTEXpQ7WGpD3n6USTDQhOueCeNPolDNHFJ/OPGN2Vdcp/IivTouYNaFMvvyhAAyQz+NnlwNfUlZC6UbB0sf36C2FhfO2WFDcZKHJJVx+5PqfobDDHQPVRqyKmowOubVJx2+4jeUCUXe9YIH1ha/CCNcPSDHWZN3+9/WfK8xtNShpdfCiokrgoHjFwgEPIDjENAJOo12xFNRcsp1DgCy8qCSgz51VY8EKa3iXupOBg7liU9P1IeYan/5wk12rgJmHC3dg3M6eNU/rBNAriR634VS6lPYLqo6mcqzs+ZSIZSgHzN3sqHdDI1iviVrwnptc1HOJoop8D8YqE7V7XcBp81xF9zwF0nSpfaTIVJnYzayMvYSv7A0oJ5Fict2fL/OW0bp0UsYNhVXAHvSVDp72DnuFDJaKg29vAuaASpm+0INlSjuPG28mtHCyuxmJS5fmmoOizC8p4WCAO9CjBWZLOlCUszmhwsxWlGiRBjdVKI9JTHDwVFukC3uCmjTnf740npGyHn7yqTC8F0DqMKMB5Ni55ud39IOplob 6pYkqGoi vQPSdnMWJ5bXwePOfTctF6ga6kUNI/nwSsvKvupXHEFHOvNWuNefs9ZIcXIfezTvsbozLAyeOa8LUFDezsCSY/1yOmb0+mbtF5+J09mpPBld1nNdUWEWdvCtWja6quiPz3Q9pSk1fbLbPZOXiNRTZap68sfhCGLf3GLiDxxJ5SUGyXZlcHMuhO1RM/6JPq/sClgkaA4Q2CMxLbcACGzVhFnJ+TEdle5RISBBxQXITzmyeECIqUMBEX2ZVfIMamgeTYNm9q9r6d/TiAB6wQRkhyamCqyKR+NXeGJ9v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: To implement batched tlb flushes for MADV_DONTNEED[_LOCKED] and MADV_FREE, an mmu_gather object in addition to the behavior integer need to be passed to the internal logics. Define a struct for passing such information together with the behavior value without increasing number of parameters of all code paths towards the internal logic. Signed-off-by: SeongJae Park --- mm/madvise.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index c5e1a4d1df72..3346e593e07d 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1665,9 +1665,15 @@ static bool is_memory_populate(int behavior) } } +struct madvise_behavior { + int behavior; +}; + static int madvise_do_behavior(struct mm_struct *mm, - unsigned long start, size_t len_in, int behavior) + unsigned long start, size_t len_in, + struct madvise_behavior *madv_behavior) { + int behavior = madv_behavior->behavior; struct blk_plug plug; unsigned long end; int error; @@ -1762,13 +1768,14 @@ static int madvise_do_behavior(struct mm_struct *mm, int do_madvise(struct mm_struct *mm, unsigned long start, size_t len_in, int behavior) { int error; + struct madvise_behavior madv_behavior = {.behavior = behavior}; if (madvise_should_skip(start, len_in, behavior, &error)) return error; error = madvise_lock(mm, behavior); if (error) return error; - error = madvise_do_behavior(mm, start, len_in, behavior); + error = madvise_do_behavior(mm, start, len_in, &madv_behavior); madvise_unlock(mm, behavior); return error; @@ -1785,6 +1792,7 @@ static ssize_t vector_madvise(struct mm_struct *mm, struct iov_iter *iter, { ssize_t ret = 0; size_t total_len; + struct madvise_behavior madv_behavior = {.behavior = behavior}; total_len = iov_iter_count(iter); @@ -1800,7 +1808,8 @@ static ssize_t vector_madvise(struct mm_struct *mm, struct iov_iter *iter, if (madvise_should_skip(start, len_in, behavior, &error)) ret = error; else - ret = madvise_do_behavior(mm, start, len_in, behavior); + ret = madvise_do_behavior(mm, start, len_in, + &madv_behavior); /* * An madvise operation is attempting to restart the syscall, * but we cannot proceed as it would not be correct to repeat -- 2.39.5