From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E373C19F32 for ; Wed, 5 Mar 2025 18:34:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54B72280003; Wed, 5 Mar 2025 13:32:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FE49280008; Wed, 5 Mar 2025 13:32:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B0E5280003; Wed, 5 Mar 2025 13:32:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E58CC280003 for ; Wed, 5 Mar 2025 13:32:27 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8C9211209C3 for ; Wed, 5 Mar 2025 18:16:27 +0000 (UTC) X-FDA: 83188302414.24.E0B93CC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id CC0FA180017 for ; Wed, 5 Mar 2025 18:16:25 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XifHhBB9; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741198585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wEDgDKxpxlKe29jaWnUQgPJdScDr4j8NcekL4GbqkVY=; b=chQKlemxf90ifPS2jd3heabx/fBkNPTLT1G2iHIMw4m4fimaoW7v2MmEZ46pTtE3wdR5vq X6RhA7Vb9nfsnd2hfHWUw/97ichzLSbBjq2Td7xnIBkgeOgJ8PDsZer6qcgq07HLLbwlOw PCk1bZyCmulnCCslumqNRPM9W0e1NVs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XifHhBB9; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741198585; a=rsa-sha256; cv=none; b=f7ix0VsXr82sYgRLD6aU3eSLEUOIk75hceapwMS790/r9vES0ECnL896Vg3r2UVymk68sC aFVFvGlbL0WcgYM8TKUZe+X6MjwqjidvUJ85vwb32vwW5sn0J2VsugLjFCcx7P3SFEx4Kl 6+rx1m59JyvkCyAEp2KIBGj0L6GarS4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1D4865C6BE4; Wed, 5 Mar 2025 18:14:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93788C4CEE9; Wed, 5 Mar 2025 18:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741198584; bh=4+ggVfIvFgjcdAiiBX8MuJhj0bQWEcWPio982NmoaDE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XifHhBB9EGx7WTdY5Gq0ixSMzm4RkQK0ZqOZ9h5RteCQnJpOLL7PXW1hXZgCieJA9 bwRB8sDJVdiADPtwYVrSaV16QQDvsSjJXn+pyfHS0EDC707FUaUPhiSjwVtM3Oh0VI 9TwicXQjUUfeNlDPCuG4B+7B6aoA7+GLOw+mIhbRTl1E3iXz9ucdlFnYQXLTfXOSkM VSAmDDuARX2Rkz42f/sh9oUZ4giZ4AJ7MkwEZC95GbWgJq0KLCQP+qH0x17J9/cn0M pq1OiyZJ1eNsUiztLw9lmF4XyWY7x7T6q8DSyrjAxc9DQmXHpz62zgUp8YpDW+2c5/ XDl0CABH8E5Uw== From: SeongJae Park To: Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 04/16] mm/madvise: remove len parameter of madvise_do_behavior() Date: Wed, 5 Mar 2025 10:15:59 -0800 Message-Id: <20250305181611.54484-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250305181611.54484-1-sj@kernel.org> References: <20250305181611.54484-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: hnxnxcggc3dkssjkigrsu693516sxa18 X-Rspamd-Queue-Id: CC0FA180017 X-Rspamd-Server: rspam07 X-HE-Tag: 1741198585-998986 X-HE-Meta: U2FsdGVkX18MUInFYRLTMxGrQyVdYytdp/aDGKlaNqvrc8ion0ezA2mPJDLaz/aMahr6M3A+7Ab7WVZLB+jjVFzb8efYCvPUgfNswE1jPGPpra5ZEquTtPJyzKBM95O0wggv0bfsRN5R98bRqiju7oY9R1WZoeIpsF4cFg6AmmYC4Ao040F/5lUc5GeCJw+oTZXuni14tWa9oaViZ1uJxZZJiWTclNSdIWt2ZbghSMl+TiW5kJKVsjYi3Eaa+lrpkTwx2VDMCvOi2EttKY/4A28vD5aMEf0iS33K/RRmZ8Ti946ulAZBKvB/q7K7/jWeVuOhDayxZW78dwYFiFDbryCavFGWAZc8O+rDdodOgAdIQg2WlxQfIZB/1/oo17CjHhZuMxVSe+gssF1PF8GcOry5U+aSJpClo0sObavfaDNiBDwBFH9/3HsckWc0/4mjuX5Jn+bV4Tap/Exra1KccandGHvtboeyAH/uVHaBpHJJt4ouV/2Qnnzs7pEQc0iua8fqZOUcFDviyuejbkE0J0cSthlacMyZq3MtT3t/C+VKJtTWBnQtOnoi08oY2XNeTwiN80fF5YKSa4bwZwLYvNgpEZ15HViGTNTp3Tc+bb0ZsTV1zVIoR0qyBOR8lsyRBQ6KVr5/8wE8sup0b4/q7kx19Rotny2Q3yM6KNvsA7TcGU/P8mrrhPND+kiILbNSNP21vZZw029+iKFt9R+nkvVAXNjFqXitanBmz832G1zJUpwPeIBa9/u7cnsb34UDy4jviG1Bzw1G0yqDrx/8JLBLER1ewO3YM4TF2GR8CI/cy3iUdL7GQxN89f0sbKx7QDENH5EM0aRmbWmK5OgJL70nN1yzPVbJw0SvXho/l3Ko7lK+JNfX8CB3kz518X01NllAYfGkKem7zWpazS/9N0/bstToqt4B0fU9wWOSa1NYGY2ahclxQOtN6KODytlOsr7PYM2F7J4QnqbZ6RZ A94COGOH KfK1SG8G5QVT0467zF/YHuYB6ym5ugmaLz9HEB3Byp+WHOFd4Mci9X9pys1an7wlLCnOOdgIfep860/z1tO/JOi7qE7VvboVaePDtnWqkWYi8Jur2fR6stobXv+sHGq93EkSxN/mka4HnPN6vjzLKAVfi+extNwI2tejzRVILwP54DD8Tg64yc+NO2R+q3KD7wVl8MVPLKn7T/e1AOyHvYxXH4/9QnGhIrh6eaepA/gljaB734ailRuh3dPtjnCnKEzdSMwrLwMUX9s31rEhi8Ju+5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Because madise_should_skip() logic is factored out, making madvise_do_behavior() calculates 'len' on its own rather then receiving it as a parameter makes code simpler. Remove the parameter. Signed-off-by: SeongJae Park --- mm/madvise.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 265b325d8829..c5e1a4d1df72 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1666,7 +1666,7 @@ static bool is_memory_populate(int behavior) } static int madvise_do_behavior(struct mm_struct *mm, - unsigned long start, size_t len_in, size_t len, int behavior) + unsigned long start, size_t len_in, int behavior) { struct blk_plug plug; unsigned long end; @@ -1675,7 +1675,7 @@ static int madvise_do_behavior(struct mm_struct *mm, if (is_memory_failure(behavior)) return madvise_inject_error(behavior, start, start + len_in); start = untagged_addr_remote(mm, start); - end = start + len; + end = start + PAGE_ALIGN(len_in); blk_start_plug(&plug); if (is_memory_populate(behavior)) @@ -1768,8 +1768,7 @@ int do_madvise(struct mm_struct *mm, unsigned long start, size_t len_in, int beh error = madvise_lock(mm, behavior); if (error) return error; - error = madvise_do_behavior(mm, start, len_in, PAGE_ALIGN(len_in), - behavior); + error = madvise_do_behavior(mm, start, len_in, behavior); madvise_unlock(mm, behavior); return error; @@ -1801,8 +1800,7 @@ static ssize_t vector_madvise(struct mm_struct *mm, struct iov_iter *iter, if (madvise_should_skip(start, len_in, behavior, &error)) ret = error; else - ret = madvise_do_behavior(mm, start, len_in, - PAGE_ALIGN(len_in), behavior); + ret = madvise_do_behavior(mm, start, len_in, behavior); /* * An madvise operation is attempting to restart the syscall, * but we cannot proceed as it would not be correct to repeat -- 2.39.5