From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F118C282DE for ; Wed, 5 Mar 2025 18:34:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ECA428000D; Wed, 5 Mar 2025 13:32:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 19ED9280008; Wed, 5 Mar 2025 13:32:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F324528000D; Wed, 5 Mar 2025 13:32:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D4994280008 for ; Wed, 5 Mar 2025 13:32:32 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 87969C0963 for ; Wed, 5 Mar 2025 18:16:24 +0000 (UTC) X-FDA: 83188302288.26.2B3C073 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id BB1CD1C0023 for ; Wed, 5 Mar 2025 18:16:22 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sAXZYSeA; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741198582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nVCdHP8k0EQ8MtPbIcCsLvckL09pzBvNFwJt0sZW7Sw=; b=VpHNrYQzd9DSvSbqurZkmLjYbXtF3BRWIL7OX0yCHVBvoz+rkjnf7IybXGvssYLgMq4lht Lmt1JblJ2y3uSEcS3Hg/A+a7BPXDnWESpfzSX/SUd1D74hejBPHipBuDICg3SCJf2Yagti +PUaKI2h29Yz2aQMHBL7mRpFjZr8428= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sAXZYSeA; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741198582; a=rsa-sha256; cv=none; b=10JbjFR6esSwNFbUsdR/gBrv52qB2uambQ8AibCJZmNtC8I+ZIiWGXO2+F45jN0+H3X8kI 208cYqQOfS/8Al7fdpDdb0Lt9bWPd0fGi/ZBsdNsAwZZDutJ528PItsk3S9bQSQU2Ebekg TIaw4b0BfG4IeC8x3iQtV3NrcszgorU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B4B1E5C6ADF; Wed, 5 Mar 2025 18:14:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1394DC4CEE2; Wed, 5 Mar 2025 18:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741198581; bh=sHWxz+0ShuFmutLGSt5hwCRMCNmucoCWmOorPvlaBq4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sAXZYSeAbWhcz5LT0yvaAeEsnGtslYmnxLZZlGzmNk7/NTF1qAvm5yqfjEVeO9TdV Rif5lZv9l5yNiQTVhD7iR1rKRmVhxb6x0f7AtA5o+dDIi8dxA8k5+/hJNfj3M46CWo sitQN1QOJpXhDlw8MsqtGOU9rDauvpS566PKb/egzlDjOjw5HOOykW0p+6aaUy4+ZO MEFOD269bYvOMYz51UGc+NTi+U4dipo10wu5Cn47Yt7HxeoiYcEFt2g0Rr6CkLSXel R0AqI1OIzw8RiD5YCnRDB4PBzWL61je0d7EWQu7B8vxEk05bBfernmks5BaYa+d+GT f/9hPYOZmRYjA== From: SeongJae Park To: Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 01/16] mm/madvise: use is_memory_failure() from madvise_do_behavior() Date: Wed, 5 Mar 2025 10:15:56 -0800 Message-Id: <20250305181611.54484-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250305181611.54484-1-sj@kernel.org> References: <20250305181611.54484-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BB1CD1C0023 X-Stat-Signature: z7nqgiju4ym4kzwgggc8kr4wi1eegxny X-HE-Tag: 1741198582-203074 X-HE-Meta: U2FsdGVkX19IwzpctDZzLD3MesqxuLJy/3GwIrMlO1GCXyT4YuAX9Ws8gMDlCkLPIfLFKAlDq8AJEDxJUG8yDTnUoBKR2eo9JFhK2/HcfnWcXMoqrL0oltj+Z01wggLVzDSmGC8t8ZPwU0e9LFweAUFAbVaM1v8FJ4bPpxPHZNiYXZVNpNo655nvTI8jhYuPmYGbJ5KMufClvF5so9Enedo5X50gaIlC+a3FiLjKwGFitNoZRcjhKoMq/Q1efooJQwzylmH4yjYvUWyLonorOaOBeNIr+rlFyVsepAk+ESYxbor5iSSv81zmZ4Par14y4qREi78Iuhw7GfsZwu21cTRYk61KxUazBU4TeE7zItCqyHjwDeQTdeTTzvg6noJ62t1GZZ2IFweZP8fEt9cAhgzkIVBAy6nwgJ0kaPI/FKmsjkCySSxx9jJ5ArjoaewjhQvPyhzX3SaDVb9Xlcef8j8NydYhyHY3RAq5AGluzUQV8zkZ00V+3LwsiwnmEbo2ZkV27aYnuJeqBbbhbw7b/n51tmRt+UK8D/qtRRQZwEk9J39WH5GjmKp1qotjNz9hrROL6dXXuMAL1QNm0o6hYBvUNKpSII/0zy/cnlICtlLKi67qYoVMWi1fMjRBtRonLrahulZq7z3lwT/1pJ/XqV/co6XAHzpiZwIJrJxvsSv8feicnp99/6zF7EpzsjRnSxgYmPpCBgkjQOhD+OUzsUE1USS90T1HCj6hi50ltFWUnkdJ2EtaGu6w4nLi/zuJyA24u3fsbUkJhuzris0nFaRNKl4ZUqSc0jEj8NjFa87JVQsQ+Q/Yis3gz5cLK7LKwCz2lN2IZxyBt7tfrJ9aVGEf8WhIqQ853JbaN3W765aGGqlmBZRrmtyQy8yA5BH1+eBGJ6eJTxV990ToLtlmJekzei7ySGBfEVSfRl1vqvtPnJwVEe+8R0MXuxll80MiTrKzleB0xWvnTpoXI6k 1uN06Nu1 Y9z0zzE1N9FfFr9+sO48hoiY19cGNfMjFQAv4lKav6v8Fdx10QVSi6LiXjXszzc6/m1lINHslz289bRcoqeLcJjN8ZfwZm2ZqlSHsM3TJGSq9q3UULHK3J7tNWq9qS9GUoIvdnkfXD8HEXc3y3KFc40/UZadgNFOwd9MQ11LQn4FoNOzCogHHzPmLfa8SnPwm8FKmHkL6+jEfuWGq0J3/dihmM0a9PaFWjQF9RS0961kH+GfMivC7+Q9jjpUOZUuJmHcDshfGK1+eqsatZD+oF3vmQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: To reduce redundant open-coded checks of CONFIG_MEMORY_FAILURE and MADV_{HWPOISON,SOFT_OFFLINE} in madvise_[un]lock(), is_memory_failure() has introduced. madvise_do_behavior() is still doing the same open-coded check, though. Use is_memory_failure() instead. Signed-off-by: SeongJae Park --- mm/madvise.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 388dc289b5d1..dbc8fec05cc6 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1640,10 +1640,8 @@ static int madvise_do_behavior(struct mm_struct *mm, unsigned long end; int error; -#ifdef CONFIG_MEMORY_FAILURE - if (behavior == MADV_HWPOISON || behavior == MADV_SOFT_OFFLINE) + if (is_memory_failure(behavior)) return madvise_inject_error(behavior, start, start + len_in); -#endif start = untagged_addr_remote(mm, start); end = start + len; -- 2.39.5