From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DEBAC282DE for ; Wed, 5 Mar 2025 18:34:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73ACF280010; Wed, 5 Mar 2025 13:34:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E894280008; Wed, 5 Mar 2025 13:34:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B362280010; Wed, 5 Mar 2025 13:34:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 38D7B280008 for ; Wed, 5 Mar 2025 13:34:34 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3336F1609C2 for ; Wed, 5 Mar 2025 18:16:41 +0000 (UTC) X-FDA: 83188303002.25.5BE304C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 61463140017 for ; Wed, 5 Mar 2025 18:16:39 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WjwJEMeK; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741198599; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SQ1d1IW0Ab0wRZqXQskXNpkWs+QEZQAOCENOwAuYnkA=; b=SaqGNgmLobxgnqrCoSSXyhULhRj0IfoPUs0p2JpbnxrtfDNdJLqOBzyvrOlOinX59GfWhp pEI/t35Seo5CZoL6t7n3DsFgd+1PsM9yucq/KHnHUGtefT3/ehDnIyhHwQ72CEP2jDlSs5 MxWsosGYD5jf7iTKBKCwl5QZNDpP8+Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741198599; a=rsa-sha256; cv=none; b=duMSaUlWs+UakfIv8Ds70zkYwN8RPvdp8QTVDozLXGm/MA16gjauxIEQUWDdPckfDHIuf0 sieJwO9Jd6vZr0TrELf43/YFpKc7w9z9rC+Qft/AY2RgMW+lcqx413e5t8GN5bIdlivylz O0FQyKry113T16Y01sbASCZ2f/B+haM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WjwJEMeK; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C29175C6BE0; Wed, 5 Mar 2025 18:14:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F21FC4CED1; Wed, 5 Mar 2025 18:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741198598; bh=iyzH21UhzYqd7Tqlxj4XxNbXqpQgjQqkRv0b1OdLlb0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WjwJEMeKovsett4/AR6x8oSEwzZnyBpsSPqAC5hvWjTXEPikGH4plKyr4a5j+irB2 kMkvzQV4rLf8MeNCGskmt4fnZSi0E/+ukl9CWU9VR7MNLtGGRPtIp4pC8DV7O99qUs ckSaJybTfvS50qC8CluLpozQzSUdtxe7VwJns/gpyd/WSidVLXrZ2je9ZuPfHzDdPY vQnD/QTFu2Wk+G5Oa01nPcfR3tl1uZt4Da93DPNVG4+5cmfGgrpgDV18EGv9E5xKzF ctBPkLmdrMp/kdrWE5sIUtOPiLvuAGSUpjwMFy9BZNiWihXtc+nEUWp2v71GSjP3Zj C+ErJUXLmDFcA== From: SeongJae Park To: Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 16/16] mm/madvise: remove !caller_tlb case of madvise_free_single_vma() Date: Wed, 5 Mar 2025 10:16:11 -0800 Message-Id: <20250305181611.54484-17-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250305181611.54484-1-sj@kernel.org> References: <20250305181611.54484-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Stat-Signature: io5udkzxmzc8f9fxxoo5i959aras66sa X-Rspamd-Queue-Id: 61463140017 X-Rspam-User: X-HE-Tag: 1741198599-508571 X-HE-Meta: U2FsdGVkX19cSxtUllDwbM3HS60MLc+jdG6a5cxYQzu52wPGI0U4pAYeO+HHNAY920lvMGhAPlFyl2Z32TdCHqYwZ/e5mTaOqN/fx/iGElrEp6wGQrDXern9OfoZb5qTw0jPIHHCBKj+udSUWnMckZ0DCaqgihqOoKpjUKIY1g/gLHOvEeT14z9i7POcddS7x9sHPjdsH0TrSaDerMuBU3a51AsDJsWglk+8U69TvwZdYbcZcYFRYl2IFiB1Vfl/2IUqETLODrPytIo4LU2+1BLYtAgZYtKYUKL6ZkMjjCLRLNy+8FUeMAj4zYPnBXt+ECC0NE3Wgjs5LSc440/C28nNbjxhcFTsj6jJ/juEih5GUP00q8VMY37sbXdQFoxAfT7BCqixV8esMjcjJ+bCcayyoqIZkr2vwEXsws8cKPIMi9iQTWz86MPTs/G5quVEBH3cGgtyH/Kh/kx67q1pDFj8JV5PLmHDtdel9kZyZxAv7DPyTYKj8d9KZPhCTcU7xwB1J9MwEclrU6cEGLARuIxHBbnI2H6TL7nbtM8jwgUOI4D+YPEI/1ut1qv1DUxWSFaWCvQcrekKOOKtWOsG6f4lHEyN/41ivRRHQgM9xGvTGH7+DY4IjfD243veWr/gwIiBaKJWsFa6zbJP4LGhwNd2NhHDK3fVEqp5QNRC3fTytVeh9cbqlboe0/NkWi/uyg091D+a6VmBe2kgeN7VQNhck9t/xX6DD6gNFsKJB0NnmdF4H9QZFVMpt5vRVU4vQHHgzvGk69Jv7o2PYjIAi/o/MYsMRhOsW7JqKBsSPJicCGDL5aIzsPR9BfxTEdVJeS1Zku/AxZDVTAEJW5nIH9Dd3oI+rWShqfWuU5oaP8uueOMP3T3BDigvAxe4rXfCdyRXiIuw3CaVX6N1up/OX0+SZX0ufXSj/Lc6Te7sCOv9FLGXLcFEUujFz57GAsiBFJm45pQP9TPnPpcQol+ mWuT+ViL QrEpVXXc2cPRKtdfr51IfpC/wSgwAYkxc/0jbvVjyh6tlj3gSYlufJGEpaUOtG5Oqby4onnIkttpcMtA6rRfVCWQ7paA18Am50yGxKST7iW7QSV4r+43/4rrS4ClMwE5isxYzAh/lHTyC9OekoVudHGamws++GpesQtSkgWb3E6tHbTAsccPXpFrTcQUYgIcKMddNiDw5jbngHgMzhVTHepDIB8rc6TgL6VIsPheklIeZrThbp5Qo96dPaoD2xIyNGGakxh82COmTSaTFf/W03ILGJ1bsxZp9wMOrEt7ZpVTYs+DqOKRHSjDizuo1L+VWjFj5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: madvise_free_single_vma() supports both batched tlb flushes and unbatched tlb flushes use cases depending on received tlb parameter's value. Both were supported for safe and fine transition of the usages from the unbatched flushed to the batched ones. Now the transition is done, and therefore there is no real unbatched tlb flushes use case. Remove the code for supporting the no more being used input case. Signed-off-by: SeongJae Park --- mm/madvise.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 1dd2c25c83d8..03ba5ff0cf9b 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -795,18 +795,11 @@ static const struct mm_walk_ops madvise_free_walk_ops = { }; static int madvise_free_single_vma( - struct mmu_gather *caller_tlb, struct vm_area_struct *vma, + struct mmu_gather *tlb, struct vm_area_struct *vma, unsigned long start_addr, unsigned long end_addr) { struct mm_struct *mm = vma->vm_mm; struct mmu_notifier_range range; - struct mmu_gather self_tlb; - struct mmu_gather *tlb; - - if (caller_tlb) - tlb = caller_tlb; - else - tlb = &self_tlb; /* MADV_FREE works for only anon vma at the moment */ if (!vma_is_anonymous(vma)) @@ -822,8 +815,6 @@ static int madvise_free_single_vma( range.start, range.end); lru_add_drain(); - if (!caller_tlb) - tlb_gather_mmu(tlb, mm); update_hiwater_rss(mm); mmu_notifier_invalidate_range_start(&range); @@ -832,9 +823,6 @@ static int madvise_free_single_vma( &madvise_free_walk_ops, tlb); tlb_end_vma(tlb, vma); mmu_notifier_invalidate_range_end(&range); - if (!caller_tlb) - tlb_finish_mmu(tlb); - return 0; } -- 2.39.5