From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11EFEC282DE for ; Wed, 5 Mar 2025 18:33:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44FF46B0092; Wed, 5 Mar 2025 13:32:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FE036B0093; Wed, 5 Mar 2025 13:32:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 315E06B0095; Wed, 5 Mar 2025 13:32:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 134776B0092 for ; Wed, 5 Mar 2025 13:32:17 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0052F1209DA for ; Wed, 5 Mar 2025 18:16:48 +0000 (UTC) X-FDA: 83188303338.10.36B3704 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf16.hostedemail.com (Postfix) with ESMTP id 0749518001D for ; Wed, 5 Mar 2025 18:16:33 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CgRqfs2N; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741198594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lAeJwmgGhh6SFkZ6qoCt267gMUrM3+PC26GwyX6F9g4=; b=E9ULUmUPv0bcDci290u2GRsZCw8+fO7zZrtxo1qQgN4rsGIaS6XFlTVOlOzpE6zLt1i/tk 0ir/paHTaAgeVpcj8mMuQjmW7TsHmecW/hFo5NqFfGUjr290boD/k4QWVX/cTFTumzKxNW Ume6HeKrKWfJ2sGbqIEk9l8OaUsrGpo= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CgRqfs2N; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741198594; a=rsa-sha256; cv=none; b=Mu+fpPUeLQnz9dZpuxReI5j5Kz5WG6i0IJyNKnTuJsEemzYLqizyP7PwZVbB4nJ37sVLqI n72k6OSFlpv0UMR6o2kuukc6+pUDzm4AevwclDYOkQ7sqhNyxnbUXR06+u3Iks0pQPpiJC MScUWUs2uRIrent7i5g8vtpY7eLsH7M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0D4B9A45E91; Wed, 5 Mar 2025 18:11:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B554C4CED1; Wed, 5 Mar 2025 18:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741198591; bh=qTz2EADhHkd12Pdb2rgzQeU5lnQ9KkIcBg1xzIMxfqw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CgRqfs2NseUkix5vrYEws4rsZfUtLGUzUiaQKz9cL3cUczbHcnhtImfhyuuyEter5 jReIK8APFWJgSQCwIor9x6PTZBSTjB3bEwYOXEQoO82GoaOItFlnPpmJ55nrb4pQEH Icz+IKD6OzUoGVchOBRUXmwZXhu8OTsKyeufqiejQsO9/JLFngmaTLNNy8cgBvvS6m eGZW+6snKE73VeZUE3xG4Q1vGmh0GAvWhjtQYXwCTzYQGH2pSqKvHU2zNH1KHyKUsi 9XZXa7koL3kvZxHcyftsU8YgULJP9WVJIazYRyRFmjTe4aa1mo4c2FD1hkRvwREDeX TV52sNWDWuA3w== From: SeongJae Park To: Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 10/16] mm/madvise: let madvise_dontneed_single_vma() caller batches tlb flushes Date: Wed, 5 Mar 2025 10:16:05 -0800 Message-Id: <20250305181611.54484-11-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250305181611.54484-1-sj@kernel.org> References: <20250305181611.54484-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0749518001D X-Rspam-User: X-Stat-Signature: rt6c8i1ky7dhrk1c4r9aikwyahdu8ucu X-HE-Tag: 1741198593-43844 X-HE-Meta: U2FsdGVkX18iFV0DzaoISn/S4eq4jeSi4TTvLPGj7poUi5Ytdt+/eXhKZc4O7O0W7CxYW6L5PS9yZJ0sIrtVt65H+4BT7VLqJrO3LidREFtk5x7vPgiuZoWAzNXvVWst8nMNbltlILy/NByaLKWAGt7kUUxgBljG/gYBJWanee4LfQPbpLpuBwlx4NjOw7oI001CoZD7MIS03U8RYJ0Dl6Zd3h+nNyR/2jXxWz4LrGIQyysux4fT2HFyTltEV+cBFfzvOIVFH4Eowdlx7je5eDnJKCzCsR67gS7amYg9DTUbzLj3vqUvlb5JvixLatjo1Gjc1QBO82+8i/4WSVvB49nDf6PaYlg73ef/nblyN3UCc7/ddA1rqfKIN/rGk7q9NB3pCeZ33h4JQ6zu2IcFo/dRW45sS8sdO+6Lmuq5FcpJzn9Ng66nd21E9C6RTZnM/8LsVO+anmWQovSYdsp+fxPVcPssAlvC75cvfDBJTz87t1zUVDDeMUaZx/s68xECM2vYjMqZBRyEWeJZTzXeRYSVeHI2UdbbfoV71N/+AVJyliOGunuW64OAwz7/l2qRDfUre4nef2bw32ZGm7JlRmO5aXbqwO7bE/UYVZt7AEJhg7RnLrfDGBK8vEQ5nXo9S12tg78V+5ByeLWH2LTOkxeR8VG+C0Zpc+In4BtXEE+afhyI6xV1LGRAapEMDCtrZ2mI1LSoeAukRFQNocHKXDhbGq5RU2codHPHa8dK0YQCqMVbvHuqV1tqjWAkp5GeB+z/NnDzngUwuwXsDEbSc4qYgUlkFs3JMJ7wRsTg7JkjzExrBiWhwEYpDX+eYn1f3ezDfR2IYH7CUMruEUNCgB98VkNqNS9MZW5CnMtZAe9tUqClSlkwE3J5/I1D29A6iy8uq6hkYbm6vCpydtT7lsswfZYrhowi+2kybvAWHsbDs9axtTv6kETOa/+AF1iXEl9pxc5YO6AYijvwW21 qGdmFnXL 3fzOEjBaMJP1iuzry3OygwWttVPAHl2bYJJAMXt5Nls3a9NRY3DLJ1VICEuIXJ+awMVp7uqy7iQeIXU0gRx1+zgUHpwG9KrVJ+6/F+mDuzVddf3LLhB4/o3oho993qSczHVRSEChXYME9dA+P8L9FbfvTVaNbPnMsF2uqAvXX2ZEJ0PqMIGyzqXQvpDl/mhQ1bb6TDVMZmvc59dVxDHm0Y/TFHZIuQ3Sk5WSN0DLnCP7aFBmggkLm+xieAkkd7RNJEOwkJzu/IEHwBVvPz86R/3p227kIE5ezuffS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Update madvise_dontneed_single_vma() function so that the caller can pass an mmu_gather object that should be initialized and will be finished outside, for batched tlb flushes. Also modify madvise_dontneed_single_vma() internal code to support such usage by skipping the initialization and finishing of self-allocated mmu_gather object if it received a valid mmu_gather object. Signed-off-by: SeongJae Park --- mm/internal.h | 3 +++ mm/madvise.c | 10 +++++++--- mm/memory.c | 6 +++--- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index 0413822ee34b..45b8d08cd176 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -438,6 +438,9 @@ void unmap_page_range(struct mmu_gather *tlb, struct vm_area_struct *vma, unsigned long addr, unsigned long end, struct zap_details *details); +void unmap_vma_single(struct mmu_gather *tlb, struct vm_area_struct *vma, + unsigned long addr, unsigned long size, + struct zap_details *details); int folio_unmap_invalidate(struct address_space *mapping, struct folio *folio, gfp_t gfp); diff --git a/mm/madvise.c b/mm/madvise.c index 73a4323197e2..22da6699613c 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -848,7 +848,8 @@ static int madvise_free_single_vma(struct vm_area_struct *vma, * An interface that causes the system to free clean pages and flush * dirty pages is already available as msync(MS_INVALIDATE). */ -static long madvise_dontneed_single_vma(struct vm_area_struct *vma, +static long madvise_dontneed_single_vma(struct mmu_gather *tlb, + struct vm_area_struct *vma, unsigned long start, unsigned long end) { struct zap_details details = { @@ -856,7 +857,10 @@ static long madvise_dontneed_single_vma(struct vm_area_struct *vma, .even_cows = true, }; - zap_page_range_single(vma, start, end - start, &details); + if (!tlb) + zap_page_range_single(vma, start, end - start, &details); + else + unmap_vma_single(tlb, vma, start, end - start, &details); return 0; } @@ -951,7 +955,7 @@ static long madvise_dontneed_free(struct vm_area_struct *vma, } if (behavior == MADV_DONTNEED || behavior == MADV_DONTNEED_LOCKED) - return madvise_dontneed_single_vma(vma, start, end); + return madvise_dontneed_single_vma(NULL, vma, start, end); else if (behavior == MADV_FREE) return madvise_free_single_vma(vma, start, end); else diff --git a/mm/memory.c b/mm/memory.c index aadb2844c701..ba011c064936 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2011,9 +2011,9 @@ void unmap_vmas(struct mmu_gather *tlb, struct ma_state *mas, mmu_notifier_invalidate_range_end(&range); } -static void unmap_vma_single(struct mmu_gather *tlb, - struct vm_area_struct *vma, unsigned long address, - unsigned long size, struct zap_details *details) +void unmap_vma_single(struct mmu_gather *tlb, struct vm_area_struct *vma, + unsigned long address, unsigned long size, + struct zap_details *details) { const unsigned long end = address + size; struct mmu_notifier_range range; -- 2.39.5