From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A86C282DE for ; Wed, 5 Mar 2025 18:33:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2503B280001; Wed, 5 Mar 2025 13:32:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FF686B008A; Wed, 5 Mar 2025 13:32:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CA976B008C; Wed, 5 Mar 2025 13:32:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DBCDD6B0089 for ; Wed, 5 Mar 2025 13:31:59 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 46A43A8A28 for ; Wed, 5 Mar 2025 18:16:33 +0000 (UTC) X-FDA: 83188302666.06.950A1ED Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 0490A40002 for ; Wed, 5 Mar 2025 18:16:30 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sIdVI7Ez; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741198591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8elOoJc4ZWGIZg4fWRwkhTHXVVCKpFYiKxTUpS1TlZQ=; b=T6IgXq4rc0L1qLAmFPWZwKBdcjmNFD9q5sIIRPeb9QyHepFFurHJE61uTTS3//gxrMlgKq BgG2W1vN0+wDF1GZjlwEMRe+leTzGhpBNvuI+kUmzwm51n7ttBSZJ6wZrteo18P7IeLj0L tm7COC++HM6kd0ZjQ9af5uSgNsV8Jio= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sIdVI7Ez; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741198591; a=rsa-sha256; cv=none; b=JYGjWjmkS8koq/D/YeDrWNAbrFemYChn3hE+SB6V9RdkHmp8Yj3vw46s4iRrM7uARnqGSH NHHecLbmDr1aGU3S3YDUI2ANG/Dc6HuM4taButQAUG0tJ4veSqt/pi4+wSuYkAOskzS9YI dtwoGZwh8wFSW2fXNV6saMWmfEFqlTA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B5B785C6BE3; Wed, 5 Mar 2025 18:14:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D2FFC4CEEC; Wed, 5 Mar 2025 18:16:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741198590; bh=2xphIriEKA8i5rp9aYhxLxFxGr/HuEVyUJQbKTIJ9W0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sIdVI7Ezc8/ZF2n0e2HlbbzQczYnvzGI5HusymbHblTUb8ZINUYydPwmj3Ni8dGNU QylfDQt4OmqKTwR0TDaBNDmpHfEvCzdEbqbG+yzY8YFAbZ2JpoKjQYMf//LdaQIXjX YrN7k4OweALQuFfzViR1+pHQmbV+YkvlqVzz2NEVMRkCRUvWciCj/FXV5PmE23qEaJ 3a2AlWAM7CkaK/nFKTlG154acKna2tJovPZeBSrDc/OMc4qnOIR5detGdZsRiJ7cCa DrCp0ukPkgd8e/ouCQ2KiOQXvIFe8tTgEil7tRhrPP7G9gIvHyQSPx54gaSXTp7HJo orNrTtIB5HhqQ== From: SeongJae Park To: Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 09/16] mm/memory: split non-tlb flushing part from zap_page_range_single() Date: Wed, 5 Mar 2025 10:16:04 -0800 Message-Id: <20250305181611.54484-10-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250305181611.54484-1-sj@kernel.org> References: <20250305181611.54484-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0490A40002 X-Rspam-User: X-Stat-Signature: io4mwi91qtctt68o4irustcrrrug3bcb X-HE-Tag: 1741198590-448883 X-HE-Meta: U2FsdGVkX1+TbAe9ryRrMVnGLL90BgJvkxOjeAy/IOgQa3DuK/lqJlhzBCkV+hxsPMcGZZCgALb45gisG011zuaToTRv13G+1P0Zx533WaB7Nf4NdXB2XlwptKefDqdzoY3FO31uxhvfK6KqHxRFdBxwK3Uk6JBAkzCQgNLpipb933VJ0+77LiEkQsH7IVDWF5UFqkrxRef2pkfRuvjzEaLxLMj7QaZKPLmhlKILeLDw3nYL1DBUX+Za4cUYMicnJbLLcOWqEPmHiPIt6EGlgS/FA5yb9l8w7Dz6Yjc+93A4OsRY0T+NrajHa97xptfCTyFrp3kXWdiqfwaRNiK/eXUgbfyvRsM09Fuvs4zkr2P4YJdcRuGsRKouCkYtNJxE4Uqpe6+M5zOx9NHp949lDoVpLX9TawRU5IOYbecnjLX4EYmCrtWQEXn0EkRXA0rM7KhdLUpFp4WUJBJvc9jmMTaeIYAy2fhAk2BjuGdqL35mqz8PnRvoO1qK/apTosWFLmZtulhOJP50rQhPSuI6YiafhoI0H17boBTLy5gUCfm8vGG/LhGYQH0Zbm0Bnkr2QehUf8tGWcezLjdWCizVpTg/GMPlDj4QIh/yzWKtKDTd7cccoH6/AD5vzstyM97t4ZpzNuyXm8U12CT9Yiii1RN2Vx+XQwtJgVrID/QRuRm2LP07CvITVBGBz8JnoN+YGGTUKiOEHvMOcrLxpEEUhwixCSAD9//Ir3JAgicVQJ8VmHBcy+rVqaCpXHNeeGARU8aBrjvSpnzVlpbh4wrHGVroRoETAkON9KU/9XjwaB/gcIlwqH+IoaKDUQxWIBn+eGherv45f8an0qhK8LLrnQKFh2sC+RICS8Z0Ne2tufW4gfXCpDXFOQYXyjauzjk6U+f4bqPcViWIbhqn7UsJSH4vIGCYzm2aV78Ibla/QMfNEYcD1v84/jYsS2vIt2J705U20LecTYR7BzcXqtF uZjsxsB0 dqpKknfBy+avUNt1DlrL8NslzDDBOwKJx907yw5hJOGl1N7I54vzUR8EDEXGLnLcyOmejuFSzy208fbkJLWPxW0L2EpcmedZpk4G2iq+jfRGX4E8PmBIAog6LT6OsiurueqYPUlEnFn+9r3D6YmQBBmEyYGfjCh48hgbFBFdNtiPcZuueUbGzopuULCr3PdVZaRrZ8Xe5VOwvZGHU8AcHO8zKIEqVyRAT3z9RkZ5JQY0+9IJsQB3f5HWDOoL9Aqwh6K50E1QHFOjMH+JJNNs8t6BxWhTQMY5BWkOs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Some of zap_page_range_single() callers such as [process_]madvise() with MADV_DONEED[_LOCKED] cannot batch tlb flushes because zap_page_range_single() does tlb flushing for each invocation. Split out core part of zap_page_range_single() except mmu_gather object initialization and gathered tlb entries flushing part for such batched tlb flushing usage. Signed-off-by: SeongJae Park --- mm/memory.c | 36 ++++++++++++++++++++++-------------- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index a838c8c44bfd..aadb2844c701 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2011,38 +2011,46 @@ void unmap_vmas(struct mmu_gather *tlb, struct ma_state *mas, mmu_notifier_invalidate_range_end(&range); } -/** - * zap_page_range_single - remove user pages in a given range - * @vma: vm_area_struct holding the applicable pages - * @address: starting address of pages to zap - * @size: number of bytes to zap - * @details: details of shared cache invalidation - * - * The range must fit into one VMA. - */ -void zap_page_range_single(struct vm_area_struct *vma, unsigned long address, +static void unmap_vma_single(struct mmu_gather *tlb, + struct vm_area_struct *vma, unsigned long address, unsigned long size, struct zap_details *details) { const unsigned long end = address + size; struct mmu_notifier_range range; - struct mmu_gather tlb; mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma->vm_mm, address, end); hugetlb_zap_begin(vma, &range.start, &range.end); - tlb_gather_mmu(&tlb, vma->vm_mm); update_hiwater_rss(vma->vm_mm); mmu_notifier_invalidate_range_start(&range); /* * unmap 'address-end' not 'range.start-range.end' as range * could have been expanded for hugetlb pmd sharing. */ - unmap_single_vma(&tlb, vma, address, end, details, false); + unmap_single_vma(tlb, vma, address, end, details, false); mmu_notifier_invalidate_range_end(&range); - tlb_finish_mmu(&tlb); hugetlb_zap_end(vma, details); } +/** + * zap_page_range_single - remove user pages in a given range + * @vma: vm_area_struct holding the applicable pages + * @address: starting address of pages to zap + * @size: number of bytes to zap + * @details: details of shared cache invalidation + * + * The range must fit into one VMA. + */ +void zap_page_range_single(struct vm_area_struct *vma, unsigned long address, + unsigned long size, struct zap_details *details) +{ + struct mmu_gather tlb; + + tlb_gather_mmu(&tlb, vma->vm_mm); + unmap_vma_single(&tlb, vma, address, size, details); + tlb_finish_mmu(&tlb); +} + /** * zap_vma_ptes - remove ptes mapping the vma * @vma: vm_area_struct holding ptes to be zapped -- 2.39.5