From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8009BC282DE for ; Wed, 5 Mar 2025 18:44:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB7EA280023; Wed, 5 Mar 2025 13:44:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4000280022; Wed, 5 Mar 2025 13:44:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE423280023; Wed, 5 Mar 2025 13:44:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9AF4D280022 for ; Wed, 5 Mar 2025 13:44:13 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A9D45C08A9 for ; Wed, 5 Mar 2025 17:28:08 +0000 (UTC) X-FDA: 83188180656.26.714E973 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id DC339C0004 for ; Wed, 5 Mar 2025 17:28:06 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WQwa1his; spf=pass (imf22.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741195687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=FN81K9t56E9HqlYjIbqgZvr81rK3E6eJk9+Qz8/XqU0=; b=eXGq6DDL7XnwcKuOGMG2m+2e0LyppvJysQ415Vt6CgdmFsQ6AFDvnQQgRMdksfnSpiahoW nkQ3vbkzExTPLPndl1N9gKS2VhGJLSPnfsgz7XRIX9b1YoHf5tN2Wee9pS7SjKHShPynzB pUtcrnVRwXsbJe8RZFk2cplCtOKT0bE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WQwa1his; spf=pass (imf22.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741195687; a=rsa-sha256; cv=none; b=aSIzGszJ1dgcLKTTOuSbJprF882yFrI91wj6jcO9J1OzTtNtUkJBnx+pQS9ouPEFvH2qwr x0dQCCn+eNSxu3KmTvba6D+kyClkyVwDxW8CLiLEF1CwImvn5cGFqk9JMPrivFdWhi0rrA oMhLsaMcKz3YieF5KH67e1x/b7VjzRk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E9A415C65EF; Wed, 5 Mar 2025 17:25:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28300C4CEE0; Wed, 5 Mar 2025 17:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741195685; bh=VuItw8oDG/JxjNFddARGZyzcjOXVjB38Cc7H5oMy7HA=; h=From:To:Cc:Subject:Date:From; b=WQwa1hisZ+I1lDEVm6G04zmuJ1fvP9ool4svAEpUXDQ9VZF6A7BxFsZPljpTbpth+ 9TrxEPKttiny8W713OaHWiw/J8xFCz+851xGvQ50coDDZOQDn1MM7vYxeyqKN8jxRa oOroD+er8bxuLgJ1RA2S9H97mpu4bSQXJqFOjTi9v4p6LsvJ0w8f+WD+th9gcSRHuy XtR2L1LlMl+Cr36v43Nu4fyphlOpdvav6jT9od7bQk9jrQg7LbGkkFD5me3PSOJ17V rcxSO83EahMSlfmxn/CYLPVBNeeM1ueQkMq7cZlrn8qDhHSnzT8Us8uCviPBq8RRRa Pa5fu5Ku010XA== From: Arnd Bergmann To: Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes Cc: Arnd Bergmann , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Kefeng Wang , Jeff Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/mremap: fix uninitialized return code Date: Wed, 5 Mar 2025 18:27:56 +0100 Message-Id: <20250305172800.3465120-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: DC339C0004 X-Rspamd-Server: rspam09 X-Stat-Signature: a5so99r4ad3thyz5wc9qkctu9owar784 X-HE-Tag: 1741195686-357024 X-HE-Meta: U2FsdGVkX1+aY5neKL84f57515zSnhnulcjC6tmUFTtwl+yMuPdlYtf9MuQPBRwJ6Dz4pkx0TA9glvoayUo7KalOUVezP9p3KAzir7JQp5o5FUpwsImF8FnxanjvZp5fvaB3tzyMwlvV6oIAnhQnD4VKGQfXWOvOjv0gz/M07UfQf48mukG+05RL8jkQ2JF0duFVluvkGR0h0vuumswe2pYLCdHF6M6EPOrVfkbSpp8Zx2EQVOHuilahA22+k5ZIFxP26ODYC9fCHrITiz+WXZ3FvlUdwOnfRgooYcalEQt2pnrXrM9k/n0o4wHg4hUKF83/RgnTHTPgrnwPfaLJy4TeNpidWO/FUGViC/UqP8un+zh/Bb/OZoNykEdzakIEMjQ6vh6GB+HuupBBfHbNqVY+ZO+dt1hAZy2EBa2Mzdk9aIZS++c7HElZ2wfCVNmlvnt7bW+DdGLGQa8pT3efwJlJX1HF3u9RZXHv2DtlDTzgT4pg8ogXxl0XrTReuQ5+NG0o6RARIHxZUbLaF3CPLBYWNC9g+R028PIxI4Ef3LDr+tt117fjC9vqWbE2+HMUa7nmLjMFU27cRqLad7VFaoACjlfnnBRGf/6TNjk7LNlyUCHGGhIkEPs8Py6T/diK+ycjNnpRmuivpaspTbyBauVQz4xHTOgGTOKxBcbiYeus/kkJ7oDkDkPwvqAMPyLyUNa0DJbCn2fEZVkrOTINsUG+FvaJRKoKjQDivLiJgK7N2CEEylot6JmvFUGwKty+AEj57gHmCKkuYglKi8fPWn0oznsbZr0DRZADYmwdFXpqvtzIoIoESJLsn1B52lF1xNsIJC1+oTTXgYT41Q36rUxSIig7gIRFljckvYVwgm7OGV5p5Aa860FIYKX7i4D61NxtmY0S3LnSflIvN6j2N19BFTVQsudiW+BI6AHhRBDWfqGLjcyQV8MbFoU0fJV0N4Is8sMzIAziCxqBYF0 iC5veNmm zDrXWVmff3Rp/UAxwUoi3F9xqQrpstm4MokPave7zKm2/P1maG7qxHvntT26rnaGBJi5EbLRJqSvBFseFh7FMBgV+85ZDbGy4FbeE1a6C/8VcFoAFZynBVlWwIXtSBnnOyk9q0Rhn2PqrRMM3489/K9fGvYqsBW/Q9qmirPbIdCm8hp+IjKKfMefdEs5dbgixLZb++401umlUxjH698ALbowbA6Suk220rWBMNd3gF49yTK+xWXjjPdr8Jx3tDWNj95ESLbdopwY5+Te0q02gCtPS8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Arnd Bergmann The 'err' variable is set in a conditinal branch and is not set otherwise: mm/mremap.c:1017:7: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] 1017 | if (vma->vm_start != old_addr) Set it to zero before the initial value is set. Fixes: 3129f7896afb ("mm/mremap: initial refactor of move_vma()") Signed-off-by: Arnd Bergmann --- mm/mremap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/mremap.c b/mm/mremap.c index 456849b9e7bd..9c51a2360d84 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -1014,6 +1014,7 @@ static unsigned long prep_move_vma(struct vma_remap_struct *vrm) return -ENOMEM; if (vma->vm_ops && vma->vm_ops->may_split) { + err = 0; if (vma->vm_start != old_addr) err = vma->vm_ops->may_split(vma, old_addr); if (!err && vma->vm_end != old_addr + old_len) -- 2.39.5