From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037CCC282EC for ; Wed, 5 Mar 2025 18:59:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5950828001C; Wed, 5 Mar 2025 13:59:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 543FD28000B; Wed, 5 Mar 2025 13:59:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E61328001C; Wed, 5 Mar 2025 13:59:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 21FFF28000B for ; Wed, 5 Mar 2025 13:59:12 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 43CBB1A0706 for ; Wed, 5 Mar 2025 15:22:47 +0000 (UTC) X-FDA: 83187864774.19.674055D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id C5F354000E for ; Wed, 5 Mar 2025 15:22:43 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UGLvj0kY; spf=pass (imf01.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741188165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VWigdSJtvf2WxMxfGPfKwCzDKILPSKtbmZRomoBqut8=; b=AFMSW+KsRqgjQtxmSk0k8hekKzN2U2eaywe1uUjz4q/tv4RHFAS+uxfbtWHpxY+YhHsGuN /iSJ2KGuNA0x636tcexmVMGKVLWP9FhczC2oPqsuNEE5zE7oBgnytj1H7J8FMUu3OqpLR+ u6RewleOmLo7r6n3BfOAsftbuf11QS4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UGLvj0kY; spf=pass (imf01.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741188165; a=rsa-sha256; cv=none; b=NcX+deW/aBbps6SeKZtVAfviOMITIJNZfL9k0+QNaJlk2wSdgtJRukUz5TBl5Z2Nasjk/5 lGqkSzT3qHzToE28fzAKy2B1RZN+8uI5WPnkOHittdmBBKezLUobP1AvYyL86t3kJ5Ovf3 aQv9kbv6D99VFfYB2LpMGEKuJrScJKE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741188161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VWigdSJtvf2WxMxfGPfKwCzDKILPSKtbmZRomoBqut8=; b=UGLvj0kYszXrqoGRw/DpfOWJFG+rq1LwaM4tqH8gxucElxNXI2/WnoPl5RC603mY+i6yKu 3ItyPvRyg+E65oezt1l0S8rRbZRlH+7LaiDVKLN5AFfRYQ+TrfwQ/COF4cWdZ15/hv09fQ OWFk2eOsOMaTwxdXdq6vT83ZuhHMQE4= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-23qFcZJ4NrSH5Me2lVeGFg-1; Wed, 05 Mar 2025 10:21:55 -0500 X-MC-Unique: 23qFcZJ4NrSH5Me2lVeGFg-1 X-Mimecast-MFC-AGG-ID: 23qFcZJ4NrSH5Me2lVeGFg_1741188097 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C55451801A07; Wed, 5 Mar 2025 15:21:35 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.44.34.66]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id B2E781800266; Wed, 5 Mar 2025 15:21:27 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 5 Mar 2025 16:21:05 +0100 (CET) Date: Wed, 5 Mar 2025 16:20:55 +0100 From: Oleg Nesterov To: David Hildenbrand , Andrii Nakryiko , Jiri Olsa Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Morton , Matthew Wilcox , Russell King , Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Ian Rogers , Adrian Hunter , "Liang, Kan" , Tong Tiangen Subject: Re: [PATCH -next v1 0/3] kernel/events/uprobes: uprobe_write_opcode() rewrite Message-ID: <20250305152055.GB28112@redhat.com> References: <20250304154846.1937958-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250304154846.1937958-1-david@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspam-User: X-Rspamd-Queue-Id: C5F354000E X-Rspamd-Server: rspam09 X-Stat-Signature: 8czs8dg8iqagruuhh187gn4munnbr9ju X-HE-Tag: 1741188163-535754 X-HE-Meta: U2FsdGVkX19Lmm6zhe475zwsA9qoZ1PLSYnm9NX9PWMuOX+RYamNY3iaeqmGKt7Vs1wnbLlG0+zYBcQaOW9ZBan42LDghsuCz+7fPM2eR/WQ8hPExWZjFRtwMljHDePPVm7/levWn9DZ8wmnIbfiHFqjWXpGZ0jO8yVHLrMFbrh1ul8W1Q9jGTF6upnyOo4fhJ63aTdIXpeOWsJ8gnoZvmBPApjkFS7cFy1wnaiv3V+hgouHazNprg3pqvzIXhHDCgKnxfgoHdV5cJOTe0/fst3mjvs1bUtZRuo1LASO7UqggZWV+l5HqtIXnbyfL5aF1ZGK1V6TJIIx1E+JCqia2vgsA7PSkK/yG+0UrrqIu1UwtsLDU/YQ1yhdTE92ryOK539wXTBjsvwA3NhiUtKDvB0rLe7eMLkQlunuurACMggzBgxpVk1Jzs2MewywkY//d+S0MIXX/sdRuipk1YLEAiDoWBaA+OXPBQ+j8fNCz5S+yhMWne5m/8yJxDt25L4q6mw7Vo2gdN0SU/cXnEEiMQCqXhYcezTATvqdMQxO6bqdOBMEQfavG0odI5/Jf75h+Oq6J9bchPRE6c/x8KUe0IBRyaFR1oMjLB4niw4po5psQphIfPkUVLUG7vQan3tGgWuxo65moUFstosDj+p/wRe4FGkNtmgavt5Iyn2zAtRcVq7Hmdfum3QLuTGC0r36gQeQndr/z548Nog2jafxRwQg3cTqE5Of2VCanhsH+AOYqLRJuq8SYq3gkUTsyWqVf/hB4AdAd5dzpQcs+dMBIxUkKZp9dMvDBSqGXYFmvtiijzgxl1zKfTb6YdNLojFSGapiHkXyoYstnJzZx2QmkoSl3NvtF/Itt492+MPHne+bCx0NGqe8GrXnmUkFu1PE/SjtuX2EWFtxSgAOFXEIlpD0AI1VpGSuAMEHVhcWBIzI4Hi3TVaynIPg47S9rlCnby9pNQ1aaEC/CRIok95 5+rCyn8x BzqHAlYEZLGPkj1iyPg82nu8gV7Rsk/ad1bLAfTYRu7ocL5Z6zOoNtIKg1a9X8uHnhDLBOfFr1df0BqoWDgnIF+Ei4o/G3ukcwWXY/F5fjVWQEbxOwAGpWZML/cnQYAwUGHaEcjEJBwYff3T6bi+U3uvMHM8T4PV1E4evHXkW8IZ1OkIwqfsJk1XLcFYvydGwuZrbJYiZBWqPOkGONA71k71b3oHAOQyU/3sn3zNrS2THcmHFLwfFXTdoMUAJaKuQNrVMXtzDhNhHNhaEiuUbttJjfK9Xt39hG1fc2gM6mSLIFZ1DycK1OGzniI+auymwb+bfl5Vex6pz6pm+XFwlafik3tI9N1IUg7JCl0voEu6Gtkk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/04, David Hildenbrand wrote: > > Currently, uprobe_write_opcode() implements COW-breaking manually, which is > really far from ideal. To say at least ;) David, thanks for doing this. I'll try to read 3/3 tomorrow, but I don't think I can really help. Let me repeat, this code was written many years ago, I forgot everything, and today my understanding of mm/ is very poor. But I'll try anyway. > Are there any uprobe tests / benchmarks that are worth running? All I know about uprobe tests is that bpf people run a lot of tests which use uprobes. Andrii, Jiri, what you advise? Oleg.