From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474B6C19F32 for ; Wed, 5 Mar 2025 19:39:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A95E280029; Wed, 5 Mar 2025 14:39:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25701280028; Wed, 5 Mar 2025 14:39:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CF57280029; Wed, 5 Mar 2025 14:39:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DDFB5280028 for ; Wed, 5 Mar 2025 14:39:22 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4894616072A for ; Wed, 5 Mar 2025 14:53:32 +0000 (UTC) X-FDA: 83187791064.27.C4D5111 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf26.hostedemail.com (Postfix) with ESMTP id 57778140009 for ; Wed, 5 Mar 2025 14:53:30 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=inSTEowM; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741186410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ONXOEdockKdHhTfqSAFsPbDgfPvHNHsMHk1hOcOegik=; b=hGrTJw4PP8seod0Yql9yLCBX3lDBO5S0rxGQO2vnhLG+8cQbnWH67fO54ur/D//9OT/JIk OlGFNb7oYhk3f4Qw5CrzIxz3iLmY8/SRFC8Zb+CJkWWYw4c5Ncilc32BCVQEDsJF53x84k yd0QPhfFJwLVmtJWSj//aiBtWLG5Lbc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=inSTEowM; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741186410; a=rsa-sha256; cv=none; b=KwzWoGgCxhgjX0Jqvz4rDTvVFGK8zMf2VGAkMQSZ8cND8k9LHNT2CjrMP1qG5ogD7nTTWZ ezJJJNPVPIMvA4xmabjLdzjDsCUgT5ET311fvQJxpGIorl1U0nrxNt4tPkp7Nay0R5D5jh Cp/H674b2cOVh260Cd9HA2KPr2cmqY0= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6e8e8da098eso5853356d6.3 for ; Wed, 05 Mar 2025 06:53:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1741186409; x=1741791209; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ONXOEdockKdHhTfqSAFsPbDgfPvHNHsMHk1hOcOegik=; b=inSTEowMeuQ7523NxtYx5oGq7jBsqDlTMGNd1R9tvffQTLB+2nq5FXwXCMYk1ebuh7 ++bcRUCk0IDdRjR5oWNoXkU54etnQsWfTglF0DC5PXpoCf5OmMRBiKA+wRiId5V16mJe KGXWv9CUy1WxmHdBAI9ouoGJKpa2mtS4e6N2jO5rM5/1s0zFIJAiI9dBy4ZCIgFCTWll LyVvpmgWvtrLV0YfOElS9U7nWtoS3xJy6XwKRfoUuWUI6mG6w4asAx+gch39D9SjXzIz G967VDSstP6ywV4YpCTWXYJm8Re3vtYsir3no8eUOLIij32RlEgrKFpU+DRONIZg/qlo hq3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741186409; x=1741791209; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ONXOEdockKdHhTfqSAFsPbDgfPvHNHsMHk1hOcOegik=; b=dLmMf2UDf8wKL6qRbTUZSfzOD8+GDEyyFLuO75136pgalCVTqUMIw86IkO7HSR0kB+ eIK0ODSQmz4Okcm9vdFSp2L2CWhe1VzTmJAcIvL0rrnaKNIeOh5AwDqGSs7zabuwWuvY uaFtUbkKiyffpN07xIDPfrFyKRtUjutPzKEJytC54esXvNSb3y29fc86IvWQsDpCUXk7 JU5/zsoARC8ktClcC9nH2lU6HwR7lNx1Ey9egxA0cYR8P+mK+soHr9faI9VBQeAr5dSB I3/4tBaekFJelqHBKknndJ8EP7Jb5B0BOPl0N8dAt985uHYcw/ASMtO39h1nedexQCyo JT0Q== X-Forwarded-Encrypted: i=1; AJvYcCUuvTRnF9vYiF8ln+53sY0zbcL1mFiSr+CUlr8M+Cn+gqVEjeU+fN8q2j93R4cF6JLpp50RYkXxYA==@kvack.org X-Gm-Message-State: AOJu0YzUhlcAeCArkvIgcn+I/eCc3fl15IeiA+WDJ601q7HG/3s34zA3 d115xKP1UwOe0RNvYnGFJplHdJJHTO6GOVeAUn+pR8HzGIcQ9w5QeWvzMcbdLOs= X-Gm-Gg: ASbGncv0wllCOPvqzWtqLhiop5Ckm20Uc1+6+j1p5eLXQWPI4Vup+iDyKX02mOqhZAy uLFo3gjzCTBsJYPErhyaJpZACAHzrggUjS6fWkEzq0U+98CNbJ9bCJNsRZBSbzwYKBgq+271kaX nGe4B4lWLDXQvzvZ68y2gPNGlY+gvwDK7PWnFUv703PV09tLwTVHzAcAdepbnCUbW5FmL7D+6Cb hvZOli1XQMXcNuyH3Y+9IYfy3RE5/qYSe4fKFfC6pCd2/lIiBo8l4ZO9xQdvdWlbKaCvQnuDS05 WRh+PX7X+dVmfq9axLIovu2Llr+CKEzwgBG+p4bwFzg= X-Google-Smtp-Source: AGHT+IGCenBDc2Fsy6T0dVcsVCJ3L8dr9JxoA9aOAo6mVTFn/Kba3M5IpAjpfnxaiyHoOLAMJqe//g== X-Received: by 2002:ad4:5c87:0:b0:6e8:ebfa:42f9 with SMTP id 6a1803df08f44-6e8ebfa4b46mr31866186d6.16.1741186409507; Wed, 05 Mar 2025 06:53:29 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-6e8976cc74asm79656786d6.76.2025.03.05.06.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 06:53:28 -0800 (PST) Date: Wed, 5 Mar 2025 09:53:27 -0500 From: Johannes Weiner To: Yosry Ahmed Cc: Andrew Morton , Nhat Pham , Chengming Zhou , Minchan Kim , Sergey Senozhatsky , Herbert Xu , Thomas Gleixner , Peter Zijlstra , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable 5/5] mm: zpool: Remove zpool_malloc_support_movable() Message-ID: <20250305145327.GE185622@cmpxchg.org> References: <20250305061134.4105762-1-yosry.ahmed@linux.dev> <20250305061134.4105762-6-yosry.ahmed@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250305061134.4105762-6-yosry.ahmed@linux.dev> X-Stat-Signature: tnca4sy49xqserym7u36g3jzgb1tix5m X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 57778140009 X-Rspam-User: X-HE-Tag: 1741186410-452964 X-HE-Meta: U2FsdGVkX1+X7LDhFmPCnt1mCG2OjyONoPzQyEEUCYzkRH5NIxCjqly6pv1CdTy6HVruUTaJMOUBFmHVlK8TJcQ1ns6rQ9ZO9t8qGdTkhw1yhCfUNG8MuwdwyXTLCb2TNJHkdHPKyvLn/k45R/rMHAuPKWqtPHqPEzdTMo3SEhMc/8QhqdNUK9LKeSWZrloosMQBhhdf21TGYNhmUfv/PEIva+os9Hzi1Q1kfC+vIPs5CYtJvJOPvqa2fQJgXw+mcWPv8fFRh+LxZ/w9qGGJrhQdjkPQfG8pqHQjBrvpgUrcafun+5INuMg7IqiaApUL/KEAY9mGEuCQdJq8VqbdePvPQdqJxiklRTyDji4/wzfxLvHstJMI4M/yxIrZ41dKsjLE/hkIe1LmMhItDt9kO+/psSAaezzHzOa9zzssdbkUFUb3KjJUcvcuMaoOERyFXTPsvBpXFcfAPqBXKSPCvXEuuxI4Ou2t4REPtw1oALendUaYalh0yFOhVHjhGzx08dS+z0WmcMO0PjhiG75x3BxEeE25DdyzJfJRjOotL4iFlefGN4+dAFjaZXT0Jo6pNL+6/uxY0aNCcHjUjdMjShnam6Irocnx91rBkHjAnw+KXNJzefRQEl4rs/PGL+rN/c2aSEtN1u2EYgUf/gKiNDUyGfsLOeKFyUSaR1OKFbxqBzdbyC6MmA77zi7A7kPpRzQzSP11AkjyoEm1VpLGEYFs5WssyLI8x1Vd1XnznMrtLy/vdQZHumjJDXFUhlb6Hf9H4TYX2ZCFQ2xxpMuBCKL5oOZhbUe6jS5hDgTGMv1ToZZuM8mP11sr6mkiDVYaRcGsDB9oV5/qp8KvnyNsZsJGH+I41ojoGxzgi1xTWOGD/BZ4W3VhAZwiqUHKVLCMVH6xfxJmBBpTiEBdeBJaEy+1iAjdvywRwWcXVRBj6ncpk9llu0rBScNY058T6uFIxeHlhkzdB9kst8hnpgd qw5tl+oX NowSOLxekPj2wXuoGCu7hPNmkviJHFxckMc7jtRrUxGwsPfb6FfDbXWNmFkbHSCZ0ZeTZc/LkcKbNkyj83Msvx4tvDVF/pSyhsRqQ5ES+6qAndYxBAEzS0YmfCSNKfQnRE9qgOO4zfTKPrJmV51DuOzSlw44M0eN2Zzv0xi4N0qwdQzbMndEghwEZVqvZEqMah0HCA5hNEJsGUWl7EJYj4PWO9VGj5jmZ5lNe1+5h1pA1NJwgooJfNWq4em09jp39+m82Mjn7ikEoD0AlhcV9UomhxGUTZn2p9eqi4MtPY2eRUglzcT2jx+vb8QRpDUSG4CTnAOpbL+5hLRJm+4gK4URlMVRaeEWvGUEBaeOBsHSKnexziDue4HqoIYMAWnUB7XEpNIAcHWjrIOx0tErilyRBQ+ucT/aIlSLNfKc7aa59TutMd/C1TDby1cSvSSYMQVWGoQz/mZYrKwOSdG5faMpUnnkiO1cahBVMguhMsagb8I2cYjG0GTr3fBoJPJL83mdmqghioqiiuXayg/WgQHIMdpwdwTuqDIAM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 05, 2025 at 06:11:33AM +0000, Yosry Ahmed wrote: > zpool_malloc_support_movable() always returns true for zsmalloc, the > only remaining zpool driver. Remove it and set the gfp flags in > zswap_compress() accordingly. Opportunistically use GFP_NOWAIT instead > of __GFP_NOWARN | __GFP_KSWAPD_RECLAIM for conciseness as they are > equivalent. > > Signed-off-by: Yosry Ahmed Acked-by: Johannes Weiner