From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8A3FC19F32 for ; Wed, 5 Mar 2025 05:17:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD7C16B0082; Wed, 5 Mar 2025 00:17:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D87136B0083; Wed, 5 Mar 2025 00:17:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4F5D6B0085; Wed, 5 Mar 2025 00:17:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A7A596B0082 for ; Wed, 5 Mar 2025 00:17:14 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2058E120BFC for ; Wed, 5 Mar 2025 05:17:14 +0000 (UTC) X-FDA: 83186338788.09.502B7C6 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by imf19.hostedemail.com (Postfix) with ESMTP id 7CC8C1A0002 for ; Wed, 5 Mar 2025 05:17:11 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=NWxhaCvp; spf=pass (imf19.hostedemail.com: domain of lkp@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741151832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=dVqQj8Kwz9SmNbL/wLCQ7jlBF39CL5/7sTw0ykbJLpg=; b=BZlMlHb9Lbshmj5Mbc8yq4ktRtydllEbnGJGJF/+odzWjz3axBrlJWnOpoyNc4P/OePohc 5zPO4ysOj9ZOLkuIFgziXCtUQQK/0cHkrxahS5SLlLeqQ46XHHz0NZy0zTqDuBfPQJZouh 5RmJNivOLdk5a+hegY7oyfl/sLbpX/8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=NWxhaCvp; spf=pass (imf19.hostedemail.com: domain of lkp@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741151832; a=rsa-sha256; cv=none; b=XXvLzuTwPW+yoH5+gZT4EJanH5VnyRBVZw+cLfj6eS58WMHQcH0amnX52eUmW7XE205PXb i3KItmV9d+9BTMtyl7DlrTHIzu3NKz3armrCy/ZfXIyYGJz4/j64+B+O8Kl3lX5V2gWz7r AVDIliXIOq3XPNQPw5PO1cHn0u6YxRM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741151832; x=1772687832; h=date:from:to:cc:subject:message-id:mime-version; bh=tN7f97WS/3gnaezF50q5JBtx3zDEhwTL3jP0gollSJ8=; b=NWxhaCvpYWLWPfAwkIdZk8JZElGqchshEzksOj6o0MZH7l7+EjkTBD+4 pAYVGEzZmJ2k/YvmbA7mKsUeBlpkq8ArZM9kt8eLnbr+ZhWSsW5MRWiGk vhsbnnMKaPbAnnfwABIm0gi2OvOwu5KrTF5KlHRUWxxtSD2ZnlXNYR9yr OhSmVUHYQv5vUep8FTXn9kQAcgVY4Nc7bSgucbrGExon+Y6apI/Ia5p8u rjBZRM/7cKwzB0K0U6jI3rbWqQpj1wMqLolPav/68sf6bD1Rcao9Q/O+u VnnBiH5UquWzTpWIRixKaQv1CIZ4sE+1VssyI/I2o5Z8nsCHzsFB9mBgx A==; X-CSE-ConnectionGUID: +vn3vg1TTb6D26NckvcXzw== X-CSE-MsgGUID: EXX4GQRLSYW60BbbgFrKng== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="42296648" X-IronPort-AV: E=Sophos;i="6.14,222,1736841600"; d="scan'208";a="42296648" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2025 21:17:10 -0800 X-CSE-ConnectionGUID: NUYqIOtTTOG4T75CFXQmRg== X-CSE-MsgGUID: G676SmsdRVWfj/XllJkoIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,222,1736841600"; d="scan'208";a="141830819" Received: from lkp-server02.sh.intel.com (HELO 76cde6cc1f07) ([10.239.97.151]) by fmviesa002.fm.intel.com with ESMTP; 04 Mar 2025 21:16:59 -0800 Received: from kbuild by 76cde6cc1f07 with local (Exim 4.96) (envelope-from ) id 1tph7o-000Kcs-29; Wed, 05 Mar 2025 05:16:56 +0000 Date: Wed, 5 Mar 2025 13:16:53 +0800 From: kernel test robot To: Lorenzo Stoakes Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List Subject: [akpm-mm:mm-unstable 400/415] mm/mremap.c:908:7: warning: variable 'err' is used uninitialized whenever 'if' condition is false Message-ID: <202503051356.jJQQ0DoR-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7CC8C1A0002 X-Stat-Signature: njk1awismr5eqre7m3by8ndh7rg4ztna X-HE-Tag: 1741151831-780739 X-HE-Meta: U2FsdGVkX1/qghoNhu+UWk/5BeKlBOhyDgdyz6hzLJcuQJ2fR1b4rKdu0mgtCVvU/JjD569x2yH6grCPTraBhPZJ4fsB7UV8OvDqXw1Mny1P0R5fVFdlRLjJlYFl+yJrcMVudGVjaWsi893ZLDGdBW0TIGq7HiKr877l0VYQyaPDknFWu2LkY6mTOS2k+ii6RfKMRHjVxN8VUtoOACJ15O2Q0XczpUc/hG8J5n9vhG3adjGQHaZPsFbGIA2dAKDxd7bRcQ9+7vQ5KyUXD5zKUVv+tUeZNzRH2WjphUQ5Ix7/AimXqBHmoKI+Faeya3T5d4uoO5JYsbvgUvQekFKHBQvICuSy4J15J0pw+HgQVy00I8D10sgiH5IOS6+740VCCNAGp3IqVPLJZRNGqY+omR4o8ymnTqA5VdMVIvOKnYb+7epfr0NSa2OA+Adc5vf0DQ5Omxo81HVL2U5ENHKBDhL85thMP8YJY5WTy7pnctk9RMEhkLUSwn+lAZJSEHS3d490eDWvaywy18VFExHDYJrqXjXgtCcE4huLXygVv/37Tn2H66TExHUwJPxm9ssOyLc6/Owno3N/v8HI4oAavDZit6GXqrenEEoD3aHOu1qlpbv2/0i+LqIZNPT6z4EeC9CQi5SseCxnONsaUM/I5sZWOzzRwM3d7Oo3cDdcYW06A6lMY2+EkalBq/N1VSGelFxPfgqrOfBeXI73RPNobmg4ArdqwKRyV3IUI1n2U8lD61MWWThJS0Ccd65ACYL4MEePnq7Yo4Y1c70Vi8qMYOnLKINjWM8VuZMNIiVyD7OEDi/388Hpc9/YOGJzfdaUJwiM9woc5N/O+CLXCGNdlKScXgT1lB5+i9tm7YA9qyqVGgIFqIkghaGyNjKhY4X0NnPBoTQnEvf1O6FkR21+i8tKp6hh4mfpUxmfoyQlZB1raEYFr2xMpg0bhHrLKsNRvRIxm7BVAeuwNdzYpem Gjpvrg5A zupPS+TdmvPgb0odqRVSlnpD7qXyB4B547nPFZhIDAyHSndJ8OwZoxBgjyJLPiyKaZG2gDQz6WRv1PW+WqrtAVPfaXHAnVKFaK0xy1lFfW1TIDRv8d/QSqV76xkEezKe78lwYhANA8zP1wEWBCDAE95IKQCBposgUAPKn1L1thN/oKQkcy9SHG6eWUt+S4d5lA81DsD59Kfh6koHLLQ1tbVHi5fA9jsVEr1mt3Xc+JJaFub7jGVA6e5sGSCrR2V8aezhGECwRN2q+UAzmdzfs3M5CdaU6c5nMCaEv88jFXqYhdGHW4cODQfGzjeq8cvFAVI1MjHt3GkAfFAdKeWRr06dGn0jYWResNhgUL7WmPYer3MmxNxW3S3luYPXmnU3H3JwvopuvK38mNqb/SWWaITSLkhZr9mukCS+sW2mq6uhmO5M/2rxpmwuapYY2eu5JlHNK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000650, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable head: 7b6c5895bb9ac3aadddd51108b7bb3bb1c7f3110 commit: 3129f7896afb86e411c0b59a553fbb4053db4012 [400/415] mm/mremap: initial refactor of move_vma() config: i386-buildonly-randconfig-004-20250305 (https://download.01.org/0day-ci/archive/20250305/202503051356.jJQQ0DoR-lkp@intel.com/config) compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250305/202503051356.jJQQ0DoR-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202503051356.jJQQ0DoR-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from mm/mremap.c:11: In file included from include/linux/mm.h:2321: include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ In file included from mm/mremap.c:12: include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 47 | __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~ ^ ~~~ include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 49 | NR_ZONE_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~~~~~~ ^ ~~~ >> mm/mremap.c:908:7: warning: variable 'err' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] 908 | if (vma->vm_start != old_addr) | ^~~~~~~~~~~~~~~~~~~~~~~~~ mm/mremap.c:910:8: note: uninitialized use occurs here 910 | if (!err && vma->vm_end != old_addr + old_len) | ^~~ mm/mremap.c:908:3: note: remove the 'if' if its condition is always true 908 | if (vma->vm_start != old_addr) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 909 | err = vma->vm_ops->may_split(vma, old_addr); mm/mremap.c:895:19: note: initialize the variable 'err' to silence this warning 895 | unsigned long err; | ^ | = 0 4 warnings generated. vim +908 mm/mremap.c 3129f7896afb86 Lorenzo Stoakes 2025-03-03 887 3129f7896afb86 Lorenzo Stoakes 2025-03-03 888 /* 3129f7896afb86 Lorenzo Stoakes 2025-03-03 889 * Perform checks before attempting to write a VMA prior to it being 3129f7896afb86 Lorenzo Stoakes 2025-03-03 890 * moved. 3129f7896afb86 Lorenzo Stoakes 2025-03-03 891 */ 3129f7896afb86 Lorenzo Stoakes 2025-03-03 892 static unsigned long prep_move_vma(struct vma_remap_struct *vrm, 3129f7896afb86 Lorenzo Stoakes 2025-03-03 893 unsigned long *vm_flags_ptr) 3129f7896afb86 Lorenzo Stoakes 2025-03-03 894 { 3129f7896afb86 Lorenzo Stoakes 2025-03-03 895 unsigned long err; 3129f7896afb86 Lorenzo Stoakes 2025-03-03 896 struct vm_area_struct *vma = vrm->vma; 3129f7896afb86 Lorenzo Stoakes 2025-03-03 897 unsigned long old_addr = vrm->addr; 3129f7896afb86 Lorenzo Stoakes 2025-03-03 898 unsigned long old_len = vrm->old_len; ^1da177e4c3f41 Linus Torvalds 2005-04-16 899 ^1da177e4c3f41 Linus Torvalds 2005-04-16 900 /* ^1da177e4c3f41 Linus Torvalds 2005-04-16 901 * We'd prefer to avoid failure later on in do_munmap: ^1da177e4c3f41 Linus Torvalds 2005-04-16 902 * which may split one vma into three before unmapping. ^1da177e4c3f41 Linus Torvalds 2005-04-16 903 */ 3129f7896afb86 Lorenzo Stoakes 2025-03-03 904 if (current->mm->map_count >= sysctl_max_map_count - 3) ^1da177e4c3f41 Linus Torvalds 2005-04-16 905 return -ENOMEM; ^1da177e4c3f41 Linus Torvalds 2005-04-16 906 73d5e06299195f Dmitry Safonov 2020-12-14 907 if (vma->vm_ops && vma->vm_ops->may_split) { 73d5e06299195f Dmitry Safonov 2020-12-14 @908 if (vma->vm_start != old_addr) 73d5e06299195f Dmitry Safonov 2020-12-14 909 err = vma->vm_ops->may_split(vma, old_addr); 73d5e06299195f Dmitry Safonov 2020-12-14 910 if (!err && vma->vm_end != old_addr + old_len) 73d5e06299195f Dmitry Safonov 2020-12-14 911 err = vma->vm_ops->may_split(vma, old_addr + old_len); 73d5e06299195f Dmitry Safonov 2020-12-14 912 if (err) 73d5e06299195f Dmitry Safonov 2020-12-14 913 return err; 73d5e06299195f Dmitry Safonov 2020-12-14 914 } 73d5e06299195f Dmitry Safonov 2020-12-14 915 1ff82995731667 Hugh Dickins 2009-09-21 916 /* 1ff82995731667 Hugh Dickins 2009-09-21 917 * Advise KSM to break any KSM pages in the area to be moved: 1ff82995731667 Hugh Dickins 2009-09-21 918 * it would be confusing if they were to turn up at the new 1ff82995731667 Hugh Dickins 2009-09-21 919 * location, where they happen to coincide with different KSM 1ff82995731667 Hugh Dickins 2009-09-21 920 * pages recently unmapped. But leave vma->vm_flags as it was, 1ff82995731667 Hugh Dickins 2009-09-21 921 * so KSM can come around to merge on vma and new_vma afterwards. 1ff82995731667 Hugh Dickins 2009-09-21 922 */ 7103ad323b1ae3 Hugh Dickins 2009-09-21 923 err = ksm_madvise(vma, old_addr, old_addr + old_len, 3129f7896afb86 Lorenzo Stoakes 2025-03-03 924 MADV_UNMERGEABLE, vm_flags_ptr); 7103ad323b1ae3 Hugh Dickins 2009-09-21 925 if (err) 7103ad323b1ae3 Hugh Dickins 2009-09-21 926 return err; 1ff82995731667 Hugh Dickins 2009-09-21 927 3129f7896afb86 Lorenzo Stoakes 2025-03-03 928 return 0; ad8ee77ea9db1f Dmitry Safonov 2020-12-14 929 } ad8ee77ea9db1f Dmitry Safonov 2020-12-14 930 :::::: The code at line 908 was first introduced by commit :::::: 73d5e06299195f4df82832cfc4a3a0c574c1e473 mremap: check if it's possible to split original vma :::::: TO: Dmitry Safonov :::::: CC: Linus Torvalds -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki