From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 808B1C282DE for ; Wed, 5 Mar 2025 19:08:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90FD8280008; Wed, 5 Mar 2025 14:08:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 897EA280004; Wed, 5 Mar 2025 14:08:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75F1B280008; Wed, 5 Mar 2025 14:08:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 53AB8280004 for ; Wed, 5 Mar 2025 14:08:46 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8CDC7A4C40 for ; Wed, 5 Mar 2025 12:02:08 +0000 (UTC) X-FDA: 83187359136.21.76CDAC2 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf03.hostedemail.com (Postfix) with ESMTP id F077C20034 for ; Wed, 5 Mar 2025 12:02:05 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=VtH57fDq; spf=pass (imf03.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741176126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w3jS644WhTQzdSpL+ORCFYYqv5biKaCzH+wq3LEiueQ=; b=TxAAgAMHsv/DQX6HzK6WFPDErSTU/DgNyYGztBqhwtqra6CWtaxwerJR4o8MfSbZZvj58K qkbW+o1imoM9mzJD1Hp2hv9a8by+uuxD8LyVXkjMkwFmUFOZjeI4laLUR0sOzRCbuojM8U GQiKi5mevskHR8EjCFly+dRrXy4He0c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741176126; a=rsa-sha256; cv=none; b=vUIkTx/c4rM0Yqo5oPbQrsiO4G+E4gLJpxL4hDlNA1Hfpdd/lpb2eQ9L9V8oOpoDnT7C04 d11zNzC3nZT9wDSHF0pF0y59OLr6wIRaSZzvTNA5av+G/txfs0We2AGk7q2woeS9n2e4PH X67Lfcy/3ZP21lwlk0mM26wtpNUbKL0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=VtH57fDq; spf=pass (imf03.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 40D7140E0215; Wed, 5 Mar 2025 12:02:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LK1hFBB4uqau; Wed, 5 Mar 2025 12:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1741176118; bh=w3jS644WhTQzdSpL+ORCFYYqv5biKaCzH+wq3LEiueQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VtH57fDqtkt3keBi/TuvJfg/qrgU7xf6qhQK2IF6dd+1rJIMNOwMUELAwnsQ0+sKY uta0LZFwrnh/+2ecNk4U4+TWtvdZPvAzQ/0MQrnpuBqRMeioNkQTPlS67nXxSc25++ 2cy/TSo3BRlfg9l6VfkAodr8RlAE8rzYqihKLSn0/nFQgbkTTNShCKpiDqLXYtZQ4e VaXo84MQK2MeiCIwYR7Grxoo/Ij7Xl0SLyTmMh26AtgTutxbt/7lcPk0gXI96We0EA U4ax4k024BdZ96vyW+oOVuE+M6WtoSX50z1gEweESaakwSuvAZEU7obD/3Nw5F4gCi UOyJGPoTGKo6CMDhqkovnlxRSS9m44hdUhGTJIh5wT2Qz9EwWTGea9fi1YOR2Vt6UL /RSqhXXQs+b3IG8e02uxwYCWCXLdxch8l16V9g6s0BiWjOfhTA/HuDzNLgQl+Prgpl XaM/eHsAqiDTJJ5OuXyFZcStXGUBQKWRRFwS/dvMT1OpJf746mtz0ZoYjf4Zq9vKRx 4hAVPLK9ANKyPFEqB2Z870H6eH1U8Ykk/DSkBixu+r3ZoFsc4GWLy6996yIYbN67a0 KgsSqV/5SI5j+S2HKRnLw+5T4flmD1hKE2bft/vg88sCICfksfRZdm8nvKrSKThm44 NZbKzQ9X2QfTZUs2Nxqo7LLE= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 01FD740E016E; Wed, 5 Mar 2025 12:01:42 +0000 (UTC) Date: Wed, 5 Mar 2025 13:01:41 +0100 From: Borislav Petkov To: Manali.Shukla@amd.com, thomas.lendacky@amd.com Cc: Borislav Petkov , riel@surriel.com, akpm@linux-foundation.org, andrew.cooper3@citrix.com, jackmanb@google.com, jannh@google.com, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhklinux@outlook.com, nadav.amit@gmail.com, x86@kernel.org, zhengqi.arch@bytedance.com Subject: Re: [PATCH v15 02/11] x86/mm: Add INVLPGB feature and Kconfig entry Message-ID: <20250305120141.GGZ8g9JU-IaaNNgTRb@fat_crate.local> References: <20250304135816.12356-1-bp@kernel.org> <20250304135816.12356-3-bp@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250304135816.12356-3-bp@kernel.org> X-Rspamd-Server: rspam02 X-Stat-Signature: 1f94m1deb195no7em459r63cfn6yo1uc X-Rspamd-Queue-Id: F077C20034 X-Rspam-User: X-HE-Tag: 1741176125-460667 X-HE-Meta: U2FsdGVkX1/ubQDwGNmrKtSSYy0p7n/Y8bhnsbcYD93dgoy/aDdbnb9LgOmpaJjoHLwisvQCLXeQ9XO/YKtLTX5sye2RGZjcF6t6/zq6Xtr0+wZvqBGh40CZrtoEZS0l/iLzNsV1U7Flh74pV2RjmjBLHyXgB4ixnpLKA/o/mTsEyKjv3s+PYTKpFISUBjmPc55vTaHW0EnorTYuY3V0LEo4pDByvL4bwRAsewC3nWIKL48IVlASYSjUJeeRNDe/pdoN+G4cAR8kAEI5AZ/rk8bLgMYm4z9T6noHx/OrpKJR5Ftl2XAqWFw0umEDYTJH8JL5A1ae/e8y+gg3q3gtL2y5Ylp7ES2wK5BG+jXcwZ4K1ijFqpoHWoXhfLFyBiEDholdBD0M1LI1nxyX19SJkLlZjO2aLIPyCUy1neU8uhKXyniF28fZ1SzOMr9sssMntICx7zmX6uYlF8T1z/wCGTStuQlulJn88zLkcn37J0WinoQXcrKpEQHzJxoPMuTbpdp1OLdmT0Sozs7gUAKE1smhbGBXbPzp5+4vS1jzRDuAfgoAWgTGxaoBLSAoRxSIDxJolfk9SVHJ9TjiHG700b6BbnuVLP7RFBcREr8zffxnI9izmqCFt26m3MpKFvo2I3DIpAqRzcRh1YJcjTs05Xb/mWLDSP4LGA3okl4ZoFxSQGrHoeivosMZ/vP07DJ6hc4v3BCxtWk6OAXq/7/Q+7WtvvaOYtTiu8m6xoKyn9KLnnOXlCKPX6Kg/hMnW0dhLXjwYKjQaaAmlDyvvIbShTF5SWurkH/9HYt8wG/CKXy7My3FpxG3Z2lOqExI5txibFDB1l1gKjaovqUxjyN9zXZ69+g4y1b1u1JwdmDwKVawgZdOXpfKrC1MccO4f2setxB2ZbXUUKjYMhHzCQC9ADMLIogjljj3p/z9d0XcDe0020JG67e5fmFRKNL0whoU2guRIG9sm3hBrt6NXH8 3eft5vSk GDxRacEMn2PaWQLpn/dCckgu2iEwV9+ioh9piPAEYLQJlSQmMUaXuPNzWF+DMF0XReXDtC/1b+RdQtEvqvj15cqU3uNbamY4rdlyLR8VIJUGHYD4DkvJIWxIbEbhPEvN38JdcnPpL4m3tmxc5Tp/IPSWqypRyp+F05dObHTxPSl3UK6wbGBZl8C0vwEfQ624s5uawEIofbQRJsqctw4Vz5kGUbBRuYKT+GiYfv1tahT4PG8yY/u2ejJ7zcZfnbR5x6E6Pjv8aRfqo+7blKhyMtwdQhfZ78KUj4wZfopr+3BburNrlWwdISrkr31b5dsygu4PUSLaTKUiXurB+8GUpzAlLHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 02:58:07PM +0100, Borislav Petkov wrote: > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h > index 508c0dad116b..8770dc185fe9 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -338,6 +338,7 @@ > #define X86_FEATURE_CLZERO (13*32+ 0) /* "clzero" CLZERO instruction */ > #define X86_FEATURE_IRPERF (13*32+ 1) /* "irperf" Instructions Retired Count */ > #define X86_FEATURE_XSAVEERPTR (13*32+ 2) /* "xsaveerptr" Always save/restore FP error pointers */ > +#define X86_FEATURE_INVLPGB (13*32+ 3) /* INVLPGB and TLBSYNC instructions supported */ > #define X86_FEATURE_RDPRU (13*32+ 4) /* "rdpru" Read processor register at user level */ > #define X86_FEATURE_WBNOINVD (13*32+ 9) /* "wbnoinvd" WBNOINVD instruction */ > #define X86_FEATURE_AMD_IBPB (13*32+12) /* Indirect Branch Prediction Barrier */ > diff --git a/arch/x86/include/asm/disabled-features.h b/arch/x86/include/asm/disabled-features.h > index c492bdc97b05..625a89259968 100644 > --- a/arch/x86/include/asm/disabled-features.h > +++ b/arch/x86/include/asm/disabled-features.h > @@ -129,6 +129,12 @@ > #define DISABLE_SEV_SNP (1 << (X86_FEATURE_SEV_SNP & 31)) > #endif > > +#ifdef CONFIG_X86_BROADCAST_TLB_FLUSH Manali caught this: I forgot this one place yesterday when converting because of the tip patch zapping and branch rebasing tetris... With that fixed, Tom's patch with the guest ASID valid bit set works too: https://lore.kernel.org/r/20250304120449.GHZ8bsYYyEBOKQIxBm@fat_crate.local I'll push a new branch soon. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette