From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB606C282D0 for ; Wed, 5 Mar 2025 02:01:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 386576B0082; Tue, 4 Mar 2025 21:01:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 336A26B0083; Tue, 4 Mar 2025 21:01:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FE456B0085; Tue, 4 Mar 2025 21:01:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 039E56B0082 for ; Tue, 4 Mar 2025 21:01:39 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A74B3160920 for ; Wed, 5 Mar 2025 02:01:39 +0000 (UTC) X-FDA: 83185845918.17.164215F Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf18.hostedemail.com (Postfix) with ESMTP id 91F931C000C for ; Wed, 5 Mar 2025 02:01:36 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741140097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=wULsWBF6JeH6s52dzVJh9en3LlUoLTTST+l3cUUwSd8=; b=cFooSEhop8y7wh90QwsUW7YbYLT0oy3cuwkHtVP9TLUh63E3gdlAqVG9mO0u0EOKommFs+ ZBIxw9/NY76NBILQ+vtAhK9lIWv1ulz7KTBV4LZedZSZKSfEivG0RU9Qxs2MDgzoFZY/PB Ki6OIjrxUUBPRjdQHfoVm0rbkDicdoo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741140097; a=rsa-sha256; cv=none; b=A9kdocDMwk57WDZDSUsgjEGdOge6+kxUfIQUPJ2DqFKPXV/DZiuTouoNCSY5OnufxT5Qch O4E5lAYW/vD6NddCnsdJUYRm3uUSAOfwYl84xRKr4uTtCDHcgtcqcW/34HnRBNOn0R/2Zi 5U8PADoucvC8J7CioJ3ejKEmN3uS0+Q= X-UUID: c08401d2f96511efa216b1d71e6e1362-20250305 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:0238dafa-989b-4e74-8877-6f1d242694f5,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.45,REQID:0238dafa-989b-4e74-8877-6f1d242694f5,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6493067,CLOUDID:04d3d84079e81ad0c78bc98d82cfcc6a,BulkI D:250305100129VIYHD579,BulkQuantity:0,Recheck:0,SF:17|19|24|38|44|66|78|10 2,TC:nil,Content:0|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,B EC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: c08401d2f96511efa216b1d71e6e1362-20250305 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1422417236; Wed, 05 Mar 2025 10:01:28 +0800 From: Liu Ye To: akpm@linux-foundation.org, david@fromorbit.com Cc: zhengqi.arch@bytedance.com, roman.gushchin@linux.dev, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH] mm/shrinker_debug: Fix possible memory leak in shrinker_debugfs_rename function. Date: Wed, 5 Mar 2025 10:01:23 +0800 Message-Id: <20250305020123.605496-1-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 91F931C000C X-Rspamd-Server: rspam09 X-Stat-Signature: 7b6u5opxux6pftxuknjbyqitkyop9cxh X-HE-Tag: 1741140096-598670 X-HE-Meta: U2FsdGVkX1+vx3J6+zZVad/3ht7yTuTUshPHzS1FzpABehXbNcCy3UubORAKgY5MQQR62fFsiLWXGWtFQlgkFNyzuE/lJX0LhkeNciZaaX7y+2VNEjPlZBEa9y6b2IkR95fIBT8BnJQy++x98mTbK/LFfGoB793GEeIyoEH9+ppu77WK08rvjBDDJd0QgmX0IPOyVtpU7qpFCEeL9DigL07PB4NJPndee3hHebwRcLKVT7YnhBJYyIRAvtsURizSyAjqnbubNU9KziLMBX/xTfwfvFscCAQsIyu0E8jN2CXljgAbJZXWbtPs8dOtr/eBF8DKlLWJ4LlEOQQhdSRQvyn6JHUAfwPgWcRmp0KPDLV9s37my5QvBBwbWaSkTUftCG9MPLlr+CQnj8YhcwfjxTTbHtSHLFG4Eq1zQG2kPL8HLG1mKLiJxk415mvllDYhw+Aa7HeFDo7c+TQ2A+NB4S+WcV4ZGn87S8Sn3jU9cSEIrP6n+WZ7IpPWzRHA4FyZ2IzM3lgL/w9RuIzKAGZsbs8Ma/SougaQ8oozm7I2L9vzcXCf7eBZYr5XTUcKxMtlp9MFNggDCJ1CcpXZbM/xFiHIv4CAGfJQFPwvUXVqk7w87OCx1YeTVzacl5/gwa/OyzbJLPn8/wwiFcvfzXJPcLQ9b3uVxwGc1T62th8FjypoFBvsYXZ1rQk7ssER6zIgjDLxXU5aR7utIVVzj9ImLBV1pacSTWKzJ8wT3GCaheY0C67hCIEB8PeL2Axe3Ax/4mXl0RCG5PVppFQD1VGtOsKsHLVStz3ZHvX++UHBN8TSZiCRBgRxVLI69sPCn2uXum/ff35BSeJvn3N0H3Pczm5M48FCp/3tEC6TJJthTdGv5MgO5PnxxHI5beIlFvdsfOHkk3pidiIyLTvfkkjbnTeGvVsh2l4mZcwc0S1WbOeqFCktYAA+KrM3vz5guucifOZ7at6nknNoYOPwLnN 4/6KGIdO Mjz+Zuku4NFFbJpyJOzAbeyW6VlG4VBGjS+avDgZmiUOwMW1LW/JZc4js4c74fklE22A+wsXcmQA4GYg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: After calling debugfs_change_name function, the return value should be checked and the old name restored. If debugfs_change_name fails, the new name memory should be freed. Signed-off-by: Liu Ye --- mm/shrinker_debug.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c index 794bd433cce0..20eaee3e97f7 100644 --- a/mm/shrinker_debug.c +++ b/mm/shrinker_debug.c @@ -214,10 +214,14 @@ int shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...) ret = debugfs_change_name(shrinker->debugfs_entry, "%s-%d", shrinker->name, shrinker->debugfs_id); + if (ret) { + shrinker->name = old; + kfree_const(new); + } else { + kfree_const(old); + } mutex_unlock(&shrinker_mutex); - kfree_const(old); - return ret; } EXPORT_SYMBOL(shrinker_debugfs_rename); -- 2.25.1