From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E92A9C282D3 for ; Wed, 5 Mar 2025 00:57:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6319C6B0089; Tue, 4 Mar 2025 19:57:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E13C6B008A; Tue, 4 Mar 2025 19:57:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D9CE6B008C; Tue, 4 Mar 2025 19:57:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2B1C06B0089 for ; Tue, 4 Mar 2025 19:57:55 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A97201A07B0 for ; Wed, 5 Mar 2025 00:57:54 +0000 (UTC) X-FDA: 83185685268.30.E6334A0 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf20.hostedemail.com (Postfix) with ESMTP id AAD231C0007 for ; Wed, 5 Mar 2025 00:57:52 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lGrTPxwU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741136272; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yfjbTJi8ZmmEX6Z1RqyCiullMZkjPPfxyDPqvwv2WxU=; b=8eJsi+Ak43YRSKcPaOsqLHV2Zg0FbYk/LjNQBCOGGg2bqLxQVKMawIhe4+b7oBhB5l6wgf u9XFbi39OCFkKf152NHgLK6ai/w6GJ3oD8KkvO5BkVmE9LOQx22HMMBfIjN+RWoTV4KE7+ Ibplk8+ti+cJB4MCBEUeCzZKHC4OCWc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lGrTPxwU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741136272; a=rsa-sha256; cv=none; b=15wjXsxCVceWGvMxZaLAlK3IXdnD6LFudftnr8cy6z9HtGXh/rFdOX4gox4je5d8gQI6rR BsUjjyyBk/f5WtL/HPBao4+pVVaC6Kz+B4p7+RudgHsb7uPP6jbAg6ao2CAm1mi3gpkEBg UpE0vsER48pYSlrEYfO03P5bmJcY5Lk= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-abf3d64849dso592358466b.3 for ; Tue, 04 Mar 2025 16:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741136271; x=1741741071; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=yfjbTJi8ZmmEX6Z1RqyCiullMZkjPPfxyDPqvwv2WxU=; b=lGrTPxwUSSBYl6hIL3kTgOEU1ZfYMdpVc7Cg7zOdFwLIaoSoiGWmpAycD66cIk4x5F dCg7RlHskCGbZ0JGHvbh8fHI7dZrCDF6mk6FFHYwn5XyfxjCcKt2AEl7aG3+mpYpdFPr pS76f7GpcKNiKLwl5itZEasfwbm/PjQWTV5ig7HIUJ6z2q68/bJOFt2p6+JuzkLgI4Pc WpMG7debpRmJz9VjKixdChp2tnAxd8WFlqV2i/kEG2MK6T3j/FZRMEgNBHSvQPtiqSgp qAZPJUlfHQKpG+nLP307EUiTeS8mJ0vtBahXgMsaX9kF9toM/mwViA6aPb1iqtVnvF5k e4DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741136271; x=1741741071; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yfjbTJi8ZmmEX6Z1RqyCiullMZkjPPfxyDPqvwv2WxU=; b=GTlIqKPOuDMYAOxYLofmW5JcTUPHwo8S1Nh0gUckkg/8dLOOfRdaj256E7g4GjdqIC qUPXK9IzwHpI1J8dHqBYBRFGTTl4Qd5YhQQeHVLMNYq6vKcr13qfHUs4mNeXeA5uzSNc AwUChtiYqyn8NrVaa79i187KSN0JLMKAKN0wkfsawDvy1DnQoj2WjK+gFz3ae9JYoxSm Bgdr08SDV7SThj5YXLvXbrI5h5WTGPyvSqvv/jiO2WFwfkQsVa2U4utXvuhCcGXlYsVu M63ffkI+g2dlMck2ucsEnCKYAhZpQItH8FiJUQPqgzFRVjN97Wfcbb50y0ZnNeip9Fx3 jHEw== X-Forwarded-Encrypted: i=1; AJvYcCVtPtM4+rMv9FhzTTKloSEYCs4GEAMlo0JB9QdwKBn/ofWJalDhvCGawmr+NoioPXOpAWC6n5xAOA==@kvack.org X-Gm-Message-State: AOJu0YwDjVniF3IJy8ma+KOyVV0f9sWp9ncSl7TmAk101PaocAV9sETy NbAoeOn9NqjfrcK81CgjlMyQDWmdBIXzal1fXPLpPOlC1b9VQd7H X-Gm-Gg: ASbGncsVTJPXApB9a9Qf4sc5j4nw4R5gSP/RDZaPtUWv8Cs0jK3Jt/+PHyCByEUX+/b Y+If0lSGz99mCc2MK8rhaVYunPp8Ljb5rys1d/9QXKl54mG+VjEsTlfx4VkjQtgFRm4+om6q9J7 N6Nx6dFee8aTw85mpeczeBIWplBtiaUXnN4abT6jWmW8f/VF3NXEG+bYPndwyWlYSFLJuBuls7B EhrhyUKA3SHu8ROIxvfvgb7JxRU2amFcOFHOC4MAR/Ozgrul/yOTGjR8tNph/djVmYaQGMmaASd DHNSORsniTsYsOYawwbZvMTIZEimQMU5awIQX1MH0Kkc X-Google-Smtp-Source: AGHT+IGfFSuGatJ2k9dwo7VK8x3OOMuLRQ9APGIc2cEOs4SD0E+HGdVvQwcdEZuGdI8dQYZsyl4oKg== X-Received: by 2002:a05:6402:518c:b0:5e4:ce6e:388b with SMTP id 4fb4d7f45d1cf-5e59f39509emr2499547a12.6.1741136270978; Tue, 04 Mar 2025 16:57:50 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf627daa5esm582167266b.154.2025.03.04.16.57.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Mar 2025 16:57:49 -0800 (PST) Date: Wed, 5 Mar 2025 00:57:49 +0000 From: Wei Yang To: Jason Gunthorpe Cc: Wei Yang , akpm@linux-foundation.org, willy@infradead.org, michel@lespinasse.org, linux-mm@kvack.org Subject: Re: [PATCH 7/7] lib/interval_tree: fix the comment of interval_tree_span_iter_next_gap() Message-ID: <20250305005749.suc63irjoqnodqea@master> Reply-To: Wei Yang References: <20250304011952.29182-1-richard.weiyang@gmail.com> <20250304011952.29182-8-richard.weiyang@gmail.com> <20250304141230.GX5011@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250304141230.GX5011@ziepe.ca> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AAD231C0007 X-Rspam-User: X-Stat-Signature: xwfj17f4kjx3utfy5shefo96mg3d97f3 X-HE-Tag: 1741136272-610161 X-HE-Meta: U2FsdGVkX18o6yjJw+N/aq12tjMygiKnjkA1X7yBkQmMy0wkm70m3wzQSLPV/8NZ5fUthBpdQ+uWCeHuaPWZSHndbp/AQGRluaTcQrhg6XldCdqgY2zhwytaQ4PqS+1NVRFzZDONPaMi8l2zw5uWJAszAHY/nqqmzjXhhbE5FpaIXsD3DTiwf3vwF+1trWmmSO4QU+qN8avhs4kKNnHoSgYCjJUEDeFXvWkmQEUd2aFNBYbadg7Yd6EzGG+jx7XqPysEVDI8kmH6iR523dphmbhhn3EB4NzroSg1F5FApxOUUkud0EKIUvpjgcylfa0TbAClwfDjdivZab0HSaC7cpJ5PQO3btnt7jo1teST/BcY9foTfWBx12NfGG8urcY+iN41xHeXy1SDHi1DX78ph/73VuEepBc5haxmUnDUMBr0/EotVJqvgilER4GfROJhNwk01BhKfh9QOGjLkQeqCf+q7//tuslCZpslRolQJcB7t57EBpTAweZUNwHz5mtlFicJYlCk1vCEXTjbKz6f4RAZ9LGSIClh4kELT8bxANxUw7zcpAnIsfhU/CUUAxbm2uXidXC3yiWkLY1JI5+QCnkB2qrvhCTu7DQqHquX87ocXWK0suxF3r7MoRzirfrqdoTXbJPRwzqJqWVRnjUXDoJFaW0grxLUmqQa5NlJEkeRlqZkHX8eXZTYPiW0aqm5x5sW/rAprJDtdFjtFs7Z5c5ZI8YWa1GOgY8Dsf2GvFBrWJyS7hpcC+yCf+iU6T4B0jd9rvZhXaqJfO1b7YM1RLeIWy2xSViSRykqTEpwfGyHb06oUJJITJFCzmgWovat3YNCuzBUUQoz9qwBXQPoNzO9EJdYEM9b8Uf2YtPPVEaFyZKP4WziJtMS8Iar2X1MZ4I1wU6cq/w0OWNVD/+okEAdp98uUqClH0CGiZRD05GwuYX1VCHYgJ2RByhP7/sPPMCyX6aGH1aqmuzLiak j+xaUs/S WsrBLb0eP9bo/krIjODz4s1Mro9VFFQV+9CP2HtLfMYIs26zz6t+x7bGVmGvc2mTzRrrIMhvN/F2uLEafgBsWNJls3KdMhfbcJTGYRkDTQ6UxqQPBs/YKhtj07d9KGUWjB/FxHrJKjoLjyP8VPWWLN2OyZk2lvoid8O/Bi03x/qVzx3nyFyxfE2ZYyhhdKGfg3wtCbckDGIs8Bn+F8IQ5desZAfN+Ct0Ob9a0S5XTsEIeNlnp90yyS/7SDAZTSWY5JK+DtLWdkcIEF05gNUFvqc2JEUq4Attq+icsjGRxm61DKc8bLkZEmYMTrIXONtvAqxAKAxKKLGFn3K/FAiOlnTHvZCPBhaaC0OKuUq7Lo2vVbg7slGR4ZTn6H7uQ/LOl/szsjnLVi9wDSp38B9CjHmanm1qeVviSugaFNdOzXyXd2cMr8R72Wff+03uzcs1s2cvf4OVuWSCzxN2F2zViECu3qoDz5GkCi2JSucRI12ASLrGxROZHxWbwLL+poDYeuwZMJM80y8ojqZLM8G7baA7/luwMkv3dP6vhbanY8GnptOjBqhPXZsGgTCwzvLFTjWob7FDI6K+rUBGvK4Ph29VGW7M9LUZBmPijq8aMjFf0wuvJP+B7lu/OCpqR5GcxI/Yswh9nBvHjBhJfFunvi9b0EQwJxuQET8hcopIMIMLO1p7zMAnGTDjvXMW733/baRRZDEbSJsXH/v3qEp30AIs0+V57mXhBX/aTC033a8E4tGMkQ9k9RTReioU0f7FepFBKaD8jfEw73qG39qVZH3/KSKFC6hf4fmKPeUKjxqE40AwqWHRyZTCt65AtGw/STBDHjR7NOyCZvE+9JErzjhq2uPwW+mkA9fm5AosjSmaDiu4j32rBTqFD8vhewooZ2gGO0adQJA440qSVA8+7u37SIje8R8B4nRANEZgwwcLeI0lNEF5fDk3O0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 10:12:30AM -0400, Jason Gunthorpe wrote: >On Tue, Mar 04, 2025 at 01:19:52AM +0000, Wei Yang wrote: >> The comment of interval_tree_span_iter_next_gap() is not exact, nodes[1] >> is not always !NULL. >> >> There are threes cases here. If there is an interior hole, the statement >> is correct. If there is a tailing hole or the contiguous used range span >> to the end, nodes[1] is NULL. >> >> Signed-off-by: Wei Yang >> CC: Matthew Wilcox >> CC: Michel Lespinasse >> CC: Jason Gunthorpe >> --- >> lib/interval_tree.c | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) > >Reviewed-by: Jason Gunthorpe > Thanks >> @@ -20,9 +20,15 @@ EXPORT_SYMBOL_GPL(interval_tree_iter_next); >> /* >> * Roll nodes[1] into nodes[0] by advancing nodes[1] to the end of a contiguous >> * span of nodes. This makes nodes[0]->last the end of that contiguous used span >> + * indexes that started at the original nodes[1]->start. > >"span [of] indexes" > Ok, will add this "of". >Jason -- Wei Yang Help you, Help me