From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25884C021B8 for ; Wed, 5 Mar 2025 00:48:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 371906B0088; Tue, 4 Mar 2025 19:48:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F9B5280003; Tue, 4 Mar 2025 19:48:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1752A280002; Tue, 4 Mar 2025 19:48:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E54386B0088 for ; Tue, 4 Mar 2025 19:48:31 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 795241407E1 for ; Wed, 5 Mar 2025 00:48:31 +0000 (UTC) X-FDA: 83185661622.27.2FDB22C Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf12.hostedemail.com (Postfix) with ESMTP id A48E54000C for ; Wed, 5 Mar 2025 00:48:29 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f0lu5jPg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741135709; a=rsa-sha256; cv=none; b=mZBvgwzG4ZDL4KefuRtAmpMXmChcobN/eOSYWY4NThjab/vpDveG7p+30v/Y8E+JzkVWgp FzvUTEu/F4iyPPlFP+xHbglnheS2OHma+o962+G3hXYS5/FTMGm+aGGQslyenPWbKmTsKr ogUBi0ElR2eQtHfB8tGLbehFZRgIJ18= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f0lu5jPg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741135709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=mZa4eYUkmXVz1t5iRUH0F0TZZ4VY704zpniKkDZZtMI=; b=g4yTObx4vtfxWGcx4dJ7dBN31/Sdyhe62bF/L/bBTAVesInfbxueMSmlo/6nw8Z8XlJL3R oZfXI1vFE0IkIheb6SGtBovPIBfAwuemDtpcWT92Wc4FWxtvwiQuw2HLAso4ZdZNMnfTTu EY339ulX8TTRs5TaoeoTa1R4w2S2HUs= Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5e538388dd1so4048415a12.1 for ; Tue, 04 Mar 2025 16:48:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741135708; x=1741740508; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=mZa4eYUkmXVz1t5iRUH0F0TZZ4VY704zpniKkDZZtMI=; b=f0lu5jPgKWFRVwmCAs7inPLXwvVGamI+/FeHxguSXe1JH7ZiBekANUcjJwdGkuHcdG ZerJHhcheS/cruhafirFuAwqLayYe96Jc13VceAPqquCN9HKFwdGQ6xy+AflKDv3MSSD rlFQue9n1bHpvXPevO6ouwiqf2yXJiodu2Ncx89fhh3I8jAqLH3bCCoi8rAxY85FCF1g QW9KO1gyC/eyb0jT8wrkgkyJxhmosW9rXbHFgIFBznixFjHzjSsHkFHrMJDjKGtoQf0l 69R6d/D9SR2yByekLu4wspCJUgLDQzb40JUAPduyEHW+F0yqguZTRTY7f8hMj3ddAvpt sHwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741135708; x=1741740508; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mZa4eYUkmXVz1t5iRUH0F0TZZ4VY704zpniKkDZZtMI=; b=P6JLoPRuXRbZjpe0vihDLEN0qMML/0ZeK8hWJQ7z7YPQpn2qwMc16QT9PY5qV3erY/ IiMHiVfb8z/MDf5wwa1qAp0bk1WasBYUrwJrEI9N0pPGyvVirpRrlv2GFhmr2dD4QTP6 6/j83SLWMS01fUce+k4Acp995HigrVeobC4V+ZmRUvfvCxV1GqFIcfHsiifeAe7zSUtO DqW31q+VR0y6PuDiy2+S5B64xK5xhMVDs/AdJsBOwL0SF9EhJUls+SRq5StEKQ1zKvgY eLruOI2XYxOISQZIRsVXjOK7pkW+aoNXOB7NueRslMzAzsV+r41WkA47LQ954eonFPm5 sDdg== X-Forwarded-Encrypted: i=1; AJvYcCUCfbIMhf92F9eSzhHl/P0aONy5ZhCLa2ZjOX9kUeMN4T3C7DNSwhoNI53BK78Sg9QsvckZfF5d9w==@kvack.org X-Gm-Message-State: AOJu0Yxcdh76kXicL6xrNansHqhGVd5JFsACEf0N5xP5fySk1Rmu/+/j zsFagZn7HzN4dTm74h29CrA6W18n7En+9kpeBl16HdW+rCEClJqtb45AqGmp X-Gm-Gg: ASbGnctwFAJUPVALwjtNYhXJDUimFVFTlKVct1AW4WhARNoqueIG0JUVZ3fCuriO3d9 lI6fFVuz88qzJcWJbbTK6RJ8GsZNYn/aLrVm7xTD6F/AscXAWDBYsbY/6Wy0TnC772crMxJb1cQ WQQuONnnVW1JnPUFtp8iO+2VO3XA67acC1mT4q9/e6rmjFOWYFC1QX5o13gozrW1yCwYJbVlC4B DaBSg5lxwn1riPcb2m+NRBJFLBm3BUDDWt8rYs1L6SkWEuWj8XaM1X/JkY55nD1H3dkxnnSu83U f2pRtoBloHxOF5N8JyoM/H3WXJDzcfNNjGtvWmSbH8O6 X-Google-Smtp-Source: AGHT+IHIAcpEyYkxtJ19bmPwgaAi+1zaZq9I8OOZ4CpLcuxco05P3VkwD22VCUticmKAIF+11gDWpA== X-Received: by 2002:a05:6402:2550:b0:5dc:7fbe:7313 with SMTP id 4fb4d7f45d1cf-5e59f352474mr1096452a12.6.1741135707783; Tue, 04 Mar 2025 16:48:27 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c43a55d5sm8845841a12.69.2025.03.04.16.48.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Mar 2025 16:48:26 -0800 (PST) From: Wei Yang To: akpm@linux-foundation.org, Liam.Howlett@oracle.com Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, Wei Yang , "Liam R . Howlett" Subject: [Patch v2 3/3] maple_tree: assert retrieving new value on a tree containing just a leaf node Date: Wed, 5 Mar 2025 00:46:47 +0000 Message-Id: <20250305004647.21470-4-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20250305004647.21470-1-richard.weiyang@gmail.com> References: <20250305004647.21470-1-richard.weiyang@gmail.com> X-Rspamd-Queue-Id: A48E54000C X-Stat-Signature: 3xx5oq4dbubuedhdk4dboxscm51ww9si X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741135709-855625 X-HE-Meta: U2FsdGVkX1/E0nJxdiEqnaDzg3+sQtne6BebI69dCAZ6uvZ6yqhD4gI148Sh6SaxECkAaWX3oooX16ZjCbECJ1PduFqEcCSq+PkzjemDIksU/cnCo1bL5dXXergZpSEsUbB8Q08WvS/LKCUGGxoBourVeeuMr8gE25O3KOVWb2vE0swIhMKaiDf12HWh+775b50ddjTHtVQ4QE5WX/igXV3kcNZsRhawnJO4eSAVtTov5EamgH1SRjHjPtl5zVfc9DTZYP296G/L7HpaIpgA6qZz6ntp4AMqDRhWTNmP3YFn4mbOR/Qo3HJxq86MR1uqYHmAV2OAktTmXhUfY01wASArx2bNEEHpyjTKB2O+he5wXda6lpv3WddwaU4C5phCe4YoHMBn8J73uBs9j1HL5SO2v0p1eZN+P8smTpRB//7r0zTvqdOfKxGvfirhrBacV6/ZoJwEcwHxZQlXL6x6NRrqZzHLMbDGcgXj1TdxZUjSXMfvHrL1ZgUe+SSUdja8V9olb7Tc6pTWGeBy0CNeuoPhGeXBMTJEZiKO1YanfwZunuRf+cFcO10HZD3FWK+/OpI8OAfRi+KC97UsQ0vHMd1jsp0tyj75Dz3SDc1Wc9x74ToFJC/GmteXXs/879YvZtMYLD2DH31WuwrB2hzJfNdnAK192zg3EcT9uFRpdDawjzQwBcRWZG8BV1RH4HJO2F/oV9HiTpmqmM2uU6aF95szs5rp2V8XYP5w2uxYP1tXB8vpEIXPwe9Hz/AqsTWGkgKj29A2Ubna0BmIaPw+4yDlu2o0Ny63tZ/Rbs7it250lnO1Ow5p+9ocwoAUFOd1C3K2INNcZryN3JTtVMIRGTTACrQoB+SH8fX4LCRrz/jh+yHlwwDSD3ov2RjK9LOM6hV1HW/nWP8AhTrf1Qby0NBTvCteNHgBOsJiZAV7wNDNQz6hic9XY2Xv1TDUez+iL4GSjSHMDJGHevFw2gk 0HIB0abm /XO59Dvn5cpPrN/w6Yk1twCCPM6ow3Hu0XGD4x5DEUCZre6iT4ZTSwjBfmUgtEc0p1zvJSXfkT7KBYFs2bFHqE0Sh1dsW91XipuOQaEO80BB/PCxQbMIHkzKz8a3edwJfdCeliWON6edeYrF5ZNXTyUBT0cJkXz4tB7jpNMBw8w4x9imZLPF5T/fZ1i4FFFI1OlBKaJ+xWtfU18N//4EIVImcOrSOUfDInzJUVzvM7ONo5/9Q9Q6Z9dEQOl/dd6P/CMVX2+Ap9QjowrKxnpBtTUVPhzWhKoFZ/EFcru9eCHQhzFPP6F5HqzrvwA49jES3DVxcAWyuoYo5TVg/tygr3heJu4js4yiYBGzOPR1yDEoUSLGhNKz1deywwvWocDaZby9LAGgkkE0qjgqVcCNUGjiwLD3pV7AcbXZcYpjI5quAzpPxmCnhBMgbo58eQKHk4MGhjCR+io3qQNqJi27VOzV7/oi25SYG6kqkIUOrrabfmECCSBMCjfGd1UuI8WvUfj7JVVE3gQolGW2L160UCk77qragwhzIwuM5jFKu2+tWCG7ABeHoEx8hvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Original code may not get the new value after overwriting the whole range on a maple tree containing just a leaf node. The reason is we didn't set the only root node dead during destroy. Add a test case to ensure the new value is returned when overwriting a tree containing just a leaf node. Signed-off-by: Wei Yang CC: Liam R. Howlett --- v2: adjust the changelog according to Liam's suggestion --- tools/testing/radix-tree/maple.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c index bc30050227fd..1e293e4d856d 100644 --- a/tools/testing/radix-tree/maple.c +++ b/tools/testing/radix-tree/maple.c @@ -35256,6 +35256,30 @@ static noinline void __init check_rcu_simulated(struct maple_tree *mt) MT_BUG_ON(mt, mas_prev(&mas_reader, 0) != xa_mk_value(val)); rcu_read_unlock(); + /* Clear out tree & create one with only root node */ + mas_lock(&mas_writer); + mas_set_range(&mas_writer, 0, ULONG_MAX); + mas_store_gfp(&mas_writer, NULL, GFP_KERNEL); + mas_set_range(&mas_writer, 0, 0); + for (i = 0; i <= 5; i++) { + mas_writer.index = i * 10; + mas_writer.last = i * 10 + 5; + mas_store_gfp(&mas_writer, xa_mk_value(i), GFP_KERNEL); + } + mas_unlock(&mas_writer); + target = 10; + mas_set_range(&mas_reader, target, target); + rcu_read_lock(); + MT_BUG_ON(mt, mas_walk(&mas_reader) != xa_mk_value(target/10)); + + /* Overwrite the whole range */ + mas_lock(&mas_writer); + mas_set_range(&mas_writer, 0, ULONG_MAX); + mas_store_gfp(&mas_writer, xa_mk_value(val), GFP_KERNEL); + mas_unlock(&mas_writer); + MT_BUG_ON(mt, mas_walk(&mas_reader) != xa_mk_value(val)); + rcu_read_unlock(); + rcu_unregister_thread(); } -- 2.34.1