From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78CFAC021B8 for ; Wed, 5 Mar 2025 00:48:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9CC6280001; Tue, 4 Mar 2025 19:48:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BFB426B0089; Tue, 4 Mar 2025 19:48:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FFFD280001; Tue, 4 Mar 2025 19:48:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 765B56B0085 for ; Tue, 4 Mar 2025 19:48:29 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1B29851D1A for ; Wed, 5 Mar 2025 00:48:29 +0000 (UTC) X-FDA: 83185661538.18.7808D3C Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf20.hostedemail.com (Postfix) with ESMTP id 3D2BA1C0002 for ; Wed, 5 Mar 2025 00:48:27 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PyW/07+A"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741135707; a=rsa-sha256; cv=none; b=fzQ+Kdc37QZxftBoIwpfz4O5ZboorUQO8CO/ZCeo9vQy3W5WysG7UDR5GwzerLipRrMrqQ b2z0KtZajO1LA+TkZu4Q9XR+NScGAzWkgPUKq56vG8yugex0wqy98kDuqsI1fMQulShnJM jQu716b0dIj5U5w1LK+Mq7FmNH5+Pqo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PyW/07+A"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741135707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=RBLmvV7Q4wPiI+MEo68mMCleA6GCDfzaBhVQhk2842M=; b=aMKAGtW+mocl+QaCvMG7nplrK15Q/hTA24PNgKNValZ6PqNr76hNy7yJsp+gRHhtmbwFH+ Zm2hRK2STvelBpVWXtPoGllGJ2U34ZiimEoHFA5+VGifKO4jnDwsdn01aJHqHACLjkP8u3 lWz/aFBx3vZug+vZmHJhUHhsFvk6xHU= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-aaeec07b705so957966066b.2 for ; Tue, 04 Mar 2025 16:48:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741135706; x=1741740506; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=RBLmvV7Q4wPiI+MEo68mMCleA6GCDfzaBhVQhk2842M=; b=PyW/07+AGdC+SlZ4OdwCAReI3v/GHwNd+kjnBYkTSTyS+36o+Bd6ehc8SZW3Mqamby uU5AvoiHERZA+ooqQY1GUS5RRoPYKVQKugRSUMFUFq9fkHF5sGrVX6q4/auJ6URDqLAh y2A516ueTukjdodRfrTB/LDrOiMtgF/qi+I7Ndm43zJN5VxZx/Yv6sP+FyOu4baGiXC/ MNRMLtVDeeGOrymCYLH7K7Ow6EfsaH/huflxml93bjyH4gLDIdXKlA/iF1k+1IETPp6D 4v4QOnz6nE6dEviRIzYfVCH2TVPaLEElxmJ8EHnJYMdQb3N+86pWjuowinW8yVI8Ccct SOZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741135706; x=1741740506; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RBLmvV7Q4wPiI+MEo68mMCleA6GCDfzaBhVQhk2842M=; b=XYw1AIIHqtNCVpv5Bv4RKjYV1/3/3LX3Yh9BkScpWtIt+1G8hcN3FAfgDHRSjTsUvH iVUO8ntDCF+FBrX9bPiAlCb2Xe4k+6SNAZjUYfh80O7McCDURxPJJ/YhX7xCEUJUpa+A ZOBEzFQBhYF8ATsx+wEpoa2KFTTNYwXpFOr9VQ/vNn6xo2/jzuzRPvxc/4sQedywv1W2 0iLABy32SzcJU8MX97YmYhtFCsgpsSgapJ0z7Zhhez2/4Nv6YVkY/1ArKDb3t7oqEcxm LjMik8UcVlqradjumF5GqNYBP5n9jf0/6y8BrRKxdYKkR2+6SN+r3NaNU8eO+jvdZFAa dKXw== X-Forwarded-Encrypted: i=1; AJvYcCVVgbvhU93JDmWm5Z/FcXxv08yN2q3NnIt4iLgv8GfjEyuY61hKGsVlqGwekrjeiI/XAhwptHFkvw==@kvack.org X-Gm-Message-State: AOJu0Yw0COI/QwmTsO3EkI4SVbD6qp10l9z5KlQVt2AGKLnfRBp+lOcf nI1fcRU3IQrpg2+H8raMX2xKDhb+7EnTx2DPp6E/7NsWY6WRSRfL X-Gm-Gg: ASbGnctLh/BZ42IqmvU+zTV7v+SHDpfFrZHP0lZ5ZcHrfINrTld1L5P0Z0Ynze3gQr0 wZ83KbxTcMnbmOmEmG6mcJghqLF15cLyG0Zkx1iu7WgWwDXfbN05pGp9ccB2ygZfWhaGwQjYzGU JFET4PHWlf/OT18MO7PL3SXLLbTa1Eb+Gh4QCcRq3rTVq0eGDSNeUgf2d6WvvNhMXW2IDn2vx5p EY1/oM+4JbPm2JtitZ7ivbgM2t41RFqhsFaimS1Zs2GCGSNG6JgVM52p0ZSXOZrvC9wzyBcHiBV ggNT4Q5/jh89zbLd/uA9T5kirEq89QYNEaeomORA/gAc X-Google-Smtp-Source: AGHT+IH7JduumBC54MsqAZwaR/YjmJeCZFd8YNGuXmtmsN0Q1iOjlUkgz58LK8J++G6AvfBKf6Wqow== X-Received: by 2002:a17:907:944d:b0:abf:7b59:6e6e with SMTP id a640c23a62f3a-ac20d02d7admr136834366b.0.1741135705610; Tue, 04 Mar 2025 16:48:25 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf58fe64f5sm647903866b.133.2025.03.04.16.48.24 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Mar 2025 16:48:25 -0800 (PST) From: Wei Yang To: akpm@linux-foundation.org, Liam.Howlett@oracle.com Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, Wei Yang , "Liam R . Howlett" , stable@vger.kernel.org Subject: [Patch v2 2/3] maple_tree: restart walk on correct status Date: Wed, 5 Mar 2025 00:46:46 +0000 Message-Id: <20250305004647.21470-3-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20250305004647.21470-1-richard.weiyang@gmail.com> References: <20250305004647.21470-1-richard.weiyang@gmail.com> X-Rspamd-Queue-Id: 3D2BA1C0002 X-Stat-Signature: 7zrczswnyst5t9515u1mfsu4hkxtdss8 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741135707-61268 X-HE-Meta: U2FsdGVkX1/L+UOZ8EB5I2o893TJ3gmOUZwfYGgySbdtGacXYhJiilW6JS658/Ei5mRNM7eiZ2ccgXx98S/mvEeB+dLEuTH9plLYp0yMtdhT6KZE7vezeuk54+hol0VjjjVTTJhH21ThfanXnGhStw5z0y4+AdaqXViyLzOPvOWrZGUeLvB02GSsJ4pu7ZPFQKur3RyJx+8v7jATMYI5naV1bxXtW9nz471ldWZDmz+yDWyd6UOmokArLSlTvMLrI3GH/GaQHyr9dCw0x9v+rOZabXsulf4ieOV8GhIMwAm0OBwrq62TfmQvpfpPierlxY/XrEEP45ofUP7ROjRKT0afdUwql3qp1P960MPKKVEKr8VV4E/p8SYM1tEM+l3QlLDGLoRav6jI2UWHuyH2Ne2iXEplc4C15vvC/6/aanGTZEg0KxqCbMNM+DyFKCv/n2aKWlz9dU86Uh//BsmytQ9LJ9y6roqJqQtndMLwiGkPngNiuqprEzaq13Zbs7FCaGcrhU+FEPCoqejWTxy6P2w4VWAh/UyntEDkWxZuej/tqS4f9n/At+AL3ofsi0PJSkw1awXzYCZgmTd2xYwu89/EV14ih6QhgtXrnd/j6cT3Mx/p19cvmiTO5tb6Ms1NwpaivZvEJT/H/mxB/v2GrkQql4iT4UfE3BRBYIjHWI+4gIgzhDv7TWtBU88osEn1nRAuy9VwChYDRl8juk48JX31MNI/RyERSHFli0CjVZZ9TsFYUb+Q4ZZO+IRzwvKqfggQ70g+0kR1JzBDSiIJL0z2WEzJ+mFUatAVr/jMHteUWXNzMUA6diIXHho+YNpfDNArwxNX1mvaSK6HM4IEo8UWhQ7ZZxWIonWgjmBxiYcBqnOJGg9kSha8RyMIAAHMbgOvqIOwm+b9cPq7fWsf2u3K6RzaWtmJmYEW0//bSMAdJz1v8fJyC0WRRllyMwjb7B3Y5eMQw3P6sKyi/io LwQ0g2lm C3X7NxjJQ1V/GsfhYGgTR8x4HIQd/anBRupSB+3aGk1iEcreen0sRnJa4U61IUgSRC0hmP5Q7g/9ucdNXqzSpC4ssEtX91XCgx0UntFuoJcrFmXtudSBE6IL4X4qmOeVTbYnMEnPsXHMihHl8CpOseRAFpSJS7K9pX7Jlcg90QRIhOfj8lJvFyp4Tl9p+UmJbqsBXgzGGZbKXOLx6JinmV8OuSantm60dmnwjFTeblI7KtVbX8GtMCdLpueylPZHuDOYG78TaaX3maSo9yiAnxtm4J45U6/8GWgb9X2/vJq4iekQ3AJ+W+babBNhf6glhXLJPCewLsyAbqCceGFsePh7S8q1K1WNLXfWzsiGnbvhKVUNEYc5wlcBmczNq2OiTxBlFLzRQpwR/SgQVu6FVhZVvvPOLdpZNw6cLc0L8/GHqQqWbwbpV0Zqy2mYV+uUVSLcWg8POZa8JwWTUZzoV3jDe1T0b1PBcDeR3LugnkpIKttCddupotq86c7m/0OVvrajoIqFVMU9PgT0Ti+b467opdp4xrSwXGfYgtd2UZPHmfuj8QtdstDlREgGi3UZhliCn5Ok0wM9nFVQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Commit a8091f039c1e ("maple_tree: add MAS_UNDERFLOW and MAS_OVERFLOW states") adds more status during maple tree walk. But it introduce a typo on the status check during walk. It expects to mean neither active nor start, we would restart the walk, while current code means we would always restart the walk. Fixes: a8091f039c1e ("maple_tree: add MAS_UNDERFLOW and MAS_OVERFLOW states") Signed-off-by: Wei Yang CC: Liam R. Howlett CC: Reviewed-by: Liam R. Howlett --- lib/maple_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index 0696e8d1c4e9..81970b3a6af7 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -4895,7 +4895,7 @@ void *mas_walk(struct ma_state *mas) { void *entry; - if (!mas_is_active(mas) || !mas_is_start(mas)) + if (!mas_is_active(mas) && !mas_is_start(mas)) mas->status = ma_start; retry: entry = mas_state_walk(mas); -- 2.34.1