From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68614C021B8 for ; Wed, 5 Mar 2025 00:48:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAD9D6B0082; Tue, 4 Mar 2025 19:48:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5D786B0083; Tue, 4 Mar 2025 19:48:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A25DC6B0085; Tue, 4 Mar 2025 19:48:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 83F7B6B0082 for ; Tue, 4 Mar 2025 19:48:27 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0ABA6A4989 for ; Wed, 5 Mar 2025 00:48:27 +0000 (UTC) X-FDA: 83185661454.23.AEEF0A3 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf18.hostedemail.com (Postfix) with ESMTP id 4ACFE1C000A for ; Wed, 5 Mar 2025 00:48:25 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dBPqEv+Y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741135705; a=rsa-sha256; cv=none; b=GHwEN9tejQu6VVvA2Ne+SxcGROXenkc+P04s/GfKsxW4UwCVdKeWAw77yUD5mJv2MwsgwY nF2riexRMMPwYfsfkmti4AGt85dMdC1DYPx7qDi2BUtOBlyhz62EfJ4t+3L7TZr32NPg9x kEwMztlROyJx9AWNB9h3cIKBQZsQuyI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dBPqEv+Y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741135705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=iwVSTTQToz1Si8xB4Dm4R1UDLYWcbQsamHW0cZfFfXw=; b=mU6Al+/jfvQ4OTx7yLTDoij8lG7G88KOaTOj6t0+Tk1CiKQ8LlTWG7Cz9w5iSYOJnJPrQb dTYobQm16pF+eGpfPy29HstUYFQOKyzuSCxO6aI9wUSBwQFOxbTCaE/7bffN+iv6wx8jLG M5gQzfG4Ianbh1GiFXjB69MjzWV9jtY= Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-abf57138cfaso686345966b.1 for ; Tue, 04 Mar 2025 16:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741135704; x=1741740504; darn=kvack.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iwVSTTQToz1Si8xB4Dm4R1UDLYWcbQsamHW0cZfFfXw=; b=dBPqEv+YQlkwmMvYlsq4NnTFclb1r9BSnyoPiFdTNcMfSr4o0vLwmbVJYIgWqRAQTH AgKoMG13NLZ4eNlAsQP8oQzNctjcjjgrdGnH1A3LXzhimvXUJFonVJpmC7oBaSQuR5Fc nsaNj69SS9v/pYGF322WPOXEL/48wkPDHFXUYkM+KkdGpM8GP+dcCM26/INsHdp6bwfb S/8mXrf/NaldRtFUe6gJw46K5zI8wzKuKKH6R1MG13QXKeXW9sub25Ic2J6wpi/bd9H2 isrgccevPo9oYYe864hgerBLa33/s5O+S1wjVHChMf80E0sF/G6TvN7T9seofBqvJOuO RhmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741135704; x=1741740504; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iwVSTTQToz1Si8xB4Dm4R1UDLYWcbQsamHW0cZfFfXw=; b=Y3Fo/bNUgKSGyF6vIyDKQcEY7ftHZOcYZ09y8cbW110/3BcvyxgF7PwJOLnThpCK7W V0mv+RAZPOwplCo9xP9/6NlzKsIqKzNr74Z0DmYVnv0MCiy/M3A8K70FQpyLlSOh3ijv hZBvURv+fH4fGlBuOOvF7KFri+Io4tCZvVewyZ+vbe0C0DyCAjIaLcNWctrNG/vSmbKg uSMrMeGjqDe01sA9cj94l5pacOg9WsETPUN8ZYlxjoycO76pUU+J6pW8COjLFwhMt4xl obgveiMEapJmjCsGdIeiU5LyL86R25YS9rMWpUmbicS1kk8MLVYNEJvM5KnO4XUyzg+O /5bA== X-Forwarded-Encrypted: i=1; AJvYcCUKRB81Sz1rMx28+8k/8kWlqemh8Ez0Z8xOq1D/IXyDGwurS9da+ibOBG6VzhhpJmtnyb4YGuKoGg==@kvack.org X-Gm-Message-State: AOJu0YzlzevAf5xEp37q/0MMhF1r5bkIFBM8JN3SYfNmK/TN2iVKLiFf bCrc5MRQtI+RTTuCwsK1DHlQAGUfx1UGJ2F65uOzmOPACTtxwqZk X-Gm-Gg: ASbGncsZyCwVpuIXHB1VpT0cG/IjDXLuu4/F+RywnO50ngqpYxrMci+/nlyHmarNOky 6x+PSZjvIJG8nXms8pytipRmCV/rl3SGPDu0T19Ll+iMDouzKxr4WW57+UaAfwv916LZxOP2PKq BuDu4+sLGD3geFWswnXO+L/5tMPXcK7APy6XPhtV95JgIARb4Cr2Izge4fjG8b+UWu7JEMFqr90 u2J06N9sYc0olnMMbPvF/jl5Mu4Fz7V57+L1U0NfG59cLtEJpBaLTzg1+jzpfxftDEt/g8aw7IE CvNL7R4TA7N4HN8/LtvnNFhiKQ34e7+oOSHEEVlg9TxE X-Google-Smtp-Source: AGHT+IFJkPWWOKXFNOhIy8+f6Le3jVJqCdnmUUrk+M36qG9zgVR6rMAdp54jw5qdWgPqEiHP+nzReA== X-Received: by 2002:a17:906:c103:b0:abf:6c2d:f469 with SMTP id a640c23a62f3a-ac20dac4979mr118524466b.20.1741135703395; Tue, 04 Mar 2025 16:48:23 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac20381299asm108465066b.46.2025.03.04.16.48.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Mar 2025 16:48:23 -0800 (PST) From: Wei Yang To: akpm@linux-foundation.org, Liam.Howlett@oracle.com Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, Wei Yang Subject: [Patch v2 0/3] maple_tree: Fix the replacement of a root leaf node Date: Wed, 5 Mar 2025 00:46:44 +0000 Message-Id: <20250305004647.21470-1-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 X-Rspamd-Queue-Id: 4ACFE1C000A X-Stat-Signature: sgd8imr9amppnjrc6ghherfuyjzdzoqr X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741135705-109822 X-HE-Meta: U2FsdGVkX1+W1X8iLIeMjDay5aazn0G3YpCQ5i7F5JvaqR4t4Ya9AjascBA9wSwi5qVGpf5hddk37ztV53rCT8mjanZKX1tzb7D038kf6BNDao57byIcYgT8oHBlaioXGkwNSJODTruKRxR6jCh8rqkrc2g4aMNj6woaakBAfXJivp8OMrxcNn2yfiDRe4u6/+tmM4Ge+jk93rf2qTYt1psS9GGndvvzRnsWUrm7Kg3l0+5Bz5bHV3MLC7Ya5K3yrWHM0tngtbI8iaOXKpARVDfGLMc8kbnMUSpj6eF7Qm+8WZbSu9Gg/X7tZzAlV0ISgw1OYDoMCpqxYXaeZ4CUBxZ+KThYK8yN97OV8OBSD3SrdlBlf9mQZvJd9lX4zF08w9ZI2PX7DI3Ag0yvTP1q8dOpsOt+uMObGVnDxOGYwxbZtEqScidNxx4C+lc1jIltbOOl/AbAyvjKYZC5pvsvDPPeSWwwwnbnqSSTmJp6ngAofMgvGJYlItocUYDwAD6BjR3bD+qOWm/uqCfU8S74aCcr+Fp/vL2TD5r1K8o+oh9TGGomK2iA1YOiMTMYUP4i1dVTcZnsWVgIe56BtTRO61XD1sSEwh3oLAY4EwgCfOAnYVwKftpB+jv9yAS4MoxEhkyHVXS2TSuXccGqDBIilzwAnpnYTFIU/NlaSMtWTw3FU1LbbB4Aku29N/vzj4a/I1J7SImcWr5T0c3Oi/Yx8fkARLisHdYz3A0qx04DnHSWkFuiwS8/9Y/aJRwYq/UT4OuBngkTFcRroadLXG4fkRYQtReP+UR30+FmGFFfp6L8GyL8+HUHNE4g8BfMMD3jomYad6rf+jOVwwww4t2WJzUUidmNxXnEQyje1nCQSl/LVjvI4uxQxKg4K9XvmfFRjjj8FQJvHZwtgMl3UOlrSdgIn/v/kG7qlyog7kufaLbRdUAGBEo6rWyrZdTMSvxQuIhTskt01K74/ZWEXWf 2JztcYPY UfPRFtZA/lvDxEiE5d/qra9KxrLd8Y2Yj9ddbjaryOrf2FsZhgAkLjtxlK/dAJacas8Wy0jzbTD1ww2T+XvrUDMBBg1QAFUI94GPxt3SFgMoTZgNBwlh6NZabkV0OwlyOC2KQWcBplyte/6ZBXjKmyvk4dwdu2RXN9EhGFKxc6MARCMW17xz778vfkdf4AHkoNk7t4KRHbo34fRkv5kutZSS5+72nDPgIyShLBEJeb+6aRPMjqasZFZaQbK1IgLBdJoBSQE6d2Ltdqg9wWr7Y0YGTY+uQCrjm23x14UVJclbyWA08DIe5bTvhWcBF09dCwbd1VNYA+LiMtw0HWTRnaxb65CFHyL2WMouRYo0YGEvbwUqwbrh0dLKDBAOVph+GEN4mJuRbV48TqE8mZUhltfAaSLsOT+1EOlFZ7Pq+nUJkDDbFdZG3h1YuXCGeS0n+aYgDGKvdH6Kmw8wIP/BvYTRNn1R4yd4j6/fT+07ab+lxidc2czYk2ulEppL1kdGStAMW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000040, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On destroy we should set each node dead. But current code miss this when the maple tree has only the root node. The reason is mt_destroy_walk() leverage mte_destroy_descend() to set node dead, but this is skipped since the only root node is a leaf. Patch 1 fixes this. When adding a test case, I found we always get the new value even we leave the old root node not dead. It turns out we always re-walk the tree in mas_walk(). It looks like a typo on the status check of mas_walk(). Patch 2 fixes this. Patch 3 add a test case to assert retrieving new value when overwriting the whole range to a tree with only root node. Wei Yang (3): maple_tree: Fix mt_destroy_walk() on root leaf node maple_tree: restart walk on correct status maple_tree: assert retrieving new value on a tree containing just a leaf node lib/maple_tree.c | 3 ++- tools/testing/radix-tree/maple.c | 24 ++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) -- 2.34.1