From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB36C021B8 for ; Wed, 5 Mar 2025 00:32:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF24B6B0082; Tue, 4 Mar 2025 19:32:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7B4D6B0083; Tue, 4 Mar 2025 19:32:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1C0E6B0085; Tue, 4 Mar 2025 19:32:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A41426B0082 for ; Tue, 4 Mar 2025 19:32:53 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F23F1120794 for ; Wed, 5 Mar 2025 00:32:52 +0000 (UTC) X-FDA: 83185622184.30.D6E5C2A Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf27.hostedemail.com (Postfix) with ESMTP id ED50D4000F for ; Wed, 5 Mar 2025 00:32:50 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=H2FVigk6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741134771; a=rsa-sha256; cv=none; b=1w7gi6dHwb0CSKM3pJu2Z31EED8A1oD01r5KbY6130s0GSf3chi6OmNBh/gcbEMPWUJZsy QFeFDNpBaQkCOAPxRFQMrN+lzWSPFCJhayyM7HI5FjM39MRS7B28UaBNTt7/Z5rNFMw6t9 1aOX0SUvU+H/ybbBQFo2wBAKPsN121g= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=H2FVigk6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741134771; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KoutY/ehakvl+zXkIfmku6JzKS6Q3qVapxIXWpx0xHU=; b=DE+YP5aauNPbOKropxoQP8Tj9CA3BR2jakI4X1ZpYRFkZdcujrAlWsxfH56F6TUimfLr12 5isSoxcm5jlUTzZnl+Nx7j0keeRgn1Dq2eRKYTjaITorQswdKp6E9wQ2EI27UxLou9SYKa o/z9PeLtoHTU/0F+oHAyVI1MH6DCadM= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-abf3d64849dso589731666b.3 for ; Tue, 04 Mar 2025 16:32:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741134769; x=1741739569; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=KoutY/ehakvl+zXkIfmku6JzKS6Q3qVapxIXWpx0xHU=; b=H2FVigk6YKtgTIqug5dQEUrRutPF/X7jh6CxDH9NFWI6y0rBrHD+vQyPYviGDVlPDG ikLDDorZqonSLltTvN7JLCzfREvbfyokefI3ZZ+BnD/49r1sn4TbzToCTkXdruWzg2W1 K3WEuLmYRMUNZrtOkb2lmv+vdaNZOz+K0eefxlPsDS1Fb4KfzlB9J/JFjH2tcktuwi9k pT6ZwFfUE9L3Mn7uJyMlKMx3Qgo+lSn9lcQ3VECn9bqha0PiSfmRTbWfM7Nh5iXpgDJ8 bNjber4pR5Llvv1iGHLQ0suVqYU9POGindrIP1VOXlQX94W4O40bj9PzIrOny8CExsOy qFrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741134769; x=1741739569; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=KoutY/ehakvl+zXkIfmku6JzKS6Q3qVapxIXWpx0xHU=; b=R18DQIh/0mFW5P9oaSCP3f4eOTq1LiP6GDdttKhV0EkEkOKvsENo//60TS3vGpybUd yruCoR8T33s8bHKTqIP3cZ7s93EsKVCaFCFLUkHqyzN075h/kPEQHzZDCpBncqXJZJDB 0ZajA1IrhXcOdTbbmAzYtjGF9skeLRxWBy1z7fOzUaXa91oucuizEH3Y8VlooigDLmni AGtHKPxhoVCIpfk5ON52Pf1qc9yhNHHeJ5bEruPmbFMvHumo12L3KxMwSqaF2ub4HINC h1FMGZF98Bxc7nGonAtXY22nTxKcE5mL3pIIYZhIAr8NJD8lGVwBcgLZZ1kVZKegkYbi WryQ== X-Forwarded-Encrypted: i=1; AJvYcCV9i/AdGr2WkU+7Om50s9RcaRgkqoT8ME5QSAbHSTqb6NdRiGDl5ttcw/5tIhyhZoAiDjVltpAC2A==@kvack.org X-Gm-Message-State: AOJu0YzOCsE8uGP2eik+lynyMEnffhUEyqXUUBQsvs+NQOLFk5e+WiAr /PVePXPm088ioQhvkVEGTOqLVmkW2t1O+0Y2icozW8sF9PE5/7AW X-Gm-Gg: ASbGncvh517mgNaYalgYUfS22c0rGEoeEKxpLmpWXIyqSP++I6JSpRUhRDTzDnuiCum StsVHEX/6s0ZHwF6avQHPa2ptoSfD3hYg6lDSGHk4ARum8aIeu4/y5YyCECDPmdzL3iQwQCQkv+ Qm71ZPElgv7daFAgcXJRdBiO66XD2hR/QvuFqFqPaEN20Fg3MWHdtjJlEGwmvw3XitkPePlO0ee Ns7rt0xWYOo8D2gWH65iolABKfAmr0gRG0F6hD/ofdcBNOdmMEvtsJqPtLlPDLRrs9vxW58P/uC kw49CJHjRbErZpQXF6tYyHDjfac7tCLr6R2hYT66yMP0 X-Google-Smtp-Source: AGHT+IE3jEXRrInyY6ryY/LzQ1Vg26y3Db8R+4k0feMW6yZXf8gMp2GCs3KDO0BNWh7B0WSq8RQ3AQ== X-Received: by 2002:a05:6402:90e:b0:5e0:7510:5787 with SMTP id 4fb4d7f45d1cf-5e59f3f46e7mr2135243a12.19.1741134768916; Tue, 04 Mar 2025 16:32:48 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf772d73f6sm442617266b.113.2025.03.04.16.32.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Mar 2025 16:32:47 -0800 (PST) Date: Wed, 5 Mar 2025 00:32:46 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 0/3] may miss to set node dead on destroy Message-ID: <20250305003246.65372xproszokbqx@master> Reply-To: Wei Yang References: <20250208011852.31434-1-richard.weiyang@gmail.com> <20250211081129.xskl56wm2dir2x2f@master> <20250212005536.6j4shtwswsyaapwm@master> <20250304120746.cas4wwnnn4ih2c5g@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: ED50D4000F X-Stat-Signature: 4mi1sw1ggyd7jck97jmiyw5f3t6bsxzc X-HE-Tag: 1741134770-267351 X-HE-Meta: U2FsdGVkX19EOsvWDrb395vesBN4fyIR6J5AfEqUSOsQYBP93zXqf1SndmZHJc9NL0Q8cpckdCJRnlQdmkuouVW9XVCrGF0cXcXKuqO5U7jyVZgRUFsYs9GXycSIjRNnQBogDSrhplp1vZLAAMVQ+QUT8r9pSO9COSrS12X6kENUk5cAWkAAZf1LyCKWnmE2UTq3MSirkivWr48SVbdnZRlDnqotFLz679fnR2EUlOXQP23TSd9loDjeEAhDzy+obkeubz/pzyxocrziz7QGgbasMORGtLNwackCTSMwCUT6+6Hfs7Sl1tSt3qCKLef69HrIJJAjZNrcaU97ZZEGK4+AiSBtUx3SbM2F527QzeeabL8LQsuK+iwK8xJV3E9lMJ4tVHEew2mEFJoefz1RTJIK96cO0ssYsYYph6DDiAxq/o25W8vG/M4r5pqt9B7d01YmIjfSLc/VHxVVxmfwpaN0g+BiIZGtzV1S5koWwvmYW8Y4JC2FeBPruuISlUUOMdn9+Udq9AAKtxr8DX59ZIQcynteKonudJzZHwUHCau320lUGTnjcDVsWjdM7ol6vNrgHgUXayRsh+8gS6aZ3AXSlreX2OloRwBI/L2TTvbwCeiqA6qTiaR9lqgwSqacl0wM4Ldaz4weD4khdd49RToIsdi1MsvwtATmwhS6bkhimWtofIt/AgkGwROIas/hPFvMKu7j03GWMbRq46NPbdhrLOjDp1BEHBeG2LFqtuOIAbQ3jUsKaZidXJPkHUYqllcP9yVdebs0ldcEddz0HGlcRJm3thz1o/v5U7G8VGrmlQQ7xSUAEUNIODUdoXeArkN2SQuuY2ArBGb1JTuCv3RuM6VeCYnIngBWh7icG7GwhFLYU75WmFB0waF7Xh5zThyQfKsrp8OyGBHwmATru5x/8XX7L9etffaoJCUjKJ4ZIHKnfJ/wLHb2T2U62UhIdcTPP9HB/Ommx7GGlgH 2eHVLlXi RBk8I55Sj9omfqJUgm5Lcdj9qim/DLru+tWbtjzc3zNpJzB58kctYK882RvgT7DWK1ps6h74hWaYHqvMRXbEdUaFLsrsFhSmmg76X9CpYczCPxKi7H7rEqVnQRE8eJ6JO4tQWcJ1MlLLtD15Yc2qDX5r72PL1HFIHiyK45vQb+AqtYLExErbaIQSQDbBD8LfCW9S4qXdTmbyNDzHnBhogc0Mnh2Foq7SXUa0owtt3shVTkS1gsTlj628vKhbEfAzMw+3eHnWyCSQfTvvhecgqtYub5HWhw18EGXAvknSWonnKaypJEbFEd+ElIdJDolSY++eRmt73lTK5jdVWSXhjDvo6yUtyHs80dVk2hERPIHq/sIU4U+/s/0ZBtcnWYKLjdm6XNnzSQZpinphOtszUKeWfYoorQdJNqJG51IFlpmZ5Mk/LKLMrwGAne1XfvDhkCoLLpv4gy4oPnTP+CyDJnBMVYTHmjCeRDKxkgJTmyj8uY5a/N1gPIzXXGYDtUSHB28U53Tk/XPq4uH2ZMNI0wsJMGEYY0vzFBSloxP/Q8tKBcGPytNar8oLLccrZ+VAsIBLR2ZMlHxlnc5ORDUTF2/1XhIwujQir2CCpRPMQcwt7aKrZ6YO6NHugej05znywqqx5lOnga2BjCVu91EKqDieDpx7W1PUpNszVyQFsq/OQsjwOHSmLe2jX/rTZ0KTxTETmGoIZttzK+QRiKeIPIVvEsTPlNCkWYNG3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000046, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 09:45:16AM -0500, Liam R. Howlett wrote: >* Wei Yang [250304 07:07]: >> On Wed, Feb 12, 2025 at 12:55:36AM +0000, Wei Yang wrote: >> >On Tue, Feb 11, 2025 at 10:28:53AM -0500, Liam R. Howlett wrote: >> >>* Wei Yang [250211 03:11]: >> >>> On Mon, Feb 10, 2025 at 09:31:28AM -0500, Liam R. Howlett wrote: >> >>> >* Wei Yang [250207 20:26]: >> >>> > >> >>> >The subject of this patch set makes the issue sound much more sever than >> >>> >it is. It currently sounds like a memory leak or a UAF, which isn't the >> >>> >case. >> >>> > >> >>> >> >>> Not intend to exaggerate the impact. >> >>> >> >>> Is this one would be better? >> >>> >> >>> maple_tree: make sure each node is dead on destroy >> >> >> >>Not really, you are fixing two nodes, one isn't even to do with the >> >>destry/dead node. You are also not making sure each node is dead, but >> >>fixing an issue with the leaf node. >> >> >> >>maple_tree: Fix the replacement of a root leaf node ? >> >> >> > >> >One more question, would it be better to use this as the subject of patch 1? > >You are not fixing the replacement of the root leaf node, you are fixing >the free path of the old root leaf node. > >The fix is in mt_destroy_walk(), I usually try to have the function name >in the first line too.. > >maple_tree: Fix mt_destroy_walk() on root leaf node > Thanks, this is better. > >> > >> >> Liam, >> >> Are you ok with this and can I send a v2? > >Pleas send v2. > > >Thanks, >Liam -- Wei Yang Help you, Help me