From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F00F1C021B8 for ; Tue, 4 Mar 2025 05:31:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DF6E6B0082; Tue, 4 Mar 2025 00:31:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 769276B0083; Tue, 4 Mar 2025 00:31:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6092B6B0085; Tue, 4 Mar 2025 00:31:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 38A7C6B0082 for ; Tue, 4 Mar 2025 00:31:16 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AD422C1525 for ; Tue, 4 Mar 2025 05:31:15 +0000 (UTC) X-FDA: 83182745310.03.08732EE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 0750520008 for ; Tue, 4 Mar 2025 05:31:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=LAqEY2Bm; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741066274; a=rsa-sha256; cv=none; b=8KYWkH1HR4K0DvVV5O7oXw7MSmp9h1QWcUUBmAdUJj/oOt9s2bXLft1SILace2JBGHJJt3 moYOF+thETho6ZeE85O3avV1yuNDK76Ag4UVjctTHH1xeAEo/gevYiUInP9NHKRXZfxhiw TFO19KKX04Msxa8wHIii+bxmE62PY+0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=LAqEY2Bm; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741066274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hLveim3mvq8ylQF5wWSvdNScpKgdanQKHJNeYN5vk40=; b=uHDrm7Cfi2shvZxVvbokf4wPFICrRHAolccTywvJRpCXDM5XSflYU94UorVtVS8RBsCK5w W+FcSdHGJJXy/0Tq4MEQml+8QCmueTPqAkgEg5bAU3P/hv+laXvBXTKfWLRjK9jLm/GWiu 38decZR2IGJI14j+AbSqRTZ80km0rSs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 08D005C4CF9; Tue, 4 Mar 2025 05:28:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 082D6C4CEE5; Tue, 4 Mar 2025 05:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741066272; bh=XOlyYoS+DYZzzpqMtqdefvheJDjjcKhfo/KUx+jL+mk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LAqEY2BmguNwPwzhfQ48ubVXpbewXHohiWkbtc1CivNRjq0lKKTbdjZ2bycuuVsKi NDGnJ6lYzINGjiiQ95PE+ZZXQ8Q8+NNZKXNqiwIBbo1k6cLp0Gp9xyBGHwzBy4DpzF ZPEF3pPw0hOB2zNhjomd98mFvfybgkAx+3RqGAo0= Date: Tue, 4 Mar 2025 06:30:46 +0100 From: Greg KH To: Zi Yan Cc: Liu Shixin , Baolin Wang , linux-mm@kvack.org, Andrew Morton , Barry Song , David Hildenbrand , Kefeng Wang , Lance Yang , Ryan Roberts , Matthew Wilcox , Hugh Dickins , Charan Teja Kalla , linux-kernel@vger.kernel.org, Shivank Garg , stable@vger.kernel.org Subject: Re: [PATCH v2] mm/migrate: fix shmem xarray update during migration Message-ID: <2025030437-posting-barbecue-94af@gregkh> References: <20250228174953.2222831-1-ziy@nvidia.com> <16838F71-3E96-4EFE-BDA1-600C33F75D36@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16838F71-3E96-4EFE-BDA1-600C33F75D36@nvidia.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0750520008 X-Stat-Signature: arwwfq18pg17madqcozt1eegnw5f7gk6 X-Rspam-User: X-HE-Tag: 1741066273-694952 X-HE-Meta: U2FsdGVkX1/mMMrOSTkE4dRxpKJoOBMDy03Dv/WraTEC81lA5dY//ZWncMnWUrALVLbpEp99gzcgeCE2T7lLZmwov2OInz9iAxWqlh2WKnrxk2RuWzQhRG4WrhC9iT2PK4JLCbySDvUDp7RwnU8WFhWOLzIpt6wWc18H70WivR6jqtanVaig9TWikC2q6KJiHwoKx0KrVLYDmdTX+2mB2kgTcBRuAWRLAzeVYjJAsMwMQ2plg/5vE1+AG6LhGMBhAw7+1dsAgM9EXraFc9lCYKoM0/YAjwmSwYYJ8aTEkqNoEVZikzPAQl71gZAnqAp6pf5/4XjYToa6XmZLlQnWlffe8NV/cAmWl6vZDBeS7ZLcCq5U8uZNk9pSqGCt5ejRzqNgb2tBobCts2UQr41jnH5P0b9CGVRAhnsospd1DpuVK5tHRyOeQbuLxbTUSNkwq7UE9H8dk+wB61GW32Y0ZB0esXdEQe+sViM2ibG+NkIPczE2v9a59cTZxslDhxetJZic6XJxvN6EAgTnLPCHUnGxrr1haTp6ZEbMMjG9nTWxkhoYcXB6AY7zMfcCRzfjrq2r38XcPLCKhBl5QDzDmNemLvtMWCUmJss2OD0X5fO1KCsGZs4BtHkOPcBXKj1Z3vu5y6to59KCBnNMzEwRPGaDtbSRE0A7A+MbpNVgfKvp9q057RC6+91/6mgato48y64MBSl1dV6I6heaSIjpNOwf9Gzzome5lirAX3LDNCfyvCoEfzAIfvEYzZib2p8nEF+LaNkYHFUEpLQSepIpdxInga86+2gEbG5yR1N9hYZjwWzp02ZqCr0MgB2C4/NqCli/BHeklbPbyvbks7gYa1obcgpEGFGc6DNnmRHG5hlrjp5wi4YV4z9L8up+9sjAQh8dHrU3/nzDHrUFw1nzRqD36cWx1vUlrBuONtUy8LVlgl7RPcN4w5KdK8I1dhUS8zbTShajJgrE9WOAoq8 PKsoVnpY 5R7TmwjDi9PvBHg7jJvCWoY4u5MXvbcRm7fAVy3Qj1LgY8mHAYp2VU0NEhCiz4TUo3bsWzy216/RlJxPDXcrk4IaanSCaGFMe8HH+HF7o3F1J2KmTDcoWMek8U878TE3MMrZI87mP7kSsxXgM59iFPDgun2KYimfbqGZIeYZU9DUbq1IPcQWS4yloiaxaluexmvf2qg3D4znETXeFMWL1rqI+6hhKV3kH4bLMwVQbr/3+ihLY5TA9CgVPJZYxhkXtIuLsmPxqtIKP8UmoTqecDoKdfbNpeaHoj8DW4IFE0X1O7X9/XGjZgAEoCsNM2du9PlfNKVMoFfqQ2z5aq7ioUv379Q5KXzApEEG+bTS1Z6GzZwLiR0LRNKGkZSFVXOk0tiys0WKENP9mfk0r/SCeGQawAgaYy80voD85CsIqpgTsh6XmSr+8RLSAID6Pp3W8FiEyu9XPgAIYgZckjrMQkCdqrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 03, 2025 at 09:03:04PM -0500, Zi Yan wrote: > On 28 Feb 2025, at 12:49, Zi Yan wrote: > > > Pagecache uses multi-index entries for large folio, so does shmem. Only > > swap cache still stores multiple entries for a single large folio. > > Commit fc346d0a70a1 ("mm: migrate high-order folios in swap cache correctly") > > fixed swap cache but got shmem wrong by storing multiple entries for > > a large shmem folio. Fix it by storing a single entry for a shmem > > folio. > > > > Fixes: fc346d0a70a1 ("mm: migrate high-order folios in swap cache correctly") > > Reported-by: Liu Shixin > > Closes: https://lore.kernel.org/all/28546fb4-5210-bf75-16d6-43e1f8646080@huawei.com/ > > Signed-off-by: Zi Yan > > Reviewed-by: Shivank Garg > > +Cc:stable > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.