From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 814E6C282D3 for ; Tue, 4 Mar 2025 21:19:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 991F36B009B; Tue, 4 Mar 2025 16:19:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 91D786B009C; Tue, 4 Mar 2025 16:19:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76D5D6B009D; Tue, 4 Mar 2025 16:19:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 486086B009B for ; Tue, 4 Mar 2025 16:19:28 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 67D39120659 for ; Tue, 4 Mar 2025 21:19:27 +0000 (UTC) X-FDA: 83185134774.09.9E8F077 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf22.hostedemail.com (Postfix) with ESMTP id CE151C0008 for ; Tue, 4 Mar 2025 21:19:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LrMKwWWt; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741123165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ylyB9J6hrsU051b7/cM5qneftJlzZ+SDbUBvnFqczoo=; b=GaZw/LLBNy4MJ1CYXeSk/brvV6JmGxzE+TvFcoBnYEJ0pWCEFbqydgE8aUxJ3N/r8kVAQB 8w8Wh5Sw02zFSlWrh0HpnpkSMu1CejsfWDqyQz/roBhd7TH8q3q/ZsfBJ9EP3gMWSUzfDp nNVlFzPEcjnziE21Id61h85WpWXv6KM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741123165; a=rsa-sha256; cv=none; b=EP1gCIyE/PHmF6nBfj97SMYTf7Gg0jzJKMKN8yEuJYxRqKbTfq6WZ57O4MxHnvDQrLTJU0 Xr2v2v76mJ25+rvGF4xbGMKBB+qndzIaSiy3LTeYlBnYusln3xbb+JvZDP1DP3A0WeZj04 xbnB/vwW4h4ph94m5L2JhPx3kkD5GKQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LrMKwWWt; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 5B6F0A45FAE; Tue, 4 Mar 2025 21:13:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9E89C4CEE5; Tue, 4 Mar 2025 21:19:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741123164; bh=JHR8X09g7RbF+z7f4pVptzblJHocAhQ0MhsGQMkHws4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LrMKwWWtHJlk8IRwUXYWPpsrLjun2KZA81/oqEUwWUUFCof6U744AYZB9SGWuivag 376YD7Tlak5+1Q7fwe46b96rtbc2VvxWQmyoiLR32HL4TFFCDWryQF5AIKv2VuA+pM XKu60rm8ooVyLivi4UUZ4POoBTrrq5GieMUbIYHwPo+Z9r3hdhvw1o6rUNVuvHa09D FLMvuZ/roJSe7NvrO6lz49C0cIjtTIpy7pC21p4gRSnCFVe4/U9aU6Ot+pOLNEehae 44lsSYbTonQDfKJu5fj7ytc4/e3H5qhRmK1DxRSLKfBwdVsHRCCQNBJsp85Y/ruJDY HMtdyIgNxgltw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 7/9] mm/damon/core: set damos_filter default allowance behavior based on installed filters Date: Tue, 4 Mar 2025 13:19:11 -0800 Message-Id: <20250304211913.53574-8-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250304211913.53574-1-sj@kernel.org> References: <20250304211913.53574-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CE151C0008 X-Stat-Signature: wsaicgerx4chu5zrypyzdxfoqucm5ktn X-HE-Tag: 1741123165-479725 X-HE-Meta: U2FsdGVkX1+VV6IhAqztVsvQNZw6pl7Qt6RLZ1SVfjri2tUTuf/bgz4aY0NBbEBnISRBMUXNynrtjgB4b6VQISFf5fR/QtT1RbPYv67Qd+/ESJ4IP4sFOxV9Tro5lwndfneo7JoTvQMeSlwTP9tuerlTbNcELWckW2g5X9HdNEaKAdY/BMQL/LdUKZ6AHSQQ7XZpcZiWZ4L7cX7m/lzajvAJIfNRKLs1wXjXBtCPA4b5WiUilH+6DCxrHMWP7rA6+PgzLu7qi1w2LEN8FGgVvmk6pj18Ihft43hkvCxNQqnMtZRhvZDEfPsOklMGwZ6oHEsSXcrU8wuWSSD08wtw5qKlSLuwNEQK5mQYs34j8XpaVlkppLjbUaNOwh1vTMcVvXB1x8EU8i6POG4nPKPt3dkJ79AsJ0Pc8wikGr+YwexJPPNyUMVK3hkr7G4Fuik5ZE7mCGx55+kwlvGQHmGyIOdP7wrT4kGKW6FiMq+9k0IytLmjWnNZn5v+NaDTaWZ1LFEsANeMM7j6HVoKdjESBKTPGT/CBzXxCDtAKFhYmzoNl1JqOTG//qKIGhWHFW4UIRt+4VnsBwk/dtMwlJ3KkOeZTh+p+SGSouxVL3/PK9XUjr/B3wpR7xgVpFZ7cG6sr5RKf0vxLHHUd8JZxNfNfCpnXgG5R9plxXwEf1K89zD/+I1+uM5OabkQojTAyUdQYjKmGQLQ+25en0/rSkN6d+DAYS3HghCzZee79TJlWsotPF7uAAvNL3Q5CUfxJqg2bBLCjrbu4Ovh9ODqMF9O8GHDbB0ymaqJMY4uUcR/UlgPaTyIo8jUO88YEyNipanqEM5fzYwn5vuPb24HAPivAuqJtt37wM6/sS/ZRIONYC5yohLrhHU052GlSaZhCRdwgHaM0yYEUo9gefILWa1QK9+Z/0a/e+YSUkjStae59cqJrvJf9nfGpiaJrVYM/4JxUtvhXzGGLZEjG1kPMxx yjeTibeN GqDwk4BtJaeiBpPcbfDPwQQFWtZN/1Kk88PtNc8I9Gv9DeG4IDahU4KFE3Ga+diwcY6M/7l2mnuhsUtdlrZiNhU4bpuyXbsGiS0t/MivuLA1YVFJdhifHN0V2gRq2QQ8rhoOF5zBLradOQ/t9y3w4QTAWghfafQJVV3nlVZSBc2TYA9PwoW7ACwiQMTVqAezrd3C6eqewQpezC1MgYyCwvMljK1cdpIg8rdeKSEm4aijnvcLKW0pc4bEcKg7ogF6VmnJaG+M/onRKkYPlSgbQOQsjWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Decide whether to allow or reject by default on core and opertions layer handled filters evaluation stages. It is decided as the opposite of the last installed filter's behavior. If there is no filter at all, allow by default. If there is any operations layer handled filters, core layer's filtering stage sets allowing as the default behavior regardless of the last filter of core layer-handling ones, since the last filter of core layer handled filters in the case is not really the last filter of the entire filtering stage. Also, make the core layer's DAMOS filters handling stage uses the newly set behavior field. Signed-off-by: SeongJae Park --- mm/damon/core.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 3fbc31d17239..194550e033b1 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -891,6 +891,32 @@ static int damos_commit_ops_filters(struct damos *dst, struct damos *src) return 0; } +/** + * damos_filters_default_reject() - decide whether to reject memory that didn't + * match with any given filter. + * @filters: Given DAMOS filters of a group. + */ +static bool damos_filters_default_reject(struct list_head *filters) +{ + struct damos_filter *last_filter; + + if (list_empty(filters)) + return false; + last_filter = list_last_entry(filters, struct damos_filter, list); + return last_filter->allow; +} + +static void damos_set_filters_default_reject(struct damos *s) +{ + if (!list_empty(&s->ops_filters)) + s->core_filters_default_reject = false; + else + s->core_filters_default_reject = + damos_filters_default_reject(&s->filters); + s->ops_filters_default_reject = + damos_filters_default_reject(&s->ops_filters); +} + static int damos_commit_filters(struct damos *dst, struct damos *src) { int err; @@ -898,7 +924,11 @@ static int damos_commit_filters(struct damos *dst, struct damos *src) err = damos_commit_core_filters(dst, src); if (err) return err; - return damos_commit_ops_filters(dst, src); + err = damos_commit_ops_filters(dst, src); + if (err) + return err; + damos_set_filters_default_reject(dst); + return 0; } static struct damos *damon_nth_scheme(int n, struct damon_ctx *ctx) @@ -1580,7 +1610,7 @@ static bool damos_filter_out(struct damon_ctx *ctx, struct damon_target *t, return !filter->allow; } } - return false; + return s->core_filters_default_reject; } /* -- 2.39.5