From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A73DBC021B8 for ; Tue, 4 Mar 2025 16:15:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E94566B007B; Tue, 4 Mar 2025 11:15:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1D696B0082; Tue, 4 Mar 2025 11:15:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C976C6B0085; Tue, 4 Mar 2025 11:15:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AB8FF6B007B for ; Tue, 4 Mar 2025 11:15:14 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4AD86A2A79 for ; Tue, 4 Mar 2025 16:15:14 +0000 (UTC) X-FDA: 83184368148.08.92DA526 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf02.hostedemail.com (Postfix) with ESMTP id 393138002C for ; Tue, 4 Mar 2025 16:15:12 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=loXnUweB; spf=none (imf02.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.160.171) smtp.mailfrom=josef@toxicpanda.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741104912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yn/mVNLBd6udkX5JiXXuHWAdMeM57oaufTToD3WukKw=; b=m8KFp4A41at9mq05+3hEms5gtENpVWNUApaqm63tI0ETUv976JHK4CaC1+jICojLvC0yK3 aXURdQ0+PkUZz199Iqwk9zsssdroaufAGDIoJtDDO2owE6b1US2R/OrTRuR5KHiYF4qoKw +ev6Ir1kIPm70f0Z3i5r7yia477G7xc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=loXnUweB; spf=none (imf02.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.160.171) smtp.mailfrom=josef@toxicpanda.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741104912; a=rsa-sha256; cv=none; b=dh5cg2uzH8cdAK6sVow5WnlBsg/WT8q+O5GgUJupO6TVxbQWJM8JYo3q/ZGEKn87LhpPeE 9dENJUu8N9bAxYRxTtJGWfanPlcBSMZV1I6zEMfbrO9ZgwpBFQBC8nSurbZZTu5ptGIpSs Pig6XuUu4eefoa0RiTwKW/HenplZx9o= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-47509ac80cbso850511cf.0 for ; Tue, 04 Mar 2025 08:15:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1741104911; x=1741709711; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Yn/mVNLBd6udkX5JiXXuHWAdMeM57oaufTToD3WukKw=; b=loXnUweBZbStmn0/XLsUR1F2yEK9qATqiDeVYH7JYcUeESFimKf6diiVntMMZ/gQuF EBxyKZ788vFciAbxjC3XNTlwWnaLSPxREuBi5EIm3JFSqDjTGGxhtd+Knxn3/vAZ4GA7 73t/aelWm7ASYe/dlIK6t35V+joW87MDe6NX9M2RZkbshZH2JzLNgdXa8RK8frmpGoRS iXHPSqdlHmAb3eA5ikFUKOLGGA0jJjkCW4lsQYW3vs3OOS1VQ2c6KC092888X5kY/zYH MfdYz1TFd02DgpmFgBFP6W6wXW1jnf7DJCpNtsq5EXMhk4lIUkhCigb6NPPyYnT1qxgn kEvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741104911; x=1741709711; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yn/mVNLBd6udkX5JiXXuHWAdMeM57oaufTToD3WukKw=; b=KPMbV4mfmBoH0sxDDbKDacf9CbJ4M/3Wtt6p4TIdjAKdgejMStdZnaZIP4s12zmoDS LJO43eYO9xaDxX/DakPBaCSFgBdK27CkfD4AJNcpk25h4JLSYc5cY1MMTc++95+hJcPv K6Kxg0IQ7Qn6ajAzUszPX0FjHlpuzGmiZh9wHli2MQrS5hxxOtCAbbtJTdOxzl/pWmKn TXa667vvTBWW3KRziyXYbs3kxjySc1rvvQJtaVBANrGId5Yd10A+v/s0ouRcxFtenMA6 alPenGZrAgWribamzFJYDWK2JjB4aTimf31q+qbhx26N5L1/O5mKeYIJJMn1f2jkqxMM s3lg== X-Forwarded-Encrypted: i=1; AJvYcCUz+hFq3BOO12Vx7ToYrNTExAIqFv5ainXsw8+G7kPK65HF4762z2Jma2o5hoYAticzOPI7G3acXA==@kvack.org X-Gm-Message-State: AOJu0YyHOFfBbttLbSfY/msxf3XAfwzh7FcKPNVp8ZKaKGdlHjIUsdAB J998noPAiLJuooNM3pyv9RzwMorJ1mR7bU2y6Z+nt/lEAa1s6pLV10ZPruTnwTk= X-Gm-Gg: ASbGncu+9RIi8cBgdzG9JSy6xb5h4tKnHhzmCwGcS+cLzhStwQTWk2mOMhiNnIncP4G Tm5hEXPMRCcVSYyF+KJXI9I+YDN05AxhAOm0lTyB5aqyVWaSdM29RYWbyReoqs2sP2XTn2sdSUm akd8Issl9JhuVOqC8PzynF8Gaf3yC1n52+bJmjfZNav3hf1H0D/z61jikzOWB1CYnv1AH2XrtNH GS1ILog/A6zzeO98Oj1wgKsDi5UwFPc+P9qKdSnJ4ydiKtsxBLzigDPvHF3SEKFpiE3MUJGI0FP /5qmoYiVU3xECgl6WN4WMyOuUkgVMEEexQItbwqVv3eSDiK1nx7Gfm2r8W0rzGrjwpZx0dDp4Va GXb7jmw== X-Google-Smtp-Source: AGHT+IET7KPbwwaDJPgxaLzaAdHSOjh+Hip5XZIqRDysdxQdHiaEvAFtjPuu1+nbA8r6dL+tqRwBGA== X-Received: by 2002:ac8:5a49:0:b0:471:a523:6ac1 with SMTP id d75a77b69052e-474bc0558bcmr281954941cf.6.1741104910839; Tue, 04 Mar 2025 08:15:10 -0800 (PST) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-47503d688f7sm5731921cf.56.2025.03.04.08.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 08:15:10 -0800 (PST) Date: Tue, 4 Mar 2025 11:15:09 -0500 From: Josef Bacik To: Amir Goldstein Cc: Jan Kara , syzbot , akpm@linux-foundation.org, axboe@kernel.dk, brauner@kernel.org, cem@kernel.org, chandan.babu@oracle.com, djwong@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [xfs?] WARNING in fsnotify_file_area_perm Message-ID: <20250304161509.GA4047943@perftesting> References: <67a487f7.050a0220.19061f.05fc.GAE@google.com> <67c4881e.050a0220.1dee4d.0054.GAE@google.com> <7ehxrhbvehlrjwvrduoxsao5k3x4aw275patsb3krkwuq573yv@o2hskrfawbnc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: gcrsjddm99oxs3ymg5fy4ba8xbc79tcf X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 393138002C X-Rspam-User: X-HE-Tag: 1741104912-566003 X-HE-Meta: U2FsdGVkX19QFf90WCTq18+ohdHEedboybNJC/xRs3CnSTGpNGRunVdSlc/3zEoJkse9K6aQRTaAEBiRauLyqvPHur/V7/Cmskqrddx4hYMFM8Iuf16MWOYLKPybxN7woOvpPeedhnEj1vyDMKHL0LnnESjVoHiBFsAABaZVnqCG3jLZJ01i1q0VL/wKd1e3T1acQ5YwuHRVFV8LQUiwGxTtefFEor5PW4P2YSiyT31jZhOPuprTtEgEcPuKEvhUaUvpPJbpYN8w2k2Uec9AAdMTG23nbmbxvHI1ImF05R30xBZw28ceN3SD2K+p+cb9pLs/ICS84/A801L7gPGG03cnD2tYVnQKcwA6s1ar8dttsWokfPJNIfz136vfNSQJDadc/5d5ZvNpE4wgIEhAa7yVodLxcgVvPRlG0EZnQJymnPzEcLygNOkWaGfswDTBgERYpJKZaZ1A5vJ7PFdZGHY4hHu2QuveJpiqbBB5Wz+5WjSa+l1DpDzt2vcQJ0kYMLkYK/LTg72kYEMNBLdmOS9IqSz7r5aZitQdlG6FgKjxPIq5kCUlQL41ZNspoBqsOovizzeSKthfDaG5oDr0ZMwL1q0HhJw6R1UPGnMopPTfouvpsqlmNx7X5bmD/WBh4zuVpp/dUWxOcpcQHZY8hEHf+umFeJmUVSeeLl9Yw6BTKjOVCdZ9s4kcbSzNZnBEzRM33iI/H9FCo42bG71ntJLaQpqioQKX62hSGi46F7ZlJ/fo3pXkBe6r75mJ1WwZbCT/LAdtaJyFY8YBmMl+2I5UWzBTJoh0FhdGbJ4ERdxjqn54DenT5OyumGdwSxT39xZLbkMlnoI6b+eOKf6ovHWM5PzAD/t55dbRla3pxPBown+XMymKd6DKkzWvrbH8niqAJRU1COh1gkGPepdk9i+gaLkaIhyYrdqX9HI1pfsxD1SfZzk9/gq0mCfuzz94/HHOxxcFAc8TaH1f05P qxynTk++ zePt3SFokPCRumNfV2kPPITSJwcBWpa/RE5jFNHgSuGxblAfyfQQSnqpYX3Hh1Av1UgZXHWRgDJY/UqAdofOsL+lacm6hZMgWqnBJEc7AZD+f3AcOTXl8TdjoUMHIprmXnIh2dS84rckaP+0vIHSTodR4JrUkeRAfxf4EcQzf1G3MpzJ14Lu2nynXzap3C8PN42P+CwWeWgMeioJguVL8epCn5h/ggsqY/3udMzpjJHDWQUS5QJDfBUFY9X9QBIYTKf9kO0wUHnGc3bcadbg9+1vVBt6WZMkPW5QOO1Bz1DN15JysQWj0OMnSVGnvR3fYB6yCCEaQboZbsykCr8YZA9osxUszPB/04wuw27fDP630lio6BHZs31FWRPsvGzJ2aqioL7GdviCPSoXUT5igZpqVvcxb0RnwN7B01QK5FRVaF7ruwTGPQNoBo31w7vTnnKDsXoypYdFuveH6K4RLMc7vm5qkP94GKmdbSIoFFgAAn/hRbQVvnwFgIc9E3BFw0UTupM5Epb2t8bbfE6hCa8WHGwvmU21VJmotwgS4dVYZd4er6rADZwlhnscg1Zn2vHpo7wail2idc1RBUyn7tWvwQi1kgOq3jEsZirwzDdtuQMc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 04:09:16PM +0100, Amir Goldstein wrote: > On Tue, Mar 4, 2025 at 12:06 PM Jan Kara wrote: > > > > Josef, Amir, > > > > this is indeed an interesting case: > > > > On Sun 02-03-25 08:32:30, syzbot wrote: > > > syzbot has found a reproducer for the following issue on: > > ... > > > ------------[ cut here ]------------ > > > WARNING: CPU: 1 PID: 6440 at ./include/linux/fsnotify.h:145 fsnotify_file_area_perm+0x20c/0x25c include/linux/fsnotify.h:145 > > > Modules linked in: > > > CPU: 1 UID: 0 PID: 6440 Comm: syz-executor370 Not tainted 6.14.0-rc4-syzkaller-ge056da87c780 #0 > > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 > > > pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > > > pc : fsnotify_file_area_perm+0x20c/0x25c include/linux/fsnotify.h:145 > > > lr : fsnotify_file_area_perm+0x20c/0x25c include/linux/fsnotify.h:145 > > > sp : ffff8000a42569d0 > > > x29: ffff8000a42569d0 x28: ffff0000dcec1b48 x27: ffff0000d68a1708 > > > x26: ffff0000d68a16c0 x25: dfff800000000000 x24: 0000000000008000 > > > x23: 0000000000000001 x22: ffff8000a4256b00 x21: 0000000000001000 > > > x20: 0000000000000010 x19: ffff0000d68a16c0 x18: ffff8000a42566e0 > > > x17: 000000000000e388 x16: ffff800080466c24 x15: 0000000000000001 > > > x14: 1fffe0001b31513c x13: 0000000000000000 x12: 0000000000000000 > > > x11: 0000000000000001 x10: 0000000000ff0100 x9 : 0000000000000000 > > > x8 : ffff0000c6d98000 x7 : 0000000000000000 x6 : 0000000000000000 > > > x5 : 0000000000000020 x4 : 0000000000000000 x3 : 0000000000001000 > > > x2 : ffff8000a4256b00 x1 : 0000000000000001 x0 : 0000000000000000 > > > Call trace: > > > fsnotify_file_area_perm+0x20c/0x25c include/linux/fsnotify.h:145 (P) > > > filemap_fault+0x12b0/0x1518 mm/filemap.c:3509 > > > xfs_filemap_fault+0xc4/0x194 fs/xfs/xfs_file.c:1543 > > > __do_fault+0xf8/0x498 mm/memory.c:4988 > > > do_read_fault mm/memory.c:5403 [inline] > > > do_fault mm/memory.c:5537 [inline] > > > do_pte_missing mm/memory.c:4058 [inline] > > > handle_pte_fault+0x3504/0x57b0 mm/memory.c:5900 > > > __handle_mm_fault mm/memory.c:6043 [inline] > > > handle_mm_fault+0xfa8/0x188c mm/memory.c:6212 > > > do_page_fault+0x570/0x10a8 arch/arm64/mm/fault.c:690 > > > do_translation_fault+0xc4/0x114 arch/arm64/mm/fault.c:783 > > > do_mem_abort+0x74/0x200 arch/arm64/mm/fault.c:919 > > > el1_abort+0x3c/0x5c arch/arm64/kernel/entry-common.c:432 > > > el1h_64_sync_handler+0x60/0xcc arch/arm64/kernel/entry-common.c:510 > > > el1h_64_sync+0x6c/0x70 arch/arm64/kernel/entry.S:595 > > > __uaccess_mask_ptr arch/arm64/include/asm/uaccess.h:169 [inline] (P) > > > fault_in_readable+0x168/0x310 mm/gup.c:2234 (P) > > > fault_in_iov_iter_readable+0x1dc/0x22c lib/iov_iter.c:94 > > > iomap_write_iter fs/iomap/buffered-io.c:950 [inline] > > > iomap_file_buffered_write+0x490/0xd54 fs/iomap/buffered-io.c:1039 > > > xfs_file_buffered_write+0x2dc/0xac8 fs/xfs/xfs_file.c:792 > > > xfs_file_write_iter+0x2c4/0x6ac fs/xfs/xfs_file.c:881 > > > new_sync_write fs/read_write.c:586 [inline] > > > vfs_write+0x704/0xa9c fs/read_write.c:679 > > > > The backtrace actually explains it all. We had a buffered write whose > > buffer was mmapped file on a filesystem with an HSM mark. Now the prefaulting > > of the buffer happens already (quite deep) under the filesystem freeze > > protection (obtained in vfs_write()) which breaks assumptions of HSM code > > and introduces potential deadlock of HSM handler in userspace with filesystem > > freezing. So we need to think how to deal with this case... > > Ouch. It's like the splice mess all over again. > Except we do not really care to make this use case work with HSM > in the sense that we do not care to have to fill in the mmaped file content > in this corner case - we just need to let HSM fail the access if content is > not available. > > If you remember, in one of my very early version of pre-content events, > the pre-content event (or maybe it was FAN_ACCESS_PERM itself) > carried a flag (I think it was called FAN_PRE_VFS) to communicate to > HSM service if it was safe to write to fs in the context of event handling. > > At the moment, I cannot think of any elegant way out of this use case > except annotating the event from fault_in_readable() as "unsafe-for-write". > This will relax the debugging code assertion and notify the HSM service > (via an event flag) that it can ALLOW/DENY, but it cannot fill the file. > Maybe we can reuse the FAN_ACCESS_PERM event to communicate > this case to HSM service. > > WDYT? I think that mmap was a mistake. Is there a way to tell if we're currently in a path that is under fsfreeze protection? Just denying this case would be a simpler short term solution while we come up with a long term solution. I think your solution is fine, but I'd be just as happy with a simpler "this isn't allowed" solution. Thanks, Josef