From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 830F5C021B8 for ; Tue, 4 Mar 2025 14:12:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 199F728000C; Tue, 4 Mar 2025 09:12:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 14A7D280004; Tue, 4 Mar 2025 09:12:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2D1528000C; Tue, 4 Mar 2025 09:12:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D23A7280004 for ; Tue, 4 Mar 2025 09:12:34 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 503D7140159 for ; Tue, 4 Mar 2025 14:12:34 +0000 (UTC) X-FDA: 83184059028.10.4012EA2 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf01.hostedemail.com (Postfix) with ESMTP id 1ADDF40014 for ; Tue, 4 Mar 2025 14:12:31 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=maMgaHAL; dmarc=none; spf=pass (imf01.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.173 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741097552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6abCKKzm0j+/AODnr7MLnrAIsUQj9vpqmkXJrZ1Y8rk=; b=VVATofvwGjYUyhfKL5laIPmaoNvUKmWWb1o+wGz5mExePW0l5Eq+0osaP/X+9YvOLRXYB/ uS2fypqqNtVZbSC9MSXgPv7g+Cu6P+0RvXXZ5/n9Sx/5edEbQ4WxUznvoz03T7/chcxhrG 9PZ2/5gMfYTUpR2LjTDdmXobjPw73M8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=maMgaHAL; dmarc=none; spf=pass (imf01.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.173 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741097552; a=rsa-sha256; cv=none; b=OhOMEeelWLRM2Y4CPm+8hzN7xEKNRumkrxa8uqxROdRh9UO/spUVgYNRWvJGO0QiEPqbmN YcTInJhQN1d88Achlk0u7Dw3gA6eoGa0xXn02/HpsLTiwOT0SZtbkjG/XLloBk3BI4Uxao 29aORe0l7440IyhRblssd6rR6IQ/awg= Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-474fba180cfso8428861cf.3 for ; Tue, 04 Mar 2025 06:12:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1741097551; x=1741702351; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6abCKKzm0j+/AODnr7MLnrAIsUQj9vpqmkXJrZ1Y8rk=; b=maMgaHALgNewjEBhzG8iINw07JNNx8n/VaYftuDNO5NdcjkVRk7dVH7N3iUKlWZUu+ Pmke0TjgOBQEqYPdwcQ4G/0CigX2r3L2sP4C0fgvaHa5HwVwq6kv0ytMNjdNy6ZikH7i QTHVxg1yIFLhuqzbymT0G8p2IE9xb7qQIqqc7j0PHdnF9PphEUvgGmjY7mtf9JlEg1d4 urFMVEVtavv0UtZhi3MrruqjPpJaDd6Acx5Cdf1ofW5WA7gEke9DBOKPUAsrZS+3oRXU ppqOxrZvWAkdOZ+Zuzapv3lxCCaiChxrIaqjlXWw1HuyYX2qmrS+9lsmmWfzL39Wzo2E 1dfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741097551; x=1741702351; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6abCKKzm0j+/AODnr7MLnrAIsUQj9vpqmkXJrZ1Y8rk=; b=AsELr601lQqnbb1AnhlgDTN+OB4e1M083aiIb/24RjiqFfI1gXqbIsAwj1b8whMr+/ JZ6fcoENiNe9K2y2SeRLThsn70OmB9A73ADozTIU4tmLiY6j4nsVhqS9PEIwj0jtDk7E vn6JQICdDW+mVz6EuHK/BbWCqFmxL33JEYAnIMsE0D4OG2kMhcsnQkW+vSlCwc1LIWHo AVZ63Q0eNRw5UZ2EHZcgLVKYChkLrNEKxqAv7p9L0fSpiYaNeuXQQeRkbJau34WHMAr4 40EAWCXvtpVSMiAvOi5nv8joSv7NHhPHrlShN07rdsIIUqdlGTo+f1P74MmlQqKkXe5G zvPQ== X-Forwarded-Encrypted: i=1; AJvYcCVuKIqtyDLXISagydB3ohyYG6lAnhSwD0CBXhwz3nRRKA7kdjmKzPFp3osSkr2juBRLkmjVzppsGQ==@kvack.org X-Gm-Message-State: AOJu0YzLHAtp2jXgvZjwpgPtihmfNOgnRm0c43G2rvce1Z+w0KrJcZC+ /nkmK9rfLHJ7V+DU2hLfCH1KfkN+Y6cOO/mWjHJgwCLdDJcG/REzmjkWTn/GLES19+VoCuvuy2r I X-Gm-Gg: ASbGnctk0h4Vc78/io7RIJyyT37/z1cfD86k7JvhTrMCuJxt5ZC791uHdzol9L2WlA4 thRitevgsQT/2yoq43KtH/Hsi7gRzRMml7/prlkecqdXMfo6UmptxsEaQXy+xIlFY/EnQe784Lt 6bYww9sPnDkqk854Smyjv8DQ4PDOW/cb5sVOpqcoCHhm9ZKbaPbPnqei43i3wpB8yEtOzypp7LM ZLTXepkUF1kECs09+PzFnXb60TkfDaRddGZsORgoZLBmHYy/+RHInT3JrLvDxFt5e4I8FfwNZLm ggoQ6NykpT4/p+evElxZPSKL1yIj2Bexg6Tm0YjEBNTs/KRIDISs4W/YgBYm/qzgfeDtbo/+bDA HgzrkrGeRzLV9U4aSfQ== X-Google-Smtp-Source: AGHT+IGBiaLPV0kUHqT5PI6jMjfFfqIeEJlZSYF/UIwyy0h53L8cX/wdnOyu53qq+Zyx3liS9mFUdA== X-Received: by 2002:a05:622a:1825:b0:474:b753:e262 with SMTP id d75a77b69052e-474bc04731emr185725851cf.9.1741097551115; Tue, 04 Mar 2025 06:12:31 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-474ec0587f9sm26813451cf.46.2025.03.04.06.12.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 06:12:30 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tpT0Y-0000000171w-061O; Tue, 04 Mar 2025 10:12:30 -0400 Date: Tue, 4 Mar 2025 10:12:30 -0400 From: Jason Gunthorpe To: Wei Yang Cc: akpm@linux-foundation.org, willy@infradead.org, michel@lespinasse.org, linux-mm@kvack.org Subject: Re: [PATCH 7/7] lib/interval_tree: fix the comment of interval_tree_span_iter_next_gap() Message-ID: <20250304141230.GX5011@ziepe.ca> References: <20250304011952.29182-1-richard.weiyang@gmail.com> <20250304011952.29182-8-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250304011952.29182-8-richard.weiyang@gmail.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1ADDF40014 X-Rspam-User: X-Stat-Signature: y5sgo4quq117947icaf9z77oje4bf9xk X-HE-Tag: 1741097551-524552 X-HE-Meta: U2FsdGVkX18vb96nqGVq7GW4WktUc+PbaY7dfc/1Xxu3tyg+81nUckyuR1DXk7iQFLHh0uaL4hgvmHxI4tL0Hn3fhUD8+F5ANH+gI58vz+2qTqGTUlFiaEU6jxuu+2wRwWagFps3znofXLYJ4ijV6vBFjRDhxw1lWsmJn1+r16N3YGNfYST8Kd0OxsSDIn4QaX08YjaZDk+ixfLSBGw9wdvc7BHACLEPf+v4fZjJF7kJtD6SzV+nwJex5ME8ETloF6GyE/E62g/fQA9xa+SEtAhJKCFY+rJQV+W1Uwxs+P3ApdI6FLyDVGAvRyEByymzCv/h68i2RnREI2NV9+M19nWlVBv8FMeLJGxOgCTMn93Go5vgJ8zOyS3s6PMWA5oq8gCLUsVtXoHyzh62/ePlyY+Dk+aTZ7OnydkqjK4R43xMRfPo9dYMpohI9gTnQWrfxW1Ay2ipBYjUWCeQnV0HkVoEYjnbp+A+vt4GaICObEfCbSf5OKQwosv6ng0ydxt5ZZ9W2qHMSYenDICEWUW5HKaQSUaVZ3AMBCeYzeHl2m0VroyGgMEqctLkpj2AKL5NTL50wCMFEiR5IFUyIDn1I/Mn6ia5QCwlrciCMS+kuFRCK1ALYayZoKoLLfPYR0jx3cAuff7DqZlYB0u2uBwIuh+rSt3Q7ZYA6+WgWJ3tr3vkoVDc0VvHb6dOlYh9oW+Pl0p8JeLq+VkAAA7VedByPSMtc3JVtFygIKhtrwwnJCnXNenrNd0ccmzYqV38ToVKkKjLI4IS38d8y7H7cHe5DyH3TtH80T/hvS+TKbHK6VypmR41SWaFPhn+y7hpTSk4J2ZslTC3TwdLy6x8C9IVIqAdW4wyL1s+xmWPIr8gQ057VHYTasai1lII3wcnYW570XVhDqBIhU8Lmg8/t4xxlYncmpupquHpt1OCod/H3EcSYvwHh+3L2puu2OLSdw4yjjwyqQ2Bu4Xde6DOuBF zxvzpML4 LlMgEOmEZDT3E2ZGB2b2HFNdKkiwuLUYzD4ol4j5/h+1eQGp0OLLQ2b0w2wwQtr+AQzYy9+7ryOKmo5ypbksKWGHtt3RByAwTIpWFreng/eJKp7p6sjT0Q07T1xLhrZBi5jU/xttS+xWDvwdIXSiL3jgZCiyRtTZT+BxKBFxDgG8p5Q+5d4VIueV78+ungKkv1qB0y1u6N5WXUzSMQpl5ycccrwg5Mp/FJIWb1G5FDwTOCCcStOXUa+RYMOQYgfdFGErwP0UfkNyR51dmZxM/9kLWks9jKQs1zpdHB6fqI2HdXvS1qpyWPzzdTNFhLgH7268pepfxWsj+ne86yJwHnd4qOhSCJ5sSK4ldraK+I1bb51U+z9uv4kfu25XyTh/64y5oeshU7YutjrlrskVe5OurNkEhusP6lw/fUxdxWXx3YiERlbzXw8JSXhsvvsztxlIEuH77w7re+2+CSolWhslol1tYZ9LT6R6EJpBarEv7onEh7+vy4aiBwdpnX3hYDPB8F1ymERve1EPQvfpY66owqlTSW3MvAkmtGoNukoe30G3AL5EgM2IWRwodZbVx/flM1QHrwiRsFp7w+KuSXgHRtmUE6+G0dBuQ9l54ZDOjKaZ5+TULgjzjNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 01:19:52AM +0000, Wei Yang wrote: > The comment of interval_tree_span_iter_next_gap() is not exact, nodes[1] > is not always !NULL. > > There are threes cases here. If there is an interior hole, the statement > is correct. If there is a tailing hole or the contiguous used range span > to the end, nodes[1] is NULL. > > Signed-off-by: Wei Yang > CC: Matthew Wilcox > CC: Michel Lespinasse > CC: Jason Gunthorpe > --- > lib/interval_tree.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe > @@ -20,9 +20,15 @@ EXPORT_SYMBOL_GPL(interval_tree_iter_next); > /* > * Roll nodes[1] into nodes[0] by advancing nodes[1] to the end of a contiguous > * span of nodes. This makes nodes[0]->last the end of that contiguous used span > + * indexes that started at the original nodes[1]->start. "span [of] indexes" Jason