From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD1AC021B8 for ; Tue, 4 Mar 2025 12:07:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C81D56B0088; Tue, 4 Mar 2025 07:07:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C315D6B0089; Tue, 4 Mar 2025 07:07:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF8236B008A; Tue, 4 Mar 2025 07:07:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 90B246B0088 for ; Tue, 4 Mar 2025 07:07:51 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0DDAEC1C4B for ; Tue, 4 Mar 2025 12:07:51 +0000 (UTC) X-FDA: 83183744742.07.90F2DF3 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf02.hostedemail.com (Postfix) with ESMTP id 116598001F for ; Tue, 4 Mar 2025 12:07:48 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZqeSsW6T; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741090069; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yrAR+gszQYIRbPlrTxrvoW8ZKqisYFCfI9SZvd/hhWg=; b=w8N9PbmiBs/tZUZq591cukCSEs17CgoTmjbbPsf+x7rqClO90exll3iTlZ8R+NpNN+dudy Bf80eszUEGyAPwEn2dUR774dSFRuF4tIx7oP1YXiB7h/fZTYRPod0JvHZRt5Hw7LQq/T2/ U7XiCLNKYxciYdMi80yAoxp7W+mQLDE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZqeSsW6T; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741090069; a=rsa-sha256; cv=none; b=XLak0vaS3dlLc6QGh1KSbPUrXqeb0oAktFrg0/KqVVPIKqqIvrCAmLdNqi4X+rBipqInyC IYtQUaHtpTRctCBbhMt+q9l5CQ87i45y7hkMTVQyGGpqhW6zuvstDztLvanlfoyDZA4Gks uDYR/S6SPl4fgEpOxE8x4umcIy/D8iI= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-abec8b750ebso969565066b.0 for ; Tue, 04 Mar 2025 04:07:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741090067; x=1741694867; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=yrAR+gszQYIRbPlrTxrvoW8ZKqisYFCfI9SZvd/hhWg=; b=ZqeSsW6TL5GB2HQHb4SxU7iWNlJc35SRRETpD1CYAd+AKgdwgIXTWYW1eK4ddSXij+ NzK4fCB79esTwrthxGuMgPCDi5GOiHTj4YUtOln503Cl3XFQFS3YmE0qBmcbWiWvwdp6 xelO5jkykhPYXzDVb/lftPX9rV3TtHsklkvtDF+LLKn838EdkbghoyLCIuKgWJDBKfi+ ul44Yz2+pcORxLH529dUv4mtNT2DMXjWK9eZZ+SprHLVTB12251gbAS+YYyACuNvq175 QDgyQ8LIPlxK6qoqhNd5osVTkjy06io+b/FLt2rpCtzA+JHPS0amvi9yY3WBeyrzW6wg 60xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741090067; x=1741694867; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yrAR+gszQYIRbPlrTxrvoW8ZKqisYFCfI9SZvd/hhWg=; b=QpmAAZELsBvtnC9YoEHGDq7wZT/KrsDNDSUuGcypF2Qdbad47sHxlTLphpJGb5G7pz 519hyn+96fA8akbUOsG4hNJRZCGRpz3B4y9avegDbDnto7z82ivK0/uMNKwkPB+aT0+q W1QwCwN5h2MjX7FJff/hjI93w30NmwKP2yc20sWwdYYzkt+YT05FZgdjxqjkgXD8Ylyr LUsZsN/7318kceRvoSyjbUETv0okajIW2bTlvSo+T0p/BV5xTBsn7jfBxNT7YC6IQZ/y 7/U1nTS4LAUOKDGZ3Fu+SD4gbsKwRb4eYd548R7MRSCF1r5oZAO2zRthREpjRCtDoe+N UMpw== X-Forwarded-Encrypted: i=1; AJvYcCWCK3zoWI6tmznGpQN3chs0FTWl2NyJgy3TsMMUBxcWOZK7hfes37miaXHrkHqsHUpLzRQPupt28w==@kvack.org X-Gm-Message-State: AOJu0Yydfb0t9jB3AaPqFrWvH+liOLKOms6H9Dd04s6Opz57lp7Et13m BEwKrtI9Nqf10jjiOVHx9gpsKhBgiLqyr7kMdpXL7139fRpRv+0/ X-Gm-Gg: ASbGncudmbNZkEFCpjNFg5bw12WKW5b/a+sWKDqKK42mvyBEt4b92ljv89rrCbeWl7S 7q3C18rq/uMEbpuJ2wVthn9Aawcq4xg5f8TbK6qRmIuOhwyv4jTyZcB6F5lPnuOVSreWFkjdAGX 4OpGAzcUt2t+3q+F7ajmSXumTUPK1NYm89slnAa89GuM3OkMJLG8aeMYCPS+hI34sWb/YX0Jt3e ZFT8xEeBjffHnc82xoqlndNT8rrROtAm4mX3BhTLWyclQGLh+ihpyHJYHinRueKnr59Gq+dhWdz uEqKPxmD1EcK/ztvt5bhlBzUNzndJo38l3yafUkPgsN6 X-Google-Smtp-Source: AGHT+IHVQsmkClu6syqYaBlBacCwzeDUOGWOfYmzyeA2r5uZ7uW+Paf1wWsKGBEApygT6sGyFbglig== X-Received: by 2002:a17:907:1b18:b0:ab9:63bf:8105 with SMTP id a640c23a62f3a-abf25f8e8cbmr1996673966b.1.1741090067237; Tue, 04 Mar 2025 04:07:47 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf5713a036sm560948966b.80.2025.03.04.04.07.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Mar 2025 04:07:46 -0800 (PST) Date: Tue, 4 Mar 2025 12:07:46 +0000 From: Wei Yang To: Wei Yang Cc: "Liam R. Howlett" , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 0/3] may miss to set node dead on destroy Message-ID: <20250304120746.cas4wwnnn4ih2c5g@master> Reply-To: Wei Yang References: <20250208011852.31434-1-richard.weiyang@gmail.com> <20250211081129.xskl56wm2dir2x2f@master> <20250212005536.6j4shtwswsyaapwm@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250212005536.6j4shtwswsyaapwm@master> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Stat-Signature: egeujm5m8r36p4deh6isu4rgd49qpm7j X-Rspamd-Queue-Id: 116598001F X-Rspamd-Server: rspam07 X-HE-Tag: 1741090068-171637 X-HE-Meta: U2FsdGVkX194dKXdehG7dFnSKYULhkKWFIJ2jOshs/19Pf5yZD1qrHjc8NUXD1Td7k0sCu1ZpCD/qDQGO8l+kH1lD9XDtCRgIsSNEVjG+r9PSqR0i0Nwkub35M7OqC7jTb/WgEnqn62KtgQuwMVP2IRuA7iPpXaRGJl07Revbrq9AJjb8CEaL/bPJMNSbUwaZgST8rMi0GLSO5HY4LNrzMFaQJ6sBmw5EwTl8XL3tqE86E4FCFhNKke5xfcjaXWe94L4A6UjikGeuVqADGOkLv8TTOiAXY2N2NvdBBJpItarw4UfXobc1lh0XfadY9tQUuVX7b8s5m66lOb8TDG4iHN6YvA2bUxDVjqV41im0puqt9zOhLuOvr/yyYOykAqkzfL8wpTrIb+7LtteOJ7/LvVEL9fyR0mW4bxHOkgsvlztuF1BBSSLzn+nlyxXMZtm/fo4GLgszT10/BM65PodrQv23Bi4Krox0Dm0CJrn7bum0fUZf1cf2HqRHbnnJueE1salWFZ7r9yT2NkUpsgT+O9rmE3Jq2L6mx6MqxVOlioyyBCkqIk1hTeaD1K3tRIUrYZsVrQI/1z9lrsbpUMfUihKBxR+pQSJScjlEF4lbIxtYmvley1cTot3J54zcOO28QQRBjG2b+byPEkxdonZ0o5JLO7HbgZNgkWpJ5n3sIZEFrmzlb50hLINHZiI1nuA57Pk10t2SlCDYpLuJ1dvX+2I+gShNolNfmA76d2zT5HauBCewPISZTPJ+EtGkHv7Hn0gpLdeK0pH0rVeu4zmePAxosOnpLAAp3saIrZJ5G1Q/qL3PbW41veQOXSFILINiCTe6fXmsJ9YOkAGZj1h2sWMJ/fqG7e/gz84KYPXn7Pby09cM3xqVhSbAZIO7BIQcK/g1jlt1r9QlahgvC5tCXxJPpy8M/GXFTmEFj5vlP9u2GoP9dE7WKS9rMkSzBO8zaVadKD7J8CkIonqi6r Zxx3YSse HZn5fSVWnDc7WdJkKedRCan1jksVAFnyCyxqfe6kJ14iYsV8xkdp16x2a/QRANJuCECC01/ErEX3xtumcswYuuq1PkHzz1wgez5H5w+Gz+WQXPZn647+U3gPN6OqZ71I+TJ/E+O33xlprcmn3Xwl8OCOgNdWZPY53MIpS3jdQtQh2i7UgPeUuv3WMNE1SoSdPh/6MNhrk13ltgWK/5CCDD6XOFTA1QwhDHLHEh4bWZ54GMK92f3Api0aRGzJFP53x5UNswN17XPhFMhBhbjoPuXofaXDdqvFXWHiXP2Q76E0q4FZx1Y9X/d1z7m9di74MkY8lCdw313qMtK69kbbKtpKq+5AvWZieLEUFMfSMhugVPWLWTSea+VdBmYvLavygtmGXzcxm9/dKxEPe2G9HrvDwLSuh+ZpDfCN/v47+7zNjVf60EaYZ0cd36KwnDS+HNSzLB68qUV4lOiu9b+/pLM4lRDI/VLUqeTmC0nxn41cMUgANc2nPJx5CLuSlPPiYVe+zA3Jt8kqYae4ggv//cMehav4/DuSKoRIGTyTJLLqTFYympz/J+Drj5YMxfz4cISBSn4fP4pnTAncTm0YSU35dnc6XoRKHaCTihr03t4lEnaeO4hRW4/JFbxpfTZka9C1sV48fU5CgGR2naloNpBa2eMJCzw83jOvg2mVxwnRWkKNz9j+olJ8n7Ftm1Pkc2geZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.018021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 12:55:36AM +0000, Wei Yang wrote: >On Tue, Feb 11, 2025 at 10:28:53AM -0500, Liam R. Howlett wrote: >>* Wei Yang [250211 03:11]: >>> On Mon, Feb 10, 2025 at 09:31:28AM -0500, Liam R. Howlett wrote: >>> >* Wei Yang [250207 20:26]: >>> > >>> >The subject of this patch set makes the issue sound much more sever than >>> >it is. It currently sounds like a memory leak or a UAF, which isn't the >>> >case. >>> > >>> >>> Not intend to exaggerate the impact. >>> >>> Is this one would be better? >>> >>> maple_tree: make sure each node is dead on destroy >> >>Not really, you are fixing two nodes, one isn't even to do with the >>destry/dead node. You are also not making sure each node is dead, but >>fixing an issue with the leaf node. >> >>maple_tree: Fix the replacement of a root leaf node ? >> > >One more question, would it be better to use this as the subject of patch 1? > Liam, Are you ok with this and can I send a v2? >-- >Wei Yang >Help you, Help me -- Wei Yang Help you, Help me