From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2CF2C021B8 for ; Tue, 4 Mar 2025 11:54:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 745D928000D; Tue, 4 Mar 2025 06:54:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CE4328000A; Tue, 4 Mar 2025 06:54:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56F6F28000D; Tue, 4 Mar 2025 06:54:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3673628000A for ; Tue, 4 Mar 2025 06:54:10 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E1ABEC1BCA for ; Tue, 4 Mar 2025 11:54:09 +0000 (UTC) X-FDA: 83183710218.20.6F48361 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf11.hostedemail.com (Postfix) with ESMTP id 17FE74000B for ; Tue, 4 Mar 2025 11:54:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=B6WyAz0g; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf11.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741089248; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8GHG5SrZxrbiSvIE9KJ7OpGdZd2qAT9K/MHNn8uHvMM=; b=FL3IlpbkAUEBLFhme38cjogCfQ25dRMcUSy/3Je/wG/MvbziSr0CLCs2nHU/tqbGgSffuD cJ3TJdtbjaxLMvczfSr3h2wjntfJJEN4eq2T87wADF8xiZGJZQXNgI8KpQ/U4R3OItCfl7 ubsoOEeKZ3dDfBGx+019WCg+ySKDXOg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741089248; a=rsa-sha256; cv=none; b=ZH1U6NtMzhMpbcnpie7dYo57wg6Dos+fT9mZVrE3qINajGDgjxr8RsOtwvo8BGDLl3/VMp OTIChwR73sbPK5Tv/K7sw459/CmiSDIJN1Ig8uEKMzHLO/U1Cu4FOKi8/BddrD9lq/hMZ7 +JkKK1kGoQqDOUbFE5N+E7bawbVDUAY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=B6WyAz0g; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf11.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 088B440E0202; Tue, 4 Mar 2025 11:54:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5eVmiwsvjl6y; Tue, 4 Mar 2025 11:54:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1741089242; bh=8GHG5SrZxrbiSvIE9KJ7OpGdZd2qAT9K/MHNn8uHvMM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B6WyAz0gzR98rv/PHGB5eUpm8blzgQE1qfpqqd+ZRj721zz1LKmQ0jL+6CrW3ies1 T1pZyPdhgjObE+tC4sw0nDViNtOzAlvgA1/MaNCa7Y4WPgJLoVarl8nqa0fAmUrv/r GPmq2elRiXvilpNp6OTx4G+5ImYI4G+vEP0hvZExDLsK0/3jSdbgR9cRf97U2c7iUp VXWAWvQxfi4REUalFPlgNtPL+iKR7l1wraRNQJT09LE/3MGQBZT3lCwuppnwKJMw9G xd6TtL7h6XEmScV1m1nQEDrP8Y04r6Hb/T6LF14tdwTVLlQdPq05GGoArr7XTOLbvB tbKX283180w+wWI892XKcLiBw/8546LPsI+4J1cTuFel84Ab0JHT4c5IHo0+RPqWza QLl8Fq04dLKrZO8p1bg6deBlN+Xn07aF3MX7VHzR1l4GTJBBH/wjvvCo0ys1XXNUih rQflzTRiRJU3ZtXFfoM1cVJcgtrFNc02Qdq1okmv6NQn6FZWj5HM/EI2ML00317v3V Tfh11f/+OvRa9lxDt9sN3XXvhLRGZyGFdofNRXRd/tZ18RH/ol8exaDgme7OZMoX0c JINDDrIiRIKz/GvNJHHn0YLvhe6HNct3ob7EE4NpphdyW8cu2wZI8nQb87yHtNmdF8 mM97U4fGrQSsF5wVyMiQcmLk= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 25AB240E0176; Tue, 4 Mar 2025 11:53:44 +0000 (UTC) Date: Tue, 4 Mar 2025 12:53:43 +0100 From: Borislav Petkov To: Dave Hansen Cc: Rik van Riel , x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org Subject: Re: [PATCH v14 13/13] x86/mm: only invalidate final translations with INVLPGB Message-ID: <20250304115343.GGZ8bpxwAZo9tksg17@fat_crate.local> References: <20250226030129.530345-1-riel@surriel.com> <20250226030129.530345-14-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 17FE74000B X-Stat-Signature: 91bsu1te1qw749uzuztxr6x4jg8ckb31 X-HE-Tag: 1741089247-598387 X-HE-Meta: U2FsdGVkX18spiOZ/63wpPHm0Bp3r8dpvDydx/yutqFT7PLi2HsU/hkunc4P8JEZ/O0tOgaBVbwGqKxAGXnQzAKcyXEZwcYGj31LZbdY95yOklzS2FqOIRNHqE9h7hXdcJU3BwhoEF+0z4XYQs6kI67Y4O+Ap06+fm36DFW14mW6MDJdfuGSX9h7NaqiAvatUWMJ7TVE99Esji95qaAFNC8dOjZU+hWgD/ccIt4J10z+wbG1Rk0+CZ8G1C5cD1CpXXxfRIOxT6//T1JejhddqVcfUvTuArOedWmR25WFPxAwMVlCAxQGDFaQhr4H08nx8R29vTWLMwWCD77p9EoXa5F7nNPRw9ayJBIqCcwEnhVoQyZLOjhppGf5uyFFfA64y1zzrbhKNKXGZk/53SHCBF7545BR/y6TyuYRVvJu5wCRHbKVnO4+A/4zX9XuX0Cb4jXLl8X6aEFi6FMaTlwLfvTsxDssVGw2+L0+1TA2IO36YCoDl+e77zz173XuPm7ZyCON7/AymrYDfMIo52IqLidjBOOcA+Hha073DoJOUb/r3wlzuI0d8+koTsGWX89ZJH8x+0gPsGioUnlZdM//USpDrGeh7zLwlAQ2TK7d5PogreNtTZX/dpiUSyyyJVWc3ObLNf0+tHNTefodWE5+RjEpO5Z2Z+brviqAKCnwHJqXB7VOYCF98lGbC7yB3wblf0fHHNV8DMLMDqoqQMEr5VK9iRCVZ74Sqy/+uVmWRgue9bL/Z5UBv58ZxQ4VIYfNpinIjjzvFygSZnuS0wuxLwm1nCXNCp59XKcBDaB5CnCKwVlAhcF6O2LBSsGXzYrJP5Ea9leXuiXiCfxpBqfUML5c5EF2yE3ygfIlT6VQOmCgipYLnjVoCX08BjMRcn5qlp63OxTN/wOK5sHLzBFqpe5+rlptp6kyjvAcSPgFQehn4Val2PmL7CO3SnYmV5mZ5OOBAw5aQgMAArOzoPt 1s8SIduj wfJaeNFu9eiVmpAvoWrRIJaRS9tpsYbWczg8x9rw9oHtKtAcpHXtf8uFLig+ESM3HHzdTWQ9Eq6R6Wy2Lq7B2pb3kOIVxDQNk96zFTn3sj48hhK84emuJTsF78AR9hvnwmJ3sht4nvajQkV1xEyPM0KfMhSdsbUxVlgXxqPOHcovdEm2ulYtLoZjwlOlu3Y+2/hIAzHJCpZoiKsXoKf09ml4le73vnfxB8cv+oXa+APkByCEZsB/fB0AGtfgUbd1Uza4fM322XxZweLXx/fE7lZLHBUWn5ea2hFM1JoI5DChXahyKIFdekcKp5DmTlI8V9znLmfubJOzi90JbqhfwxA717Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 03, 2025 at 02:40:49PM -0800, Dave Hansen wrote: > On 2/25/25 19:00, Rik van Riel wrote: > > static inline void __invlpgb_flush_user_nr_nosync(unsigned long pcid, > > unsigned long addr, > > u16 nr, > > - bool pmd_stride) > > + bool pmd_stride, > > + bool freed_tables) > > { > > - __invlpgb(0, pcid, addr, nr, pmd_stride, INVLPGB_PCID | INVLPGB_VA); > > + u8 flags = INVLPGB_PCID | INVLPGB_VA; > > + > > + if (!freed_tables) > > + flags |= INVLPGB_FINAL_ONLY; > > + > > + __invlpgb(0, pcid, addr, nr, pmd_stride, flags); > > } > > I'm not sure this is OK. > > Think of a hugetlbfs mapping with shared page tables. Say you had a > 1GB-sized and 1GB-aligned mapping. It might zap the one PUD that it > needs, set tlb->cleared_puds=1 but it never sets ->freed_tables because > it didn't actually free the shared page table page. > > I'd honestly just throw this patch out of the series for now. All of the > other TLB invalidation that the kernel does implicitly toss out the > mid-level paging structure caches. Right, I guess we can revisit this later, once the dust settles. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette