Re: [PATCH 7/7] mm/mremap: thread state through move page table operation

[kernel test robot <lkp@intel.com>]

Hi Lorenzo,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.14-rc5 next-20250303]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Stoakes/mm-mremap-correctly-handle-partial-mremap-of-VMA-starting-at-0/20250303-192101
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/4cc18ebfc0cb32e9e42d86503cef3265108343e4.1740911247.git.lorenzo.stoakes%40oracle.com
patch subject: [PATCH 7/7] mm/mremap: thread state through move page table operation
config: x86_64-buildonly-randconfig-001-20250304 (https://download.01.org/0day-ci/archive/20250304/202503040721.0r47FGNO-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250304/202503040721.0r47FGNO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503040721.0r47FGNO-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from mm/mremap.c:11:
   In file included from include/linux/mm.h:2302:
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   In file included from mm/mremap.c:12:
   include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
      47 |         __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages);
         |                                    ~~~~~~~~~~~ ^ ~~~
   include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
      49 |                                 NR_ZONE_LRU_BASE + lru, nr_pages);
         |                                 ~~~~~~~~~~~~~~~~ ^ ~~~
>> mm/mremap.c:581:43: error: too few arguments to function call, expected 5, have 3
     581 |                         move_huge_pud(pmc, old_entry, new_entry);
         |                         ~~~~~~~~~~~~~                          ^
   mm/mremap.c:478:13: note: 'move_huge_pud' declared here
     478 | static bool move_huge_pud(struct vm_area_struct *vma, unsigned long old_addr,
         |             ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     479 |                           unsigned long new_addr, pud_t *old_pud, pud_t *new_pud)
         |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   3 warnings and 1 error generated.


vim +581 mm/mremap.c

   552	
   553	/*
   554	 * Attempts to speedup the move by moving entry at the level corresponding to
   555	 * pgt_entry. Returns true if the move was successful, else false.
   556	 */
   557	static bool move_pgt_entry(struct pagetable_move_control *pmc,
   558				   enum pgt_entry entry, void *old_entry, void *new_entry)
   559	{
   560		bool moved = false;
   561		bool need_rmap_locks = should_take_rmap_locks(pmc, entry);
   562	
   563		/* See comment in move_ptes() */
   564		if (need_rmap_locks)
   565			take_rmap_locks(pmc->old);
   566	
   567		switch (entry) {
   568		case NORMAL_PMD:
   569			moved = move_normal_pmd(pmc, old_entry, new_entry);
   570			break;
   571		case NORMAL_PUD:
   572			moved = move_normal_pud(pmc, old_entry, new_entry);
   573			break;
   574		case HPAGE_PMD:
   575			moved = IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) &&
   576				move_huge_pmd(pmc->old, pmc->old_addr, pmc->new_addr, old_entry,
   577					      new_entry);
   578			break;
   579		case HPAGE_PUD:
   580			moved = IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) &&
 > 581				move_huge_pud(pmc, old_entry, new_entry);
   582			break;
   583	
   584		default:
   585			WARN_ON_ONCE(1);
   586			break;
   587		}
   588	
   589		if (need_rmap_locks)
   590			drop_rmap_locks(pmc->old);
   591	
   592		return moved;
   593	}
   594	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki