From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F3EBC282C6 for ; Mon, 3 Mar 2025 21:56:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D62016B0093; Mon, 3 Mar 2025 16:56:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D12136B0095; Mon, 3 Mar 2025 16:56:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD98C6B0096; Mon, 3 Mar 2025 16:56:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A0CDE6B0093 for ; Mon, 3 Mar 2025 16:56:46 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 43FDA810A0 for ; Mon, 3 Mar 2025 21:56:46 +0000 (UTC) X-FDA: 83181600012.09.CA3B655 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf02.hostedemail.com (Postfix) with ESMTP id A529B80004 for ; Mon, 3 Mar 2025 21:56:41 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=d5T8g5tb; spf=pass (imf02.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741039001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MNbwSIfUeSXXPmyUg0Xj+MaylekMn1nHxUkSWUyl25E=; b=oiOuLssWE+osPnsmHsQ2jzHA8o6S5+chDZRfeqazFurfRptLDIlAx8bKN1mN/9ESPJ3ERL bzLEso8COqCTAhZl10wvYh1lO/HYTLVB6+KMresPdqQX1TL8oblVVis1UymZ86gok1cpoD VCeVVMc8Z2OJOfbFyoiSLg+9PfWoxAw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=d5T8g5tb; spf=pass (imf02.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741039001; a=rsa-sha256; cv=none; b=ZpwE/dciNsCWJw8EgAlV47aBFapnwrCF/34Zgd+r7sObvD0/hg9H6jFjQujFU3XBLqcqST itG7Jt4Npz0xf7S91Br7qYruSdasjZT4LQy4A7we7cPngeHRP5jDocpHe1cxHvPSgGBh7C inlucU6hjaOedWTg4EQSicAwDx589a0= Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-e3c8ae3a3b2so3674363276.0 for ; Mon, 03 Mar 2025 13:56:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741039000; x=1741643800; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MNbwSIfUeSXXPmyUg0Xj+MaylekMn1nHxUkSWUyl25E=; b=d5T8g5tbXXkJT5a+JC+71BLc31CKM5RJLtsjx3BGkQxy9MxCei2jg2U/+RGjKjSMk6 cGaxcj3n3vhUZhpWeSoHkpIiq5zMoOJVphvjdxZXiV2LqV1UYV1MOQU33ctebuNqnsma DUJoZkLmC3LFINRj5WhrnExgO57XU/dZYVmbSJW1UaEED8Ej77zmODPNfSAZJWYT7H95 toEpLip10DhRWgPUj1oybMIrAFYYKo6qG1TNLg7cXkh02AmslzqftUxVwfYXHHTFAGvo ePJOO2c45Gk0n3wljvJHTiBv4LYy43z3BayxX2JMspS0GhAubxBmWtXfPedk2eyNdPM7 l6xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741039000; x=1741643800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MNbwSIfUeSXXPmyUg0Xj+MaylekMn1nHxUkSWUyl25E=; b=HGKQdOSa4i0MToA45Cj2jIxR1X8NlkKn3+qtsdG5NiId/opcRhxoiLbz+9fIVDRqPk ujS0ClvqUhM9m+ynG7mrL+T7TUQaUHQNHqY8FpbUKa4jtp98vEb+jrJTYQWyfaZaxfaB czLqFVPuXNwTU8AW7ZdfAS27+bo++L/GfD3KcRFxXYyGeJJ+HhZV9OMcfiwMube3ACHz Lkwz+ZVtQAUtGIf/swdWPUipus8rtgu3csxqvJRP58qpgJCiN2baEqDV/Ki5uIl6H3dt TAzYO0Yr1IzDTGwe7gwChaGJNyE2OioRVjILsSLTJNFMjUCNl1sB342qCvtM3sGHmpta aphw== X-Forwarded-Encrypted: i=1; AJvYcCWaCCGvmvR0D9e41mS60x5YFU/WxrQoLZPOlM06krMWdx1EJoYyNLN7LaIf9rQW2kUmEyT/bY8QoQ==@kvack.org X-Gm-Message-State: AOJu0YyJUleNAE/b9wDSdugW/wpY7Xl1tQI9ofpIqSP9h6PcVKfJ2PFh FJBv1D/cBSa7xpIjYeVfP8J3OsHOG6jYXgnwqxhdmwW7e+yBqpTn X-Gm-Gg: ASbGncuUAKDooXdmVHiUuJ7CHAcoRTICwCwEMDL81yb8lhFOpPIUCSFqqAoy+aeuDiL nKUJDTwlpeQVot88Ek1V604A7sZBad1PGHWzaohkHep30v+o3fWcAj7aKYg6CtY1X7YRd9rjDyD 39dhasnzGPoGlo/68oh0Nfc2XTKhiUQdzkycqLu7xSlCH8ZIq2E42FEjkJN9q1WNR+nC6EcSvVg Q3ASQGOwahiMwJhfSIcjyfZC0nkPO24t84x9ydZoO8gxkda3qc3EVdk8RVDwHzPH400XMJxmKg5 VDVPHdEiT7YXajibgcKkCkjq122LmxQiZoY8lGRABxM= X-Google-Smtp-Source: AGHT+IEA8yLhpHzDWjatXgDyinVX0Lpz5abZAJlFq+1cN7NEeFsiJwzy35+xYSdJC0T1I1JTUbAr+Q== X-Received: by 2002:a05:6902:1682:b0:e5a:ca6b:4531 with SMTP id 3f1490d57ef6-e60b2e9a4d2mr20720874276.12.1741039000158; Mon, 03 Mar 2025 13:56:40 -0800 (PST) Received: from localhost ([2a03:2880:25ff:5::]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e60a3a42594sm3315506276.31.2025.03.03.13.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 13:56:39 -0800 (PST) From: Joshua Hahn To: Honggyu Kim Cc: gourry@gourry.net, harry.yoo@oracle.com, ying.huang@linux.alibaba.com, kernel_team@skhynix.com, gregkh@linuxfoundation.org, rakie.kim@sk.com, akpm@linux-foundation.org, rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com, yunjeong.mun@sk.com Subject: Re: [PATCH 2/2 v6] mm/mempolicy: Don't create weight sysfs for memoryless nodes Date: Mon, 3 Mar 2025 13:56:36 -0800 Message-ID: <20250303215638.317539-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: eriqdqmj18qp4h9txprw4t5qjjdew9zq X-Rspamd-Queue-Id: A529B80004 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741039001-842583 X-HE-Meta: U2FsdGVkX1/RVKdqZRfX3EO4MVnqgQmvlmdU1NgG0iu1CIGgYKYRM71Gi+LjdnxLMM6/MVnFxSPNPdDynrs7l3o94tJFeCJSZ6oJyPoGvutkzQQHb6wOPPkSarPpLs2PV410PKWxQtvnWQV3jyTOAPNFHwQwgDz2W0yIffGGZSiSGv+0iKWjHCRkZkAsU+nTD68hXBt2XK9iPcqAbt+eoE6S5Omq+Y915hNTIw5WaO8vE3DC4ES/w/jY0lL3QKIncMrqL3MWGFRN+oNaArhcj1DM5Z0qBfgAhH89Kv7RORgjhEg2IJQ8M2W3gkCCOqVyYtldpw7kALjvx0PBAY5YZ10C2EGTTIVddsLzsfr0vQZxdoGAdCcOMQUYJp3QGuCzpizf8Cdb871uukaCkK5VRmsQfSfRJa8LAQ0dmsOIFcIPyDXvvbx6AybOovP9c8xCZzReRFntpx3T4LTN+yKJzS8TLblFVb91IgTmwKthBGXJnjOg/7Vm2kxO5OFD+YreF757Xy04lWSgyX57kR3jD/mFz+37HiVxwSNv3eHZgGTUD5AgdHSaZFaho8QgigiZSGbPEiEjJr02e0T9u935/wXFFs5M0zDBfjQYz4itJeMpanD3eFnpZrnMSgaygwXsYMzr+g7nM8EkXxYhLardT9L7wM6RzcVoxJdeX6ethuK/qGpYel4D5txh/CTKasAod8mnsxzzpU8ovuhOlMxZ1E2ImR5PJvf95kBePPPZbuOwFovFx8CzsqrgMyDZ9bgmqfqVDi00Y4r/JP6C5eXKSRUiZQ/gNyaeDF9Sckz6ia30ZByfYVVfEp+hPu+EkbINR0UB0LwzIiYGDs4cg4TBB6sIEj91S1aRlYPhIGHUqj7K8XdebatQdLwVflTKdUBXqWfSCh7UdZx1QM5NJ3nmvPBo7IeSfRgL8yl6R0m/fotcmHeFfgkMClFgYAVh5JVx5fL1xS9Ytza0D7zYG36 O6bbwbfy DFZ9cIpxOkDNckvwVABucIJCC4o3Eu+nYmE9POPQqDMSTYwbreVgbfK73NG1MpYoHpku5kyLtnZAd13dzKUnxVThloZIRp0f1XlS6ZffNAub3OqYuyHpyrAzwXuLE2TIiLvUexoZ54gbYPRGy/4kkq0klz9eoY68vcBNJRC7PJe0crcbAMoDDS6MvBEFyuHmyH2G38+IC8v/RABzB9/D20Iacj90jYr+IrQN700gqLO72+seabkZTUb/NFcFARJ5P6C8jJXIattTAv/+SHam+1UNPoxG1yYofO966An+9Kut4GXu5hCnUDFtaGm4QpXaDb1SPG9k0huWz18E5/TAE9KUlo6CMjQejhUO+KBsGGGuNoQOQyE4eW9gmBzvi+AqR2KI/24IfrSw4ThpKRoGkPFsLHVqNdrWfk4TeVf3R2J2V5O0iB3aD+Ku9FfPMA9pwzN3u2cDxLHkNipdRm2ktLOjppDMBDqpi+mq+k9LCRb/dYdGNFdx/+obEBiD07WjfTd/ltvS3YJ9Vtzi8wm5M0kvvkdsy5rmL8leKMgbBng9w/Qi6uSzHqrRSXcTRIGHjHZmFLzCpEunANLQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 27 Feb 2025 12:20:03 +0900 Honggyu Kim wrote: Hi Honggyu, thank you for taking time to review my patch, as always! I thought I had sent this, but it seems like it was left in my draft without being sent. I will follow Gregory's advice and we will drop the patch from this series, and send the first patch only (with Yunjeong's changes). Thanks again! > > On 2/27/2025 11:32 AM, Honggyu Kim wrote: > > Hi Joshua, > > > > On 2/27/2025 6:35 AM, Joshua Hahn wrote: > >> We should never try to allocate memory from a memoryless node. Creating a > >> sysfs knob to control its weighted interleave weight does not make sense, > >> and can be unsafe. > >> > >> Only create weighted interleave weight knobs for nodes with memory. > >> > >> Signed-off-by: Joshua Hahn > >> --- > >>   mm/mempolicy.c | 2 +- > >>   1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/mm/mempolicy.c b/mm/mempolicy.c > >> index 4cc04ff8f12c..50cbb7c047fa 100644 > >> --- a/mm/mempolicy.c > >> +++ b/mm/mempolicy.c > >> @@ -3721,7 +3721,7 @@ static int add_weighted_interleave_group(struct > >> kobject *root_kobj) > >>           return err; > >>       } > >> -    for_each_node_state(nid, N_POSSIBLE) { > > > > Actually, we're aware of this issue and currently trying to fix this. > > In our system, we've attached 4ch of CXL memory for each socket as > > follows. > > > >         node0             node1 > >       +-------+   UPI   +-------+ > >       | CPU 0 |-+-----+-| CPU 1 | > >       +-------+         +-------+ > >       | DRAM0 |         | DRAM1 | > >       +---+---+         +---+---+ > >           |                 | > >       +---+---+         +---+---+ > >       | CXL 0 |         | CXL 4 | > >       +---+---+         +---+---+ > >       | CXL 1 |         | CXL 5 | > >       +---+---+         +---+---+ > >       | CXL 2 |         | CXL 6 | > >       +---+---+         +---+---+ > >       | CXL 3 |         | CXL 7 | > >       +---+---+         +---+---+ > >         node2             node3 > > > > The 4ch of CXL memory are detected as a single NUMA node in each socket, > > but it shows as follows with the current N_POSSIBLE loop. > > > > $ ls /sys/kernel/mm/mempolicy/weighted_interleave/ > > node0 node1 node2 node3 node4 node5 > > node6 node7 node8 node9 node10 node11 I see. For my education, would you mind explaining how the numbering works here? I am not very familiar with this setup, and not sure how you would figure out what node is which, just by looking at the numbering. > >> +    for_each_node_state(nid, N_MEMORY) { > > Thinking it again, we can leave it as a separate patch but add our patch > on top of it. That sounds good to me. > The only concern I have is having only N_MEMORY patch hides weight > setting knobs for CXL memory and it makes there is no way to set weight > values to CXL memory in my system. You can use weighted interleave auto-tuning : -) In all seriousness, this makes sense. It seems pretty problematic that the knobs aren't created for the CXL channels, and I'm not sure that hiding it is the correct approach here (it was not my intent, either). > IMHO, this and our patch is better to be submitted together. That sounds good. We can hold off on this patch then, and just consider the first patch of this series. Thank you for letting me know! Thank you for always reviewing my patches. Have a great day! Joshua Sent using hkml (https://github.com/sjp38/hackermail)