From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A47C2C021B8 for ; Tue, 4 Mar 2025 04:08:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09EC56B0082; Mon, 3 Mar 2025 23:08:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04DE46B0083; Mon, 3 Mar 2025 23:08:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7E4A6B0085; Mon, 3 Mar 2025 23:08:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C95676B0082 for ; Mon, 3 Mar 2025 23:08:20 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4C0D0C147D for ; Tue, 4 Mar 2025 04:08:20 +0000 (UTC) X-FDA: 83182536360.07.7348166 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 95021A0019 for ; Tue, 4 Mar 2025 04:08:18 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=SvBh6xKu; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741061298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZGZG2B6v8MKwl/nSJ0KoqWQ0hady/U7PdPhgWJxR0Ws=; b=Y4AQZR8K3aPdoh0A11U+8FR7aDvAmcft43FpDEbdrV/tzcrJdhQVfDNdHCM8p/i/pY4D3A cgL1uLblA63r3a6yWTja2BFfQbMT39aXszE886iu0tPrsyDywZ/1uR3+L91wLQUXNYpDRK ia8UlgODU8/33KNalCYoBDTrt6m6bvA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741061298; a=rsa-sha256; cv=none; b=rwKSCJ5aylTymbTHYYmyExDAxHWuWWuP7jGYjVMNHXG8Q36ImPkmZ6l7QY56J7gqFAedK9 Ek2z7Zc33h+hB325G53orpJyREBaBXje3z1uvwS3dhYU+XuPl25QBDKBD/0YGPOsTpwZx2 Snbw5L2dK2MW3jCk03oIVe0Sc+2T1X0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=SvBh6xKu; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A050B5C546A; Tue, 4 Mar 2025 04:06:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 356E8C4CEE7; Tue, 4 Mar 2025 04:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741061297; bh=OJc+K+BY2l6V5qT9+IgOwiKvV4q44ADIwUlWFtnBRCQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SvBh6xKua0O4rbGl5Th2h893FxX7s75aMSK/CI6eO1DqDbPVeGxH+L5gTK/tJ4vje QLYaFB944eCWG2oj9FNuFYy6/4EahBL+GAxWOzP5wMTbXrh24P5KHR5JL+N97R06cN 9W9X6UKdyRcG1D0ubqQLtWnF+VBx6UkJKFwVkdEY= Date: Mon, 3 Mar 2025 20:08:15 -0800 From: Andrew Morton To: Qi Zheng Cc: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Geert Uytterhoeven Subject: Re: [PATCH v2 3/6 update] mm: pgtable: convert some architectures to use tlb_remove_ptdesc() Message-Id: <20250303200815.53007fb79e5049a99f24c999@linux-foundation.org> In-Reply-To: References: <19db3e8673b67bad2f1df1ab37f1c89d99eacfea.1740454179.git.zhengqi.arch@bytedance.com> <20250303072603.45423-1-zhengqi.arch@bytedance.com> <20250303155331.de9b2fff9b04984a255a7bc2@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Stat-Signature: 5rcw9zi4mhhnmuugnp6zbuskajkp3jad X-Rspamd-Queue-Id: 95021A0019 X-Rspam-User: X-HE-Tag: 1741061298-419246 X-HE-Meta: U2FsdGVkX1/0bGpapa6GYOqZ26DdIvCstJApTQaFn8wSo9BpYLwZ5CO6NX4B1YPgejN/eW9sNa2vsSbbzJ6rTvZ6nq8tTI4LEoCPrkAA0dJFetpeBonB5XGModP1dmb1vXETPTXruaw3z+PnIlxZUlhuutoSkaGU3qYAA3yEMxWb7bkt7r/A2FtT+JibXFksA7cgN3TeZKpJwzuufLS6cGjDEgtRzFuIfxV7Ahd5zIsN/QxvLGKZI7evrC2tNSYTuSjNNwmf65QXXvU1sjXXumoaCuFpPr5hYTzVq8j2ujXaXI4lePb9/vDT2ecfJn9oG27q9rQt9sHhQo9Jah7r2V/lqsoT+t7A3Bajm39XkuPz2lux/GuvAilKDhHQLkRN4Ph6G824aox78ekk7UCzTSt5wyIrEBFvuofktBFriL9OVaHrK13mV8fX5jdHUSaBOEehvIDo/365Y/l+y7nebX+RcUYwf86fnLYFD+er2zRgRT8B416WoHQIJ6emFmf12aNGXLV8X1DdKkMEVVPRe44MlAGoMB/xkvRWPgru952LR8VuTyCQr/EJOPJ7paCbQNAU5L0XXxra6Y8rFojQHEtpE8ZY8PTCs/LCf9u1u13OmQC4z3luJde8J0eIs94pEbKuSQjCq5RIJZR2H8mUsiwpvyy0NluqCmWW+htw7cCSnkAZ/RGYmctzzR/iuUBSJTHx0CgSaeQ4so0CxPak/8XPq4z9IreNdhPCLDz1V/+dG11z6/v9wjiuogT5c8d7E6231uAK+g5DOaivQPckTqw8WADIamy6GU8WwGrbGq8GoF0UJO5upcskkOkqJxCEeWPD1imWwT5VNPhC+Eq5vtgdbGG3592p1Gd7sQ4FRZOKDSrlg1VTP6mwKPa524cAChkugjnep0/B2uiSuCf2CITBvFgizaAtmt4NBjjJ1kX4Ts+t4pbiMMj+SXSHx/V1DzQ3+PmVpgkhSEvQp3r BY2B7yE6 OnNu5prDypfvE5VPWbK5Eq0uYs43zJp8jJMGP+HybSy4RS5HEfBbroNRfyjhFytDiDvoD5tmRCnPyz7Vs6g/XLUwasSJxZMypgNzyy/bb7eT4NF6SPGzIKdJLJywN2ZciI3O38N6tZTsUFIqgyu6Mj+bedIhNBXz7G8j1BRRnv2JEkhpeIi9lUaOOvsLwfHxJsYbDZ5IOJI/OVjwrWW7etCVD2KDyj1o4+F1pLloqVr5dcpco8IGX9huq54+qoOEj6rxIE6dgOFXoWSi3jgQm8MD9C/hssPvpaLJlo0hZZcWgJuU0utLnhQUmVGHyWEIYJixD369PJfIdwnpoLw9dOUkxbVC3julCsZhz79fgeu1e3f/PCocjrHy/RuDerH5QASpRlizgCva8AtU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 4 Mar 2025 10:31:07 +0800 Qi Zheng wrote: > > > On 3/4/25 7:53 AM, Andrew Morton wrote: > > On Mon, 3 Mar 2025 15:26:03 +0800 Qi Zheng wrote: > > > >> Now, the nine architectures of csky, hexagon, loongarch, m68k, mips, > >> nios2, openrisc, sh and um do not select CONFIG_MMU_GATHER_RCU_TABLE_FREE, > >> and just call pagetable_dtor() + tlb_remove_page_ptdesc() (the wrapper of > >> tlb_remove_page()). This is the same as the implementation of > >> tlb_remove_{ptdesc|table}() under !CONFIG_MMU_GATHER_TABLE_FREE, so > >> convert these architectures to use tlb_remove_ptdesc(). > >> > > > > checkpatch warns. > > > > Do these things have to be macros? Switching to static inline fixes > > the unused-arg warning in a nice fashion. > > This can be switched to static inline. In addition, I found that alpha, > arc, microblaze, parisc, sparc32 and xtensa also have the unused-arg > issue. Do I need to add a new patch to fix all of them, or just fix the > newly added 11 warnings? I guess leave things as they are now. Switching all these to C functions can be addressed at a later time?