From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B38BC282C6 for ; Tue, 4 Mar 2025 00:47:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CABB76B0082; Mon, 3 Mar 2025 19:47:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5A626B0083; Mon, 3 Mar 2025 19:47:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B48A46B0085; Mon, 3 Mar 2025 19:47:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 956676B0082 for ; Mon, 3 Mar 2025 19:47:20 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0B7FA141187 for ; Tue, 4 Mar 2025 00:47:20 +0000 (UTC) X-FDA: 83182029840.29.1589768 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id 55A24C0011 for ; Tue, 4 Mar 2025 00:47:18 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="zrvda/Qj"; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741049238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Fg2TCx28PtwVZUfPE9wgol8ICeIzAASpO5CSq4AMHA=; b=YZimxpsEPNtJ+X7U1YgHYJmRTl44kQo32nYChQfCWNIhF/J84OzjfQMQKlKPtjQGGa6AeZ rzZ7IG2utEshp+Er/nHwSXTAk7qGVAdnMwm7oJvMX7mnvf8PkDBCSIJoBUJuGDy4/vQaa1 xQziwL3KG8ICkcEwKTCxMkqkoWR9fgc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="zrvda/Qj"; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741049238; a=rsa-sha256; cv=none; b=6C3GYzWoLq/OlQjzkiRbediuoSWbDnAQTCFFsdRVwkI3UhHtAwnePobl0nETvZQis7r7dL pU00/UpC55esmuD+nqDhKYgC43R9bAvYafBfRumSZjSeAgWB3LbBYlHkwzgD4Okq/ALuA2 FVk/2/uCqMHWZXTIhUcpk+pGLHD6ccM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D0129A451DA; Tue, 4 Mar 2025 00:41:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4259DC4CEE4; Tue, 4 Mar 2025 00:47:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741049237; bh=76/XWDwZVHvJ8/uhNZJfs1uJ4fJJCpM1IBiy8YtPoDc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zrvda/QjpPuS9xFpjoOhceLjGVlk5T/cG+UzBELZuiUgQWtHCt13x60up1sQVimL2 EFzSlWNBQwWZI/0gFDPpOcudMxMeYFbM9/eqkPQaMXSzR3ViF3nCW/bkyvo6mu3E1s 3O4n2GlRRsKAu6xV30o1SnK/LHPq+9YPFO2aUMTM= Date: Mon, 3 Mar 2025 16:47:16 -0800 From: Andrew Morton To: Liu Ye Cc: urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: Move free_vm_area(area) from the __vmalloc_area_node function to the __vmalloc_node_range_noprof function Message-Id: <20250303164716.a98b1e3ceb27a264b57a56d7@linux-foundation.org> In-Reply-To: <20250303015702.319416-1-liuye@kylinos.cn> References: <20250303015702.319416-1-liuye@kylinos.cn> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: s5kdn746uujsroaa4a489wdrfuamwioh X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 55A24C0011 X-Rspam-User: X-HE-Tag: 1741049238-600620 X-HE-Meta: U2FsdGVkX18QS4Z5Q915NTYjSLBNfSXh7b3NcqipLHS+H06bkUsoXCRJ8RV4+qrbSVmr2NdxJ/Go2GmyCzYNp49VYRUN4i0JQCPVhaR9mvtFbcVTlc3WYvu0hvHfGM+KakOTJNhZex2EAsPesA9GPIadTLZ/zct9PrdVeTyfaZ0ftQ7g2u45xkVEesggnhedEKvBzj/hZ5wR8YnR4Cum+pR6blCgrk5Yvd7Vriv00w3EuKIKkicQkSumslktcMCUjIJfycnC/tWs33RoKX17LOmzDXTMWxNKuv1hKv+Jqxcx983svJnV4CAdf02QuEH6pO5x3hwyGKHwVmJ2ihksRjAZY8idIIX0nW3su6wihvtcCEC0mK4quWSbYYpeoB1Q1mYkylKcbV7vID1HLCguQPUW6mDfsyUsnN8hunfwr3TOxcQuC7pZcB2BkNvaNr/2YC+21i8zoTrNC6hyRMqgQsif11c4ESfivynINpNSkreFrbIKMvIdOeZD9vac5AzII9u83ZNxsVQ1d2jXzK2NEGDmJk08Eu0xYCIAPwzEaPSWx7zpKwOM7HXGmMai8NRMmo/OEbVMxH8dn6bugIGI/Z3HuYXMntIuB5Dwqjcoqci4WYfu8uqaiWzRcxvwVFkVG+P7dD56N8z0AcfpTDSv1wHn8EH0/x39t9mEvf09m0hwoeatUE0rj0qK6UN01IvDlvSSFrz8LwkWccGvwKE5p+8L76WENj3XcoS3MNcp84rt0bNyAVGPNlU76/PGKwI5PEVvi/jdB0r+M4RuexDjQNVRunm4UizF93rtmhAAZHz2a2n65CmNVErAiswgFNB5K+4mD4tXR6ma5IbVbUsUT8lL+LembeBGkwV6wbDOBoBnwlpisXaVirNCAoBoBscFo7LsrpFBK26OF7iz2GxIvd0qMbR8pJ7YS7I0JZ3tqUlP97wlNeddEqx5Hq/s16tOJ3Hoi51HtfGHjTc3b9/ bJmT+3hQ Rm6HcHFqDXZUhwjTdy3JYuy/n1g0TyNIDrrZmh9U3bKy3ERhqsX029+jObKLFNj5VbaFXY9jebGZuB5HWGYge/xu6sswZqYdPynlV6kT4WuTobwn250e9BM2cnySeYYaZ2K4MkR5bmsKDi8GEsPyiAufRlPiaXSb1iAyXMfvksw+Tvirlqw42io/T2AduDZvqBYFKpE6emvbTvwvrYeMY03qfofoYiLhKSLYcXtYdD93me9+xeJqHL3WfvQUop9uI/5EFudTp6zRdVeeET8u+iyydeWabMYXjfkDPfAqWcVJrIxQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 3 Mar 2025 09:57:02 +0800 Liu Ye wrote: > Moved free_vm_area from the __vmalloc_area_node function to the > __vmalloc_node_range_noprof function so that allocation and freeing > of the area can be paired in one function for better readability. > > ... > > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3651,7 +3651,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > warn_alloc(gfp_mask, NULL, > "vmalloc error: size %lu, failed to allocated page array size %lu", > nr_small_pages * PAGE_SIZE, array_size); > - free_vm_area(area); > return NULL; > } > > @@ -3844,8 +3843,10 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, > > /* Allocate physical pages and map them into vmalloc space. */ > ret = __vmalloc_area_node(area, gfp_mask, prot, shift, node); > - if (!ret) > + if (!ret) { > + free_vm_area(area); > goto fail; > + } > > /* > * Mark the pages as accessible, now that they are mapped. yes, nicer to free it at the level where it was allocated.