From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB837C282CD for ; Mon, 3 Mar 2025 16:31:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C489628000A; Mon, 3 Mar 2025 11:30:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD8D428000B; Mon, 3 Mar 2025 11:30:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1E7428000A; Mon, 3 Mar 2025 11:30:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 84A59280003 for ; Mon, 3 Mar 2025 11:30:59 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2A0B5A4960 for ; Mon, 3 Mar 2025 16:30:59 +0000 (UTC) X-FDA: 83180779038.26.C4AEFDD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 652CC12001C for ; Mon, 3 Mar 2025 16:30:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XSZM7zAo; spf=pass (imf29.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741019456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VusPlBbKEOGpL4wS1BqoWY6CYb2f4HQ+/wIDh8p+vAo=; b=yMkYgzxTzm4+1WN9ojWZ0wUvOYB1bL10bna7QN6dF3YlYMfaMZXe6DRw6uh11ihhF7+ya7 OtogA1Fq5chE4bQqJhlMf2c5870dLJ0OBzvoOeL5wgIFCkrk+vIyusqKMm+p5ALQUAvXHU nyVU0N9xYTeQiNEHqnWb0q8zZZsxxrU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741019456; a=rsa-sha256; cv=none; b=CIZ1lVgh+9lI3CDPSVdOhdBgUz1OtPWEEwviBTw6n7Qe+1L5kAGPtJGR3GLgxcfeUUHuwI 0RaT7R5pXs5eyMsjyBrLVSa0BAG6SGwPCnjyV3oHhKpyLGqXW3Sub2zpdLM98JC2D1VXFC 0Z3CyeaBLzsCqWSMfsb7XHWzIWK/rog= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XSZM7zAo; spf=pass (imf29.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741019455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VusPlBbKEOGpL4wS1BqoWY6CYb2f4HQ+/wIDh8p+vAo=; b=XSZM7zAojUVklKQobu24Roi8FXCvTmnmvssa7yGdJ4e0Vq8BnVpMqM0Ufe4yPGo93qX3oX huwYfbzZq9VycY1yFq/5oVKQjfJFTP/8YUUX8VRU220c8FeQgEG9B+kiVFk67n/1DErPzS tBj9rJjmFRiRgexl0FBfI84eqUvjC7Q= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-JXO8oKebOxGKcpxyjxJJww-1; Mon, 03 Mar 2025 11:30:43 -0500 X-MC-Unique: JXO8oKebOxGKcpxyjxJJww-1 X-Mimecast-MFC-AGG-ID: JXO8oKebOxGKcpxyjxJJww_1741019441 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4394040fea1so22860935e9.0 for ; Mon, 03 Mar 2025 08:30:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741019441; x=1741624241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VusPlBbKEOGpL4wS1BqoWY6CYb2f4HQ+/wIDh8p+vAo=; b=AxxItoQf4O2bth1G79Le1EPivqRXbrIkvUqSLxzZ1Gf7F0LvcOrL7/jCDWkvNemWrz bNCgn8bHQA2s0vYU8NIzLH02P6ZENdRREAH8O98g13OIC6BOE+2iHtCXZFUDE/NAODMe fpYzoKnMOd3x1Nhaqce3VsgP/OvSSl0Ds7kOlKoHvL/BKcKWM/MBSbSz9AEIABXXnGgK yD9H1OG4l2HR3N3N9ct4pj1H67TAV6q3SY1N3tzVBFmJpasVH+vPMaadpfCRWVxM0Jc7 3tBFaGsETqqRu0uvKmXJNovTJyV37Tbr2eLWEFvv9qxZ7cR70ZMJA6QpULfKgSVcQ0UW HO+Q== X-Forwarded-Encrypted: i=1; AJvYcCV7D1k/LAheymbLmcKesVkHY7c5FRJd41Sgx78LWuRS1CyXo2Dkcq+nH1TOwvZefpb3xq8OOokYgQ==@kvack.org X-Gm-Message-State: AOJu0YyMBcF2RmDpyt5MDOBTpoN9japlzRw1mal+IbHRbfmheHs4Gqvm wTtKfvRk/6GzftbYnUAgcgDncvG19XJgu24UCxNtNGRPAA0sIXvmSSxKqqvpw2xdcn3CfCC8ggf DVrdaQGOerA+V1gZN8aL0QaMjRtYmAvcEVTFg3Q/6uvw83tR6 X-Gm-Gg: ASbGnctpdVBRmILQQh8qHWDjzw7PJgIEJyJLjgfsEfDY/lRmAOWSEqTWHO/v3or8VVX AkG4IUHp4aWZSUpR3Ip/8xUc7DTmqi/9eBli+mLe/tlumBvtM4CK9ECYygbFueYoJFcVjdptNw7 +G20YGeMtuq13ADLxqxZhNkI8Z99N5CmJ4ogJq+pY2mXM7hgG1SrEaaQUSgWAt3zx1ZsiRANsMi ceiwezXJmf7whxzkta5qUDG+zLsm27dvmdUFu0CRyYbg5GeNnw9K/Y+YKSvm9myekaG3eXmdtmi Xn1ti0JC0UBnsp2+4gZtNW3fQXD4gJDimySyN5KtDOvXPcONorXQTJlco+Y4wOjKZoqc27OYLJK y X-Received: by 2002:a05:600c:26c6:b0:43b:bb72:1dce with SMTP id 5b1f17b1804b1-43bbb721f8fmr44417465e9.5.1741019441213; Mon, 03 Mar 2025 08:30:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6XV9dtRCnC9UYnKtk79gh146334CB5ZefECKJp7wi6xxTybGeqstnFZTU3vfWQysm8+TPqw== X-Received: by 2002:a05:600c:26c6:b0:43b:bb72:1dce with SMTP id 5b1f17b1804b1-43bbb721f8fmr44417035e9.5.1741019440886; Mon, 03 Mar 2025 08:30:40 -0800 (PST) Received: from localhost (p200300cbc7349600af274326a2162bfb.dip0.t-ipconnect.de. [2003:cb:c734:9600:af27:4326:a216:2bfb]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43bc1b5db02sm42954325e9.19.2025.03.03.08.30.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 08:30:40 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, David Hildenbrand , Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Muchun Song , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn Subject: [PATCH v3 10/20] bit_spinlock: __always_inline (un)lock functions Date: Mon, 3 Mar 2025 17:30:03 +0100 Message-ID: <20250303163014.1128035-11-david@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250303163014.1128035-1-david@redhat.com> References: <20250303163014.1128035-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WfXq_G-NjpfCPZUoj38iuCHt0Sr_fLRiLdFxruyTCyc_1741019441 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Stat-Signature: wozgmhac4reu8p857d37wbsp5ws6cgbw X-Rspamd-Queue-Id: 652CC12001C X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741019456-965292 X-HE-Meta: U2FsdGVkX19M+jfzkQbWei+BrWxJ6xPWzq6ManR67ngldllUtGO+yclnpvOyjg2urmgzWq/ERCjayoZJC8HyPFIaWOXSYsw7E37D9g+bb17k8iTGXHDEzSzgzOCnvpWOctoZI1hI7CtvlgG9xbYC2ZoWdnpy7l2gavq7LkaqOaPhbbkN1jnLOXcb8ZDuOJGnDam5B89rVzeETcAgVaUPAVDpDIh0tMHUfoYf/zfiyvKVhDYpjj4r/7ZeUlJ7etksjfEQ0bKiRt/0wtfxMAhSaqWi8+X413TY3jhnfvpMkozjn+52+wWcUw3b82RIh3f2QnnGUYOHzzcKiPfu/fifZSZkvthfpZ1tifiDkVRaSnvoCOi39nel+wcjma7FS+W25CWvlWrJ53EAxvv3gv7QGOm+M4UDYDDooLTurkgMIeiUvSLIkNinYXskp5Y4VbgGPQHWkBsbj4zVGRAZg41kvSn6mshPbXVIzllRUadt9ZEY08cGflWBs4x2LlpIMe8QL/TVgfJI6XRC96zIeWoh9TPFvP0HzEmJJdagG/tGwaeEEuYdw1cMcA3wsZ+EqhHFkcBbiPtL4bFAAMo/JvoQdKxz4izNgzqArIbHVvZAIMcQBsApJOfsZIbPfO02GrYYrOzpvqUwg+h89r1paqFk1jWm2XMsXei2G99II8fH427BCRw+LLiZIPo7AC692c7ml+jTIc4FbW99CW6h6bCSsfQ8rJaUBbOBs+ZnU/BX9b0jO6Ykmsu2cxeFhoRoBe2R48/7HdTtOP9AtEDg2gTsKn2Xi2xXCnzqW8NIcg1tJQjjT39eedeB63rMbHUuT+f3oQMgi+84ukzC26Yvs290rOPlQ6F6OW2nAmRZAui/FbYHuPbyMymo6tHDoM0pBnKpn3foAXNETvkmakQlrSze9QDBH0gEKCuY1vGZckoGdQKjekmKoR9NyamgBapVWMpZJJ3e0Lj2tbpHf8rPRn9 df2OELFe 2moKll14EvbK9jivXOz22933uBFVsuMDLOjokBdoB6Cj5gD85CbIOJuyxBgJUePTimNIKeCG8Wu9tXItOSi9HE2TqSO7yQFFR76bjywiJgdbVwqLGQaYtdcLsg87oy1z1M0OGl0Fm0ceE4lAI6vpQ7XSCtdeFmNEpsTbqi3U6O+0U6LW5suPYFm1JTsi1+GVf+H8/kCvzxBMnaFicd1IWghyodHauc8FdBuMr2qvOTi6sTl3VPGPw+2IgNjiEQvI+djw8P7vw9BPVhGt0v7U/XEKkMgYUs7Xf321S0CYp94kFeCvok01Tjf7Wk6lMIbncnnT7mN8VXZhBxRbDNUfHQi+gNWWQ9UKsQBgDuYoJi+3T1kJ1JQGgW+8ZVhdMa8Gw//hqQZ23x9vn9ETIG9pmxEaZLUQvnVuO3QgnPCKNIykORi44s4+Sl0uzWdtV8A+T+/+4cyqjw/MQQjJM7I7/L+piEtEYENOGfOPguExRCibyorXFTs0rBE/nQeIru6ySijBPNXbXyJpLONQYGqEbL35mxg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The compiler might decide that it is a smart idea to not inline bit_spin_lock(), primarily when a couple of functions in the same file end up calling it. Especially when used in RMAP map/unmap code next, the compiler sometimes decides to not inline, which is then observable in some micro-benchmarks. Let's simply flag all lock/unlock functions as __always_inline; arch_test_and_set_bit_lock() and friends are already tagged like that (but not test_and_set_bit_lock() for some reason). If ever a problem, we could split it into a fast and a slow path, and only force the fast path to be inlined. But there is nothing particularly "big" here. Signed-off-by: David Hildenbrand --- include/linux/bit_spinlock.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/bit_spinlock.h b/include/linux/bit_spinlock.h index bbc4730a6505c..c0989b5b0407f 100644 --- a/include/linux/bit_spinlock.h +++ b/include/linux/bit_spinlock.h @@ -13,7 +13,7 @@ * Don't use this unless you really need to: spin_lock() and spin_unlock() * are significantly faster. */ -static inline void bit_spin_lock(int bitnum, unsigned long *addr) +static __always_inline void bit_spin_lock(int bitnum, unsigned long *addr) { /* * Assuming the lock is uncontended, this never enters @@ -38,7 +38,7 @@ static inline void bit_spin_lock(int bitnum, unsigned long *addr) /* * Return true if it was acquired */ -static inline int bit_spin_trylock(int bitnum, unsigned long *addr) +static __always_inline int bit_spin_trylock(int bitnum, unsigned long *addr) { preempt_disable(); #if defined(CONFIG_SMP) || defined(CONFIG_DEBUG_SPINLOCK) @@ -54,7 +54,7 @@ static inline int bit_spin_trylock(int bitnum, unsigned long *addr) /* * bit-based spin_unlock() */ -static inline void bit_spin_unlock(int bitnum, unsigned long *addr) +static __always_inline void bit_spin_unlock(int bitnum, unsigned long *addr) { #ifdef CONFIG_DEBUG_SPINLOCK BUG_ON(!test_bit(bitnum, addr)); @@ -71,7 +71,7 @@ static inline void bit_spin_unlock(int bitnum, unsigned long *addr) * non-atomic version, which can be used eg. if the bit lock itself is * protecting the rest of the flags in the word. */ -static inline void __bit_spin_unlock(int bitnum, unsigned long *addr) +static __always_inline void __bit_spin_unlock(int bitnum, unsigned long *addr) { #ifdef CONFIG_DEBUG_SPINLOCK BUG_ON(!test_bit(bitnum, addr)); -- 2.48.1