From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8F7C282C6 for ; Tue, 4 Mar 2025 00:13:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 588316B0082; Mon, 3 Mar 2025 19:13:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 538B46B0083; Mon, 3 Mar 2025 19:13:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FFD16B0088; Mon, 3 Mar 2025 19:13:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2346F6B0082 for ; Mon, 3 Mar 2025 19:13:01 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CBA1DA50A2 for ; Tue, 4 Mar 2025 00:13:00 +0000 (UTC) X-FDA: 83181943320.28.2B2F527 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf14.hostedemail.com (Postfix) with ESMTP id 1994310000F for ; Tue, 4 Mar 2025 00:12:58 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1bhucTTg; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741047179; a=rsa-sha256; cv=none; b=vTSLw/zWClAXr4TGfNtvGH5wY6QN9rrGYEH3BePeIMUGurgZ2scQzwOGJlG8XaXjGL67J7 P80N3RTL77MvDrDU4BEftfwG2bnEt6v4wou2lY1PeHQC6JuYoAAvuuYIcRpyJyXmlXoyVr /GgU0JEi00OtYAdFajXclUGwGdHiWws= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1bhucTTg; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741047179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1lBP4VYQjuOEn0IAoSavZcxjFJ0tcvmyTB0P/DLE3Kw=; b=F4OL1k2s17wc5bw966X8aG7DQJbg0vYi9t3IUTu8pIu02jWrjuOeijyUk5iNJhr4A2yguJ gwJfMP0/+qwKkMyMdVuh3VgoN0uuj+hE5sMf+tg0e+pCxPYIOgB786QKRBPQmrG+FHAbHX 0egjfF0blcmNRuAW4xycEgJ98RAmNyw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 6080CA45181; Tue, 4 Mar 2025 00:07:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB7EDC4CEE4; Tue, 4 Mar 2025 00:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741047178; bh=+A2vHnPtDGgHYWfp6Vrd79SQ/a3Q5kR6CC2TqhmwZH0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1bhucTTgI9r5/CUvJVKJDXNqto5VgtoBD7h6knps8SqLHWdDMfm2CRuiuCoqwxFpE VLr594BI1UkWlMwXJqMyUv1t6XqovD8j1x/dVydnGDOMFmIKtWIYRa4qT4EfMNEItv I+077K1Kip/GG/+XNc4UycHU7+VuzEx6DhKu1VIw= Date: Mon, 3 Mar 2025 16:12:56 -0800 From: Andrew Morton To: Andrew Morton Cc: kernel test robot , Lorenzo Stoakes , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] mm/mremap: thread state through move page table operation Message-Id: <20250303161256.1c3d497ee525023d239d1c38@linux-foundation.org> In-Reply-To: <20250303160555.46915fd9f69ca13e1fe2c5f9@linux-foundation.org> References: <4cc18ebfc0cb32e9e42d86503cef3265108343e4.1740911247.git.lorenzo.stoakes@oracle.com> <202503040759.5zpJdC2i-lkp@intel.com> <20250303160555.46915fd9f69ca13e1fe2c5f9@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1994310000F X-Stat-Signature: h9r3yqrrtstq3gojewsrkpo37ypra1fn X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741047178-908931 X-HE-Meta: U2FsdGVkX19HG1oMnZ6cF/DjClAqSqKTrJMoTFCiQjirMwcAwvue4wZqQpW2aq46KUp13vI1EeovG8u/YyhmaFBdqEv3QHHQbpxAlYNBdkFuRpAjg57ORRQOLmMZNWmrvVIibsdkPfBqxqmPfq/5JhmKp3O5eNDx9gMvQx23NVpXAejtdYMpVPR0h3gA/j36wQyMXiHjiC1aVS90rRSDc5wtta0VZlxN3nSMRR6UOqt+qto4EGL6SqBV43J6s7GSCmmem3f17L1h/SQzSUEvCQQWrCDzTzVLQ3YDsncOHllHXe1UFT+Zx9mLxaQM9Vg4pssPxHAng0bxZxPaRXUS8sQqzVr9/r66jog7W/dXF98mRI0jqLRTfSs5LXHkOwsen+k1/uTiNivEPeHxbAWph+7ocloQZVNL7IeYhsHdxW3piS3aexRIgmSflVe6RCYMY11R0crxVkRF9UbvMunaqyTODFvU+PmHy0YuMoyG54ui3XeQ0NMnu564jwh20/r3YqFdpu8PkbVm7W68FyUMjWLNXEgO42NgFu7BVAvBGaCoEjYeQumgJxAJTB7waiScd+oYmEwf8S43MUjux3Uo3G6UhTs1AhCiR8G145tmK8KaFkc374hvNJQCbqhLOGFbUne2FhRpmqQE1fj+fL6hccturd4jzAl4R+e1EeuX91q869vf94/2SQD2koapFE0kFngV/u15AaM0fH0JhabbplC6J8zxlvIFmalJeqDt1T6xhm2AzJyBgrUFq2Dq1KmbStPKcwPJip9yHjrn4RKSugVyQRyfS2XlgIxAZqK0R7tJb4Wy6FTxWcQQrJFcAga7u85Z4HOTahvKZBYll4EzqFgP5Y9M6eixli3ZiiZzOXtuaXExHAxrqyZo98kmu7G9p69cEkiq33XoUV14BfMoVJJ09d8tQr1An1GqAEocStxLJpCqWaWw4ZPdF6SIxNBMfl21RvA7YbZB+179UCz /UJ8qEi0 K7uHZMMzc/sLBMjr5YdYv5Pz10seg2ppSdB55v3G40P0rv05ESDspL41zhiYD9AGNJRJm3dgHk+QPQ6vc6pT/Z2foauQEF/EMrcjNFT9KEhue7O1W1vQUq/yFug/BiaNCPTkHe1T234KIqIQ8lGyzMP/BJaIw85M7a0WljQbNbAc135U0QGFt64emJh5AKUlXMLuazvclI79LKblZdP4lVc/M1NQmsLwNuvEa2qBc6BVKAW2P9Vw+WsksLw5NciYYIl2eCeJN9Ku6EjyWMgnzDxsdAC28jEK3M+wjPM72K36WAqLe0br7SpNvXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 3 Mar 2025 16:05:55 -0800 Andrew Morton wrote: > --- a/mm/mremap.c~mm-mremap-thread-state-through-move-page-table-operation-fix > +++ a/mm/mremap.c > @@ -475,8 +475,9 @@ static bool move_huge_pud(struct pagetab > return true; > } > #else > -static bool move_huge_pud(struct vm_area_struct *vma, unsigned long old_addr, > - unsigned long new_addr, pud_t *old_pud, pud_t *new_pud) > +static bool move_huge_pud(struct pagetable_move_control *pmc, > + unsigned long old_addr, unsigned long new_addr, > + pud_t *old_pud, pud_t *new_pud) > { > WARN_ON_ONCE(1); > return false; err, --- a/mm/mremap.c~mm-mremap-thread-state-through-move-page-table-operation-fix +++ a/mm/mremap.c @@ -475,8 +475,8 @@ static bool move_huge_pud(struct pagetab return true; } #else -static bool move_huge_pud(struct vm_area_struct *vma, unsigned long old_addr, - unsigned long new_addr, pud_t *old_pud, pud_t *new_pud) +static bool move_huge_pud(struct pagetable_move_control *pmc, + pud_t *old_pud, pud_t *new_pud) { WARN_ON_ONCE(1); return false; _