From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61039C282C6 for ; Mon, 3 Mar 2025 23:53:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB1136B007B; Mon, 3 Mar 2025 18:53:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C61BF6B0082; Mon, 3 Mar 2025 18:53:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B293D6B0085; Mon, 3 Mar 2025 18:53:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 935306B007B for ; Mon, 3 Mar 2025 18:53:36 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1D5AD120EB0 for ; Mon, 3 Mar 2025 23:53:36 +0000 (UTC) X-FDA: 83181894432.14.6A7D1E6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 48956120007 for ; Mon, 3 Mar 2025 23:53:34 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iru1kz8e; dmarc=none; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741046014; a=rsa-sha256; cv=none; b=kr0aiTa/sGBnWoCXFOimEE9ALCx+IrRfHo63WlX7Luyd+vRAHtSnlbKYr/zfBJGxHk49UL OdG0qwZriBGzsbQcP5s7vx8tTt5+P6DHoogGKAoxX2FiKTTG6iFy0S8EcGOinuuPMJDWSy 5Hr0Eq74PJfHKlz8nLF0nk63oZ5tUww= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iru1kz8e; dmarc=none; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741046014; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vVAwml3WeV6QjnH3HyPii16QwOhdPQBqzVQhLi4KPGo=; b=EpjAAgmbo+boZnoFjFSLtLCf6j7QOygiNyK8JmqTjqBfb2NKuA4WyaPwbsNJsv1ir7iFX3 djiZU5JYBdp2mWKQA0A1ABBQor90847mH6rxueOb7BD7xgCmr/AyzfF2I5POOxlE1KPvDC EePiX3b2FgXUezUUTtx2Te0DMnDbbUg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 46AF55C496D; Mon, 3 Mar 2025 23:51:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0037FC4CEE4; Mon, 3 Mar 2025 23:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741046012; bh=SrQtbfxYGblSpvS8LPwAgsKM2zI/YMCSsrpy1uMUZvU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iru1kz8eq+EO/xgcHrFXDnYxmdtltZ7HKDfYUYddhUyXIwLnElsYIp63ESBZEJTKx 20QT7RWf+uU+xBUqIpZgldSFkrt7I8Ub9UgRKVHhsmRSgrMICJwd4jOLrI8Bw2DMys tlGrdvsjvMaxS/SprlLy5ikI+6BesGB7n/0hWGA8= Date: Mon, 3 Mar 2025 15:53:31 -0800 From: Andrew Morton To: Qi Zheng Cc: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Geert Uytterhoeven Subject: Re: [PATCH v2 3/6 update] mm: pgtable: convert some architectures to use tlb_remove_ptdesc() Message-Id: <20250303155331.de9b2fff9b04984a255a7bc2@linux-foundation.org> In-Reply-To: <20250303072603.45423-1-zhengqi.arch@bytedance.com> References: <19db3e8673b67bad2f1df1ab37f1c89d99eacfea.1740454179.git.zhengqi.arch@bytedance.com> <20250303072603.45423-1-zhengqi.arch@bytedance.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 48956120007 X-Stat-Signature: 3ki4ryksgk84fynrc3hpt68osw3u7tfj X-Rspam-User: X-HE-Tag: 1741046014-585994 X-HE-Meta: U2FsdGVkX1+PhxuNIS91QHX0qQS4vuJRip5mHVuh28Bofsc3rwHLXFHLwVXy5Gt+f1rpcSY4kuIiwJYcuvSt4bg268W1Ic2tfdwPhfukuFcML41FiURDPZFYjH6fnM1/vPPZy7GSF95TegdNpOEmLR6Sjpi7YTSRAG5R0DaN5YH0c1oIHwjkZzSzyYxvZ3etRW4YDcgCN89srXzbeQorTqh/hlWbxlm2bl25/2gzMwfvXVTTr1BzjQHon1Q2w6gae7oFVB7Gw20I4kQkNjfguTSxs9vdQ0BivTAOs8MqOtH8DbOC1tTBrdQ0ZAV5hZ2OtiXK5tPjj+wleq6a0sn+z93fWJFVaniiAuMMNp6ViGUJhvAT4giRNn580daYdlYaWyH5qym7O9mI6cs7Q1Od3d0AG1Ofbm206HOX+ig7/40HKh9LJl7GnPITdDMr79pW8QYve7oPT+or3K9wz0C1jRCqbusDCsG6KixpbOkYOBtvhQMNV0GAvujR697njLCkd7dgQZnNHcLwGKq74ByJWLvWSCBZz6eed+6D7Chiem6flyRWmbPSnhAqRDNyQHRcQ72AGg7vcY1Vflo5fi+CUM6ljQ4YU8mtLkDkWJJSpYTH11H5Q+9V1KFcZEvgXLzRqEH0ETZURs3fDefzcrvxWnkhxwVCD9ZsUt++u/9BqRuh4TcWnSC36Y5JY+QdZ5brGpcAJEOqLsnP4TkjsLOw3OQpxg5Rzu64aLBxezmNCvog36DMyN6vMRGw5BH7GACr75YoXq3a9BxPL7qV677v6Ra6iLNqmDU3MwDw64rN4hT01R5+3nIz5jYEX4hFf6BmUhi39jIRcj8UJSkZTiBfs4hf9qdlLOyPVA3nyHTgxi1pPsxYeO/cS/AiBPJQDr2D9F8S5dDomWNutADxEaAaMGu4JMUapTiuwXsdezAy1AtJQeytPWhx1qyKlulTZ8WfJMzynebtcVsRLLIDQu/ llmfum80 EArD1CHSrnqtoFiAJogQswoNsxUhjY7UWvQOe6TdvIRVKUrQtQh8nfTollxb4PL4MxWpKF8RopvfbmaghlYx4yAEiOsc2Jcv52/3MR8tPrxBBD4aCewamSTDRZ108fLpy3XNZCOMpSbqZHGWAdTdBE96JR6KZT56430IR9itEo+ZCOwUduKhHF4pXJCx9BOv2ASR9vSnKFR6PzpVOcFCTTTcVTjafMo6rELh3jNjLVVxKQ4fmU8TmkZQEDsiBy/3d5/Naf3LaSv7ZLL/K+ag7ea3sXWkyIy07NgfSilLJ0Ca8n5OTr7Hq4Edyg48rv+Z7KiikmyKq3oOBR5nMpMOKLVRQVyvglXF7ZcnBR81u/PIx3vIlCWJW2hTWwtLusz1bjbZXJKzDa+OgynM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 3 Mar 2025 15:26:03 +0800 Qi Zheng wrote: > Now, the nine architectures of csky, hexagon, loongarch, m68k, mips, > nios2, openrisc, sh and um do not select CONFIG_MMU_GATHER_RCU_TABLE_FREE, > and just call pagetable_dtor() + tlb_remove_page_ptdesc() (the wrapper of > tlb_remove_page()). This is the same as the implementation of > tlb_remove_{ptdesc|table}() under !CONFIG_MMU_GATHER_TABLE_FREE, so > convert these architectures to use tlb_remove_ptdesc(). > checkpatch warns. Do these things have to be macros? Switching to static inline fixes the unused-arg warning in a nice fashion. I'll fix the trailing-semicolon issue locally. WARNING: Argument 'address' is not used in function-like macro #51: FILE: arch/csky/include/asm/pgalloc.h:64: +#define __pte_free_tlb(tlb, pte, address) \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) WARNING: Argument 'addr' is not used in function-like macro #66: FILE: arch/hexagon/include/asm/pgalloc.h:90: +#define __pte_free_tlb(tlb, pte, addr) \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) WARNING: Argument 'address' is not used in function-like macro #80: FILE: arch/loongarch/include/asm/pgalloc.h:58: +#define __pte_free_tlb(tlb, pte, address) \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); WARNING: macros should not use a trailing semicolon #80: FILE: arch/loongarch/include/asm/pgalloc.h:58: +#define __pte_free_tlb(tlb, pte, address) \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); WARNING: Argument 'addr' is not used in function-like macro #95: FILE: arch/m68k/include/asm/sun3_pgalloc.h:20: +#define __pte_free_tlb(tlb, pte, addr) \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) WARNING: Argument 'address' is not used in function-like macro #110: FILE: arch/mips/include/asm/pgalloc.h:51: +#define __pte_free_tlb(tlb, pte, address) \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) WARNING: Argument 'addr' is not used in function-like macro #125: FILE: arch/nios2/include/asm/pgalloc.h:31: +#define __pte_free_tlb(tlb, pte, addr) \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) WARNING: Argument 'addr' is not used in function-like macro #139: FILE: arch/openrisc/include/asm/pgalloc.h:67: +#define __pte_free_tlb(tlb, pte, addr) \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) WARNING: Argument 'addr' is not used in function-like macro #153: FILE: arch/sh/include/asm/pgalloc.h:35: +#define __pte_free_tlb(tlb, pte, addr) \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) WARNING: Argument 'address' is not used in function-like macro #167: FILE: arch/um/include/asm/pgalloc.h:28: +#define __pte_free_tlb(tlb, pte, address) \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)) WARNING: Argument 'address' is not used in function-like macro #176: FILE: arch/um/include/asm/pgalloc.h:33: +#define __pmd_free_tlb(tlb, pmd, address) \ + tlb_remove_ptdesc((tlb), virt_to_ptdesc(pmd)) WARNING: Argument 'address' is not used in function-like macro #185: FILE: arch/um/include/asm/pgalloc.h:38: +#define __pud_free_tlb(tlb, pud, address) \ + tlb_remove_ptdesc((tlb), virt_to_ptdesc(pud)) total: 0 errors, 12 warnings, 122 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/mm-pgtable-convert-some-architectures-to-use-tlb_remove_ptdesc-v2.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.