From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA89C282C5 for ; Mon, 3 Mar 2025 10:36:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C482280005; Mon, 3 Mar 2025 05:36:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1745A280003; Mon, 3 Mar 2025 05:36:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03A8F280005; Mon, 3 Mar 2025 05:36:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D9BCF280003 for ; Mon, 3 Mar 2025 05:36:29 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 35CA71A06B0 for ; Mon, 3 Mar 2025 10:36:29 +0000 (UTC) X-FDA: 83179885698.06.3A59268 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf09.hostedemail.com (Postfix) with ESMTP id 1C57C140006 for ; Mon, 3 Mar 2025 10:36:26 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=CIeizD2K; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf09.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740998187; a=rsa-sha256; cv=none; b=rGtqm+i4WTAaSoeoRrIXXlTh0mUamiUE/RP8VtETZ5TVW2tNDGu9q2fj938gmoUKb7wxPs vgjiKi5YOodExtSyx6Io768cn01wXGXEyq94QT4dE9cn2r2Z7xCuM72SQ6IQEFmboDsPSS 4FcM2KQosLdr1GtjlDdIcXFY4KgiidA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=CIeizD2K; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf09.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740998187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XNI3SnVJolAxVhmPjt2JrEwot6jN/8zHjxYEktMG+4Y=; b=Jr6MB0ijKx3k81N6sd9D3hReJl2Eq4VSYVPhO3ofymt6bdXojd7H08Y5UjQrj3GfcyWsnT mxiVlVGtdfu0Z2iwTO6Z/AsZQGeAqqAMPebg6piAiGP01rK+a8aUTP1E0pIktic4yG/vbU CDd+yZxZsPqMJcjck/hu9toZi6BdOdU= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id AE1BE40E0202; Mon, 3 Mar 2025 10:36:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bd2HeietVv99; Mon, 3 Mar 2025 10:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740998178; bh=XNI3SnVJolAxVhmPjt2JrEwot6jN/8zHjxYEktMG+4Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CIeizD2KFeTbtYEKdnNDnpUDBbCjZpqwAkO17eGwBzpecuIzivjikXY8+BLNqxtL2 TfnD+4lmhvBtg1RPiedflnah3OqDiwlBEBTHScYraeZze7/vUBJVWbqOtLh/XIEfjf vn/H+X1OHwlS2JlD8EBWQMFyYz/AgvkAOLcqLSgOtfU4Szlas4X45SSXuDPsVsV4Do Q7ZFUIHAXlbqcNetihj/DrGOUoaMkmc9qwyrh5qv72T88BBIbMpkWzY1kvcEiCVVWH F+vMqJ1sz3KLAeG2gLiG+Q+iwVsztkq8WEwP8NTNzwMyDJSXxV3GowCo7DzwWVSuyS rTwrDZtqJWLGIi3sq8VTlwCqmYP1JEhwzQMkNt+zboA+0kjJp/ufc0cVIsN9uWI5rT KADNathwh6qa4OElEeBSQ+KHdgd5GosTf/1l4FXVgdfjUUW0j2W5RIklyg3XpjXNn9 8UoqEkzjBKx7RzqCx7/fG+/iIAANKeTrCYJv5O0dqlv8dcqZXFbR/QHjgYSuPpvGTV zqweiOFcXs/A/sbIvjqzKFK/yw9U/5dTi1XPNk4jyk8uMBmgV8ICdpd0kzMELYqAmK JdJnxk878YZy4HeTp+fgj+qZ/OFOXuPRXHUaXQS3+x4U6yPqmh0o+MOSmbIAM1magZ KbUuiDvnDuZkQIiP7vXiu4eo= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id CAC8940E01D1; Mon, 3 Mar 2025 10:35:34 +0000 (UTC) Date: Mon, 3 Mar 2025 11:35:29 +0100 From: Borislav Petkov To: Jonathan Cameron Cc: shiju.jose@huawei.com, linux-edac@vger.kernel.org, linux-acpi@vger.kernel.org, rafael@kernel.org, tony.luck@intel.com, lenb@kernel.org, mchehab@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, j.williams@intel.com, dave@stgolabs.net, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH linux-next 0/2] ACPI: Add support for ACPI RAS2 feature table Message-ID: <20250303103529.GBZ8WF8flezRahE-1h@fat_crate.local> References: <20250228122752.2062-1-shiju.jose@huawei.com> <20250303173538.000007cd@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250303173538.000007cd@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1C57C140006 X-Stat-Signature: aru5uknn71ddtt8wwkzhkcokff1qyq8x X-HE-Tag: 1740998186-899374 X-HE-Meta: U2FsdGVkX18JXjI9WYsezLju5NQkJ0PCKq/2fgen28p4FAs3WkdE3DMz3Wm2MraayoWkfW6uw08F3WlGum04Wp8TpclBsgaUnGoTw8qL0r8qhnRTUYvDpzvoscy0t+cNLmRaDgtJTFseZAtjXpsoWZ603RHKqYSFfbq3SOOJOzW/7MnyUX3gVhK/sh768yYzrlUM96nXkXsLHlcdesQwzQfv5aVMbVHBnoNS66Dzlph7U9dL60EYeqNU2LJO9pYSBaRo9f97t6toxXP9tplZcIQBKP+rA0E3UaVdD+sikwmZCVZLEdlBDeWhFTi1h3ynyKqqzug+q/61Mvv4OQrvtucF4UxdNI5OHXIq390SXNXmebijEvXEOAm1Znn46QjLNqoo2yWZX298h30EQa4y8iONMXx5GgLAYg6P/zxhQ8z57pRIT80AI8wNDs2kjAs9o+4J30SG+7q/KTDpShnEXzQxGaKcn4ZFaF4NiIgLMeb5q7xS+wnUiZ9XUTQkv/vgGFNSEKfBsuqMTSFGykEtnq4vOzABvksmRV664036wlE2Lp/OPAzaRxBzdtfN+8FSAJGvL+d4fjVBBipbjRancZ7WfcUMpk0Dg6mjl6QfmQ0br7P3d3vOsKUGAtB7Eo8+oZT0rDW1SvLCsRNWL2Mu6IONIUeRC71PpflF59A6cpz5DB0vFM+JJcj1wCL5Mah3vJTilQCT6mn+QgCzLayVy1B63RJV/DgduyfRe1KMpWW/yAz7Wmcx3Y4sZ7CoX8sddj945RdDQEW1KPLNR91aNqKjUeFFiIyB8ljBM6aWq45i0zO6TXipNiAsCGow21N3izBUMsfta8diDdZ+f2a+QfaLHPjLEK9ELC0LtHgkpQOg/SKQm/deA8kha+OOj0i4yoQOwvmh6xtgeUOxsruIftL5HIkv1nIAX8kMHTlKClKqFpvK7PcHkkq5X0BiWxBUxmoCjMBM3hoSC8BdQXe kVn49fUl DJQHX0AYp/JPhZkk/yowAough1hma5/zzDZBIsxDi0I1KhNZnaWCJw11wHgfnvG1+XEp2E9MWXPOP+05S8hEwwcPjhIQbSau0DTSDnfp9/T4sszl0foqfkHtod4cXZQb83EhI7sxi65mNXWaagfHoRUgYUXtwFoQIEbMM1bcxG+tNV5ZigUe+dL8TCmxjdObxWBiWQXNlqBTlXzsfMWO8oNY9H43QZBD47batRCQ+UdIdJYd2f7n9ZSK3gwh8tbxMRSMFHhnrJb0RmojUkYTr8Ks8xifmou6DorU6HmEb4RZ+AAgUQ26YK560HO49couT5SI74DWUHknP7KHZMZhfzv/RIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002137, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 03, 2025 at 05:35:38PM +0800, Jonathan Cameron wrote: > Borislav via ras.git, or Rafael via acpi.git? I don't really > have any preference other than making sure it doesn't fall down > the cracks! It's probably easier if I take it. However, just from a cursory look, it would need some scrubbing. There's stuff like: + ps_sm->params.requested_address_range[0] = 0; + ps_sm->params.requested_address_range[1] = 0; + ps_sm->params.scrub_params_in &= ~RAS2_PATROL_SCRUB_SCHRS_IN_MASK; + ps_sm->params.scrub_params_in |= FIELD_PREP(RAS2_PATROL_SCRUB_SCHRS_IN_MASK, + ras2_ctx->scrub_cycle_hrs); + ps_sm->params.patrol_scrub_command = RAS2_START_PATROL_SCRUBBER; which definitely needs shortening. There's no need for a wholly written out "requested_address_range". I know variables should have meaningfull names but writing fiction shouldn't be either. +static int ras2_acpi_parse_table(struct acpi_table_header *pAcpiTable) Yuck, CamelCase?! And I'm pretty sure if I start looking more, I'll find more funky stuff. HTH. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette