From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D52C282C5 for ; Mon, 3 Mar 2025 10:17:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 863EC280005; Mon, 3 Mar 2025 05:17:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EC98280004; Mon, 3 Mar 2025 05:17:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6670C280005; Mon, 3 Mar 2025 05:17:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 436C7280004 for ; Mon, 3 Mar 2025 05:17:15 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E748850918 for ; Mon, 3 Mar 2025 10:17:14 +0000 (UTC) X-FDA: 83179837188.15.1957E4D Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf01.hostedemail.com (Postfix) with ESMTP id 4EE704000D for ; Mon, 3 Mar 2025 10:17:12 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=UXAvkE01; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740997033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/T0jAtQw2ziyIRYjhPBximB345bKPYtbcsbnKNs9H3U=; b=1TZlABYECi8FoWA93XK0lk3H8UNsjCr7Eo2JKwXGn/Br9By5CXGSxWE8mlf8HXZRjgRQEQ 0Swu/kuH8AjuiNwJlVPqb5pBOHFdovzKtL4072m4CenDsryjYrhzvdmzTAXFCayqKRFG4s h+9LQUac8nE5jAw6tYz+wkrQq7FiIeM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=UXAvkE01; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740997033; a=rsa-sha256; cv=none; b=e1fw8bXaHF4qHUHGF/pFzPHDxd0acQCL926d8EmkOoz33auYHOAEY6lWZns6ReQWAueL6e Np6EA5jJ79eKkjvpyeaAYhjXsuxNs+TFrk0+7ys+2Ep1O8VNzWdJWakXHQ4IgdLDfFVnL3 JwgiHpL/lRzDO8LE/I84z5efY6HsMmg= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 8D28640E0202; Mon, 3 Mar 2025 10:17:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bKFAI4kJqnOJ; Mon, 3 Mar 2025 10:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740997024; bh=/T0jAtQw2ziyIRYjhPBximB345bKPYtbcsbnKNs9H3U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UXAvkE01IkdKwazAXwV/pp3KJw9vaBpwc+EZbw3VpkFbVdFcOhfIsKbIPbqheUm87 BJLVKwKluj+oWUVUNisfoSb/L8UPi2ranJcIWn5FqETo4hoqCvI7+/yEWxeXS2l7Fh c56nm5ovL7PzHgOZSyKoUw2dmH2SHQVZVRosdOWunSziqmBF9krMH7WZLl3uXKSSbV wf2kkHo9s0Rq/u+0x5j8HNMY6Y3daCdoASNNOYCInoOnet4aBzuR1x3eoH1omwB6ke cmhHN32AahpGV0bBd0pX/rITM6zvC+WjMy9tnuuaIsKERDBCtiEv+P3TtC5p3QaHEk p4RlgVQ41Yvq+IQ8/ei7Xz/FSausGb4CxblDsNUwbW5JDgOQxjZ764clOpof9OZLeb aB68XJqRKYXuIstJQhs4+S75C9mPViLQYU/s95/gSkrqH5rFqGebU8HP6WPDB4BnbD JbQawXEd2ewT9aj5JyJBBPDxMFXsoUfgC4ve5p3sv1fohqrdJ095yYcY/ZWQ11UouX 9GYldv6T/vQui+sbJ+gKWGgw8Qnq1aztr5QqvyzcXmfdltwqXbj6PbY7PUsq49G2Sr wc9ei7jcN/5D2L8c2nuwt9vomNqVvYDbfn4g1UGJ7xkm153mt8XB9S6Dpc0tne1vnh j6DlnEd0FcKQsZt781YnDr4g= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 489BB40E0214; Mon, 3 Mar 2025 10:16:47 +0000 (UTC) Date: Mon, 3 Mar 2025 11:16:40 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org Subject: Re: [PATCH v14 09/13] x86/mm: global ASID process exit helpers Message-ID: <20250303101640.GAZ8WBiPNKG_4wkVDv@fat_crate.local> References: <20250226030129.530345-1-riel@surriel.com> <20250226030129.530345-10-riel@surriel.com> <20250302123838.GKZ8RRTgRxvBSry6mk@fat_crate.local> <683d34253e2bdef9f74d8c44b2eff7ae9cfea5f9.camel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <683d34253e2bdef9f74d8c44b2eff7ae9cfea5f9.camel@surriel.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4EE704000D X-Rspam-User: X-Stat-Signature: nczi6kgjb4khhmxx91b1gmfp8bnd1jo9 X-HE-Tag: 1740997032-587170 X-HE-Meta: U2FsdGVkX1+PZj58w4uTLxWo2+1zeE0PZrOFjfOLv3AcXGrOMeS5vHwz4wJBCAazN3I7tTdnqflGOP7Ym3inOM1PAtR+62u/cgmXXKMPpNzYQh8S3tuwxLimD23J7OkroqNKMNFbb6m65JEFxSmOK9zkOQzMmJJ9/aUyX3/vnNHkWLg4e716rTX71LSO/syptjblkPUgKE7H0RpF1hVIxxG3LkOxIx4c3CX8DRotgNrlYFY+Nw4Weuu03QNsLKE4HWcJ/gOfc9OAOSxVPlxLOy31DNM8JLe/You+qTo2Jo1ocJt1mjhEulaRils9Zb1wutd6BpsY8aQOE/XiAC5Mx6R7YUOHuNKHwxF3mAa4u/sMwkJOYy0iI1w8Vb2f/aeIPqevXgORXhjKvL/cF5kpCf6CL3wuC6cn8sWBQgM5FOpD5sCKtnPwLu94WhldScbPqJ+X+uEjIgkW+LZRPIcGG8JHl8wbHOmFpKldcAmlS3hkRdiDo6Qf9rMVwNVzPIWEV0UJ3Ur2S0A9mLz5voeDGxeokF6Cl6v9B5ogc8Tf/31Aazi2cpiiz9DBAwHZsByQ/rK5WIyc0nOK9WGn9vNJd1EdDKeQ++VQ2SlHZz6KfzaSX2rZXb7WlNk8MTtmvWCAXN8Sji/WX4HKw644fs+rakZzMqbI0pHmjM9k5zBlFAJOyUKBXiXm5L8YsOmdwM6sa7b4TI9KOyPpfPivdmMoY1cIaF2beioKOOZx4ONsWCRWJ+C/X/Nw4jU/D8uDqgztzXYcjAKZ1o/yIrDuldQsnazTN/TDA1zhtqDuwuphAdbp7u3sSw9KKhDC7N/Qo+eLk5bccHHEkWVPGG1XmjMAwulGHGcaacecAmKnOP4/Nn0Yrl+os4yWjk19Ov58IdjeEh7/Xj7lWpuTZcT1zHylzUiAULhS2A6P6zcojM5FijN4T5LUL1snhg6O+h4WG/QmDAUtr2AZOzJeI8u2moN BDdGHBpx h7tLqneljoEw/r1NNEzTfY9AaSjMRnCOc6NhurXwQMxFP+QhRGTxkOtqQnzJ//NTBwjU0jqIajXvSKQNOXX+Kyln6kxfa4fUdsiTWeFK5iyqdrft+OpyG0fuUOcr7NoeFxUv8RZGp6YmXKn3RcDIWhE8N1Nq9Uxf/Lt+MYlVDQA4i3IQEedfWHApC0Ibl8ffL/imMKYq4lsMEjBppvgc3WayVVy2sQnIjXkrggMs1hH4ixnUAO7RoctaJfOu5VIzIbpsJguTV0DpaH/nG2P/idESq/DFtX1HTcxkx0kOdJ67Cqz7tnTo01J9j8zpjehoECXZF2m+hM4gWBog2Xu6nU9fZqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Mar 02, 2025 at 08:53:10AM -0500, Rik van Riel wrote: > I've been there. Repeatedly :) Yap, it is. And despite all the compile-time disabling fun, clang still can't do proper DCE and complains about the inline asm in __invlpgb() using a u64 on 32-bit builds. So I did the fix below, ontop and with that randconfig builds all pass fine. What I have so far is here: https://web.git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=tip-x86-cpu-tlbi Lemme go through the rest of your patches now. Thx. diff --git a/arch/x86/include/asm/tlb.h b/arch/x86/include/asm/tlb.h index 5375145eb959..04f2c6f4cee3 100644 --- a/arch/x86/include/asm/tlb.h +++ b/arch/x86/include/asm/tlb.h @@ -29,6 +29,7 @@ static inline void invlpg(unsigned long addr) } +#ifdef CONFIG_BROADCAST_TLB_FLUSH /* * INVLPGB does broadcast TLB invalidation across all the CPUs in the system. * @@ -74,6 +75,14 @@ static inline void __tlbsync(void) /* TLBSYNC: supported in binutils >= 0.36. */ asm volatile(".byte 0x0f, 0x01, 0xff" ::: "memory"); } +#else +/* Some compilers simply can't do DCE */ +static inline void __invlpgb(unsigned long asid, unsigned long pcid, + unsigned long addr, u16 nr_pages, + bool pmd_stride, u8 flags) { } + +static inline void __tlbsync(void) { } +#endif /* * INVLPGB can be targeted by virtual address, PCID, ASID, or any combination -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette