From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20159C282CD for ; Mon, 3 Mar 2025 16:48:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A79B8280020; Mon, 3 Mar 2025 11:48:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2A4728001E; Mon, 3 Mar 2025 11:48:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F1AD280020; Mon, 3 Mar 2025 11:48:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7114928001E for ; Mon, 3 Mar 2025 11:48:33 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EA022120C4C for ; Mon, 3 Mar 2025 16:48:32 +0000 (UTC) X-FDA: 83180823264.10.BDA3988 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 0815E180011 for ; Mon, 3 Mar 2025 16:48:14 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Kma46+1m; spf=pass (imf06.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741020495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zJld88j2wdAi7L00b/efYSTeTpygrYKTgbdi7z652nE=; b=05otAcN/KUxc3jsNZcoKO/rDDdnnIXneVj/3C54H5Xmje4EIfdHGQwP/sq1gUCINCC7q+G QyyBUJONnk2G3AsS/lkvP2M50wBoFPARyHeMFeXkeGjzjHCdv4w4OyfuCFlZfEf36vLZQP f4qTFHhSbtNMkxGlkE18mJn9ybDvEnA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Kma46+1m; spf=pass (imf06.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741020495; a=rsa-sha256; cv=none; b=OEHN4Cc/ILZp8SkhGyLqFtpfwwxlcvyy/Ahf0kiSgiyd0tKZbdae9TxcVHqiE8T919CRc6 myKoXyNjvNGRDnnfwWEbsorO9NW2FLdOrEWwZAz21jKa9xk+O2fHpHzohvkOCYO3N6eCG2 LEs8fiG34HBpJUdfQ+ANlTjoYrxq5hc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 642E65C59B6; Mon, 3 Mar 2025 16:45:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D655DC4CED6; Mon, 3 Mar 2025 16:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741020493; bh=bw0yJZnhs1/BZaCqXfD9wjtRb11sZ067nWTPBfuSx8k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kma46+1mbo5HVbvSYni1BkXX+MDggtOQ4udarzKeT0m3EGju2PFRlGQ9KOdvgAHYj xuH7xIujwcqkI8VldRhMtzPRoJW1xMiaB8vELBXD4z94E1DPXsQnBO6FbLJSORi6yU qkBnC+fe6HFJRSnmsswBb9bUF+Rn0qWZsnM2eQlgETiFjtfStyeOpbxfwZCFnbDua2 txE5ukd7zBvy7W2mkC4+YHInipJyqlCTnEZpJGH+vEDLOjkiMSKDVMdbPt0mcRxHxQ FYuNxam14opEZtWVKlYIB+30IudERhVk3LhDfclOncqey/tJVPiDd4hmnaFcgzjjb8 w+RQHt2dVgslw== Date: Mon, 3 Mar 2025 08:48:10 -0800 From: Kees Cook To: Lorenzo Stoakes Cc: jeffxu@chromium.org, akpm@linux-foundation.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Subject: Re: [PATCH v8 7/7] selftest: test system mappings are sealed. Message-ID: <202503030847.5E73540@keescook> References: <20250303050921.3033083-1-jeffxu@google.com> <20250303050921.3033083-8-jeffxu@google.com> <8285bc26-6afe-4141-ad1a-6d8c5d6d76f9@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8285bc26-6afe-4141-ad1a-6d8c5d6d76f9@lucifer.local> X-Stat-Signature: zzyue9xmcr7sf3amfy5z1zsz1pzdmyi1 X-Rspamd-Queue-Id: 0815E180011 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741020494-496774 X-HE-Meta: U2FsdGVkX1/rgAVOcW/UHXHdNBh05Mc5v+GhfTDmwD8uKRFCWM1w/6+HEqSqxUKm8FNhXUm70amy/Rpa5GpFyS8gvLtktyW2KwNgn0SFUaao7sXHVHmSbXuoASbVw1h+5lttoLhFhu2hRaz3or9TgP7BC6//oU/apCAi2YgyHA4zD42AqiVK3D8s18D116jDCBDs64vWexFrZfS4KPUgv/BHEfjj1IMzgevsyzzGsvGybxuokylMxR5o1APnrjDZjADtj8gzlqMFXw4XXYIAjq7cOiSGFoWXV2agHbojtf3n4EXRYijGktd/Gg1rO2GQzqjDqNjyVoKDtaIx/azXCNNrZqGabZ2iMX4uFdWvlappruYvpwS7sH6DJVMKmpgPMxs4sLAEbWcu38j6ozTbQ+5qXOTlRnFXSA2sG06uID8RlRpsaXuCSnw5mwMahhDGcezqkJGKLTcakizIt2NTWLGKmZC4NsQJJl0WyplCYA4Ae3T78CRp9H2aLsS0TZ/bhtoIz1q0TsnMEmpTeai69BOAhUcNvnJ5CGNGvJkNCo/o7FVZXGSZTBsTBFTZpSgPJL2EX9Shoh6Vf9lA+wJ2Qy5XqTO4yMlHzykNB5MCQK4pwj2++zatGbkfwaZ7kC2QJYyQNfzmgztJh8u0fcTTAGbbwCC+GHqvbrj0XuRrzhMCiKsA/s7sYsuxegcuoHHubm63ZY+qe1/WdypzLjoaDIlDUvB33gwEhWQItaXhTycmOR3VSIYf6fsTRI7bEs3GDPd7bMSOLPvE52Q7Tgnp5ff6sK0vczVR7nRQVg/KZt9qvnVqPSUrGuOyQu6JxOnzabPPVpP8L8MEwriJQBCE25WBK4z/bZoYs02bdGv503JUAq36qNac1W2gl5rFfycJtnqFUkRT6eMc4mvboWW2LHjM5OWpOkkrlHYWQ0LkS3fsHpuT7Tv7WUG9xiVa/hBiB37GDNxoW0YH9GYk2s+ P/Stp+Qn sICUQK36EoS2XtGzHeupspPQbEtvMIiy6mTDo2Q9jRs0R2r3ZGiFvDXBuAZDTalZj3yFmBaYp4bGw6LBwC4GjzwyzJygq/2hq2jzEJ5+z1CEXPD6tLwzUtgrD+A9apb9QnJ1jbK0CaSsguTAPGFKBS16ATuLOyBYFtViw4yZXMD/EueZLhvFfhu8YVzP6cHHZpb8qyN5ea+jqQh6nPfSEpkXVsOM9uqLkVRlbqA8QmU3RFo2ZVvwR2tmI2c3oW/GXRsJK2PHM2xMhFUtxIiu1LP7cLjr8XvW1JOnqLq50WNg6bfnOWMAR5EK5xpH/heJS6UlrCGMyP6Px/+RCu2iRNB542utOARm0fCYzc087pR0EOo0EFcFe2yFXEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000530, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 03, 2025 at 04:43:47PM +0000, Lorenzo Stoakes wrote: > On Mon, Mar 03, 2025 at 12:08:49PM +0000, Lorenzo Stoakes wrote: > > > > On Mon, Mar 03, 2025 at 05:09:21AM +0000, jeffxu@chromium.org wrote: > > > From: Jeff Xu > > > > > > Add sysmap_is_sealed.c to test system mappings are sealed. > > > > > > Note: CONFIG_MSEAL_SYSTEM_MAPPINGS must be set, as indicated in > > > config file. > > > > > > Signed-off-by: Jeff Xu > > > > We do need to add this to the general selftests Makefile, but this code is > > fine, so have a: > > > > Reviewed-by: Lorenzo Stoakes > > > > Congratulations! :) and thanks for addressing the issues that were raised, > > appreciate your efforts on this. > > > > Maybe you could send a fix patch? As it's such a small fix. > > > > Cheers, Lorenzo > > > > > > > --- > > > .../mseal_system_mappings/.gitignore | 2 + > > > .../selftests/mseal_system_mappings/Makefile | 6 + > > > .../selftests/mseal_system_mappings/config | 1 + > > > .../mseal_system_mappings/sysmap_is_sealed.c | 113 ++++++++++++++++++ > > > > Can you add this to tools/testing/selftests/Makefile? I _think_ adding: > > > > TARGETS += mm > > > > Should do it. Thanks! > > Obviously I meant to say: > > TARGETS += mseal_system_mappings > > Doh! :) Heh. Simultaneous emails! ;) -- Kees Cook