From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BAFBC282CD for ; Mon, 3 Mar 2025 16:47:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 485F728001C; Mon, 3 Mar 2025 11:47:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4363E280004; Mon, 3 Mar 2025 11:47:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D72028001C; Mon, 3 Mar 2025 11:47:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0E6BB280004 for ; Mon, 3 Mar 2025 11:47:20 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AA0FC1A0D3D for ; Mon, 3 Mar 2025 16:47:19 +0000 (UTC) X-FDA: 83180820198.06.0A9A41D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id CD26A14000C for ; Mon, 3 Mar 2025 16:47:17 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CsRv0MyW; spf=pass (imf26.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741020437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YnsvWBFd6SbsiJZPiHdD+2AjA40Hfmt/dhCQxJtRguk=; b=axQUkEaH0mdXmiJQWEPJvi0sUXHPyffwPRN9i0aGhgf1ILZUN23ZRvsUDc5fuTYO5hG8DR CE44k0SLTXyab4Vn8hRvvwJPmGnp7IqDPCEcTfBFn9BTeOYS9e1ESWizkUaCOXWMgighAk m9oThzabi3XeqOWqEimj3KyEUGgogHA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CsRv0MyW; spf=pass (imf26.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741020437; a=rsa-sha256; cv=none; b=t7INmp3zApuUUjFezygMC6Lwm7OkuQ6NBC4Tljknb5nFnBhc01dt/dYhm/hUmRQtqzkfPp yo+jbtzPnftK4c4YZQA1H8wOIxdcEhxdmhybG+yOSFM+dtWYYRU/sNMn0IMnabIg7WS2Nz akK+3WME651xuQBYjfewAnSX3urz2yw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 103EC5C38A5; Mon, 3 Mar 2025 16:45:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8464FC4CED6; Mon, 3 Mar 2025 16:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741020436; bh=4yX2ove+H3YjYb7KFBwrFbNCLgvX35Q86cuMFRmKlmw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CsRv0MyWb+t3rjCyUZTUyqI56U/wOdbvhCqw7g+9KdrxzR3/QeNOxqJ65ZG4omkdd ruH0sc6mTJoa6DU3Vb4Y6MTZ2RpmRisWPO5hgfOX+r8wpMIL5VAQMJQ/cmlX63MZcy ek8rOlVpJc3p0sfU3yTqqqkAo+DdPepnQmjAMgz7lHMzarDpqMFtvGSmuXMAmk1YPK D3/l/IdInHqvuXDEUQ9BurqRH20feH0B1krtXTp+KxxEPNasrAbjCSqIkFYFNEA58i ajZ0QzoQZlC96mxyDoJvdYJPGkrOeFRQKnWp69A5QaWUp0SQunJz1Mc3Q5vnY210aF nztTqWcHF922g== Date: Mon, 3 Mar 2025 08:47:13 -0800 From: Kees Cook To: Lorenzo Stoakes Cc: jeffxu@chromium.org, akpm@linux-foundation.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Subject: Re: [PATCH v8 7/7] selftest: test system mappings are sealed. Message-ID: <202503030843.553DA01@keescook> References: <20250303050921.3033083-1-jeffxu@google.com> <20250303050921.3033083-8-jeffxu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CD26A14000C X-Stat-Signature: uewrxbmc4asyrqjg7eg69ene5hx5dsb9 X-HE-Tag: 1741020437-815780 X-HE-Meta: U2FsdGVkX1/+HUdN+5QWkMmINrb8wfKkvRbTFZbtBA5TkYTuSJ0gl65OJQynm/E6YffLd5BkF2N4kDfnvL3R5pOqY/DEbpf9ER0DLFPZOpei/YO4JmEqe2VlQF/nbHpO1U4ghzLV+qa+P8EgSdhOjnujgGmzmwgpFimknHpNg9Ai6a1s71IQMPMYKqnaVU/B0an9sz8dEUjGJVBiY12LBcPwRitPM63cm3hfBsCMl+km9U6ObmmcteNEJVAtF6NQFubYef+G6HGvNBtnKBws1ZyhfHFhjWh9M6lSev2zYH6/BoexH3F8Pv+b3v8/h4VUz1Ofsd6jn+xHoWCtHLW8Mr9mEN0ftf0+N7PbqC25Wa5R0er4iB9EG81dHFBWLozScDSrMcl4eAANRnbB8N8srs+1kfXHfGxKgon8+Q6sxdlnjAVJ+O3dZw09BwQ6k9Fu40sGBEZnZK7atBRbyrftrkGlayVbT9pxnFw/uFMV7w9/WfUIcqRRazyPAJ++dcNKCcXHC2PvygbUojenRmWEfAtAxJPyZsaaHpWUS8ZtnoJyac5xr6Wh10mg1vEXg6nAQueGXg2iPhPMOLL1xmLhGmMd2gbZgryhbtC4n0OzEOSdH6f3fmt6bbvfVaut1IOe/mhxiedcAlKi5tc9KezJZ6yU3CqI3QcopIFfstnKWPkeb3lsaTT/BbvVzQCuM87fYAJB8jBin5C2NAbRbawBProeilLphGQYVfjydZ0k3Czam5F7HsR5zg9AB7ZSoFhBlKC93+ndCo07fXlr6cgTQu4Wz/yR3iEvEQFI0rhwFzwdy2wT9AX2GknB7l7kpFVakFJnPHpTDCMoinSAvHP+OuqiyTw9bbzoX3Q6blGCpey8XrztFJ4cniWX99dddpI9yHdGLsR5clwkCEDSMzqdtbZWFjR0SW5CUrMEqvkKqnoW8yAsob48akjnnz9UAavc7UJX8YVhtC38og1qTSL C+9HwwlM 3pkog5d+oN/iNByBliyhAwmvGBE5xZamJarJA/FMKsqj5eSXYu2+CNS9FfnYnaWVCY5p0j8DMbUrv+dB5nuZPJxJm9NR8oPDxTBhAxEfiIJtVVmvmitBxVig+vpB8oDUuhgwNWYVwri+GUuY8kR5WL9Qipcs71JIvrK1RrYyMUwsn7eKvbjRZrCvahvQ4AOS6LT/q0VXx95e5bxFcyDAsCmLJh12ll3WRxB8VwzQxcZJcJYeASfTQNzGDyupaoESkPOpXNyvXh5+iVD2UWGO/fJ0zsLHKwMCoEFPADN/p5N8l7Io4qOGChhC9u3Th5uOhUhCtJ8RIqY45qegmJnzEboHSgX92dUMwHNSVRyOcX+IpiLGEzq7/H3NmlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001681, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 03, 2025 at 12:08:49PM +0000, Lorenzo Stoakes wrote: > > On Mon, Mar 03, 2025 at 05:09:21AM +0000, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > Add sysmap_is_sealed.c to test system mappings are sealed. > > > > Note: CONFIG_MSEAL_SYSTEM_MAPPINGS must be set, as indicated in > > config file. > > > > Signed-off-by: Jeff Xu > > We do need to add this to the general selftests Makefile, but this code is > fine, so have a: > > Reviewed-by: Lorenzo Stoakes > > Congratulations! :) and thanks for addressing the issues that were raised, > appreciate your efforts on this. > > Maybe you could send a fix patch? As it's such a small fix. > > Cheers, Lorenzo > > > > --- > > .../mseal_system_mappings/.gitignore | 2 + > > .../selftests/mseal_system_mappings/Makefile | 6 + > > .../selftests/mseal_system_mappings/config | 1 + > > .../mseal_system_mappings/sysmap_is_sealed.c | 113 ++++++++++++++++++ > > Can you add this to tools/testing/selftests/Makefile? I _think_ adding: > > TARGETS += mm You mean this, I think? TARGETS += mseal_system_mappings (But while we're here, why is "mm" where it is in that Makefile? Everything else is alphabetical?) -Kees -- Kees Cook