From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDFDC282CD for ; Mon, 3 Mar 2025 16:33:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E67A5280017; Mon, 3 Mar 2025 11:33:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E190D280015; Mon, 3 Mar 2025 11:33:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D06A9280017; Mon, 3 Mar 2025 11:33:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B4EAD280015 for ; Mon, 3 Mar 2025 11:33:56 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 732CF160C3E for ; Mon, 3 Mar 2025 16:33:56 +0000 (UTC) X-FDA: 83180786472.30.FF77EAE Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf11.hostedemail.com (Postfix) with ESMTP id E7A7040018 for ; Mon, 3 Mar 2025 16:33:54 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DijonD+M; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of kees@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741019634; a=rsa-sha256; cv=none; b=GHpx73vfoKcon6/pfKRquoEHYPe97j1bkKJKZgAhbn7KF1i429YIooWcv7W8YMsPBUlIq/ 3BNMZSOmBlf/UcXyDNTRD/RApofNpLazXxi0N68jCiHgoUNjdfRBYi8uTI6fP3vMrZlAOh th84Zr6rxJgb5SXpYTTzeR/5kauFaB8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DijonD+M; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of kees@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741019634; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uMdryiqhqUNSZhWRoqoeqlAj4d860MZwxQ4cPIKpfis=; b=r5GZqA5RlwOTxtpYDPXy+78KWpT7lA8HQTZzgs3tzPzGzDVHe0c1YrlAOMtnerHrOdeJ5c /g/HYXmRg1SGQcOUFBraxkTn+EDXjFmQf7x9XCVLH/OKABxahatfgzSCW8Malmxt9xpqYL OWGZ4fn3OSARdJKCBAUelPtJB+3GhJo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 5D88A61211; Mon, 3 Mar 2025 16:33:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF1ADC4CED6; Mon, 3 Mar 2025 16:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741019634; bh=kXL73sjW9CE6qW2km9AaFyZiQTVa+1IdrzDGd3cNszo=; h=Date:From:To:Subject:References:In-Reply-To:From; b=DijonD+MX6p+TQYDSVX7lFCVR5+au+A6DEzqIx+A9Ue79cQvzZCDewi4pcu6LQeso 9nBl8wr7o/ZuJv0drQyGjxDyXakhIg0cUs/cB0k6ixu4ID2orKKl1NASD3R4SNE1YU QkyROTUKnHSjLbYOClOAwsaYP9wMDZDy2g5IvezgJFAN0U/BilMPBtRexWzmDvGJtt NKCLMUcboAekwVmhy2ZvtOrXCCgA4u+rzhAWnQu/0tEtcfglE+HxMSqhjINzAxw2/a cEpDE0P+eeeEqSE3S0C59LxJKG2aWZU3fDoDJ1rPonLoljk3rV6sPcAfZhhs2Gqb2H Zqux9FNh8IXNg== Date: Mon, 3 Mar 2025 08:33:51 -0800 From: Kees Cook To: "Liam R. Howlett" , jeffxu@chromium.org, akpm@linux-foundation.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com, Jeff Xu Subject: Re: [PATCH v8 0/7] mseal system mappings Message-ID: <202503030832.200CF1F46@keescook> References: <20250303050921.3033083-1-jeffxu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: E7A7040018 X-Stat-Signature: stuskt1mbi3iujj9zikuwp8cjqfx3ggq X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741019634-715399 X-HE-Meta: U2FsdGVkX19gaMhsAiCXW/9FWyt+F1ZRzVELEpugjsCfcrzzrLniYxGLjLx32ZiFOSBi87388fZ+V2sOPeRARzBA2cjX5YfCQ/b/8pOoXcwH1DROlb9XJfhZNGucAqGGammKiiCs4/ImiRM0KUOihba1O8AKoa3bngY62aGutFhubQHpO/rVm4N2uKiKzbxItL3BgBRApiEoKOebcMcObyJiTQKlu7Z1U7nyJdRoBCrIUYSNuItSaemw3fF6JyjQ58Ies0AC563WE8FL3DSXa6rORx87KyB1A3yXqZ+ybePiSP67Bk40LB6w1+BvRye6ps8n5NILTUPuaeO1zMpvxr2FtNZAp4VgKF9WYpgP70BbRWauT4KIlXbMImvbMWns0JHoXLUMhTeL3sUlbgshiAbFeLBuEhFXZz0555ZQaJNsWyipo6Y2Rg/hs2GIUNM4NHm9I5oUzF0z/TDlcY7sAXUj2RVglsCxocv24Rlh0+3SccLEqoSM6lCy3fUVt+RvEFhgc1wvOz4efTWpn3ZChI44e3O4EEWhkt+nR1WMdfgtTPj/JdlAS0EwCbFuhB0mV34CjomsmEaDZFC4UrXspxpcObyhscn1r6ZOuIunZm369MwzepFryOpMrnkA8RRphXaIlDgbk6uSpOs+ghQh0+i7W63gxiWvfG5sbqrOi08m+5qBTHuj4JOe3CM6DQ94SDpN3pVVBUI0y2RQ+VDIWqCvNPKZ9h1KmHLWdVHXHLxzjVMkHmaHcv74UscEsxtkLPXao+UkEbC9e37J4STS/mjHO6SiHj4/Rkm6Cx0pL4zDnvba7x1By4Rgv302XzFLkBuzRSuIhM/sp9XV4oNRsSKtlDDTWhBFW8qGarIBuCkzbWI6L972o2KMWSSAoDj37M7wv09vQ2AlD28k3fxsPKFRqsHAZ0VPhr5hmVxsjmqUJ1kkq/HHLKDeZZFZw6j6LCBKBpyvJqhCDPI9oOi ntJ210P7 +/3DDWJP0pjy+xEXtsM5irWhOPsClZuonOZ4RFKNhA/mDLqeiiMSdrU6nSYCWO2J5drZPhMlQbQ/Q3z2Cq3iVXfndBkmJxBLN6VfnfHZDUT453CQmAhLyZLEA2Ldx8L1zYVoC+6CO0nMC4ukwj9wLK4FOPdS/YtEOFQzK3qGCipw/tz+D8FCZ0Kmt8dn1/5D2lAA4UcwECAbt0Xwy0bEOPrCjPC5bUNibUB4kMsTYgzD1t7OoD54qbTTu6r47F2rAisYmCd6xQd1B3PtoaJ8vEkYdaDdR6PS3roCBr8A/yvmTo2nAEFo9HHtDel6mISqpilQmFsc+Cab9j0dld7hWmQU3e1ygNXcKMAUi0SImvT+ObfFd5CVRwH89JEIDGx7IXEFwGRdNaCcpqsI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 03, 2025 at 09:59:13AM -0500, Liam R. Howlett wrote: > * jeffxu@chromium.org [250303 00:09]: > > ... > > > > > Link: https://lore.kernel.org/all/20240415163527.626541-1-jeffxu@chromium.org/ [1] > > Link: Documentation/userspace-api/mseal.rst [2] > > Link: https://lore.kernel.org/all/CABi2SkU9BRUnqf70-nksuMCQ+yyiWjo3fM4XkRkL-NrCZxYAyg@mail.gmail.com/ [3] > > Link: https://lore.kernel.org/all/CABi2SkV6JJwJeviDLsq9N4ONvQ=EFANsiWkgiEOjyT9TQSt+HA@mail.gmail.com/ [4] > > Link: https://lore.kernel.org/all/202502251035.239B85A93@keescook/ [5] > > > > ------------------------------------------- > > History: > > > > V8: > > - Change ARCH_SUPPORTS_MSEAL_X to ARCH_SUPPORTS_MSEAL_X (Liam R. Howlett) > > It looks like this was captured wrong in just this update. Change > ARCH_HAS => ARCH_SUPPORTS. Code looks correct. > > Kees also ran down the meaning of the two more than I did, so thanks > again Kees! You're welcome; I'm glad I did it -- I really need to capture that research somewhere. Perhaps a blog post ... I can't really find a good place in Documentation/ ? Hmmm -- Kees Cook