From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6780C021B8 for ; Sat, 1 Mar 2025 23:01:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 038A26B0082; Sat, 1 Mar 2025 18:01:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F29856B0083; Sat, 1 Mar 2025 18:01:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF01A6B0085; Sat, 1 Mar 2025 18:01:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C09A66B0082 for ; Sat, 1 Mar 2025 18:01:17 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E9152827B0 for ; Sat, 1 Mar 2025 23:01:16 +0000 (UTC) X-FDA: 83174504952.22.FD4F6AB Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by imf09.hostedemail.com (Postfix) with ESMTP id 3D8ED140010 for ; Sat, 1 Mar 2025 23:01:13 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Jdrak5tR; spf=pass (imf09.hostedemail.com: domain of lkp@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740870074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jIq/Fidz1W7W9BpYsxD6rWgpw0AQ8tj2NTYh3F2lvdQ=; b=mkEEH6SNiqyNe52cDYQp61yKWsSL2GE7lHV+PUzTEoAyoxor3jRpDhqdB5l2Kghj9Senm3 guoUxxRyUelpK2pNohiXpqsGTFHDPiVP3YxymypVzxUkkBKuJCVOV3Ow3dbKbnM7+p41GS OX+mzc5KJSlc7TC6psxwzLRKrgB1dms= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Jdrak5tR; spf=pass (imf09.hostedemail.com: domain of lkp@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740870074; a=rsa-sha256; cv=none; b=DsePQ++1K/WScpHZJhnS6lrGz9TX2jr2IvYVDOtEgw2i9gT6mhAhvjdyQjSwk+r5YPsV8M xSWrP1VjsShDCh36s1A/bE9O+pORG3eSzKBjz1/UAuHk1ISjzQLTdiliDmXha5Ma9T9AEo t3kiJq5swPVa+Ozg6WTpWteiGEcEhPw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740870074; x=1772406074; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7w2CX1Ue6tyDuYsaxdofmnT+sluFZwvTVHk4Da0sm+I=; b=Jdrak5tRSDNo5+ImZpi99C0+5H6br2j6wPAI3PlstkAtTitzvgaw6MTp 20Psp9wvMxZKflhLUC4IPbk4VaYUGeM0gAj79w3vyuEQcREs3HU4EzP6H 6/1Eqde2N2LVny952/Y81s2qYje+EvVCDpQspmyLwZlrQRWIbxP9a9fMr KL+eNNsCsNjvHjk5+vwr1GdZMTSLmRMgj9QSBHbkl9tek1pgm/MzPeQWh er7l5tssXkpXsV19KQpL8zLoQsnLEfysHXY3e5t490f7J/05dJg7oqNQt dBOSYGoo5fb4caDq7meMiB6jyqUwE6iwd2lXlJlsJ3+p1BaI1J8LpDEj1 g==; X-CSE-ConnectionGUID: eoYVrrpiRVu9+MTRs2M0dg== X-CSE-MsgGUID: NVgFPU+lSmi8p6pLwsjZ1w== X-IronPort-AV: E=McAfee;i="6700,10204,11360"; a="41895972" X-IronPort-AV: E=Sophos;i="6.13,326,1732608000"; d="scan'208";a="41895972" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2025 15:01:12 -0800 X-CSE-ConnectionGUID: 3MvU6VudQkqtGj/otM+KYg== X-CSE-MsgGUID: 8qNv6xtxTou9EF4gBFQ4/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="121772219" Received: from lkp-server02.sh.intel.com (HELO 76cde6cc1f07) ([10.239.97.151]) by fmviesa003.fm.intel.com with ESMTP; 01 Mar 2025 15:01:09 -0800 Received: from kbuild by 76cde6cc1f07 with local (Exim 4.96) (envelope-from ) id 1toVpP-000GnW-2y; Sat, 01 Mar 2025 23:01:04 +0000 Date: Sun, 2 Mar 2025 07:00:47 +0800 From: kernel test robot To: inwardvessel , tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, mhocko@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 3/4 v2] cgroup: separate rstat locks for subsystems Message-ID: <202503020616.SJVwhuOV-lkp@intel.com> References: <20250227215543.49928-4-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250227215543.49928-4-inwardvessel@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: 3D8ED140010 X-Rspamd-Server: rspam09 X-Stat-Signature: 8ndy581podcyrqryeka94gnqomkccm9n X-HE-Tag: 1740870073-87684 X-HE-Meta: U2FsdGVkX1+ONpTMgD5XXy9H8wNJebIhqntlJIvFSCz73cnqiNBUsXybYO/+sVYMHGxbP3RlehoMvr2dMoHBKWUo8q0VasanPxmkgzv7WMRKvodfRNj2mhxum9fs7aW73jTmZPQVqB9/3p89kFy6GF2WKVDn5b7XoMGYqH+qm9UWjQMUtBFV9w72FuxHzauEn0KUyA5AbdWPj+x6cB/KKNeTUsAc2y7+aQlbEOaUScHX9AzYtsg3403oiTO8tuFcnLCFp3q4hasKJPFd0W2pAXW6pSTM7Jmgnd+x8yVOd4b/+PVhDEdDu+tBoRN8wWTSWWswfbv8xmnPuIIKw9rL481F/vRtXvFDowOND4z7razxKfMjQ+DFZZzRW1Alz2+ZNAmj8IHvEaRQYzPF8uGM798AT2CFksk3ngSdvRC+5x7C9wvYKGaZiAbF0ZVI0yJGoO6XFoFxpSBE0yoChayXwAIH6qsBZ6hyj/5qCRozAis3BZthPvOZl99/BT7IZdPUlHOwq297jNieCvuJh5cSSOV7nPdSQzsJhdxW8hYdsCSOdCbzMI+Q9/uBJ9H4Aj3bEjSnDGnXhObyP5Cfct1GM3arjq2qwdSLo6XsuvyXp5xxy8LRUNOGGn0YcrRH9OA4tIzlNrDKOaiONnBpBNo0KCGY+axvDcac3OaV2u4N/SaO8M2kMXqmNOliUY4+HU1F3CSp7DlWHgi/yVYIEkpSvCu9GrvPOd8OwXEt8zIbJ/37Tq+HGmq3A/XvUSD+eXFEbPhackGLtSPT4p56XQSGL6LqtOr6ILlbnLTF3hnKjYZPb4DPBSy4KgoET1fAm8sRLHF/uF9ONmj0ADfSQjQAHjtJt0BMrSnIXQbWEgaTjA4NV/5rji4/LvS6mSuiwgVuvo+EI90cDiP3PNR2Yg4r6LURdjvI2GNNeBmzPJqrKBwy2y+iCvRhKEORo3PqH9QbXDvNtzj1zv/Xplf6CK2 xhGMGYvX zk7CHIXqJG0I32FU1y9Mko2GkrVfb+Ok7Kjf/txYfVU7GyEZ5GK96ndoIKEsnx7wJAa65w0jptc4dqsfIsALjjobQxExhB6lQkGVYAePsneaSb+/EtM6MKdBiFk7XqtXfmZMB2Z07oE7ei2opfg+2hN5NAD2ltS/mqVDVsqqhwZqwiG5uKqb+vraiziZP2bct18imxtXGg45xkwA4URftY/nXPJQc8G0qGfAqHdYUBva3xcNjuAWVE3dyStwh+2vd8Ec6vkmS+Y4l5/1mbDLsu9ceUYd2ZpDbjvMYnEXzu8kwiuxHWyYvUwb+VXvYh3vkXzfv/mfEGOfMSb4jffytbcrggxsE227d8ldrVRzJ+IP0jmdklX+679gK3XyDK7ejFUln X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi inwardvessel, kernel test robot noticed the following build errors: [auto build test ERROR on bpf-next/net] [also build test ERROR on bpf-next/master bpf/master linus/master v6.14-rc4] [cannot apply to tj-cgroup/for-next next-20250228] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/inwardvessel/cgroup-move-cgroup_rstat-from-cgroup-to-cgroup_subsys_state/20250228-055819 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git net patch link: https://lore.kernel.org/r/20250227215543.49928-4-inwardvessel%40gmail.com patch subject: [PATCH 3/4 v2] cgroup: separate rstat locks for subsystems config: hexagon-randconfig-001-20250302 (https://download.01.org/0day-ci/archive/20250302/202503020616.SJVwhuOV-lkp@intel.com/config) compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 14170b16028c087ca154878f5ed93d3089a965c6) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250302/202503020616.SJVwhuOV-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202503020616.SJVwhuOV-lkp@intel.com/ All errors (new ones prefixed by >>): >> kernel/cgroup/rstat.c:339:2: error: member reference base type 'spinlock_t *' (aka 'struct spinlock *') is not a structure or union 339 | lockdep_assert_held(&lock); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/lockdep.h:285:17: note: expanded from macro 'lockdep_assert_held' 285 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/lockdep.h:252:52: note: expanded from macro 'lockdep_is_held' 252 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^ ~~~~~~~ include/linux/lockdep.h:279:32: note: expanded from macro 'lockdep_assert' 279 | do { WARN_ON(debug_locks && !(cond)); } while (0) | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ include/asm-generic/bug.h:123:25: note: expanded from macro 'WARN_ON' 123 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ 1 error generated. vim +339 kernel/cgroup/rstat.c 330 331 /* see cgroup_rstat_flush() */ 332 static void cgroup_rstat_flush_locked(struct cgroup_subsys_state *css, 333 spinlock_t *lock) 334 __releases(lock) __acquires(lock) 335 { 336 struct cgroup *cgrp = css->cgroup; 337 int cpu; 338 > 339 lockdep_assert_held(&lock); 340 341 for_each_possible_cpu(cpu) { 342 struct cgroup_subsys_state *pos; 343 344 pos = cgroup_rstat_updated_list(css, cpu); 345 for (; pos; pos = pos->rstat_flush_next) { 346 if (!pos->ss) 347 cgroup_base_stat_flush(pos->cgroup, cpu); 348 else 349 pos->ss->css_rstat_flush(pos, cpu); 350 351 bpf_rstat_flush(pos->cgroup, cgroup_parent(pos->cgroup), cpu); 352 } 353 354 /* play nice and yield if necessary */ 355 if (need_resched() || spin_needbreak(lock)) { 356 __cgroup_rstat_unlock(lock, cgrp, cpu); 357 if (!cond_resched()) 358 cpu_relax(); 359 __cgroup_rstat_lock(lock, cgrp, cpu); 360 } 361 } 362 } 363 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki