From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE43C021B8 for ; Sat, 1 Mar 2025 11:10:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A84C26B007B; Sat, 1 Mar 2025 06:10:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A34746B0082; Sat, 1 Mar 2025 06:10:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FBCC6B0083; Sat, 1 Mar 2025 06:10:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 72FA26B007B for ; Sat, 1 Mar 2025 06:10:57 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EACE1C1F0C for ; Sat, 1 Mar 2025 11:10:56 +0000 (UTC) X-FDA: 83172714912.24.E48CD0D Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf26.hostedemail.com (Postfix) with ESMTP id 60675140007 for ; Sat, 1 Mar 2025 11:10:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=CZ9TN39J; spf=pass (imf26.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740827455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BiSU+Q7ZrfwJRrUo70LXGiUrNSCWo21yGEk9PwKhUrU=; b=Q4ktQoROI45zTvWP7FqsXjFztpribuh1yWY87ejze7yIbV9swhBpMMx6bCtbWIPppwDb3/ 43w20Zymj8zQtkvF27J9vIB7rYJgZd7PrUN4gbC8oxXjKgWxZl98ey3kKsKm3qCke4RxVg ERbm+1M/jjAcVc1KtGN9cSQSvK//wyY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=CZ9TN39J; spf=pass (imf26.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740827455; a=rsa-sha256; cv=none; b=zLS3QT4ynXmosI0qGgR/hB+fRDMR2SNRBSdE4JNWXhGUabO4f4xLxcELfzpvHc8CR2/5qE lcbcWbGB+8l4q21C8OGhU2WPQFtsfNYyZ8EmbuCFn0aV2493Xw1bzWOE1d8nX+a8ZCuf4+ PXE2e7L+nzJO+BDJKz0g38V7KVy5+lM= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id E5D2040E0177; Sat, 1 Mar 2025 11:10:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3u-IJD7GA1my; Sat, 1 Mar 2025 11:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740827446; bh=BiSU+Q7ZrfwJRrUo70LXGiUrNSCWo21yGEk9PwKhUrU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CZ9TN39JBPbtTZ5eEeEUlcUCmId+Boay7JIEaehgfJrmffwTDb8k/bCN414LSOXz/ RYZ2p8lQWiXpz8e5Si0p3q/Pi7S8KgQFgxIGsXFIOl8aXV7BJH7QacMxYd8A0qrafC HMvKI3olYS5ZkeYWWS1syNz9sKxvX8/Xl2toIWmTDlP3IZN7IsiTlqOOS/teQOoRh5 Q90OJNfLP1DMka37QjWZWkX30D0yBejX5YkzZq8bzMzl5Fu1iixxxcu4WjKIbwFeMC 2V3R51HVY7Y8bgcOmQJ555sku1tzxqWDVA/A+HscxVQUmxnmCeWbpvtWuGsYXLDFAU 4ZX/+kZIo+n4I1e2XIE8lE+7gFSG1F9aj8gkq38OmuOx/vEPxo0cR3SSWuTyirr2jM xXU1x5sTeSYBqD8nZtkfA6TBbTFF1xSKSJ3qWXzjP+xCpWeCccnQHGH4rL3TJuKz5K kbxrjOTW6rZOUY7EnT0gw3Piw2HYUfAvV9IgScZ+8ap6m+gjbEIPrGkSyosGrpVrUx K3pCWHLbJoHqE/ie9Fbe5kB5np/N6ooNUBpPwWfl1XRapXV2v8w4BY4LZsJI0+whUf njHmnZCZjQNpn4Vg5WN3xVud9BMZ5l/mDV+oobreI2/r4MHLiGCKOd5LiCryb/MxS4 bBobDJZjb77Hl7B0dFqaRICs= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5DC4A40E015F; Sat, 1 Mar 2025 11:10:29 +0000 (UTC) Date: Sat, 1 Mar 2025 12:10:22 +0100 From: Borislav Petkov To: Shuai Xue Cc: tony.luck@intel.com, nao.horiguchi@gmail.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linmiaohe@huawei.com, akpm@linux-foundation.org, peterz@infradead.org, jpoimboe@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, tianruidong@linux.alibaba.com Subject: Re: [PATCH v2 2/5] x86/mce: dump error msg from severities Message-ID: <20250301111022.GAZ8LrHkal1bR4G1QR@fat_crate.local> References: <20250217063335.22257-1-xueshuai@linux.alibaba.com> <20250217063335.22257-3-xueshuai@linux.alibaba.com> <20250228123724.GDZ8GuBOuDy5xeHvjc@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 60675140007 X-Rspamd-Server: rspam09 X-Stat-Signature: pxhbb9711xya7mdn47a57ao3c3jcpot7 X-HE-Tag: 1740827454-362668 X-HE-Meta: U2FsdGVkX19Ok1zEefOxUF2kA5MQQWgAV8Lf8Olm7iNisyWic+KZf8S/0lmIWE5x2XyXnQFllq+UABuQzGcNME28gO7XiSJhpenqo5NcFNbym0eh32X2gEBjC3XZqQgP0diWN28lz74iczt/0t0oD5kUD6MjxiNiSTpLtpFCLO9jVvmpFAB9iWJTXYW7PTFPZyJq7Waz3KZDc5PEvZQ1zg3tP4ITQcyvBaTR0gFNGRLaDxYlnlZVTW0ouFDQ0PsLhVFrNxwVjodrqk9oAy2l/Z0btCvuoN3lHRzX8otSG73wb2NUCm6x6I+/+Rqn/uSSbCQdY7207eh0xy6OvhF1vetdzeKDOlT57I4J296l1RxTiDDQsGEL9nLdpKtgTyck4PTMVQcpwcByEA6igt1zQYorlqgUty48PB+6T2o9M1UaP402dtD5t4loourXkiX4dkyQRtjXZZ34uDNpNkAnpQiu/GcJovfSQRvUE+kzCsNpA0EyPL1EjRy2/RthbViW3PGnVffaC2WiEz+9iD26bL7pVVcA5QEnHiUNYrEo9rDMmVTcXDT8nJZlOhilzuEUZGdjowiLWAS+o7TUJScQ2SfKTAcjy073ewzx7dmMZ/yzk/b2hKbfORYEdLSvLq762QSjaVMS8002vejE9fL+SEz+9BjBQbgUeTBYjiESJ0pP70i0yQYyk8L1ktS1lwhu99aJmGg6gim6c2p5kjeHGYOF7Y07ORAI4vCgGPSFC1afZGZ+/n5LeAYcxFeErHMGHLrR9db+19FR5qTvjlyK89fqzVbLAB/tLm8D+Z6irxAoPDkv7u0ctt+Bt/wLEjDugcsLyn6u0MOF2EM6pRKNimhMo6mKSh6/3W8hSuHf7oo4k133tiZ+xbNnJbpWLtPiA4BaXNswicv+aIGY64pSOI+l8Grjs9zE9TTX6DskbHKG9fr8U+MqX7X0KbylPYgXz7yPVnuDMXwVpib1vIx RaF98jsV jgYPHIIJP7KwuJ0NdKKS0O4udQgbHebYI83sNq/T+IAgiQoDQQpB5BmBZdIfuteOqKhwMZaIFI9zS2idBBTaVmAlbky1StdcLvwSVzSFCcPjZO4NZDovlLM4Ey11+lp5cJmfI0rzwdtSsAPM8AAzGOzHFd+HGgWvz6W6l12HQkf5/1+IaS4gWgeK8vxNvLoP4XlnAie8HZxScNdGejQB1QDXIWDNRqBwrnT6ownilJfiNX68c2IlitIh+FnxsxNsjpv4pO+eUlIv2XP1GCmz2/FyNcC9bi68GAx+pQoXV72eJA/9jkPzs4PvHLJ3qLbAXqCMgtc6aEzPMenuzC1RbTuK75w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.014246, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 01, 2025 at 02:16:12PM +0800, Shuai Xue wrote: > For instance, it does not specify whether the error occurred in the > context of IN_KERNEL or IN_KERNEL_RECOV, which are crucial for > understanding the error's circumstances. 1. Crucial for whom? For you? Or for users? You need to explain how this error message is going to be used. Because simply issuing such a message causes a lot of panicked people calling a lot of admins to figure out why their machine is broken. Because they see "mce" and think "hw broken, need to replace it immediately." This is one of the reasons we did the cec.c thing - just to save people from panicking unnecessarily and causing expensive and useless maintenance calls. 2. This message goes to dmesg which means something needs to parse it, beside a human. An AI? 3. Dmesg is a ring buffer which gets overwritten and this message is eventually lost There's a reason why MCEs get logged with the notifiers and through a tracepoint - so that agents can act upon them properly. And we have had this discussion for years now - I'm sorry that you're late to the party. > For the regression cases (copy from user) in Patch 3, an error message > > "mce: Action required: data load in error recoverable area of kernel" See above. Besides, this message is completely useless as it has no concrete info about the error and what is being done about it. > I could add more explanations in next version if you have no objection. All of the above are objections. Please go into git history and read why we're avoiding dumping useless messages instead of proposing silly patches. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette