From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E28C282C5 for ; Fri, 28 Feb 2025 21:44:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F020280004; Fri, 28 Feb 2025 16:44:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 478EB280003; Fri, 28 Feb 2025 16:44:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 341AE280004; Fri, 28 Feb 2025 16:44:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 15E70280003 for ; Fri, 28 Feb 2025 16:44:03 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7C81FAD6E2 for ; Fri, 28 Feb 2025 21:44:02 +0000 (UTC) X-FDA: 83170681524.13.3EE55A2 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf19.hostedemail.com (Postfix) with ESMTP id 3F28C1A000F for ; Fri, 28 Feb 2025 21:43:59 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=OJLwt0qI; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740779040; a=rsa-sha256; cv=none; b=yuC2Ixe/hv41ruopJ65aoEuFjfbq0B5O1kvzevxDqXzYY7gz+8bAs/SuZcgdvNH2c4fjgQ /WQxN6x7jsascX6lDNXR19m8cpDkeSzt4LyrAqm6a/4rU8s+7SN74mthQwJA3Iuou4F6tL yrTal7xc5sZYsDgT/sMSV4HltjP9suM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=OJLwt0qI; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740779040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9UV1IcJ900touH3JTaTltIhj++lVmzYmB/lL+8OAMUk=; b=FgYz0v1ToJ6dOD2cEegacu3PZVikGfAeVaMJES3KSsFeL+I+44NQryy9r8JSGgiaKwLwlJ /jC5ECaBEFwmkNOBZrHD80Wvm61iKw7nak3jnM/aD3+UFDLQJTK2rwHVAiWwKs6vc3HU7g MZrMUz9HkgkEWmpvoD1+W+JmO8n/Z2o= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id DEDB540E01AE; Fri, 28 Feb 2025 21:43:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PIOsHn8YW_Vu; Fri, 28 Feb 2025 21:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740779032; bh=9UV1IcJ900touH3JTaTltIhj++lVmzYmB/lL+8OAMUk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OJLwt0qIS4tB6CaY/OYGn6tBWhWzFkvn2lu4L9zDlanRYogIDVGS2XQfYMdNaGezE 8iUB+dNpMTlttLT6sjnLqMsivArWwiv8LUj9vaJvIYoOMWcIPPQjAkV0Cxg+5rgTyF quv4bxUP/RCWuUm+AF4Q/33tBTkjDdpakHjCGMK7scrFGt56zxVCJ0DNqdiZgvhmRx 900Rhrcb1o+/w44treZ4Nb982ZTu+DlLZQ4kzKyAwq00myJYukBcCMA8kBZr/uaqXY z3ojT2KDB9KD33XzTE8aVLpcuUYrzi007E61ILHMVdWMhWnkfb1jEJjLrrpizeOG60 D297S1AjssmhC65Oo6VJk6ShpD0Vo/WebS0ZdseGe6Y2Fe3gBPdOX/+8Fyf71NNzvc 5SEjEvn+bW7PijkuhLZ88ZqyLdtU5VcpRtc/9LHn8Y0vs83+I/7iCGfnFONtaBnvKt tv7UTu6U5nw6dy+onKmHt2qrTNEnc6K13uDGYdbAprauG2OvMLZcRybmaVxN/xApLb fV3VS6+oJq61Pow/ecCx1p93hi5RdoXd3bvzffcRAddTz9SHC0qPksuSTOO9gJWIci NH/ugoCtvAOCj/OkAd2Oekx2XPxyB8w168k94KNOpu9bSXQB+MB2Ae0lWNg7nplmYY Mqza9MqJr0+z+6Yl/iHqWKUM= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C559740E015E; Fri, 28 Feb 2025 21:43:34 +0000 (UTC) Date: Fri, 28 Feb 2025 22:43:28 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org Subject: Re: [PATCH v14 04/13] x86/mm: use INVLPGB for kernel TLB flushes Message-ID: <20250228214328.GGZ8IuAMKL4FeSTBER@fat_crate.local> References: <20250226030129.530345-1-riel@surriel.com> <20250226030129.530345-5-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250226030129.530345-5-riel@surriel.com> X-Rspamd-Queue-Id: 3F28C1A000F X-Stat-Signature: e4357e1pozzrru9wgh5sw8cjjg7tcx3d X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1740779039-287481 X-HE-Meta: U2FsdGVkX1/eHQZ9GNiGaWKcs93vJeOD2N2qdNOgMlq9c22GXhg82S8Q6zjkx1+E7XFNIODka8Fc5tDmk6jXW5D4+cq5O5P2H2XHhp0ua+d8zdQw1TKhsqUcTX9F0d47IEaYJV5MydhkRPuNv7/64kP1gHGUHMeqHIaOT6AKln3b5H9n2hsR26pIPF26efHWVKDZpcaPDqRD0Z4GEIw1GSkNIlNMhIfjjaN9RvOuRfG1EX5IdbZ1bcoS/r6V+C59auQqPvCwZ0JyAA/Pv1B0REgWQH7ff5Qw+wiPiEZGz97++IvjlA1ifyUFDXEezMPumYUI0iyDo+Ww40iqvNW1jLqLdJGxH7SsX/5L1aYxaAi4I/zKxXmp6HhlT32fYz/lO/Nh7trQtaqtPY+7XUsQ1z7HNXntggOUJL72FY/rNbnmP9kqV2sBbJKxM5IZ6Y4hnaiT5ukqQPL5YDx2El+Sp408JQQcHx4L8C6uR4IgXHN+P/2s7ZH5CoSznAIHYjullCUjWs1YLiTOGxoHzcI33RzGLRTXqKwfazKX4oqHby83z9hhvys8hfTehmZGObA6f+rwk6zR3YuU0R2iCdZG48kUMHa7e+NeD3gsdNOp4Vdc7sJHjhUfdJ5EuGYOJaA5U7XWPrW234ttpoIap5yV2QAwIDhm5fz79gXCP/Xr8ygYV2Mp/nYpRfW8GquVvPel8vriTeg2CSOt/9rZrDx7v/ri5l6kV76yjM4DfowAjSwhRO7RCleHhC2zEMt++rDMiZbukJEfxdUOtQ1+Nu7kq3siYM3EUYYeQ5xoWBigcF6YDrQ5UkxPpOUrdNOqTmiMQzPGQ9ZMwDaAz+FGJHBVzjd3tJEUpLyBydnUyfXGNMYfYpYJdhJihT+6/6m7TBEi+EHYhcQ/wWRYRJxHWxob/LGHljsCfe4LGrzEUOAx1ztGOz5+tu3KN3Mj0lhc1GfMB9fh8tjIPNCPc17OrKU ih8OY1g+ NIgvWoeRpd78fhALDtgHvsRHGKQxd8bvlSFnOKi8nDugj157qpxiXiIhPo0xxvWSejr4ae8gBGrr75KKRKrRYgEoi120cE90oEith8e5/PuhQoQ/hlrzExUJwjDkjEoVVOp1KIulSU+rtNwEVseDmyefYBvIhIIm+kdV4DZ8yv196lR1b78O4j918VxDyDui10RzwgE3mzSpBAYMr/y4pwukN5notfCMi/iPnsbxPdrh11dlyd0095bUj+9Ufs7ZYq151Drv8QxecAS5vr+SiRxD2yERdiHdsSxJS296PJe0JkDKJF7OEURLp7+NuRHmrIGhraS0C+9s0Bjun1mH+c/5mI1tF4H4S9hzCdz6YGvb7UT60NnjxjKGjLTdETHZAwEW7/r70/2kBTfkBQw4fwdvO/wsdvSGDtNX62vyUiZaUx8q0xmEXC74c9MCB3xDznhDDVGVgX8czbcNrK/gR+cwkdcnkTbkebt+CiQjs07ayKCab6JzvBtbtvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 10:00:39PM -0500, Rik van Riel wrote: > Use broadcast TLB invalidation for kernel addresses when available. > > Remove the need to send IPIs for kernel TLB flushes. > > Signed-off-by: Rik van Riel > Tested-by: Manali Shukla > Tested-by: Brendan Jackman > Tested-by: Michael Kelley > --- > arch/x86/mm/tlb.c | 32 ++++++++++++++++++++++++++++++-- > 1 file changed, 30 insertions(+), 2 deletions(-) Changes ontop: --- /tmp/current.patch 2025-02-28 22:39:33.236465716 +0100 +++ /tmp/0001-x86-mm-Use-INVLPGB-for-kernel-TLB-flushes.patch 2025-02-28 22:39:59.432310072 +0100 @@ -1,36 +1,43 @@ +From b97ae5e31069cd536b563df185de52d33a565077 Mon Sep 17 00:00:00 2001 From: Rik van Riel Date: Tue, 25 Feb 2025 22:00:39 -0500 -Subject: x86/mm: Use INVLPGB for kernel TLB flushes +Subject: [PATCH] x86/mm: Use INVLPGB for kernel TLB flushes Use broadcast TLB invalidation for kernel addresses when available. - Remove the need to send IPIs for kernel TLB flushes. + [ bp: Integrate dhansen's comments additions. ] + Signed-off-by: Rik van Riel Signed-off-by: Borislav Petkov (AMD) -Tested-by: Manali Shukla -Tested-by: Brendan Jackman -Tested-by: Michael Kelley +Acked-by: Dave Hansen Link: https://lore.kernel.org/r/20250226030129.530345-5-riel@surriel.com --- - arch/x86/mm/tlb.c | 32 ++++++++++++++++++++++++++++++-- - 1 file changed, 30 insertions(+), 2 deletions(-) + arch/x86/mm/tlb.c | 39 +++++++++++++++++++++++++++++++++++++-- + 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c -index dbcb5c968ff9..f44a03bca41c 100644 +index dbcb5c968ff9..5c44b94ad5af 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c -@@ -1077,6 +1077,18 @@ void flush_tlb_all(void) +@@ -1077,6 +1077,25 @@ void flush_tlb_all(void) on_each_cpu(do_flush_tlb_all, NULL, 1); } ++/* Flush an arbitrarily large range of memory with INVLPGB. */ +static void invlpgb_kernel_range_flush(struct flush_tlb_info *info) +{ + unsigned long addr, nr; + + for (addr = info->start; addr < info->end; addr += nr << PAGE_SHIFT) { + nr = (info->end - addr) >> PAGE_SHIFT; ++ ++ /* ++ * INVLPGB has a limit on the size of ranges it can ++ * flush. Break up large flushes. ++ */ + nr = clamp_val(nr, 1, invlpgb_count_max); ++ + invlpgb_flush_addr_nosync(addr, nr); + } + __tlbsync(); -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette