From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A1ECC282C6 for ; Fri, 28 Feb 2025 18:57:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7536280002; Fri, 28 Feb 2025 13:57:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFCE2280001; Fri, 28 Feb 2025 13:57:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEC70280002; Fri, 28 Feb 2025 13:57:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A06F4280001 for ; Fri, 28 Feb 2025 13:57:54 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 39D40121191 for ; Fri, 28 Feb 2025 18:57:54 +0000 (UTC) X-FDA: 83170262868.25.A9A29E1 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf15.hostedemail.com (Postfix) with ESMTP id 4D6CEA000C for ; Fri, 28 Feb 2025 18:57:52 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=jHaLIwOg; spf=pass (imf15.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740769072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pXVDuBMKpUtgMtGyRbUlZRZSsfyLj/5MpDTqbtNqe24=; b=Cy+DcymbYu4Ye+D+2YUygAAeppKFh4aXqkoU9i7JHVNQY1yfqmkUXLLMkPhrZqfpZpUlEz T9LivzjVWfzhFAtJmEVT6GU5fc45oQy/yoFmqmWnCO5uTnOj3jjZIjkSt5AbnOxeULKkgU OH5W1KTC6UaNmBh3HZ/q9lJ4gkwKNWQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740769072; a=rsa-sha256; cv=none; b=jNWa2VQPSZXro+emg38QCkmRA5tdBzcaTVp5ZQlcuiwFH4H8Itn+scgwcTvzD4xM/+1nsj 2hTVNdtprQoYNPC2eSnUaT+taHyVBaZdko7So6+JrBBUsVGYjG4DccAJlP3Ns+t2PsFHz4 NyZIb/hxGLzW95898ssGxzlUxphNkr8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=jHaLIwOg; spf=pass (imf15.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 8E5CD40E019C; Fri, 28 Feb 2025 18:57:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id roGHl8cJet9Y; Fri, 28 Feb 2025 18:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740769065; bh=pXVDuBMKpUtgMtGyRbUlZRZSsfyLj/5MpDTqbtNqe24=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jHaLIwOg2LgCMZembJa0+82tNeEx37kUF7jjud3rWlc4ye4U7drSCXH9vV9M12k/Q DGuQgr/06sQKRqbktx9hYUkSB5eAbUd0qTW6gQcDcSvvJ7mkpHFAqRzehU7uw6z/YG SPib/TsqiU8kxoHLBKfd+qiuv1nzR0v8H6WK77Oi3JFIN5FTc54/Hru/62SIemnIX4 wUFpkjrhoPjz8dAC5Hzx/KjLckgHSwm59Jna6e/yLV+CCZQbQrQbSV1GA9+t33Xx9L 4rATTS3gNih/PatrXm/yYzBsL0S7XzQEeNhIQGwQUHR6AB8C0cbG39KbaAtQcBfXA4 Si1ZQaIO5NPnP+q3hm0XpdIPRHpzMoTvNOg2BeR/UhbxpiP2G0Qo9S+dGzGUxAUmMU NCQXaSJo21fX42G2UmCOf36Z4c1jKnv2NAZqOjOpu+A2kmyJfTzHUCnCAvg9/TnYfN o4XwPt1imtAjXloI+SUOhnJDmWF+qkKx12GCOsqsfZKOGhdma6rlWG6IxXRjpJmfb/ bMHDRDZZ7nfjmNL8LOUb1PsCIqQqEHCNf3a5x8K2GJOHGHkFr84rxb8RfJXZ8m56ap OFJ1K9CdTL1BDqbmU0IffB2JCHTR2Rzpql7+e8GX6E/Wb0kHCunpr4h+/SxURrei9X epvBl1Lm2lGfYJK1G4en36wo= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 770FF40E0173; Fri, 28 Feb 2025 18:57:28 +0000 (UTC) Date: Fri, 28 Feb 2025 19:57:21 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org Subject: Re: [PATCH v14 06/13] x86/mm: use broadcast TLB flushing for page reclaim TLB flushing Message-ID: <20250228185721.GFZ8IHEap-MWvwswsu@fat_crate.local> References: <20250226030129.530345-1-riel@surriel.com> <20250226030129.530345-7-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250226030129.530345-7-riel@surriel.com> X-Rspamd-Server: rspam02 X-Stat-Signature: hu1xfzmuokncifejf4iuq1fj8mpdji5s X-Rspamd-Queue-Id: 4D6CEA000C X-Rspam-User: X-HE-Tag: 1740769072-639537 X-HE-Meta: U2FsdGVkX1/X1ittaYejaWk3HTIBkkZ0xcvm3ZhnNMxINZdJVghdsLmRgOnZVehFugmhiNfr0MK8OW7s2BotBXBeKjSz9qMPcQBXfFcrJ+piRg4UEmcrplWlBIvT31MeFTOCFNumpjKeSqA27wK13AGUNxHyEqCv2s/2hWMYsDUyjsj0dOpNBopK1saeAaqbm9o5WEHxnS2ZC2R7Z1IKq31giC8y4+tuQu9CGukN1V74hPlAgo5JIOZnYqX3bXoNeaCydhy3F6m2Dko1/X2aI5iBjOPoyAPVlyv93S8KOU8NTdXQFtol3wH3RS2zpE+X3zUV4jSvOcafRH4TyW0tgZAmBtGNmcKmXaQMb+y6Pa+au3gJfrik3lmYn5nGL0ctyYcDbaC2wUo+iLD7wUZ+2yxvm/iuu6U0C5olRn8n31iJXxf/pY/22cE8EoE37imOFbkuDOCbDZ0j4atLQPt8xgyRj+4Ph1asBOGZbKIN11Bag8XBwwDGipb47YcIgq5PWbN8YwNPIE5Wi+J2Ka0WSj8ipU+VG9fGZzvfqktGb2cP3OFOwkOS4jS2tOd9c/JdvtHRZ6tsTku2PIsEcriqRt6uljNnEYotVLnCaDVvsqkCWEN8J7kO62TJRN9YD08h+s9dHAZUAHLY5UtvUFQczGyZLMj8wFGY7d2b5x4e8R9t6grdWfrRWZMBs1Zq/GkW7aUN7jdAvhc1PC7tqHhQ9WHuP8k7UBVfkBbvaCSqxwF3lsskT7uUbbVmR2sXzhYZ3VgVYSzJhse7QuuchsT1b38ApJL6UhNnlrhJbzlwkPzvYj2h5FGnT+S/ir3yqjXWW8tf+HZxcoOluZlNhzixcufdQllaB0zMdbZ8akeGHo56ZYJ+XmXIWLgNhpqDnRo5yc4WuHPIN1o8RV978t4kDAZIMe3dQb6EIHAa6WgWFsds3oXp5yiTc/YsFPPGFus8Rq4P40FX9i3D/YVu10r +0kpWC4A 7vK5PYi3G5wo180nUSoUeHMqohwC/6NzI8Ah8mTK5QdfeeJG0IFkD/ck37zW40wxM0AUj/kqhn4WrnR72N2VK4RLsaw7T1h1PMnXPkfZvrNBVmPFz/Z0PqdI7QhIBLj25A5P9ggVl/ibYdcASOI3BwiQ/qgUr9pn1sSFwhmWKrq1MFrQkW5pn19+jh72b6Jqf2+f/ELhFJdRyfitV78rlyiiMFp3uchylSqcO3KcmM6xctZ29zTpgXDzlGD/Fc5TX8zPzWyYC/NKrXox6QGwbytTTjSL0blosIv/lKw8kgWhRQbvv9sZX9E3a/1oclkgawyWf91ndmVGUC6bRdIxGD6ElsQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 10:00:41PM -0500, Rik van Riel wrote: > In the page reclaim code, we only track the CPU(s) where the TLB needs > to be flushed, rather than all the individual mappings that may be getting > invalidated. > > Use broadcast TLB flushing when that is available. > > This is a temporary hack to ensure that the PCID context for > tasks in the next patch gets properly flushed from the page > reclaim code, because the IPI based flushing in arch_tlbbatch_flush > only flushes the currently loaded TLB context on each CPU. Ok, why am I bothering to review stuff again if you're going to ignore it? https://lore.kernel.org/r/20250224132711.GHZ7xzr0vdhva3-TvK@fat_crate.local Please go through all review feedback to v13 and incorporate it properly. It is not nice to ignore review feedback: you either agree and you incorporate it or you don't and you explain why. But ignoring it silently is very unfriendly. :-( Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette