From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3640AC282C6 for ; Fri, 28 Feb 2025 18:47:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C33A0280002; Fri, 28 Feb 2025 13:47:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE3B4280001; Fri, 28 Feb 2025 13:47:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD233280002; Fri, 28 Feb 2025 13:47:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8B9FF280001 for ; Fri, 28 Feb 2025 13:47:16 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 37E1D1C8D6B for ; Fri, 28 Feb 2025 18:47:16 +0000 (UTC) X-FDA: 83170236072.09.2AB6146 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf25.hostedemail.com (Postfix) with ESMTP id 7A784A0015 for ; Fri, 28 Feb 2025 18:47:13 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=DNfHxAvr; spf=pass (imf25.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740768434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1KiKu6KpywPSyZTKP4+7kFo3bBQmsCg/DkCOyPCqlcQ=; b=p0QhlxmSkT8pBfLUjk1PXVK9ScwtByUovdWsAohrmV1loviHHsYHb9+QCxsIW6HRdIW75q 2Xev9SqbsTa8vUl97/D8X1zwFyKKTLJzGef6xN1iCFCWIfuTVZYV1KFblrsEEoXWAqy7wE IbL85Rot4Uuawr50HVbr6BH9sg+b50A= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=DNfHxAvr; spf=pass (imf25.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740768434; a=rsa-sha256; cv=none; b=nmD7somTlkENdduVBdWX/y1JkRqH+XwPlGUo5Yruwqn+0vccybmQ12NVXFsuQ04fI99aD9 IZvNm0+60k97fYabphfJv0inhbIRctTBiQBzh8XffRk2JN1yMMFKnWfySNhEmmP5Sz4EAR 9gKwIK75b+9GBQJVO0ZcYfrZkvmk4yU= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id F0A4E40E01AE; Fri, 28 Feb 2025 18:47:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bToSY47InZRh; Fri, 28 Feb 2025 18:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740768425; bh=1KiKu6KpywPSyZTKP4+7kFo3bBQmsCg/DkCOyPCqlcQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DNfHxAvrlVsW+K4gF137B+Ffa4GP9EXu9UbkpFiXRVppvIV35iIWGQ79RLNPrT/PG ma1dhphFB9eAczcfn3ryQmL3Gtbb77yKjS8Np0WXbUDlfzygi6Bo+KelEUFQLs/RSe Rz75yHlIISOCFO/UjRXRuRzy2H5srszsJROqNO39kppH4iMqHHwQ/GZ7SpOolFTGyo E0uJKkd518aNcO4e796FVJy/Ev0Dz9AJf7ElHsKIcO+XplXnh77jNrNenrlF9i6gOF BQE4vVrxBFVt5ny1hcOoXARJv/KDvOt9l9GJVADdEuRG8LNfIwIMUZ+zeuTQ5+RDpK P/ox3qx8ELpI5svPxejXOqIZdnSQFFxCtyMO2I+kW0geZjp9cha3f8+INMawjtIta6 LxnEo2cE/0bhBc+3Gw642nC8HBCntsbeqnofmxDDxxlcA4IHsrqpvTCrqi+BOhnOCp P6ndAQP9teJa/+UmLI0tmhbI2yIwUDSNZ6mRqQ0y24MnjQPW5vr/qa5K5zs38IN7Pn q9TvQwknjJXWnuLWLCEiCepZFF1ArgKkqo8RKrJXY9xpVJfKKTaSJ0t4kHhmN6/TRb 45pytiSLQvqK2YFfP/Ya0qtQLc/0xVg6kCRfAFgZMaHeFnRpDtmpWtk9K2GLVaIfRt e0PIP0il59k3HzhQx//2pk6o= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 06B5340E0173; Fri, 28 Feb 2025 18:46:46 +0000 (UTC) Date: Fri, 28 Feb 2025 19:46:40 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org, Dave Hansen Subject: Re: [PATCH v14 03/13] x86/mm: add INVLPGB support code Message-ID: <20250228184640.GEZ8IEkBFDZhOpyK4e@fat_crate.local> References: <20250226030129.530345-1-riel@surriel.com> <20250226030129.530345-4-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250226030129.530345-4-riel@surriel.com> X-Stat-Signature: ab1gmen1xtruu9tazmnacruswyjj3ju7 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7A784A0015 X-Rspam-User: X-HE-Tag: 1740768433-786125 X-HE-Meta: U2FsdGVkX19ZSNSsH368ED/XIhyf66UGdFxohxdmY9ZHPxmQnkyP3aSXOp+oIQESKabHjpEFIMOqd8r3R8i5x3FxPHPWK3lI8PZ33FG2YUWGPDTaDZoOmhfCAXJZPXULUrgxfC5t13qlitvzMLRbIQG28NmNZO1eMglhZ2fUHoBnOujAnQclrkytlby1mhsk5TPg/ihrhWMkn7r3Av/rtC6u5McRDpj08ipSfs1vUBkjQ2Fsr+HVxHTUzdOb25uNXj/Xso+nZ3c0YT5kTn5tLABghWq3X+u1bfpIDqHwuunfMYUC1H5NK8bnY55G0joqlL44G1wFJX9XpQSSso5Rg+7msJibife96vGtuYRyv4L91rWYQcyVhW31+Kvaeh5hyZBNIcAIgDSgLtNGGMlIaqCIVxFJzeo7YGT3a7l9C79LhXXWFT8EKYj5dUbRdncB2aKuVPX9uArZl6yWU6I2b4/W0lBWyCNBOAzlux4GwKEBylh5ubdHU2v5yCI9i0kO70PhK0XMlJsc2zcLFL5gZTEpJtRnqnWKXB0+eoqYPgdsYHOYk+SCOdW7J4sQwtk+pZtor+1z79r+MHn7GO1MikKq3H4+8T8/SQhKPw7NeRO16Ixlqr1U9O8ivztDDokjesTHmJPEBA9B0zSoDA8i2LSPTF+u1K966r2Hdbdgbn/LGV/k8opsuBN6E5duaC/kbbdxroZ1rhy6y4pFAWKZnXxoJ9MCX1dq16BrwW16kdJNZjoJBdoCszw9VL771f7K7yMsdRnRwoCaeq5Fr6d2dcDC0pJ+JdsAZw83j0XnPnFnHVYjzp8EMQUeEvLkWKh6sM6gtprzrcEZZ/GMjb/JKfDnEBaylAmrEtd/B0IrjpCHtUYXgy2Rcwjn/2FkwEVDVMzz+IchQh6guSFcezKN9G4qMROgTEFXnDiNF37RjNczdctXwe2uc7COYJXulMyykfowiBb7wmUWV1qf2z4 V2lWicYU DgrofdqtG6IP1i8u9NJ8cuYOWY3LJhejN9Cb/yiwAKvkjHlRqSwcq+OBzuH7R0FBcGvfohBZwX3FKPqoR8FHmE9kkge4Hnsef74eXdNdPdLiztxW3xDsNxRjluJ70xjOUz6dzlVNJlXb4RbYeBooZYlLE4aK+Cx930CY0ct3FAu9TPhQoikj7el7yfjojIJGL5h99gxE+9XgkPixTwbpdpC7aSlZXB0zwt1FKXFrzjf7ZcXWQN0oHFLSlXMAjjFGBa1U66ZwVlIeBcPQ1GmJ4kzvgcz3bMsatkXGBCilbwlFau0Fn/HMurMCxpgcC3h4YvbI6Fm344ejRP2MDqvQgKjt6/RdksIfTwdeuX5dBhDQ09zD1OgS2fiYk+bHrsFjosJ8PO2hUpi5qnoq2r+pRQ5IS3wGpG83TBkj8JvHbBWCfWtf41K50BfiDb+XMQKej5s/sQZydz6Esii9owux1c4xfqAQh3BTWDJjCx0OgZFrR+16vH8L/SFzOLg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 10:00:38PM -0500, Rik van Riel wrote: > Add helper functions and definitions needed to use broadcast TLB > invalidation on AMD EPYC 3 and newer CPUs. > > All the functions defined in invlpgb.h are used later in the series. Uff, that's tlb.h now. As already said. :-\ Btw, this is why there's no point to write *what* the patch does - that is visible from the diff itself. This sentence is simply not needed. > Compile time disabling X86_FEATURE_INVLPGB when the config > option is not set allows the compiler to omit unnecessary code. > > Signed-off-by: Rik van Riel > Tested-by: Manali Shukla > Tested-by: Brendan Jackman > Tested-by: Michael Kelley > Acked-by: Dave Hansen And I asked you already but still crickets: What do those Tested-by tags mean if you keep changing the patches?! https://lore.kernel.org/r/20250224123142.GFZ7xmruuyrc2Wy0r7@fat_crate.local ... IOW, you need to drop those tags. > +/* Flush all mappings for all PCIDs except globals. */ This comment should state that addr=0 means both rax[1] (valid PCID) and rax[2] (valid ASID) are clear and this means: flush *any* PCID and ASID. So that it is clear. > +static inline void invlpgb_flush_all_nonglobals(void) > +{ > + __invlpgb(0, 0, 0, 1, 0, 0); > + __tlbsync(); > +} > + > #endif /* _ASM_X86_TLB_H */ > -- -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette